Posted	Nick	Remark
#openstack-nova - 2017-04-26
21:33:19	mriedem	yeah i guess with like the online flavor migrations, those are all of the style where we looking in the api db first, then fallback to looking in the main cell db
21:33:29	mriedem	we don't migrate those in the object code, we leave that for the online_data_migrations CLI
21:33:44	mriedem	cfriesen: have you guys been running the online_data_migrations CLIs in newton?
21:36:23	mriedem	dansmith: so say i wanted to remove all of the api->cell_db checking code in the flavor object during the lookup methods, are the steps add a blocker db migration, then drop the compat code in the flavor object, but leave https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L604 since you need that to get through the blocker migration
21:36:47	mriedem	this doesn't buy us anything for perf, but it would drop all of that compat code in the flavor object
21:37:20	dansmith	mriedem: historically we've done the blocker and then removed it, saying you had to use N-1 code to do the migration
21:37:25	dansmith	but those were thigns we really wanted to drop
21:37:32	dansmith	and it was all intertwined with object code
21:37:41	dansmith	and, we always do blockers as the first migration
21:37:46	mriedem	yeah i figured we wouldn't have to here b/c the object code isn't doing a migration
21:37:54	dansmith	potentially
21:38:24	mriedem	before you start using multiple cells you should really have your flavors in the api db
21:38:29	dansmith	yes :)
21:38:36	mriedem	in fact....
21:38:55	mriedem	multi-cell basically breaks the lookup routine since we don't know which cell db to fallback to if the flavor isn't in the api db
21:39:14	mriedem	so we kind of need to drop all of that code anyway i'd think
21:39:44	dansmith	I'm confinced
21:39:47	dansmith	convinced even
21:40:24	mriedem	are we unable to do this if the blocker migration isn't the first migration for pike?
21:40:44	dansmith	no, we did that to avoid you being able to keep running on N-1 code
21:40:54	dansmith	like, we tweak your db, then tell you you can't run N without migrating in N-1,
21:40:59	dansmith	but N-1 might choke on the tweaks
21:41:01	dansmith	that would be evil
21:41:15	dansmith	if you're not dropping the migration code, then I guess you could do it
21:41:33	mriedem	right that's why i said we still keep https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L604
21:42:07	mriedem	but you really need to purge this stuff out of your main cell db and get it into api before you can do multiple cells
21:42:20	mriedem	maybe a nice reminder for your summit talk :)
21:44:28	dansmith	heh
21:45:17	mriedem	so https://review.openstack.org/#/c/374307/
21:45:23	mriedem	we already enforced this in ocata :)
21:46:26	dansmith	flavors yeah
21:46:36	mriedem	and keypairs, aggregates and server groups
21:46:44	dansmith	and those yeah
21:48:44	openstackgerrit	Dan Smith proposed openstack/nova master: WIP: De-complicate some of the instance delete path https://review.openstack.org/458636
21:48:44	openstackgerrit	Dan Smith proposed openstack/nova master: Move to proper target_cell calling convention https://review.openstack.org/458634
21:48:45	openstackgerrit	Dan Smith proposed openstack/nova master: Make target_cell() yield a new context https://review.openstack.org/458635
21:48:45	openstackgerrit	Dan Smith proposed openstack/nova master: DNM: Canary test against multi-cell devstack https://review.openstack.org/458537
22:09:11	efried	mordred Still around?
23:05:39	mordred	efried: hey! not really - EODing - catch you in the morning?
#openstack-nova - 2017-04-27
00:39:48	mriedem	dansmith: i just got thinking that maybe we shouldn't have removed the online data migration hook in https://review.openstack.org/#/c/448579/ but then again that was added in mitaka, and the blocker migration was added in newton. the thing that makes me 2nd guess it is people skipping releases for upgrades.
00:39:54	mriedem	which we don't support, but people do it
00:40:02	mriedem	skipping from newton to pike though, would be nuts
00:41:14	mriedem	the online flavor migration was added in newton, the blocker migration was added in ocata, so theoretically we could remove all of that in pike, but if people skip ocata, and we removed the online data migration CLI for flavors, they'd be screwed
00:47:13	mordred	mriedem: skip-upgrades seem like a completely crazy thing if they're not actually supported and planned for
00:48:57	efried	mordred Yes, mañana. Want to make sure I'm on the right track with https://review.openstack.org/#/c/460337/ and ask some questions about same.
00:49:39	mordred	cool- looking forward to it
00:51:02	mordred	efried: oh great - I missed that you'd pushed that up - I'll read it first thing
00:58:11	mriedem	mordred: yeah, except ops are always talking about doing it
00:58:18	mriedem	because we don't have LTS or whatever
01:16:55	mriedem	dansmith: oh fun, uncovered a bug removing all of this flavor object compat code for the main cell db,
01:17:13	mriedem	when sending a flavor delete notification, we lazy-load the projects which results in a FlavorNotFound b/c we just deleted that flavor
01:23:42	mriedem	looks like that's due to https://review.openstack.org/#/c/445697/
02:53:33	openstackgerrit	Matt Riedemann proposed openstack/nova master: WIP: Remove compatibility code for flavors https://review.openstack.org/460377
02:55:46	morgan	huh I saw my name here
02:55:51	morgan	what did I miss?
02:56:00	morgan	can't find it in the backlog ATM.
03:48:31	RiteshPaiboina	who jaypipes
04:18:02	openstackgerrit	falseuser proposed openstack/nova master: [BugFix] Check the instance task status to release the memory quota for vram https://review.openstack.org/456050
04:18:03	openstackgerrit	falseuser proposed openstack/nova master: [BugFix]Include the video ram when comparing the difference of two flavors https://review.openstack.org/460388
05:15:37	openstackgerrit	Kiseok Kim proposed openstack/nova master: Fixed a broken link in API Plugins document https://review.openstack.org/460398
05:58:21	openstackgerrit	falseuser proposed openstack/nova master: [BugFix] Release the memory quota for video ram when deleting an instance. https://review.openstack.org/456050
06:20:37	openstackgerrit	龚肖 proposed openstack/nova master: Add mock check and fix uuid's use in test. https://review.openstack.org/459501
06:44:45	openstackgerrit	falseuser proposed openstack/nova master: [BugFix] Check the instance task status to release the memory quota for vram https://review.openstack.org/456050
06:44:46	openstackgerrit	falseuser proposed openstack/nova master: [BugFix] Include the video ram when comparing the difference of two flavors https://review.openstack.org/460388
06:58:33	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(2/4) https://review.openstack.org/459569
07:00:27	openstackgerrit	龚肖 proposed openstack/nova master: Add mock check and fix uuid's use in test. https://review.openstack.org/459501
07:04:14	openstackgerrit	falseuser proposed openstack/nova master: [BugFix] Release the memory quota for video ram when deleting an instance. https://review.openstack.org/456050
07:13:43	openstackgerrit	falseuser proposed openstack/nova master: [BugFix] Release the memory quota for video ram when deleting an instance. https://review.openstack.org/456050
07:40:46	openstackgerrit	jichenjc proposed openstack/python-novaclient master: Remove 1.1 extension comment https://review.openstack.org/459503
07:54:32	openstackgerrit	jichenjc proposed openstack/nova master: Use plain routes list for limits endpoint instead of stevedore https://review.openstack.org/458805
07:54:33	openstackgerrit	jichenjc proposed openstack/nova master: Use plain routes list for hosts endpoint instead of stevedore https://review.openstack.org/459231
07:54:33	openstackgerrit	jichenjc proposed openstack/nova master: use plain routes list for hypervisor endpoint instead of stevedore https://review.openstack.org/459235
08:00:18	openstackgerrit	Mikhail Feoktistov proposed openstack/nova master: Add is_vz_container function https://review.openstack.org/445947
08:08:03	openstackgerrit	Sylvain Bauza proposed openstack/nova master: WIP: Delete existing allocations for move operations or retries https://review.openstack.org/460433
08:08:05	openstackgerrit	falseuser proposed openstack/nova master: [BugFix] Include the video ram when comparing the difference of two flavors https://review.openstack.org/460388
08:16:20	openstackgerrit	Shunli Zhou proposed openstack/nova master: Periodically load nova.conf https://review.openstack.org/460437
08:55:59	openstackgerrit	Sylvain Bauza proposed openstack/nova master: WIP: Allocate instance by the conductor https://review.openstack.org/460455
09:22:10	openstackgerrit	Gábor Antal proposed openstack/nova master: [WIP] Transform instance.live_migration_rollback notification https://review.openstack.org/402124
09:26:42	openstackgerrit	Abhishek Sharma M proposed openstack/nova master: Catching OverQuota Exception https://review.openstack.org/460305
09:42:48	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Add BDM to InstancePayload https://review.openstack.org/448779
09:42:49	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Add keypairs field to InstancePayload https://review.openstack.org/419730
09:47:47	openstackgerrit	NidhiMittalHada proposed openstack/python-novaclient master: Nova volume-attach doesn't care for device name https://review.openstack.org/454048
09:50:36	openstackgerrit	John Garbutt proposed openstack/nova master: Add description to policies in migrations.py https://review.openstack.org/459727
09:51:43	openstackgerrit	Matthew Booth proposed openstack/nova master: Don't check for file type in _find_base_file https://review.openstack.org/334958
09:51:43	openstackgerrit	Matthew Booth proposed openstack/nova master: Add context comments to _handle_base_image https://review.openstack.org/334956
09:51:44	openstackgerrit	Matthew Booth proposed openstack/nova master: Rename _handle_base_image to _mark_in_use https://review.openstack.org/334957
10:03:29	johnthetubaguy	sfinucan: did you look to see if someone has got the change to bump the oslo.policy minimum up yet?
10:09:52	openstackgerrit	John Garbutt proposed openstack/nova master: Sensibly wrap policy help messages https://review.openstack.org/460097
10:27:11	cdent	johnthetubaguy, alex_xu: if you have spare brain this improvement to placement and resource tracker wants eyes: https://review.openstack.org/#/c/448791/ (and above)
10:27:40	johnthetubaguy	I have my head in policy right now, but I should do something different soon
10:28:10	cdent	if you've been in policy I would be very surprised if you have spare brain
10:31:42	openstackgerrit	John Garbutt proposed openstack/nova master: Ensure sample policy help text correctly wrapped https://review.openstack.org/460097
10:33:12	openstackgerrit	John Garbutt proposed openstack/nova master: Ensure sample policy help text correctly wrapped https://review.openstack.org/460097
10:38:11	sfinucan	johnthetubaguy: I did not, but I figure we can
10:38:38	johnthetubaguy	sfinucan: I tried a few things out, and pushed a new version of your patch
10:38:51	sfinucan	johnthetubaguy: Yup. +1d it. Works fine for me locally now
10:38:53	sfinucan	Thanks :)
10:38:56	johnthetubaguy	https://review.openstack.org/460097 that is
10:39:47	johnthetubaguy	sfinucan: cool, yeah, did a rebase to drop all that observable messy, whoop
10:40:13	sfinucan	johnthetubaguy: admin_or_owner, admin_api, and network:attach_external_network are the only ones left. Two of those are being deprecated, right?

Earlier   Later