| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-04-26 | |||
| 11:24:17 | ralonsoh | jaypipes: good morning. Flash question: https://review.openstack.org/#/c/451777/6/nova/objects/pci_device_pool.py | |
| 11:24:34 | ralonsoh | jaypipes: do we need to bump the version of an object if the parent is updated? | |
| 11:24:51 | jaypipes | ralonsoh: no | |
| 11:24:54 | ralonsoh | thanks | |
| 11:25:06 | jaypipes | ralonsoh: flash answer :) | |
| 11:25:08 | ralonsoh | that's all, enjoy your coffee | |
| 11:25:14 | jaypipes | hehe | |
| 11:41:43 | jaypipes | moshele: mornin. just approved the hw-tc-offload os-vif patch. excellent work on that. | |
| 11:42:23 | moshele | jaypipes: thanks :) | |
| 12:45:34 | alex_xu | nova api meeting is in 15 mins at #openstack-meeting-4 | |
| 12:50:55 | openstackgerrit | sahid proposed openstack/nova master: numa: fix an uninitialized local variable https://review.openstack.org/458848 | |
| 12:52:21 | openstackgerrit | Stephen Finucane proposed openstack/os-vif master: Require OVS 2.8 (presumed) and kernel 4.8 for offload https://review.openstack.org/460093 | |
| 12:52:22 | openstackgerrit | Stephen Finucane proposed openstack/os-vif master: Standardize README https://review.openstack.org/460094 | |
| 12:53:04 | sfinucan | jaypipes. moshele: noddy doc fixes ye should check out ^ | |
| 12:53:14 | sfinucan | sean-k-mooney too ^ | |
| 12:53:30 | johnthetubaguy | sfinucan: about your comments here, I am just quoting from the api-ref, which seemed the correct thing to do: https://review.openstack.org/#/c/459711/3 | |
| 12:55:33 | sfinucan | johnthetubaguy: Yup, I get your reasoning. I'd rather have it "correct" in one place myself but I'm not too worried to hold it up on that | |
| 12:55:47 | sfinucan | the reno/left over vars were what the hold up was for | |
| 12:56:07 | johnthetubaguy | sfinucan: left over vars? I thought that was the other patch | |
| 12:56:25 | sfinucan | johnthetubaguy: I might be mixing up patches. Oops | |
| 12:56:35 | johnthetubaguy | sfinucan: no worries, I keep doing that too | |
| 12:57:37 | johnthetubaguy | sfinucan: my grammar is fairly terrible, so they all read the same to me, I just don't want to flip flop between different wordings | |
| 12:58:03 | sfinucan | johnthetubaguy: Hmm, could I be super-nitty and ask you to fix it? :/ | |
| 12:58:07 | sfinucan | I can do it too | |
| 12:58:17 | johnthetubaguy | sfinucan: I can fix it up, thats fine | |
| 12:58:26 | johnthetubaguy | sfinucan: just wanted to be sure thats the way you want it | |
| 12:58:41 | sfinucan | johnthetubaguy: Ideally, yes :) | |
| 12:58:47 | sfinucan | I tend to write those things in imperative mood, present tense | |
| 12:58:51 | sfinucan | like a command | |
| 12:58:59 | sfinucan | ditto for commit message, fwiw ;) | |
| 13:00:19 | alex_xu | nova api meeting is running | |
| 13:00:59 | johnthetubaguy | sfinucan: yeah, I don't really know the difference really, never got taught any of that, except a small amount in french and german, its kinda frustraighting they culled all that for a few years over here, I should probably go back and read up on all that at some point. | |
| 13:01:55 | kashyap | johnthetubaguy: Git itself uses the "imperative mood" | |
| 13:02:03 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Sensibly wrap policy help messages https://review.openstack.org/460097 | |
| 13:02:20 | kashyap | Merge branch 'blah' | |
| 13:02:22 | sfinucan | johnthetubaguy, sdague: You were asking for this ^ | |
| 13:02:24 | sfinucan | ? | |
| 13:02:30 | kashyap | (Revert "Foo", etc) | |
| 13:02:51 | sfinucan | johnthetubaguy: I don't know where I learnt it, though I'm guessing school | |
| 13:03:10 | kashyap | Speaking of grammar, /me _just_ gave a "level-3" exam of his 4th language, Dutch | |
| 13:03:34 | kashyap | And _just_ managed to pass (52% in writing; 71.% marks in speaking) | |
| 13:03:34 | johnthetubaguy | sfinucan: yeah, its stuff they brought back in just after I left school, I believe | |
| 13:04:02 | sfinucan | johnthetubaguy: We did things like cursive writing (? the one where you join letters etc.) in England, but I don't recall them teaching any of that in Ireland :/ | |
| 13:04:23 | mriedem | alex_xu: api meeting? | |
| 13:04:27 | sfinucan | My siblings' writing is absolutely awful | |
| 13:04:34 | sfinucan | mriedem: Yup, openstack-meeting-4 | |
| 13:04:51 | mriedem | cursive is old news | |
| 13:04:59 | sfinucan | kashyap: Congrats, dude :) That's outrageously impressive | |
| 13:05:10 | johnthetubaguy | sfinucan: oh, funky, they did a slightly strange course at mine I think, missed out the useful bits! | |
| 13:05:20 | johnthetubaguy | sfinucan: I don't remember its name now | |
| 13:05:47 | kashyap | sfinucan: Duh, that 52% in writing was danglingly close! The goddmaned thing trips me up is the "inversion" (which is same in Dutch and German) | |
| 13:05:52 | kashyap | E.g: "If I am sick, I go to the doctor", it becomes: "If I am sick, go I to the doctor" | |
| 13:05:57 | sfinucan | johnthetubaguy: I blame Thatcher | |
| 13:06:04 | sfinucan | Always blame Thatcher | |
| 13:07:11 | kashyap | sfinucan: But yeah, not complaining; tomorrow night (right after work) starts my level-4 -- "maintain the momentum" :P | |
| 13:07:13 | sdague | sfinucan: yeh, though is that going to destroy intentional formatting? | |
| 13:07:13 | sfinucan | kashyap: It's be "If I sick am", no? | |
| 13:07:34 | kashyap | sfinucan: That, too! | |
| 13:07:37 | sfinucan | i.e. Wenn ich krank bin, | |
| 13:07:39 | sfinucan | ... | |
| 13:07:54 | sfinucan | yada yada random guttural words | |
| 13:07:55 | sdague | I feel like we went around in circles here before on oslo.config where force rewrapping is not always the answer | |
| 13:08:20 | sfinucan | sdague: It would if we're doing things like bullet points | |
| 13:08:28 | sdague | yeh | |
| 13:08:43 | sdague | which are often useful | |
| 13:08:49 | sfinucan | but I didn't spot any of those during my reviews so I _think_ we're good here | |
| 13:08:55 | sdague | right, yet :) | |
| 13:09:12 | sdague | yeh, we should be ok for now, but I am sure it will show up as a desire | |
| 13:09:20 | sfinucan | Well, hopefully by time that happens we'll be using the oslo.policy version | |
| 13:09:25 | sfinucan | then it's their problem | |
| 13:09:55 | sdague | so, out of curiosity, what was the key issue with the wrapping? was it losing 2 columns to the comment? | |
| 13:10:07 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Plumbing for tagged nic attachment https://review.openstack.org/415622 | |
| 13:10:08 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Delete nic metadata when detaching interface https://review.openstack.org/435387 | |
| 13:10:10 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Libvirt support for tagged volume attachment https://review.openstack.org/418100 | |
| 13:10:12 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Delete disk metadata when detaching volume https://review.openstack.org/435082 | |
| 13:10:17 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Plumbing for tagged volume attachment https://review.openstack.org/391941 | |
| 13:10:17 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: API support for tagged device attachment https://review.openstack.org/376021 | |
| 13:10:19 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Libvirt support for tagged nic attachment https://review.openstack.org/415520 | |
| 13:10:22 | sfinucan | Pretty much, yeah | |
| 13:11:10 | sfinucan | and the outputter was presumably doing a dumb, N char wrap | |
| 13:11:43 | sfinucan | artom: Anything new in those or simple resolution of that merge conflict | |
| 13:11:44 | sfinucan | ? | |
| 13:11:50 | openstackgerrit | Daniel Pawlik proposed openstack/nova master: Added kvm_hidden feature https://review.openstack.org/459753 | |
| 13:15:08 | artom | sfinucan, rebase and api version bump because something else took 2.43, 2.44 and 2.45 | |
| 13:16:04 | artom | dansmith, mriedem, actually, since sfinucan brought it up, can you take a look at that series? Rebasing it with a new API version is a pain, I would greatly appreciate if we could merge before I have to version bump again :) | |
| 13:16:07 | openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: console https://review.openstack.org/409402 | |
| 13:18:16 | mriedem | artom: is the tempest test passing? | |
| 13:19:08 | artom | mriedem, well, not right this instant, but yes, I got it to pass by waiting for the default cache expiry duration | |
| 13:20:54 | sean-k-mooney | sfinucan: ya the readme change makes sense to me | |
| 13:21:40 | sean-k-mooney | i have +2ed the review but ill hold off on the +W untill the gate jobs have run | |
| 13:22:18 | sean-k-mooney | i want to make sure the embeeded image render corretly but the rst files look fine | |
| 13:23:14 | sfinucan | sean-k-mooney: There's an embedded image? | |
| 13:23:20 | sfinucan | oh - the pypi badge | |
| 13:23:23 | sfinucan | Cool :) | |
| 13:23:41 | sean-k-mooney | yep the pypi ones | |
| 13:23:42 | openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: SSP emphemeral disk support https://review.openstack.org/443189 | |
| 13:24:07 | efried | sdague mriedem ^^ trivial (but manual) rebase FYI. | |
| 13:25:18 | sean-k-mooney | sfinucan: wait https://review.openstack.org/#/c/398277/ was merged? | |
| 13:25:27 | sean-k-mooney | has the code landed in ovs yet? | |
| 13:25:35 | sean-k-mooney | if not this should not have been merged | |