Posted	Nick	Remark
#openstack-nova - 2017-04-25
19:16:18	mriedem	yes
19:16:35	mriedem	https://review.openstack.org/#/c/455443/
19:17:34	cfriesen	kay...will adjust it.
19:18:47	cfriesen	why 2_46 instead of 2.46?
19:19:15	mriedem	can you have . in the name?
19:19:38	cfriesen	no idea. :)
19:20:01	cfriesen	I see this: - security_group.name: name
19:20:22	cfriesen	I'm easy either way
19:20:59	mriedem	security_group.name is the label in the docs
19:21:02	mriedem	which is fine
19:21:12	mriedem	and how we label entries within a dict/object
19:21:33	mriedem	but within parameters.yaml i don't know if the names can have . in them
19:22:22	cfriesen	I'll play it safe
19:23:48	cfriesen	mriedem: as far as describing the fields in the dict, the volumeAttachment parameter in parameters.yaml just has a text description of the fields in the dict...is that the correct model to follow?
19:24:19	mriedem	no
19:24:22	mriedem	that's the lazy way
19:24:50	mriedem	i recently did something with this, lemme see if i can find it
19:25:20	openstackgerrit	Lee Yarwood proposed openstack/nova master: compute: Detach volumes on _rebuild_default_impl failure https://review.openstack.org/442105
19:26:21	mriedem	cfriesen: see https://review.openstack.org/#/c/449809/
19:26:29	mriedem	i guess you can have periods and colons and stuff in the parameter names
19:27:41	cfriesen	mriedem: okay, will try that
19:27:47	mriedem	that gives you https://developer.openstack.org/api-ref/compute/?expanded=show-server-details-detail#show-server-details
19:28:06	mriedem	so os-extended-volumes:volumes_attached is the top-level array of dicts,
19:28:22	mriedem	and each dict has os-extended-volumes:volumes_attached.id and os-extended-volumes:volumes_attached.delete_on_termination (the latter depending on microversion)
19:28:38	mriedem	so "volumes_attached" is a kind of namespace
19:28:49	cfriesen	mriedem: is there any way to avoid duplicating it every place that flavor_server is used? (four places in servers.inc)
19:28:51	mriedem	and the .<field> suffix is the entry in that dict (namespace)
19:29:10	mriedem	well, are you changing all 4 of those places?
19:29:31	cfriesen	mriedem: yep...but they're all going to get the same dict....so I don't want to have to define the dict separately in all the places
19:30:42	mriedem	i'm not aware of way to do that, unless you just have a single parameter and describe all of the fields in that dict within the single parameter description
19:30:55	mriedem	i'm not totally opposed to that
19:31:00	mriedem	sdague: oomichi: ^ thoughts?
19:31:11	cfriesen	I don't see any precedent in parameters.yaml to define a dict
19:31:12	mriedem	it's all .rst so you can format it nicely with bullets
19:31:52	cfriesen	I can give it a shot....which tox test do I run to get the output of this?
19:32:02	mriedem	tox -e api-ref
19:32:10	mriedem	your flavor dict is going to have what, 7 fields?
19:32:15	cfriesen	ish, yeah
19:32:24	mriedem	https://developer.openstack.org/api-ref/compute/?expanded=show-server-details-detail,show-flavor-details-detail#id187 minus is_public and disabled
19:32:47	mriedem	oh plus extra specs
19:32:49	mriedem	so 8
19:33:02	cfriesen	yes
19:33:06	mriedem	cfriesen: so maybe just start with a single new parameter
19:33:16	mriedem	with the big description detailing each field within it
19:33:19	mriedem	and we'll see how that looks
19:33:38	cfriesen	it's too bad, because the fields are mostly already described in parameters.yaml
19:34:06	cfriesen	but yeah, I'll give it a try
19:34:07	mriedem	there might be a way to reference parameters, but idk
19:36:18	openstackgerrit	Matthew Treinish proposed openstack/nova master: Remove nova-cert https://review.openstack.org/459460
19:36:29	mtreinish	sdague: ^^^ is that what you were looking for?
19:41:19	oomichi	mriedem: I could not get which patch I need to review.. anyways your patch https://review.openstack.org/#/c/455443/9/nova/api/openstack/compute/rest_api_version_history.rst has strange HEAD
19:41:37	openstackgerrit	Mathieu Gagné proposed openstack/nova master: Add ability to signal and perform online volume size change https://review.openstack.org/454322
19:42:56	mriedem	oomichi: gah!
19:43:03	mriedem	oomichi: that was an easter egg for sdague :)
19:43:16	oomichi	hehe :)
19:43:28	mriedem	i'll fix it up
19:46:33	mgagne	now that's challenging when you have multiple changes bumping microversion :D
19:47:49	mriedem	yeah it's not fun
19:47:55	mriedem	plus novaclient
19:47:58	openstackgerrit	Matt Riedemann proposed openstack/nova master: Support tag instances when boot(1) https://review.openstack.org/459523
19:47:58	openstackgerrit	Matt Riedemann proposed openstack/nova master: Support tag instances when boot(2) https://review.openstack.org/459569
19:52:43	openstackgerrit	Matt Riedemann proposed openstack/nova master: 2.45: Remove Location header from createImage and createBackup responses https://review.openstack.org/455443
19:52:45	mriedem	oomichi: fixed ^
19:55:52	oomichi	mriedem: sdague is faster than me, +A
19:57:30	mriedem	thanks
19:57:53	mriedem	i've got the 2.43 novaclient change up, need to work on 2.44 and then rebase the 2.45 novaclient change
20:06:03	openstackgerrit	melanie witt proposed openstack/nova master: Add FixedIP.get_count_by_project() https://review.openstack.org/446246
20:06:04	openstackgerrit	melanie witt proposed openstack/nova master: Add FloatingIP.get_count_by_project() https://review.openstack.org/446247
20:06:04	openstackgerrit	melanie witt proposed openstack/nova master: Add get_count_by_vm_state() to Instance object https://review.openstack.org/446244
20:06:05	openstackgerrit	melanie witt proposed openstack/nova master: Add SecurityGroup.get_counts() https://review.openstack.org/446245
20:06:05	openstackgerrit	melanie witt proposed openstack/nova master: Remove 'reserved' count from used limits https://review.openstack.org/446242
20:06:06	openstackgerrit	melanie witt proposed openstack/nova master: Remove useless quota_usage_refresh from nova-manage https://review.openstack.org/446243
20:06:06	openstackgerrit	melanie witt proposed openstack/nova master: Count server groups to check quota https://review.openstack.org/446240
20:06:07	openstackgerrit	melanie witt proposed openstack/nova master: Count networks to check quota https://review.openstack.org/446241
20:06:07	openstackgerrit	melanie witt proposed openstack/nova master: Count instances to check quota https://review.openstack.org/416521
20:06:08	openstackgerrit	melanie witt proposed openstack/nova master: Add InstanceGroup.get_counts() https://review.openstack.org/457857
20:06:08	openstackgerrit	melanie witt proposed openstack/nova master: Add check_deltas() and limit_check_project_and_user() to Quotas https://review.openstack.org/446239
20:06:09	openstackgerrit	melanie witt proposed openstack/nova master: Add InstanceGroup._remove_members_in_db https://review.openstack.org/457858
20:06:09	openstackgerrit	melanie witt proposed openstack/nova master: Count server group members to check quota https://review.openstack.org/457859
20:06:10	openstackgerrit	melanie witt proposed openstack/nova master: Count security groups to check quota https://review.openstack.org/457860
20:06:10	openstackgerrit	melanie witt proposed openstack/nova master: Make Quotas object favor the API database https://review.openstack.org/410945
20:06:11	openstackgerrit	melanie witt proposed openstack/nova master: Count fixed ips to check quota https://review.openstack.org/457861
20:06:12	openstackgerrit	melanie witt proposed openstack/nova master: Add online migration to move quotas to API database https://review.openstack.org/410946
20:06:12	openstackgerrit	melanie witt proposed openstack/nova master: Count floating ips to check quota https://review.openstack.org/457862
20:10:02	openstackgerrit	Ken'ichi Ohmichi proposed openstack/nova master: Update doc/source/process.rst https://review.openstack.org/457888
20:18:12	openstackgerrit	Rick Bartra proposed openstack/nova master: Add policy granularity to the Flavors API https://review.openstack.org/449288
20:36:05	openstackgerrit	Ildiko Vancsa proposed openstack/nova master: Add Cinder v3 detach call to post_live_migration https://review.openstack.org/456988
20:41:20	cfriesen	maybe an odd question...but has anyone ever considered that it doesn't really make sense to rebuild a boot-from-volume instance to a new image since we don't overwrite the volume contents but we do change the reported image in the instance details.
20:41:43	cfriesen	seems like either we should overwrite the volume contents or else we should disallow rebuilding to a different image
20:48:09	mriedem	cfriesen: https://bugs.launchpad.net/nova/?field.searchtext=rebuild%20boot%20from%20volume&search=Search&field.status%3Alist=NEW&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=FIXCOMMITTED&field.assignee=&field.bug_reporter=&field.omit_dupes=on&field.has_patch=&field.has_no
20:48:10	mriedem	kage=&orderby=-datecreated&start=0
20:48:57	mriedem	known issue
20:53:22	openstackgerrit	Matt Riedemann proposed openstack/python-novaclient master: 2.44: Deprecate multinic/floatingIP actions and os-virtual-interfaces https://review.openstack.org/459859
20:56:10	openstackgerrit	Matt Riedemann proposed openstack/python-novaclient master: 2.44: Deprecate multinic/floatingIP actions and os-virtual-interfaces https://review.openstack.org/459859
20:58:53	cfriesen	mriedem: is that the openstack equivalent of lmgtfy? :)
21:00:06	mriedem	cfriesen: not necessarily
21:00:14	mriedem	i just know there are known bugs with rebuild + bfv
21:00:59	cfriesen	mriedem: looks like https://bugs.launchpad.net/nova/+bug/1482040 is what we ran into
21:00:59	openstack	Launchpad bug 1482040 in OpenStack Compute (nova) "rebuild volume-backed instance with image" [Undecided,In progress] - Assigned to Akira KAMIO (kamio)
21:04:22	cfriesen	seems to me that we should either make it work "properly" or else disallow rebuild with a different image. otherwise the results are unexpected.

Earlier   Later