| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-04-24 | |||
| 09:21:46 | johnthetubaguy | abhi89: ah... sorry, let me read the comments not the code | |
| 09:22:12 | abhi89 | yes.. please go through my comment of proposed solution once | |
| 09:23:00 | johnthetubaguy | abhi89: we do need to translate the exception, its a common patter we have for all cinder errors. What I would do is just add additional information into the translated exception | |
| 09:24:37 | sfinucan | johnthetubaguy: Could you stick these on your review queue? https://review.openstack.org/#/q/status:open+topic:bp/move-nova-cmds-to-cliff | |
| 09:24:47 | johnthetubaguy | abhi89: I would recommend you instead look at this line of code: https://github.com/openstack/nova/blob/5a6d4e089dca2515c0f7e083a8b903ac7a166773/nova/volume/cinder.py#L203 | |
| 09:24:54 | sfinucan | I'd like to get them merged this cycle so I can push on with that bp next cycle | |
| 09:26:36 | abhi89 | johnthetubaguy: yes. we can even add additional information to the translated exception at https://github.com/openstack/nova/blob/5a6d4e089dca2515c0f7e083a8b903ac7a166773/nova/volume/cinder.py#L203 | |
| 09:27:11 | johnthetubaguy | sfinucan: possibly, my queue is getting a bit silly right now, particularly given I don't have a job by the time the summit happens, AFAIK :( | |
| 09:27:11 | abhi89 | johnthetubaguy: i will try this out | |
| 09:27:23 | johnthetubaguy | abhi89: thanks, I think thats probably going to be easiest way to fix it | |
| 09:27:42 | abhi89 | johnthetubaguy: yes, thanks for your suggestion | |
| 09:28:05 | johnthetubaguy | abhi89: no problems, sorry I didn't add that on the first set of comments, I should have. | |
| 09:28:55 | johnthetubaguy | sfinucan: oh, wait, I see, its tiny | |
| 09:31:08 | sfinucan | johnthetubaguy: Yeah they're tidy enough. If you've enough on your plate though then they certainly wait | |
| 09:38:27 | openstackgerrit | jichenjc proposed openstack/nova-specs master: Add os-quota-class-sets-query-update https://review.openstack.org/459185 | |
| 10:01:57 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types https://review.openstack.org/430608 | |
| 10:06:48 | openstackgerrit | jichenjc proposed openstack/nova master: Use plain routes list for limits endpoint instead of stevedore https://review.openstack.org/458805 | |
| 10:18:15 | bhagyashris | cdent: Hi, | |
| 10:21:54 | cdent | hi bhagyashris, what's up? | |
| 10:31:48 | openstackgerrit | jichenjc proposed openstack/nova master: Use plain routes list for hosts endpoint instead of stevedore https://review.openstack.org/459231 | |
| 10:32:35 | bhagyashris | cdent: Fine. I have one doubt. Actually I have configured the multinode setup and tried to use the nfs shared storage. so How can I used the single resource provider in multinode setup? | |
| 10:34:06 | cdent | bhagyashris: are you saying you want to track the nfs share as a resource provider? If so, that's not yet supported. It's still the case that the compute-node will report the disk to which it has access. Shared resource providers is something we hope to get done before the end of this current cycle | |
| 10:34:15 | cdent | bhagyashris: if you mean something else, what is it? | |
| 10:35:25 | bhagyashris | cdent: yeah i want to track nfs share as a resource provider. | |
| 10:36:35 | cdent | bhagyashris: there's a blueprint for that here, but progress is stalled while we work some other things out first: https://blueprints.launchpad.net/nova/+spec/shared-resources-pike | |
| 10:37:24 | bhagyashris | cdent: ok. means on current master we can not configure the shared disk resource provider for multinode set up right? | |
| 10:37:24 | cdent | you could, if you wanted, track the nfs share as a resource provider and manage its inventory with your own tooling, now, but that information wouldn't yet be used in scheduling decisions | |
| 10:37:31 | cdent | correct | |
| 10:37:41 | bhagyashris | cdent: ok i will go through the blueprint. | |
| 10:38:22 | bhagyashris | cdent: i look in to the blueprint regading the resource pool but not sure that the implementation is completed. | |
| 10:38:40 | bhagyashris | cent: thank you for information | |
| 10:44:31 | openstackgerrit | jichenjc proposed openstack/nova master: use plain routes list for hypervisor endpoint instead of stevedore https://review.openstack.org/459235 | |
| 10:49:30 | openstackgerrit | jichenjc proposed openstack/nova master: Use plain routes list for limits endpoint instead of stevedore https://review.openstack.org/458805 | |
| 10:49:30 | openstackgerrit | jichenjc proposed openstack/nova master: Use plain routes list for flavors-access endpoint instead of stevedore https://review.openstack.org/456589 | |
| 10:49:31 | openstackgerrit | jichenjc proposed openstack/nova master: Use plain routes list for '/servers' endpoint instead of stevedore https://review.openstack.org/445864 | |
| 10:49:31 | openstackgerrit | jichenjc proposed openstack/nova master: Use plain routes list for flavor endpoint instead of stevedore[1] https://review.openstack.org/456549 | |
| 10:49:32 | openstackgerrit | jichenjc proposed openstack/nova master: Use plain routes list for hosts endpoint instead of stevedore https://review.openstack.org/459231 | |
| 10:49:32 | openstackgerrit | jichenjc proposed openstack/nova master: Use plain routes list for '/os-aggregates' endpoint instead of stevedore https://review.openstack.org/456825 | |
| 10:49:33 | openstackgerrit | jichenjc proposed openstack/nova master: Use plain routes list for flavors-extraspecs endpoint instead of stevedore https://review.openstack.org/456585 | |
| 10:49:34 | openstackgerrit | jichenjc proposed openstack/nova master: Use plain routes list for '/os-keypairs' endpoint instead of stevedore https://review.openstack.org/456478 | |
| 10:49:35 | openstackgerrit | jichenjc proposed openstack/nova master: use plain routes list for hypervisor endpoint instead of stevedore https://review.openstack.org/459235 | |
| 12:00:58 | openstackgerrit | Moshe Levi proposed openstack/os-vif master: HW offload support for openvswitch https://review.openstack.org/398277 | |
| 12:00:59 | openstackgerrit | Moshe Levi proposed openstack/os-vif master: add documentation for vif plug ovs https://review.openstack.org/459258 | |
| 12:14:59 | openstackgerrit | jichenjc proposed openstack/nova master: Add description for /consoles https://review.openstack.org/459266 | |
| 12:25:45 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types https://review.openstack.org/430608 | |
| 12:43:26 | mriedem | lyarwood: i replied in https://review.openstack.org/#/c/456896/ - i'm not sure i get your concern though | |
| 12:45:08 | lyarwood | mriedem: morning, yeah I missed the optimisation, I just assumed we were doing this to allow non-local connectors to be passed in as a kwarg that we would default to None when we wanted to use the local connector. | |
| 12:49:14 | mriedem | lyarwood: when i looked at the change that were passing a connector in, none of them had a local connector | |
| 12:49:28 | mriedem | *was | |
| 12:52:12 | lyarwood | mriedem: into _terminate_volume_connections? Sorry I don't follow. | |
| 12:52:44 | mriedem | earlier version of the patch https://review.openstack.org/#/c/456896/3/nova/compute/manager.py@3615 | |
| 12:52:54 | mriedem | was going out of it's way to get the connector and then pass it in to justify the kwarg | |
| 12:52:56 | mriedem | i don't know why | |
| 12:53:17 | mriedem | so until we actually need a connector=None kwarg on _terminate_volume_connections, i've omitted that | |
| 12:53:47 | lyarwood | mriedem: yeah that didn't make sense but that's the local compute connector, thus my confusion above ;) | |
| 12:54:07 | lyarwood | mriedem: and yeah, until we have a stashed connector to pass in the kwarg doesn't make sense | |
| 12:54:32 | lyarwood | mriedem: I just missed the optimisation and assumed we wanted to add the kwarg early | |
| 12:55:04 | lyarwood | anyway, back to these LM failures on stable | |
| 12:55:26 | mriedem | lyarwood: so are you still -1 on https://review.openstack.org/#/c/456896/ ? | |
| 12:55:36 | lyarwood | mriedem: no, I'll clean that up now | |
| 12:56:05 | mriedem | thanks | |
| 12:58:14 | mriedem | jgriffith: when you're around, i had some questions marked with TODOs in the swap volume change for using the new cinder attachment APIs https://review.openstack.org/#/c/456971/4/nova/compute/manager.py | |
| 12:58:30 | mriedem | like, will deleting an attachment mess up migrate_volume_completion on the cinder side? | |
| 12:59:10 | mriedem | https://review.openstack.org/#/c/456971/4/nova/compute/manager.py@4993 and https://review.openstack.org/#/c/456971/4/nova/compute/manager.py@5017 specifically | |
| 13:00:29 | lyarwood | mdbooth: https://review.openstack.org/#/c/458807/ updated if you have anytime this afternoon | |
| 13:00:36 | lyarwood | kashyap: ^ also | |
| 13:00:55 | lyarwood | kashyap: could you also take a look at https://review.openstack.org/#/c/458854/1 | |
| 13:01:04 | kashyap | lyarwood: Struggling with something else at the moment :-( | |
| 13:01:13 | lyarwood | kashyap: np | |
| 13:01:13 | kashyap | lyarwood: But I didn't forget your ping here | |
| 13:02:10 | kashyap | lyarwood: Oh, the latter one I have the context in my head | |
| 13:02:13 | kashyap | Should be easy :-) | |
| 13:02:31 | kashyap | It's in 1.2.7; which is well above the min version we have. | |
| 13:02:34 | kashyap | Nice find! | |
| 13:06:34 | kashyap | lyarwood: Done for the second one; the 'rebase' failures are from an iSCSI-related bug? | |
| 13:07:16 | lyarwood | kashyap: yup, from the SELinux issue | |
| 13:07:18 | kashyap | Yeah, at least the linked bug says so | |
| 13:07:45 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add Cinder v3 detach to swap_volume https://review.openstack.org/456971 | |
| 13:17:30 | lyarwood | http://logs.openstack.org/43/458843/1/check/gate-tempest-dsvm-multinode-live-migration-ubuntu-xenial/145ed83/console.html#_2017-04-24_13_15_00_520308 - Can anyone comment on why we would want to skip block live migration tests here? | |
| 13:18:31 | lyarwood | ah nvm I think it's https://bugs.launchpad.net/nova/+bug/1398999 | |
| 13:18:31 | openstack | Launchpad bug 1398999 in nova (Ubuntu Trusty) "Block migrate with attached volumes copies volumes to themselves" [High,Triaged] | |
| 13:22:21 | jaypipes | cdent: thx much for the review on the get_inventory() for libvirt patch. I'll address your comments after a meeting in a few minutes. | |
| 13:23:08 | cdent | ✔ | |
| 13:23:33 | mriedem | lyarwood: we've never run those as far as i know | |
| 13:24:13 | mriedem | ah yeah because of that bug | |
| 13:24:19 | mriedem | in the config option help text | |
| 13:26:51 | openstackgerrit | Stephen Finucane proposed openstack/os-vif master: Add documentation for OVS plugin https://review.openstack.org/459258 | |
| 13:26:52 | openstackgerrit | Stephen Finucane proposed openstack/os-vif master: HW offload support for openvswitch https://review.openstack.org/398277 | |
| 13:26:53 | openstackgerrit | Stephen Finucane proposed openstack/os-vif master: Add documentation for Linux Bridge plugin https://review.openstack.org/459291 | |
| 13:27:51 | mriedem | lyarwood: looks like that bug is fixed https://review.openstack.org/#/c/227278/ | |
| 13:27:56 | mriedem | if you're using new enough libvirt | |
| 13:28:09 | mriedem | so we could probably actually turn that on in master now since we're using UCA | |
| 13:28:34 | mriedem | we're using libvirt 2.5.0 now | |
| 13:29:40 | kashyap | lyarwood: Just looking at the first change related to 'rebase' failure & dangling devices; so the disconnect_volume() is coming from os_brick (os_brick/initiator/connectors/iscsi.py) | |
| 13:29:54 | lyarwood | mriedem: yeah just reading through the bug now and thinking the same | |
| 13:30:07 | mriedem | i'll post a change to the live migration job to enable that test and see what happens | |
| 13:30:20 | lyarwood | cool thanks | |
| 13:30:42 | lyarwood | kashyap: well it's calling down into os-brick to disconnect the new volume, yeah. | |
| 13:30:57 | Shashi | Hello, anyone run into nova issues with the error "AttributeError: 'module' object has no attribute 'VIR_MIGRATE_POSTCOPY'" | |
| 13:31:30 | Shashi | I could see n-cpu services are not running because of this error | |