| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-04-14 | |||
| 16:45:14 | peter-hamilton | feeblepipes: i find it helps to summarize decisions and the back-and-forth over the months | |
| 16:45:30 | feeblepipes | yeah, it actually makes it a bit easier for those of us kinda coming into a spec late in its lifetime. | |
| 16:45:30 | peter-hamilton | feeblepipes: no one else seems to use it for much | |
| 16:45:42 | feeblepipes | ++ | |
| 16:52:44 | jangutter | Any more actions on https://review.openstack.org/456386 I need to take? | |
| 16:56:52 | feeblepipes | jangutter: did you push a new revision with wording around the "genericness" of parameters passed via os-vif/Neutron port binding profile? | |
| 16:57:49 | jangutter | feeblepipes: yeah, that's been updated, plus a link to the chat. | |
| 16:58:56 | feeblepipes | jangutter: awesome. reviewing again. | |
| 17:06:54 | feeblepipes | jangutter: k, +2 from me. mriedem, feel free to give 456386 another spin. | |
| 17:07:37 | jangutter | feeblepipes: thanks! | |
| 17:07:44 | feeblepipes | jangutter: np | |
| 17:08:03 | feeblepipes | dansmith: did you see johnthetubaguy's request for your review on https://review.openstack.org/#/c/407237/? | |
| 17:37:54 | owalsh | mriedem: yea, the related change in tripleo was to handle this | |
| 18:08:02 | mriedem | feeblepipes: jangutter: done | |
| 18:08:28 | feeblepipes | mriedem: thanks, Matt. and apologies for the delay on these after spec freeze. | |
| 18:08:33 | mriedem | p | |
| 18:08:35 | mriedem | *np | |
| 18:08:48 | mriedem | you get an exception because jay was sick | |
| 18:08:53 | mriedem | was/is | |
| 18:08:53 | feeblepipes | mriedem: I'm trying to get the GPU spec finalized and the one about listing migrations. | |
| 18:09:10 | mriedem | feeblepipes: i have not looked at the gpu spec and probably won't | |
| 18:09:20 | mriedem | i plan on looking at the listing migration types one though | |
| 18:09:24 | feeblepipes | mriedem: k | |
| 18:09:27 | mriedem | because that api annoys me | |
| 18:09:35 | feeblepipes | mriedem: I have a number of concerns on it, yes. | |
| 18:09:45 | mriedem | lack of gpu complexity in nova doesn't annoy me | |
| 18:09:58 | jangutter | feeblepipes, mriedem, you have my eternal gratitude! | |
| 18:10:36 | mriedem | feeblepipes: e.g. https://bugs.launchpad.net/nova/+bug/1668747 | |
| 18:10:36 | openstack | Launchpad bug 1668747 in OpenStack Compute (nova) "api-ref: os-migrations is missing response details and information about v2.23" [Medium,Confirmed] | |
| 18:10:42 | feeblepipes | jangutter: kein Problem! | |
| 18:11:18 | feeblepipes | jangutter: or maybe "geen probleem!"? :) | |
| 18:11:37 | jangutter | It's the second one! | |
| 18:11:41 | feeblepipes | aha! | |
| 18:12:44 | jangutter | Fair warning, don't let us Afrikaans people start teaching you phrases. You might end up learning the ultimate language to insult someone in. | |
| 18:13:03 | feeblepipes | :) | |
| 18:23:52 | openstackgerrit | Chris Dent proposed openstack/nova master: Update resource tracker to PUT custom resource classes https://review.openstack.org/456915 | |
| 18:32:44 | mriedem | feeblepipes: while you're close to passing out or vomiting, let me throw this on you https://review.openstack.org/#/c/453272/ | |
| 18:35:38 | feeblepipes | mriedem: what's the difference between the instance action of evacuate vs the instance action of rebuild? | |
| 18:36:09 | mriedem | with evacuate the source compute host is dead | |
| 18:36:13 | mriedem | with rebuild it's not | |
| 18:36:24 | feeblepipes | mriedem: how would the user know which is which? | |
| 18:36:31 | mriedem | users don't evacuate | |
| 18:36:33 | mriedem | since it's a migratoin | |
| 18:36:34 | mriedem | *migratoin | |
| 18:36:36 | mriedem | damn | |
| 18:36:37 | mriedem | migration | |
| 18:36:41 | mriedem | admins evacuate | |
| 18:36:47 | feeblepipes | mriedem: and who rebuilds? | |
| 18:36:58 | mriedem | users that want the same attached volumes but a new image | |
| 18:37:02 | mriedem | you can specify a new image with rebuild | |
| 18:37:08 | feeblepipes | le sigh... ok. | |
| 18:37:10 | mriedem | basically it's a server create to over | |
| 18:37:27 | mriedem | same host though i believe | |
| 18:37:31 | feeblepipes | do-over you mean? | |
| 18:37:46 | mriedem | the rebuild happens on the same host that the instance already lives on | |
| 18:37:51 | mriedem | it would have to for the networking and volumes | |
| 18:38:06 | mriedem | now rebuild + volume-backed root disk.... | |
| 18:38:11 | mriedem | i'd have to investigate | |
| 18:38:43 | mriedem | we track evacuations with the migrations table since it's a type of move | |
| 18:38:57 | mriedem | that was part of dan's robustify evacuate changes in i think mitaka | |
| 18:39:09 | mriedem | so that when the old host comes back up it doesn't delete all of your instances that are now running somewhere else | |
| 18:39:15 | mriedem | because that was a real thing | |
| 18:39:22 | mriedem | and could wipe out your entire vcenter cluster | |
| 18:39:24 | mriedem | you're welcome | |
| 18:39:50 | mriedem | i.e. we check the migrations table to see if an instance was evacuated on startup of the old host | |
| 18:40:27 | mriedem | https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L635 | |
| 18:42:40 | feeblepipes | mriedem: +W'd that spec. working on mgagne's one now. | |
| 18:44:09 | mriedem | i guess i should read the list migration types one | |
| 18:45:00 | mriedem | sfinucan: the spec for this is approved now so you can drop the procedural -2 https://review.openstack.org/#/c/430608/ | |
| 19:00:33 | openstackgerrit | Dan Peschman proposed openstack/nova master: Option to always create network metadata information as static https://review.openstack.org/336293 | |
| 19:49:01 | mriedem | feeblepipes: i left some comments in https://review.openstack.org/#/c/407237/ too | |
| 19:49:23 | mriedem | feeblepipes: i'm not sure why the various task state transitions were left in there, unless that was to show what in-progress meant for each type of migration? | |
| 19:49:35 | feeblepipes | yeah, maybe. | |
| 19:49:39 | mriedem | those don't line up with what the supported migration statuses are though | |
| 19:49:54 | mriedem | also, i've always found it odd that we filter what we return to just in-progress migrations | |
| 19:50:10 | mriedem | that is an artifact of when os-migrations was added, and i think it was only there for the cancel action | |
| 19:50:16 | mriedem | so those were tightly coupled | |
| 19:50:40 | mriedem | i don't think we should restrict the returned set to in-progress migrations by default, but rather allow a status filter parameter | |
| 19:54:37 | mriedem | i might blast the ML on that one unless there is a good reason i'm missing | |
| 19:54:40 | mriedem | i'd also like operator feedback | |
| 19:54:55 | feeblepipes | cool with me. | |
| 19:55:06 | feeblepipes | almost done with the VGPU spec. | |
| 20:01:10 | sdague | mriedem: hmmm... that does make me wonder if I could pillage instance actions in a reasonable way then for statistics. Perhaps I'll ponder that next week | |
| 20:01:26 | mriedem | and that reminds me to ask about instance actions for shelve in the ops list | |
| 20:05:49 | sdague | I think it would mostly be useful if we put something into nova-manage that would build statistics based on it for dump | |
| 20:11:30 | mriedem | yeah | |
| 20:11:40 | mriedem | also, crap, but we return db primary keys for the migrations api | |
| 20:11:56 | feeblepipes | sfinucan: -1 from me for a few remaining niggles on https://review.openstack.org/#/c/450122/, but it's pretty close. | |
| 20:12:04 | mriedem | so when you want to cancel an in-progress live migration out of the api, you pass in the id but with multi-cell we won't know which cell it's in | |
| 20:12:08 | feeblepipes | mriedem: yeah... that needs to die in a fire. | |
| 20:12:24 | mriedem | feeblepipes: well that's dying for services and compute nodes in the api, but i missed migrations | |
| 20:12:30 | feeblepipes | mriedem: also, since migrations list runs in all cells, you get duplicate migration IDs. fun! | |
| 20:12:38 | mriedem | feeblepipes: true story | |
| 20:12:43 | mriedem | i don't think dansmith has fixed that one yet | |
| 20:12:49 | mriedem | which is why we didn't think about it earlier | |
| 20:13:19 | feeblepipes | mriedem: it's not terribly important really... now that we removed the top-level os-migrations/ REST resource, it's not like there's a global key. | |
| 20:13:42 | feeblepipes | mriedem: meaning it's always under servers/.../os-migrations | |
| 20:13:58 | feeblepipes | mriedem: so, no harm no foul. the primary key is within the server's cell. | |
| 20:14:05 | feeblepipes | mriedem: but still, annoying and should die in a fire. | |
| 20:18:59 | mriedem | feeblepipes: oh you're right yeah, we'll lookup the instance via uuid, and when we do that we target the context to the cell that the instance is in | |