| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-04-07 | |||
| 15:35:27 | bauwser | but I think it could be worth it for operators wanting to ping-pong their migrations | |
| 15:35:29 | mriedem | so newton? | |
| 15:35:32 | bauwser | yup | |
| 15:35:42 | bauwser | the fix itself is not really intrusive | |
| 15:36:07 | bauwser | in general, I'd -1 such things, but I think the benefits go over the risk | |
| 15:36:20 | dansmith | yeah | |
| 15:36:31 | mriedem | seems fine to me | |
| 15:36:32 | dansmith | super tiny and it's a really stupid problem to have | |
| 15:37:06 | dansmith | "ownership" in the commit message -> security -> fine.. right? :) | |
| 15:37:08 | mriedem | +2 for you | |
| 15:38:52 | bauwser | mriedem: dansmith: thanks to both of you | |
| 15:39:23 | mriedem | you can pay me back by reviewing some stable/ocata backports | |
| 15:39:46 | mriedem | oh wait jesus | |
| 15:39:47 | mriedem | https://review.openstack.org/#/c/454593/ | |
| 15:39:58 | mriedem | is that in ocata? | |
| 15:40:11 | mriedem | oh it is | |
| 15:40:13 | mriedem | ok whew | |
| 15:40:18 | mriedem | i thought that was master for some reason | |
| 15:42:46 | bauwser | mriedem: it's in master and stable/ocata | |
| 15:42:53 | mriedem | yeah i see now | |
| 15:42:59 | mriedem | thought you pulled one over on me | |
| 15:43:16 | mriedem | always like it when you red hat kids are doing customer bug duty on a friday | |
| 15:43:47 | bauwser | mriedem: see my reviewstats for the last 3 days, and you'll guess it's not only friday :( | |
| 15:44:21 | mriedem | i see #16 here http://stackalytics.com/report/contribution/nova/30 | |
| 15:44:27 | mriedem | are you trying to impress me :P | |
| 15:44:59 | mriedem | we need these https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/ocata+topic:bug/1678326 | |
| 15:45:04 | mriedem | those are the regression backports for ocata | |
| 15:45:11 | bauwser | humpf http://russellbryant.net/openstack-stats/nova-reviewers-30.txt tells me 70-ish | |
| 15:45:14 | mriedem | and then i'll do an ocata release | |
| 15:45:33 | mriedem | ^ probably includes specs | |
| 15:45:55 | bauwser | oh, the stackalytics one doesn't ? | |
| 15:46:03 | mriedem | nope | |
| 15:46:05 | mriedem | this does i think http://stackalytics.com/report/contribution/nova-group/30 | |
| 15:46:06 | bauwser | ah ok | |
| 15:46:12 | mriedem | nova-group is multiple nova projects | |
| 15:46:17 | mriedem | i'd have to see what's actually in there though | |
| 15:47:21 | bauwser | mmm, interesting, just looking over my stats for like a while ago | |
| 15:49:20 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle new hosts for updating instance info in scheduler https://review.openstack.org/454426 | |
| 16:31:09 | openstackgerrit | John Garbutt proposed openstack/nova-specs master: Add capabilities into the compute API https://review.openstack.org/454792 | |
| 16:31:32 | johnthetubaguy | tonyb: I had a quick go at kicking this off, as I hadn't seen anything go up: ^ | |
| 17:09:53 | samarendra | what does the nova.conf on the controller actually do if it isn't also an hypervisor ? | |
| 17:10:23 | mriedem | samarendra: different options are used by different services | |
| 17:10:30 | samarendra | it doesn't seem like it configures the api according to it because i am able to have and use different capabilities on the hypervisor than what is on the hypervisor | |
| 17:11:19 | samarendra | i have disk_cachemodes different on my compute node and controller and the compute node options take precedence when spinning up the vm | |
| 17:12:05 | mriedem | that's because disk_cachemodes is only read from the nova-compute service | |
| 17:12:23 | samarendra | mriedem: ok | |
| 17:12:39 | samarendra | so i can remove the option completely from controller ? | |
| 17:12:42 | mriedem | yes | |
| 17:12:50 | samarendra | ok. | |
| 17:13:40 | samarendra | mriedem: also on the same note, is there actually a detailed doc (apart from code :)) telling how disk_cachemodes can be configured? | |
| 17:13:49 | samarendra | last i saw in the doc it was a bit confusing | |
| 17:14:26 | mriedem | besides https://docs.openstack.org/developer/nova/sample_config.html you mean? | |
| 17:14:46 | samarendra | mriedem: yes | |
| 17:15:08 | samarendra | it talks of only file and block | |
| 17:15:17 | mriedem | there has been a multi-release effort underway to provide better help text to all of the config options, but unfortunately it looks like one hasn't been done yet | |
| 17:15:40 | samarendra | ok i just found another one on https://docs.openstack.org/developer/openstack-ansible/mitaka/install-guide/configure-nova.html | |
| 17:16:34 | samarendra | mriedem: ok. i will try and contribute something on that front from our experience | |
| 17:16:40 | mriedem | thanks | |
| 17:16:59 | mriedem | samarendra: this is the blueprint for the cleanup effort by the way https://blueprints.launchpad.net/nova/+spec/centralize-config-options-pike | |
| 17:18:14 | mriedem | samarendra: fyi https://review.openstack.org/#/c/18042/ | |
| 17:18:28 | samarendra | ok. i guess we using mitaka may mean not many useful things can be contributed. | |
| 17:18:40 | mriedem | sure it odes | |
| 17:18:41 | mriedem | *does | |
| 17:18:49 | mriedem | the option is basically unchanged | |
| 17:19:03 | mriedem | the option was introduced in grizzly | |
| 17:19:05 | mriedem | without docs | |
| 17:19:09 | samarendra | oh ok | |
| 17:20:30 | mriedem | from https://libvirt.org/formatdomain.html | |
| 17:20:35 | mriedem | The optional cache attribute controls the cache mechanism, possible values are "default", "none", "writethrough", "writeback", "directsync" (like "writethrough", but it bypasses the host page cache) and "unsafe" (host may cache all disk io, and sync requests from guest are ignored). Since 0.6.0, "directsync" since 0.9.5, | |
| 17:20:35 | mriedem | "unsafe" since 0.9.7 | |
| 17:21:48 | mriedem | sfinucan: is it possible to use choices with ListOpt? | |
| 17:22:14 | samarendra | mriedem: if by choices you mean x=y, a=b, then we are already using it :) | |
| 17:22:37 | mriedem | no sorry i meant something else | |
| 17:23:07 | samarendra | mriedem: ok. btw thanks for the links! i never thought of looking at libvirt docs | |
| 17:30:55 | mriedem | also https://www.ibm.com/support/knowledgecenter/linuxonibm/liaat/liaatbpkvmguestcache.htm | |
| 17:35:25 | openstackgerrit | Tadas Ustinavičius proposed openstack/nova master: Adding unit test for the patch https://review.openstack.org/445558 | |
| 17:36:23 | samarendra | mriedem: thanks. have seen that already :) | |
| 17:36:36 | mriedem | i'm shamelessly copying it into the config option help | |
| 17:43:51 | samarendra | mriedem: where can i find bugs for openstack nova? i was looking if anyone reported any issues with attaching and detaching volumes on ppc64le arch. or would that be in the domain of openstack-cinder? | |
| 17:44:26 | mriedem | samarendra: https://bugs.launchpad.net/nova/ | |
| 17:44:26 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Expand help text for [libvirt]/disk_cachemodes https://review.openstack.org/454823 | |
| 17:44:31 | mriedem | samarendra: also ^ | |
| 17:45:02 | samarendra | review.openstack.org would be where people submit patches for the bugs on launchpad, right? | |
| 17:45:08 | mriedem | yes | |
| 17:45:17 | samarendra | ok | |
| 17:45:28 | mriedem | see if https://review.openstack.org/#/c/454823/ looks ok | |
| 17:49:46 | samarendra | mriedem: +1 | |
| 18:01:01 | mriedem | no jaypipes huh | |
| 18:01:21 | mriedem | dansmith: re: https://review.openstack.org/#/c/407228/ do you know if we changed to always pre-load instances with 'tags' loaded by default now? | |
| 18:01:42 | mriedem | i'm not really sure why we care about sending instance tags on every instance action payload | |
| 18:01:55 | dansmith | mriedem: I have a -1 on the patch to do that | |
| 18:02:05 | dansmith | https://review.openstack.org/#/c/415298/15 | |
| 18:02:10 | dansmith | haven't really gotten an answer on it | |
| 18:02:39 | mriedem | hmm, so that comes AFTER https://review.openstack.org/#/c/407228/ | |
| 18:02:53 | mriedem | and ^ will lazy-load instance tags on every instance action notification | |
| 18:02:54 | dansmith | I imagine the desire to have it in notifications is so you can do something for all instances tagged a certain way, | |
| 18:02:56 | mriedem | which is a buttload | |
| 18:02:57 | dansmith | but it does seem expensive | |
| 18:03:00 | dansmith | mriedem: yeah I know | |
| 18:03:24 | mriedem | seems we should figure out the lazy-load thing before we start blasting that everywhere | |