| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-04-05 | |||
| 16:06:44 | mriedem | sfinucan: we don't need a bp to deprecate commands | |
| 16:07:16 | sfinucan | No? Sweet. I'll re-target that for Queens so | |
| 16:09:32 | openstackgerrit | Chris Dent proposed openstack/nova-specs master: A spec for idempotent custom resource classe creation https://review.openstack.org/453732 | |
| 16:09:38 | cdent | mriedem, jaypipes, edleafe ^ | |
| 16:09:49 | cdent | feh, typo right at the start mehness | |
| 16:09:58 | jaypipes | cdent: cool, thanks! | |
| 16:10:23 | openstackgerrit | Chris Dent proposed openstack/nova-specs master: A spec for idempotent custom resource class creation https://review.openstack.org/453732 | |
| 16:10:35 | edleafe | cdent: added | |
| 16:16:23 | openstackgerrit | Gábor Antal proposed openstack/nova master: Transform instance.volume_detach notification https://review.openstack.org/408676 | |
| 16:21:36 | openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Add 'move-nova-cmds-to-cliff' spec https://review.openstack.org/433603 | |
| 16:21:36 | openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Create specs directory for Queens https://review.openstack.org/453737 | |
| 16:21:50 | mriedem | dane-fichter: i'm completely confused by how we don't end up with an empty tuple for registered types here https://review.openstack.org/#/c/351232/16/nova/objects/fields.py | |
| 16:23:47 | openstackgerrit | Gábor Antal proposed openstack/nova master: Transform instance.volume_attach notification https://review.openstack.org/401992 | |
| 16:23:49 | openstackgerrit | Sujitha proposed openstack/nova master: Add sync_instances action in os-cells API https://review.openstack.org/453366 | |
| 16:26:25 | efried | mriedem The register method can stuff things into the class member REGISTERED_TYPES. | |
| 16:26:56 | efried | mriedem https://pastebin.com/aECAcEFK | |
| 16:28:23 | mriedem | is register a special method in python? | |
| 16:28:49 | efried | Not that I know of. Does it need to be? | |
| 16:29:07 | efried | It's defined on the SignatureKeyType class. | |
| 16:29:56 | mriedem | yeah, but without calling SignatureKeyType.register, which the nova code doesn't do, how does REGISTERED_TYPES get populated? | |
| 16:30:28 | efried | mriedem Well, okay, I wasn't assuming we knew for sure that register never got called anywhere... | |
| 16:32:41 | openstackgerrit | Chris Dent proposed openstack/nova-specs master: A spec for idempotent custom resource class creation https://review.openstack.org/453732 | |
| 16:34:01 | mriedem | it seems to work, i just don't know how | |
| 16:34:52 | openstackgerrit | Gábor Antal proposed openstack/nova master: Transform instance.volume_detach notification https://review.openstack.org/408676 | |
| 16:35:13 | mriedem | efried: dane-fichter: ah import time fun https://github.com/openstack/cursive/blob/0.1.2/cursive/signature_utils.py#L172-L180 | |
| 16:35:47 | efried | I was gonna say, "must get called from within cursive somewhere". But I would have been grasping at straws ;-) | |
| 16:42:22 | openstackgerrit | Anusha Unnam proposed openstack/nova master: Add description to policies in security_group_default_rules.py https://review.openstack.org/453748 | |
| 16:49:05 | johnthetubaguy | aunnam sneti this is the keystone spec I was raising about the additional roles spec: https://review.openstack.org/453739 | |
| 16:50:32 | aunnam | johnthetubaguy thanks, will review it | |
| 16:50:35 | sneti | johnthetubaguy, will check that.. | |
| 16:56:30 | openstackgerrit | Sujitha proposed openstack/nova master: Add sync_instances action in os-cells API https://review.openstack.org/453366 | |
| 17:06:32 | openstackgerrit | Bob Ball proposed openstack/nova master: Use physical utilisation for cached images https://review.openstack.org/353862 | |
| 17:07:27 | mriedem | melwitt: so just for closure, were you going to amend the placement usages spec to use a new /usages handler rather than /allocations? | |
| 17:07:50 | melwitt | mriedem: yes. will do that today | |
| 17:07:56 | mriedem | ok cool | |
| 17:08:01 | mriedem | i got confused by all of the options | |
| 17:08:13 | mriedem | plus, someone jangled some keys in front of me | |
| 17:09:10 | mriedem | sdague: well with https://review.openstack.org/#/c/447728/ merged i think we're ready for novaclient 8.0.0 which drops all of the proxy crap | |
| 17:09:11 | melwitt | heh, yeah. I've had a lot of meetings this morning so I didn't get to it yet | |
| 17:32:21 | dane-fichter | mriedem: sorry I had to step out for a meeting | |
| 17:32:24 | openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Update reno for removed network CLIs https://review.openstack.org/453800 | |
| 17:32:32 | mriedem | melwitt: dansmith: want to get ^ quick and then i can releaes? | |
| 17:32:33 | mriedem | *release | |
| 17:32:41 | mriedem | dane-fichter: np, +2 | |
| 17:32:51 | dane-fichter | mriedem: great, thanks. | |
| 17:36:24 | melwitt | mriedem: +W | |
| 17:50:11 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-manage: Deprecate '--version' parameters https://review.openstack.org/453808 | |
| 17:50:11 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-manage: Rename 'api_db', 'cellsv2' commands https://review.openstack.org/453809 | |
| 17:50:50 | sfinucan | ^ artom Per your comments in the 'move-nova-cmds-to-cliff' spec yesterday | |
| 17:51:09 | sfinucan | the first one is particularly disgusting :) | |
| 17:57:02 | openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: make it clear that os-cells is for cells v1 https://review.openstack.org/453433 | |
| 17:58:00 | mriedem | this is a pretty simple fix for a long-standing bug https://review.openstack.org/#/c/452577/ | |
| 17:58:06 | mriedem | which i'm going to backport once it's merged | |
| 17:59:11 | dansmith | ooh | |
| 18:00:36 | mriedem | ooh is right | |
| 18:16:30 | mriedem | ericyoung: what's your launchpad id? | |
| 18:21:22 | mriedem | dansmith: melwitt: we also have this regression from ocata to get backported https://review.openstack.org/#/c/452359/ - i've been waiting on that one before fixing https://review.openstack.org/#/c/449334/ since they are going to conflict | |
| 18:22:03 | dansmith | guh | |
| 18:22:10 | dansmith | I cannot wait for counting quotas | |
| 18:22:46 | artom | sfinucan, so you're going to add deprecation warnings in Pike, and remove the old commands in Queens entirely? | |
| 18:22:56 | artom | I think there needs to be a period of overlap when both coexist | |
| 18:23:25 | artom | For instance, does tripleo call them? | |
| 18:23:33 | artom | I think we've broken tripleo enough as is ;) | |
| 18:23:45 | artom | Let's give them a chance to adjust because we yank commands from under them | |
| 18:23:50 | artom | s/because/before | |
| 18:24:41 | mriedem | i hope tripleo isn't using deprecated nova clis | |
| 18:25:28 | artom | mriedem, they're not deprecated yet :) I'm trying to think of ways to make the deprecation as painless as possible | |
| 18:25:35 | mriedem | artom: i mean novaclient | |
| 18:25:36 | mriedem | not nova-manage | |
| 18:25:38 | mriedem | https://review.openstack.org/#/c/453819/ | |
| 18:26:09 | mriedem | https://governance.openstack.org/tc/reference/tags/assert_follows-standard-deprecation.html | |
| 18:27:34 | dansmith | our delete path(s) are just hilarious | |
| 18:27:40 | mriedem | dansmith: i know, | |
| 18:27:45 | dansmith | maybe we should get rid of delete? | |
| 18:27:51 | mriedem | dansmith: that's why i'm holding https://review.openstack.org/#/c/449334/ to the end, | |
| 18:28:04 | mriedem | because i think the fix for that bug is to re-use the _local_delete method in the compute api | |
| 18:28:09 | mriedem | but i think there will be dragons | |
| 18:28:17 | artom | soft-delete in the client is the way to go ;) | |
| 18:28:29 | mriedem | _local_delete is what cleans up ports and volumes | |
| 18:28:38 | mriedem | and was missing from the duplicate 'local delete' that was added for the cells v2 case | |
| 18:29:02 | mriedem | once these ocata regression bugs are fixed, i think we spend some time just removing the transition code in the delete path for cells v2 | |
| 18:29:16 | mriedem | but need the fixes and tests in place before we unwind that onion | |
| 18:30:00 | mriedem | artom: per the deprecation policy, we can deprecate in pike and remove in queens as long as it's been deprecated for at least 3 months | |
| 18:30:16 | mriedem | so you can't deprecate something at the very end of pike and drop it immediately in queens if it's under 3 months | |
| 18:30:24 | mriedem | the 3 months thing is for CD | |
| 18:30:35 | artom | mriedem, I can't argue with the policy | |
| 18:31:03 | artom | I just think it's safer to have a period when both coexist - so that whatever depends on them can change to the new way of doing things while the old way still works | |
| 18:31:23 | mriedem | that's the whole point of the 3 months | |
| 18:31:27 | mriedem | and full stable branch | |
| 18:32:19 | artom | Right, assuming the new way is ready and available during those 3 months ;) | |
| 18:32:24 | artom | Good point for stable though | |
| 18:33:31 | sdague | mriedem: you have 7.0.0 instead of 8.0.0 in https://review.openstack.org/#/c/453819/1 | |
| 18:33:37 | sdague | which is why it's failing tets | |
| 18:33:39 | sdague | tests | |
| 18:33:53 | mriedem | derp | |
| 18:33:55 | mriedem | copy/paste | |
| 18:34:22 | mriedem | it's dependent on a novaclient reno change for now anyway | |
| 18:36:41 | mriedem | dansmith: don't forget the regression test patch below it | |
| 18:37:10 | dansmith | yeah dude, it takes a while :) | |
| 18:37:43 | mriedem | sorry | |