Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-04-03
19:58:21 mordred well - I have a patch coming to maybe make it friendlier
19:59:07 sdague mriedem: yeh, honestly, I would say a better response body is probably the right answer
19:59:13 sdague and drop the Location header when we do it
19:59:20 mriedem sdague: i can totally do that, today
19:59:38 mordred ++ - I still think fixing glance interactoins to use catalog long term is the correct and healthy thing to do - but it's not going to be quick
19:59:40 sdague the Location header is clever, and when it was an internal location for nova, maybe really sensible
19:59:45 sdague mordred: yeh
19:59:46 mordred agree
19:59:58 mordred but the world it has changed since then
20:00:03 sdague I think the only sucky part is that the fix isn't really backportable
20:00:14 sdague this is basically an edge case of the v1 -> v2 bit that we missed
20:00:33 mordred yah - but it's also luckily not TERRIBLE to workaround as an API consumer
20:00:35 mriedem does /images alias to /v1/images though?
20:00:48 mordred I mean id = "/".rsplit(location, 1)
20:00:49 sdague mriedem: honestly, I don't know
20:00:50 mordred isn't bad
20:00:56 mordred mriedem: I do not believe so, no
20:01:13 sdague mordred: yeh, sure. We should probably mention there are weirdnesses in the API call
20:01:30 mriedem ok, i wasn't sure looking at https://developer.openstack.org/api-ref/image/versions/index.html?expanded=list-api-versions-detail,id1-detail
20:01:34 mriedem and the api refs for glance
20:01:50 mriedem or https://developer.openstack.org/api-ref/image/v1/index.html#images
20:01:55 mriedem which has an explicit /v1/ in it
20:02:09 mordred mriedem: no, it doens't
20:02:15 mriedem maybe this has just been broken since glance became a thing birthed from nova? :P
20:02:20 mordred GET https://image-ca-ymq-1.vexxhost.net/images/05a02839-5eb2-4335-8869-fabe88601f18
20:02:27 mordred gets you the image version discovery document
20:02:39 mordred mriedem: yes - I believe it likely has been broken always
20:02:46 mordred mriedem: because of how novaclient consumes the value
20:03:23 mriedem mordred: to be clear, "no it doesn't" meaning /images doesn't alias /v1/images?
20:03:48 mriedem because yeah i see https://image-ca-ymq-1.vexxhost.net/v1/
20:04:03 mriedem ok, well i'll draft up a spec
20:04:07 sdague mordred: so... on other clouds is it returning a glance url or a nova one?
20:05:00 mordred sdague: I can check - but it'll be a little bit - I need to create some vms first
20:05:23 sdague mordred: yeh, no worries. Just curious, because it's been so long
20:05:32 sdague because, I think that might be part of what happened
20:05:40 sdague as we used to push through nova urls
20:06:33 mordred image = cls.compute_images_client.create_image(server_id, name=name)
20:06:35 mordred image_id = data_utils.parse_image_id(image.response['location'])
20:06:37 mordred cls.images.append(image_id)
20:06:41 mordred tempest ALSO employs the novaclient workaround
20:06:47 sdague heh
20:06:54 sdague yeh, ok, we've just been terrible forever
20:06:58 mordred yup
20:08:41 mriedem ok so we're a go for removing location header and return image_id in a response body dict in a microversion, yes?
20:08:45 mriedem if so, i'll start writing up a spec
20:08:54 raj_singh mriedem: sdague We are working up a spec to use catalog lookup for Glance. This spec will have details on making consistent use of keystone_auth in Neutron and Cinder client as well.
20:09:05 mordred mriedem: ++ I think that's a GREAT microversion
20:09:07 raj_singh and we will have it up by today
20:09:30 mordred raj_singh: hey - will you point me to it as well?
20:09:37 raj_singh pumaranikar: is working on it
20:09:49 mordred pumaranikar, raj_singh: I have some thoughts and a half-done patch for improving that area as well :)
20:09:53 raj_singh mriedem: Sure I will ping you once ready
20:10:09 mordred sweet
20:10:16 sdague mriedem: sounds great
20:31:08 melwitt mriedem: I thought you might want to look at this docs change, makes a new page for release notes how-to and links from the main page and the code review page https://review.openstack.org/#/c/451870
20:33:06 mriedem sdague: mordred: funny, but we emit notifications for snapshot start/end, but don't actually include the snapshot image id in those
20:33:11 mriedem kind of useless
20:33:30 mriedem gibi: ^
20:33:35 sdague so, question, in log messages, sometimes we use instance= and sometimes we use instance_uuid=
20:33:43 mriedem sdague: no different
20:33:45 mriedem *difference
20:33:56 sdague is there a reason we couldn't abolish instance= and do the uuid dereference thre?
20:33:56 mriedem oslo.log checks to see if it's 'instance' and pulls the uuid from it
20:34:13 sdague mriedem: yes, I realize it, but it actually adds a reasonable amount of gorp in oslo.log
20:34:15 mriedem it would be a bunch of churn
20:35:51 sdague yeh, though the dual fields do make doing some additional stuff with exposing variables to systemd journal a big gorpier
20:36:53 mriedem melwitt: can i have no opinion?
20:37:07 melwitt mriedem: of course
20:49:42 openstackgerrit Lee Yarwood proposed openstack/nova master: WIP encryptors: Do not overwrite file volumes on attach https://review.openstack.org/452938
20:49:54 lyarwood melwitt: ^ hackaround for the encrypted nfs volume corruption bug if you get time today
20:50:41 melwitt lyarwood: cool, thanks for the heads up
20:50:52 lyarwood mriedem: thanks for the heads up re the stable bugfixes btw, I'll queue them up for the morning
20:51:27 mriedem mordred: createBackup API has the same issue :)
20:54:33 dansmith sdague: instance_uuid would suck measurably more, IMHO
21:02:05 openstackgerrit Anusha Unnam proposed openstack/nova master: Add description to policies in servers.py https://review.openstack.org/451966
21:04:25 mriedem wow, nova backup does not print out the actual image id for the created snapshot image
21:04:31 mriedem so i guess that's just an exercise for the user
21:04:53 mriedem melwitt: ^ have you ever seen anyone propose a change for that in novaclient?
21:05:36 melwitt mriedem: I haven't but to be honest I haven't been paying attention to novaclient changes in awhile
21:07:40 dansmith mriedem: backup is broken for certain things, right? like bfv instances?
21:07:47 openstackgerrit Matt Riedemann proposed openstack/nova-specs master: Remove Location header from createImage and createBackup response (spec) https://review.openstack.org/452951
21:07:55 dansmith tbh I kinda relegated it into an old usage scenario
21:08:12 mriedem flwang tried fixing bfv with backup years ago, but we blocked it
21:08:27 dansmith yeah
21:10:09 openstackgerrit Sarafraj Singh proposed openstack/nova-specs master: WIP: Replace live migration steps and delays with memory iteration logic https://review.openstack.org/443339
21:10:58 openstackgerrit Matt Riedemann proposed openstack/nova-specs master: Remove Location header from createImage and createBackup response (spec) https://review.openstack.org/452951
21:11:08 mriedem mordred: sdague: ^ the spec
21:11:49 mriedem dansmith: i bet we don't mention that limitation in the api ref for createBackup either
21:12:21 dansmith I kinda wish we didn't mention it at all :)
21:12:30 mriedem like the os-pci API?
21:12:34 mriedem which reminds me...
21:13:44 mriedem nice, this is the message you get back with the 400 in that case, "The request is invalid."
21:14:00 mriedem it should also kick you in the balls while it's being helpful
21:14:34 dansmith it logs something relevant, but yeah, no help for the user
21:15:20 mriedem logs something for the admin to check when he gets the support ticket
21:19:44 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove unused migrate_data kwarg from virt driver destroy() method https://review.openstack.org/452958
22:02:36 mordred mriedem: awesome
22:03:25 openstackgerrit Matt Riedemann proposed openstack/nova master: doc: Separate the releasenotes guide from the code-review section https://review.openstack.org/451870
22:04:25 mordred mriedem: the impacts are awesome
22:04:33 mriedem None?

Earlier   Later