Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-04-02
21:59:56 openstackgerrit Takashi NATSUME proposed openstack/nova master: Refactor a test method including 3 test cases https://review.openstack.org/394738
22:46:32 openstackgerrit Alex Szarka proposed openstack/nova master: Reduce code complexity in vmops._spawn method https://review.openstack.org/438502
23:06:14 mriedem mordred: yeah, bdm metadata, converts to an image bdm during boot for boot from volume
23:06:32 mriedem surprise!
23:07:08 mriedem there is a test in tempest which creates a server, attaches a volume, snapshots the server, which also creates a snapshot of the volume and stores that in the image meta, then creates a 2nd server from the snapshot image, which actually makes it a boot from volume on the volume snapshot from the 1st server
23:07:13 mriedem super fun when that breaks down
23:09:45 mriedem artom: we talked about deprecating the virtual-interfaces API and returning tagged VIFs in the os-interface API right?
23:10:03 mriedem artom: or what were you returning tagged VIFs from today? the virtual-interface API right?
23:24:45 mriedem nevermind I guess we don't expose vif tags out of the rest api
23:25:18 mriedem oh yeah derp, i had a spec to expose bdm tags out of the api, but we got stuck on that because we didn't know what to do about exposing vif tags
23:34:27 mriedem mordred: were you asking because of ftersin's reply in the ML on the "[openstack-dev] [nova] Removing BDM devices from POST requests" thread?
23:36:23 openstackgerrit Alex Szarka proposed openstack/nova master: Transform instance.resize.error notifications https://review.openstack.org/417882
23:52:21 openstackgerrit Matt Riedemann proposed openstack/python-novaclient master: Remove deprecated network APIs https://review.openstack.org/447728
23:54:53 openstackgerrit Matt Riedemann proposed openstack/python-novaclient master: Remove deprecated network APIs https://review.openstack.org/447728
#openstack-nova - 2017-04-03
00:39:12 mriedem Kevin_Zheng: i think i have a much easier way to fix this https://review.openstack.org/#/c/403568/
00:40:17 Kevin_Zheng mriedem: thanks，Im looking at it
00:44:41 mriedem let me work something up quick
00:53:13 openstackgerrit Matt Riedemann proposed openstack/nova master: Preserve pre-existing port when attach interface fails https://review.openstack.org/452577
00:53:14 mriedem Kevin_Zheng: ^ see if that works, i still need to update tests
00:55:51 openstackgerrit Matt Riedemann proposed openstack/nova master: Preserve pre-existing port when attach interface fails https://review.openstack.org/452577
00:58:28 mriedem i'll be back in an hour or so
01:19:15 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Fix parameters in os-hosts.inc https://review.openstack.org/416444
02:30:41 mordred mriedem: I was
02:31:50 mordred mriedem: basically, the idea that I could put metadata on my glance image and it somehow at boot time might cause other volumes to be needed/mounted is both surprising and also might solve one of clarkb's complaints with booting servers with volumes
02:33:01 openstackgerrit Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2) https://review.openstack.org/408955
02:34:57 openstackgerrit Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964
02:35:14 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042
02:35:37 openstackgerrit Takashi NATSUME proposed openstack/nova master: Add functional tests for cold migration to same host https://review.openstack.org/414926
02:36:26 mriedem mordred: all sorts of undocumented goodies lurk beneath
02:36:34 mriedem and apparently is why we can never change anything
03:06:09 mordred mriedem: fantastic
03:07:08 mordred mriedem: I may, when it's not 10pm on a Sunday night, ping you more to try to learn more things
03:07:37 mriedem wfm
03:07:40 mriedem i'm learning too :)
03:18:36 openstackgerrit Matt Riedemann proposed openstack/nova master: Preserve pre-existing port when attach interface fails https://review.openstack.org/452577
03:21:34 openstackgerrit Matt Riedemann proposed openstack/nova master: Preserve pre-existing port when attach interface fails https://review.openstack.org/452577
04:24:42 openstackgerrit Maciej Szankin proposed openstack/nova-specs master: Add use-local-scheduler spec https://review.openstack.org/438936
04:36:07 openstackgerrit Maciej Szankin proposed openstack/nova-specs master: Add use-local-scheduler spec https://review.openstack.org/438936
06:19:04 openstackgerrit Alex Szarka proposed openstack/nova master: Reduce code complexity in vmops._spawn method https://review.openstack.org/438502
06:19:29 openstackgerrit Alex Szarka proposed openstack/nova master: Reduce code complexity - servers.py https://review.openstack.org/359861
06:19:34 openstackgerrit Alex Szarka proposed openstack/nova master: Reduce code complexity - manager.py https://review.openstack.org/359868
06:19:39 openstackgerrit Alex Szarka proposed openstack/nova master: Reduce code complexity - linux_net.py https://review.openstack.org/359871
06:19:50 openstackgerrit Alex Szarka proposed openstack/nova master: Reduce code complexity - libvirt/config.py https://review.openstack.org/359879
06:32:06 openstackgerrit Alex Szarka proposed openstack/nova master: Transform instance.resize.error notifications https://review.openstack.org/417882
07:08:10 openstackgerrit Alvaro Lopez Garcia proposed openstack/nova master: Ensure that periodic reclaim cleans DB deleted instances https://review.openstack.org/323250
07:19:59 openstackgerrit Dinesh Bhor proposed openstack/nova master: Use HostAddressOpt for opts that accept IP and hostnames https://review.openstack.org/445782
09:02:29 openstackgerrit Tadas Ustinavičius proposed openstack/nova master: Implements: blueprint custom-emulator-path https://review.openstack.org/452646
09:35:40 openstackgerrit John Garbutt proposed openstack/nova-specs master: Add policy-remove-scope-checks spec https://review.openstack.org/433037
09:42:40 openstackgerrit John Garbutt proposed openstack/nova-specs master: Add additional-default-policy-roles spec https://review.openstack.org/427872
09:53:06 openstackgerrit Stephen Finucane proposed openstack/os-vif master: doc: Rewrap 'vif_types' document https://review.openstack.org/452665
09:53:07 openstackgerrit Stephen Finucane proposed openstack/os-vif master: doc: Add glossary https://review.openstack.org/452666
09:57:43 openstackgerrit Stephen Finucane proposed openstack/nova master: hardware: Flatten functions https://review.openstack.org/367470
09:57:43 openstackgerrit Stephen Finucane proposed openstack/nova master: Standardize '_get_XXX_constraints' functions https://review.openstack.org/385071
09:57:44 openstackgerrit Stephen Finucane proposed openstack/nova master: Rename '_numa_get_constraints_XXX' functions https://review.openstack.org/385072
09:57:44 openstackgerrit Stephen Finucane proposed openstack/nova master: De-duplicate _numa_get_flavor_XXX_map_list https://review.openstack.org/385074
10:26:44 openstackgerrit Stephen Finucane proposed openstack/nova master: Plumbing for tagged nic attachment https://review.openstack.org/415622
10:26:44 openstackgerrit Stephen Finucane proposed openstack/nova master: Delete nic metadata when detaching interface https://review.openstack.org/435387
10:26:45 openstackgerrit Stephen Finucane proposed openstack/nova master: Libvirt support for tagged volume attachment https://review.openstack.org/418100
10:26:46 openstackgerrit Stephen Finucane proposed openstack/nova master: Delete disk metadata when detaching volume https://review.openstack.org/435082
10:26:48 openstackgerrit Stephen Finucane proposed openstack/nova master: Plumbing for tagged volume attachment https://review.openstack.org/391941
10:26:49 openstackgerrit Stephen Finucane proposed openstack/nova master: API support for tagged device attachment https://review.openstack.org/376021
10:26:50 openstackgerrit Stephen Finucane proposed openstack/nova master: Libvirt support for tagged nic attachment https://review.openstack.org/415520
10:30:43 openstackgerrit Stephen Finucane proposed openstack/nova master: Optimize creating security_group https://review.openstack.org/315311
10:34:24 f10d4 hi
11:02:21 openstackgerrit Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for GET RP inventories https://review.openstack.org/449765
11:02:22 openstackgerrit Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for POST RP inventories https://review.openstack.org/451855
11:02:22 openstackgerrit Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for PUT RP inventories https://review.openstack.org/452707
11:02:23 openstackgerrit Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for DELETE RP inventories https://review.openstack.org/452708
11:02:37 openstackgerrit John Garbutt proposed openstack/nova-specs master: Add additional-default-policy-roles spec https://review.openstack.org/427872
11:10:59 openstackgerrit Dinesh Bhor proposed openstack/nova master: Use HostAddressOpt for opts that accept IP and hostnames https://review.openstack.org/445782
11:13:07 johnthetubaguy ildikov: had a deeper look at this check_detach patch, actually I think we loose some super important checks, but I could be missing something big: https://review.openstack.org/#/c/446671
11:27:47 ildikov johnthetubaguy: I added that check as a prep for multi-attach, which Nova still does not support
11:28:19 johnthetubaguy ildikov: right, but I am saying it breaks all our existing users, how do we stop that
11:29:07 johnthetubaguy ildikov: it seems like it would work fine with multi-attach to me, it would be good to describe what checks are bad for multi-attach there, I guess its one of the status checkes
11:29:38 ildikov johnthetubaguy: it's just that it's unnecessary just like the check_attach was
11:29:55 johnthetubaguy ildikov: I described in my comments, I believe its critical
11:30:09 ildikov johnthetubaguy: it's Cinder who should do the status checks
11:30:23 johnthetubaguy ildikov: sure, but we don't have an API in the new flow to do that
11:30:44 ildikov ildikov: the status checks you mean?
11:30:49 johnthetubaguy ildikov: and the old flow doesn't seem to check the instance uuid
11:31:09 ildikov johnthetubaguy: because it didn't need to
11:31:09 johnthetubaguy ildikov: ... so your patch says stop check_detach, because we can just call begin_detaching?
11:31:34 johnthetubaguy ildikov: it really, really does
11:32:17 ildikov johnthetubaguy: I think we went through the detach cases when we removed check_attach and I think we got a good coverage, but I need to look into the code
11:32:31 johnthetubaguy ildikov: so lets think about the new flow quickly
11:32:38 johnthetubaguy ildikov: what call does the checks?
11:33:10 ildikov johnthetubaguy: you need to find the attachment_id in the bdm to detach
11:33:38 johnthetubaguy ildikov: that doesn't tell us what the state of that attachment is, we could be out of sync
11:34:02 ildikov johnthetubaguy: the attachment state is Cinder's responsibility
11:34:07 johnthetubaguy ildikov: we still need to check that the user has asked us to detach a volume that is currently attached to the instance
11:34:21 johnthetubaguy ildikov: I agree in principal, but we don't have the APIs for it in the new flow
11:34:48 ildikov johnthetubaguy: Cinder should do that either as part of attachment_delete or we can look into other options
11:35:10 ildikov johnthetubaguy: for attach we can create an empty attachment to lock the volume and not for the status checks either
11:35:16 johnthetubaguy ildikov: so attachment_delete is after the API has returned, and after we have attempted to remove the volume
11:36:24 johnthetubaguy ildikov: so we need a spec in Nova to describe all the multi_attach loose ends
11:37:19 ildikov johnthetubaguy: we need that for other reasons too
11:37:27 johnthetubaguy ildikov: this might be one of those, be we need to be clear what checks are replacing our existing guard rails, and describe how you don't break the current API behaviour for Nova
11:37:53 ildikov johnthetubaguy: I would like to just clean up the code and solve the problems that we really have at the right place
11:38:11 johnthetubaguy ildikov: we have the same goal, the problem is your patch breaks our API
11:38:33 ildikov johnthetubaguy: even for the non-dteach cases?

Earlier   Later