| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-03-30 | |||
| 17:45:01 | jaypipes | melwitt: sajeesh has commented already on that. | |
| 17:45:09 | jaypipes | I have it on my long list of todos... | |
| 17:45:21 | melwitt | oh, okay | |
| 17:45:47 | jaypipes | but basically, sajeesh, the idea is to have the service projects (i.e. NOT keystone) do the usage checks and to have Keystone only store the absolute limits. | |
| 17:46:06 | jaypipes | guh. | |
| 17:47:42 | sdague | jaypipes: so I just reved that spec, it would be good to make sure it still jives with your thinking, as we were going to do basically go / no go tomorrow on moving forward on it - https://review.openstack.org/#/c/440815/ | |
| 17:47:50 | melwitt | oh, I see, he was thinking usage and limits had to be in the same service maybe | |
| 17:47:56 | sdague | melwitt: nope | |
| 17:48:06 | sajeesh | sorry...jaypipes...I couldn't chat as I am having some problem with internet connection | |
| 17:48:13 | sdague | https://review.openstack.org/#/c/440815/5/specs/keystone/backlog/unified-limits.rst@117 | |
| 17:48:18 | sdague | melwitt: ^^^ | |
| 17:48:27 | sdague | hopefully that bit makes it clear | |
| 17:48:36 | melwitt | yeah, I know. I was saying I think maybe sajeesh was thinking they had to be both in the same place | |
| 17:48:54 | sajeesh | yes.... | |
| 17:49:00 | sdague | melwitt: ah, sorry, I misread your sentence | |
| 17:49:07 | melwitt | (based on his comment on the spec) | |
| 17:49:13 | sdague | and missed the pronoun switch from I -> he | |
| 17:50:43 | melwitt | no worries | |
| 17:51:30 | dansmith | sdague: omg.. pronouns are SO important these days and you're just ignoring them? tres bad! | |
| 17:54:56 | openstackgerrit | Steve Noyes proposed openstack/nova master: Do not attempt volume swap when guest is stopped/suspended https://review.openstack.org/389798 | |
| 17:59:00 | jaypipes | sajeesh: did you see my last comment? it was this: | |
| 17:59:02 | jaypipes | but basically, sajeesh, the idea is to have the service projects (i.e. NOT keystone) do the usage checks and to have Keystone only store the absolute limits. | |
| 17:59:21 | jaypipes | sdague: yes, will review shortly... dealing with some Mirantis $work things right this sec | |
| 18:00:23 | jaypipes | looks like we have a case of the net-sh*ts today. | |
| 18:00:28 | sajeesh | ok | |
| 18:34:35 | openstackgerrit | Anusha Unnam proposed openstack/nova master: Add description to policies in services.py https://review.openstack.org/449782 | |
| 18:35:13 | openstackgerrit | Samantha Blanco proposed openstack/nova master: Make flavor-rxtx policy more granular https://review.openstack.org/444036 | |
| 18:35:53 | openstackgerrit | Gábor Antal proposed openstack/nova master: Move rebuild notification tests into separate method https://review.openstack.org/451789 | |
| 18:57:03 | openstackgerrit | Sujitha proposed openstack/nova master: Add BDM to InstancePayload https://review.openstack.org/448779 | |
| 20:03:05 | efried | mriedem Good time to catch up on code reviews, so your deltoids don't get burned up. | |
| 20:03:34 | mriedem | let me drink some eggs first | |
| 20:04:14 | efried | Purely selfless comment, of course. Just looking after our noble and eminent PTL. | |
| 20:06:17 | jaypipes | sdague: ok, phew, finally finished the limits spec review. | |
| 20:10:37 | melwitt | jaypipes: I've made similar comments on terminology on other reviews. like to keep it as "limits" and "usage" and make it clear about the difference. "quota" is overloaded and confusing | |
| 20:10:44 | mriedem | yuh dun blowed up all ma stats | |
| 20:13:59 | xgerman | hi, | |
| 20:14:27 | xgerman | wonder what the status of soft-anti-affinity is? I am on master nd it doesn’t work | |
| 20:14:37 | xgerman | https://www.irccloud.com/pastebin/zfgU1sJu/ | |
| 20:17:03 | sdague | jaypipes: ok, most of the clarifications are good, I'll look at doing another quick edit to be consistent there. When it comes to why I think there needs to be a library, see the various quota rule sets here that were being explored - https://review.openstack.org/#/c/441203/ | |
| 20:18:22 | mriedem | xgerman: i'd talk to gibi or ildikov | |
| 20:18:35 | xgerman | thanks | |
| 20:18:49 | openstackgerrit | Anusha Unnam proposed openstack/nova master: Add description to policies in servers.py https://review.openstack.org/451966 | |
| 20:19:07 | xgerman | when I grepped my nova dir it was there so odd | |
| 20:19:42 | ildikov | xgerman: is that latest master? | |
| 20:19:52 | xgerman | pretty much | |
| 20:20:07 | xgerman | build my devstack 3-27 | |
| 20:20:44 | xgerman | or is there something I need to enable - I am run ing with default settings | |
| 20:20:47 | ildikov | hmm, I wonder whether there's any config/filter option that you need to set | |
| 20:21:12 | xgerman | yeah, me, too — had trouble finding docs at all for soft-anti-affinity | |
| 20:21:28 | ildikov | I need to look into it as it was quite a while ago when we introduced it and I cannot recall any config related change in it now | |
| 20:23:51 | melwitt | xgerman, ildikov: I have seen some usage of it in a functional test before, maybe it will help. it implies you need to add ServerGroupAntiAffinityFilter to the enabled_filters config option https://github.com/openstack/nova/blob/master/nova/tests/functional/test_server_group.py | |
| 20:25:07 | xgerman | I have it: | |
| 20:25:24 | mriedem | it's not a default filter i don't think | |
| 20:25:36 | xgerman | it is on devstack | |
| 20:25:38 | xgerman | scheduler_default_filters = RetryFilter,AvailabilityZoneFilter,RamFilter,DiskFilter,ComputeFilter,ComputeCapabilitiesFilter,ImagePropertiesFilter,ServerGroupAntiAffinityFilter,ServerGroupAffinityFilter,SameHostFilter,DifferentHostFilter | |
| 20:25:50 | mriedem | ah | |
| 20:26:00 | xgerman | wonder if I need the weights? | |
| 20:26:01 | mriedem | the weighers are all loaded up by default | |
| 20:26:13 | mriedem | weight_classes=all i think | |
| 20:26:36 | mriedem | we recently updated the api-ref for this | |
| 20:26:40 | mriedem | when creating the server group | |
| 20:27:24 | xgerman | mmh, what throws me off is that the REST call response only gives me tow options | |
| 20:29:43 | mriedem | https://developer.openstack.org/api-ref/compute/?expanded=create-server-group-detail#create-server-group | |
| 20:29:54 | mriedem | see the 'policies' attribute | |
| 20:30:05 | mriedem | are you specifying the correct policy when creating the server group? | |
| 20:32:28 | ildikov | it's also a weigher: ServerGroupSoftAntiAffinityWeigher | |
| 20:32:45 | xgerman | mriede: Yes | |
| 20:32:53 | xgerman | https://www.irccloud.com/pastebin/o38ZPMUT/ | |
| 20:32:56 | sdague | jaypipes: ok, I think I cleaned it up | |
| 20:33:07 | mriedem | xgerman: and you specified the hint when creating the server? | |
| 20:33:10 | mriedem | *servers | |
| 20:33:13 | sdague | I left 2 references in there to "quota system" to mean limits + usage | |
| 20:33:28 | xgerman | well, I can’t create a servergroup with that polciy | |
| 20:33:34 | sdague | but it should hopefully be pretty distinct from the rest of it | |
| 20:35:13 | mriedem | xgerman: yeah but you also have to specify the group hint when creating the servers | |
| 20:35:25 | mriedem | https://docs.openstack.org/mitaka/config-reference/compute/scheduler.html#servergroupaffinityfilter | |
| 20:35:28 | mriedem | it's a whole dance | |
| 20:35:32 | mriedem | sdague loves it | |
| 20:35:58 | xgerman | well, my flow is: create server-group and then create severs with hint (servergrouo) | |
| 20:36:16 | xgerman | I fail when creating a server-group | |
| 20:37:08 | openstackgerrit | Dan Smith proposed openstack/nova master: Teach HostAPI about cells https://review.openstack.org/442162 | |
| 20:37:09 | openstackgerrit | Dan Smith proposed openstack/nova master: Make scheduler target cells to get compute node instance info https://review.openstack.org/439891 | |
| 20:37:10 | mriedem | RESP BODY: {"badRequest": {"message": "Invalid input for field/attribute 0. Value: soft-anti-affinity. u'soft-anti-affinity' is not one of ['anti-affinity', 'affinity']", "c | |
| 20:37:10 | openstackgerrit | Dan Smith proposed openstack/nova master: Sort CellMappingList.get_all() for safety https://review.openstack.org/443174 | |
| 20:37:11 | mriedem | ode": 400}} | |
| 20:37:11 | openstackgerrit | Dan Smith proposed openstack/nova master: Add get_by_instance_uuids() to InstanceMappingList https://review.openstack.org/443292 | |
| 20:37:12 | openstackgerrit | Dan Smith proposed openstack/nova master: Clean up ClientRouter debt https://review.openstack.org/444487 | |
| 20:37:13 | openstackgerrit | Dan Smith proposed openstack/nova master: Make server_groups determine deleted-ness from InstanceMappingList https://review.openstack.org/443293 | |
| 20:37:14 | openstackgerrit | Dan Smith proposed openstack/nova master: Remove Mitaka-era service version check https://review.openstack.org/442861 | |
| 20:37:15 | openstackgerrit | Dan Smith proposed openstack/nova master: Add workaround to disable group policy check upcall https://review.openstack.org/442736 | |
| 20:37:29 | mriedem | something wrong with your jsonschema | |
| 20:37:37 | xgerman | ok | |
| 20:37:47 | xgerman | then I will look there | |
| 20:37:50 | oomichi | mriedem: sdague: do we still need to put _LI() etc on LOGs? I guess _LI() could be unnecessary after https://review.openstack.org/#/c/447528 | |
| 20:38:12 | ildikov | xgerman: it looks like you have only the base from here: https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/server_groups.py | |
| 20:38:28 | mriedem | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/server_groups.py#L50 | |
| 20:38:35 | sdague | oomichi: no, we don't | |
| 20:38:36 | mriedem | you need 2.15 | |
| 20:38:59 | mriedem | you're using the wrong microversion | |
| 20:39:03 | sdague | the hacking rule was removed, we just need to do the rest of the deletes | |