| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-03-27 | |||
| 11:04:16 | openstackgerrit | John Garbutt proposed openstack/nova master: Remove unused policy rule in admin_actions.py https://review.openstack.org/447611 | |
| 11:04:46 | sean-k-mooney | moshele: hi | |
| 11:04:54 | ygl | bauzas: hi | |
| 11:06:40 | moshele | sean-k-mooney: hi, can you review HW offload support for openvswitch https://review.openstack.org/#/c/398277/ and https://review.openstack.org/#/c/398265/ | |
| 11:07:03 | sean-k-mooney | moshele: yes ill take a look. | |
| 11:07:21 | sean-k-mooney | https://review.openstack.org/#/c/447269/ is failing tempest test | |
| 11:07:26 | sean-k-mooney | im not sure why | |
| 11:07:41 | openstackgerrit | John Garbutt proposed openstack/nova master: Add description to policies in keypairs.py https://review.openstack.org/448461 | |
| 11:07:46 | moshele | sean-k-mooney: I will take a look | |
| 11:07:48 | sfinucan | moshele: Done | |
| 11:08:14 | sean-k-mooney | moshele: has the ovs support merged yet? | |
| 11:08:30 | moshele | sean-k-mooney: the ovs patches https://mail.openvswitch.org/pipermail/ovs-dev/2017-March/330151.html are close to be merge | |
| 11:08:32 | sean-k-mooney | its targeted to the 2.8 release correct | |
| 11:08:44 | moshele | sean-k-mooney: yes | |
| 11:08:44 | sean-k-mooney | ok cool. | |
| 11:08:58 | moshele | sfinucan: thanks : ) | |
| 11:09:14 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Short circuit notifiations when not enabled https://review.openstack.org/428260 | |
| 11:09:45 | sfinucan | moshele: np. It's a very high level review because I'm not up to speed on the context. Would appreciate a better overview in the commit message | |
| 11:09:55 | ygl | bauzas: how to proceed now | |
| 11:10:35 | sfinucan | moshele: In fact, a 'Supported VIF types' document in os-vif wouldn't be any harm. Perhaps add one and populate it with details of this ovs_accelerated vif | |
| 11:10:55 | sfinucan | i.e. what it is, why you'd want to use it (vs. other vif types) and perhaps what the minimum requirements are | |
| 11:11:11 | openstackgerrit | John Garbutt proposed openstack/nova master: Add description to policies in simple_tenant_usage.py https://review.openstack.org/449742 | |
| 11:18:30 | openstackgerrit | John Garbutt proposed openstack/nova master: Add description to policies in pause_server.py https://review.openstack.org/449478 | |
| 11:25:39 | ygl | hi all | |
| 11:25:54 | ygl | my nova-scheduler filter is failing and not launching the instance | |
| 11:26:05 | ygl | it is returning 0 hosts | |
| 11:28:44 | ygl | it is ocata setup | |
| 11:34:50 | sean-k-mooney | moshele: once you add unit tests to the nova review it looks good to me but i left 1 question regarding the designer but its minior though | |
| 11:35:10 | moshele | sean-k-mooney: thank :) | |
| 11:35:20 | sean-k-mooney | moshele: for this to work you will also need a bump of os-vif right | |
| 11:35:30 | sean-k-mooney | ie we will need a new release | |
| 11:35:58 | moshele | sean-k-mooney: ok | |
| 11:37:31 | johnthetubaguy | sfinucan: self.stub_out doesn't use mox right? there seem to be lots of folks trying to remove the use of that. | |
| 11:42:10 | bauzas | ygl: again, like I said, please look at n-cpu.logs | |
| 11:42:24 | bauzas | ygl: find the request-id by looking at the n-api.logs | |
| 11:42:32 | ygl | bauzas: ok | |
| 12:00:35 | BobBall_ | johnthetubaguy: Can you comment on https://review.openstack.org/#/c/444230/4/nova/virt/xenapi/vif.py@275 pls? I think that Rackspace may depend on this magic value but I'm not certain | |
| 12:01:04 | johnthetubaguy | BobBall_: I believe we do | |
| 12:01:29 | johnthetubaguy | BobBall_: I would pefere adding old and new ones to allow a transition | |
| 12:02:32 | BobBall_ | johnthetubaguy: I don't suppose there's a public reference we could link to showing where Rackspace use it? | |
| 12:02:42 | BobBall_ | johnthetubaguy: e.g. something on github? | |
| 12:02:56 | BobBall_ | so when Rackspace update to neturon-port-id we can go back and remove the old field? | |
| 12:03:03 | johnthetubaguy | BobBall_: I don't know where that lives, or if its up today, I think its all back internal now | |
| 12:03:36 | BobBall_ | johnthetubaguy: I actually just found it :) https://github.com/rackerlabs/quark/blob/6b0e51d4c5f80b41695a030bb4ff13bb314ac72e/quark/agent/agent.py#L53 | |
| 12:04:01 | johnthetubaguy | BobBall_: thats all old, but I guess thats good enough | |
| 12:04:16 | BobBall_ | ok thanks. | |
| 12:04:27 | johnthetubaguy | BobBall_: my ask is simple, give folks the ability to transition | |
| 12:05:04 | BobBall_ | Totally agree - I just wasn't 100% that Rackspace were actually reading that magic value. | |
| 12:06:11 | johnthetubaguy | for me, rackspace using it doesn't chanage my thinking on that, at least I don't think it is | |
| 12:08:00 | BobBall_ | IMO it should be a totally internal Nova string, but anyway, happy to deprecate for P and remove in Q+ | |
| 13:14:40 | openstackgerrit | Jens Rosenboom proposed openstack/nova master: WIP: Fix network metadata information - part 1/3 https://review.openstack.org/450211 | |
| 13:14:41 | openstackgerrit | Jens Rosenboom proposed openstack/nova master: WIP: Fix network metadata information - part 2/3 https://review.openstack.org/450212 | |
| 13:15:51 | efried | mikal I was told I should ask you for reviews of PowerVM changes. | |
| 13:16:05 | efried | mikal They're listed here: https://etherpad.openstack.org/p/pike-nova-priorities-tracking | |
| 13:18:06 | efried | harlowja Suggestion from thorst... | |
| 13:18:29 | efried | We added some wrappers around our TaskFlow usage that log time spent in a particular Task (https://review.openstack.org/#/c/438729/11/nova/virt/powervm/tasks/base.py) | |
| 13:18:38 | efried | Those metrics would be neat to have natively. | |
| 13:27:37 | thorst | harlowja: also, huge fan of taskflow. Love it. | |
| 13:45:29 | edleafe | Nova scheduler meeting in 15 minutes in #openstack-meeting-alt | |
| 13:58:40 | sfinucan | johnthetubaguy: Correct | |
| 13:58:51 | sfinucan | self.stub_out is mock-based | |
| 13:59:25 | openstackgerrit | Sean Dague proposed openstack/nova master: WIP: proposed different wording on quota doc https://review.openstack.org/450244 | |
| 14:00:13 | johnthetubaguy | sfinucan: I was talking to the osic folks about focusing on the mox stuff instead, as we can leave all the old self.stub_out, for saftey | |
| 14:02:52 | openstackgerrit | Maxim Nestratov proposed openstack/nova master: libvirt: Virtuozzo containers config drive support https://review.openstack.org/449818 | |
| 14:03:23 | johnthetubaguy | sfinucan: I added a note on the spec | |
| 14:03:29 | sfinucan | johnthetubaguy: Yeah, that would make sense. iirc the 'stub_out' thing was something sdague wrote to ease migration from Mox. No reason to stop using it now | |
| 14:03:31 | sfinucan | spec? | |
| 14:03:48 | johnthetubaguy | sfinucan: I meant blueprint | |
| 14:04:06 | johnthetubaguy | sfinucan: yeah, self.stubs.Set just gets a simple re-write thats easy to review | |
| 14:04:29 | sfinucan | exactly | |
| 14:04:40 | sfinucan | johnthetubaguy: If you had an OSIC'er that wanted something interesting to do for a week or so: write a cliff plugin for Sphinx | |
| 14:04:52 | sfinucan | a la https://sphinx-argparse.readthedocs.io | |
| 14:05:25 | johnthetubaguy | sfinucan: they are all overbooked right now | |
| 14:05:39 | sfinucan | johnthetubaguy: Good to hear :) | |
| 14:21:20 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: do not log error for missing _save_tags https://review.openstack.org/450265 | |
| 14:27:47 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Using max api version in notificationt sample test https://review.openstack.org/443686 | |
| 14:28:55 | bhagyashris | johnthetubaguy: Hi, could you please take some insights on https://review.openstack.org/#/c/409644/ if you have free time. | |
| 14:28:56 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Using max api version in notificationt sample test https://review.openstack.org/443686 | |
| 14:30:01 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Move 'floating_ips' opts into 'network' https://review.openstack.org/431039 | |
| 14:30:01 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Deprecate 'default_floating_pool' https://review.openstack.org/431038 | |
| 14:30:02 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Add neutron.default_floating_pool https://review.openstack.org/431037 | |
| 14:30:02 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Rename '[neutron] ovs_bridge' https://review.openstack.org/450266 | |
| 14:33:41 | sfinucan | sdague, johnthetubaguy: Renamed 'ovs_bridge' instead ^ :) | |
| 14:40:35 | sean-k-mooney | sfinucan: regarding the ovs bridge name | |
| 14:40:48 | sean-k-mooney | that is now passed by neutron to nova | |
| 14:41:05 | sfinucan | sean-k-mooney: Yeah, that option is the default in case it's not needed | |
| 14:41:07 | sean-k-mooney | is this config being kept for nova-networks | |
| 14:41:09 | sfinucan | hence the rename | |
| 14:41:16 | sfinucan | See https://review.openstack.org/450266 | |
| 14:41:47 | sean-k-mooney | sfinucan: yes but my question is when do we need it? | |
| 14:41:50 | sfinucan | I'm going on the assumption that there are still instances where that won't be passed by neutron, though I don't know how I could go find out | |
| 14:41:52 | johnthetubaguy | I think its to support old neutron versions, I guess. At somepoint we can probably pull that, if we got microversion like API system | |
| 14:41:54 | sfinucan | Aha, jinx :) | |
| 14:42:31 | sfinucan | Yeah, I wouldn't even know where to start in investigating that | |
| 14:42:47 | sfinucan | ...besides just handing it off to neutron guys | |
| 14:43:02 | sean-k-mooney | ya as far as i know the openvsiwtch,ovn and odl drivers now pass the bridge as of newton | |
| 14:43:31 | sean-k-mooney | ill take a quick look and confirm | |
| 14:45:04 | sfinucan | sean-k-mooney: Awesome. If so we could drop that option entirely instead | |
| 14:46:13 | sean-k-mooney | sfinucan: im not seeing it in odl at first glance but it would be a small change to enable. | |
| 14:46:52 | openstackgerrit | Matthew Booth proposed openstack/nova master: Improve the readability of check_instance_state https://review.openstack.org/440536 | |