| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-03-21 | |||
| 14:46:04 | edleafe | cdent: I was reading alex_xu's comment at http://p.anticdent.org/1sVC and your reply | |
| 14:46:45 | cdent | edleafe: if there is a body, and there is either no content-type or no content-length, that's a 400 | |
| 14:47:17 | cdent | edleafe: but we only have the content-length header as a reasonable proxy for knowing if there is a body | |
| 14:47:21 | openstackgerrit | Sujitha proposed openstack/nova master: Change os-server-tags default policy https://review.openstack.org/396420 | |
| 14:47:21 | edleafe | cdent: a body with no content-length? | |
| 14:48:22 | cdent | edleafe: a healthy client would never do that, but if, for example, you telnet to port 80 and write a PUT it's easy to do | |
| 14:48:37 | cdent | also, if chunked encoding is being used, all bets are off | |
| 14:48:45 | cdent | but we don't use that, so that's a relief | |
| 14:50:43 | cdent | alex_xu, edleafe: does that help clear things up or just make it more muddy? sadly we can't protect against all cases of "telnet to port 80" but we can cover some. | |
| 14:51:22 | cdent | on the other hand it is entirely possible I'm putting too much trust in the existing gabbi tests, but since they pass, I feel pretty okay | |
| 14:51:50 | alex_xu | I think i get your point now | |
| 14:55:30 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add description to policies in assisted_volume_snapshots.py https://review.openstack.org/445238 | |
| 14:55:44 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add description to policies in admin_password.py https://review.openstack.org/443957 | |
| 14:55:45 | edleafe | cdent: you mean there are other ways to use OpenStack other than telnet? | |
| 14:56:16 | rfolco | mriedem, edleafe: re: first pike bp implemented: nice! thanks to edleafe, cdent and jaypipes for great guidance :) | |
| 14:56:17 | cdent | edleafe: only if you pass the awkward test | |
| 14:56:35 | cdent | \o/ rfolco | |
| 14:59:00 | alex_xu | if we check the presence the body, that means we have to read the body first | |
| 14:59:05 | jaypipes | rfolco: and now you can submit a patch that changes the scheduler/report client to use DELETE /r-p/{uuid}/inventories :) | |
| 14:59:31 | alex_xu | that is waste, that is the reason cdent didn't want to check that | |
| 14:59:36 | openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: mark some Image backend methods as abstract https://review.openstack.org/448142 | |
| 14:59:37 | mriedem | mdbooth: see how that suits you ^ | |
| 15:00:08 | cdent | alex_xu: yes, besides being a waste, it also limits some of the options for future handling | |
| 15:00:33 | alex_xu | cdent: what options? | |
| 15:00:46 | mdbooth | mriedem: WFM | |
| 15:00:49 | rfolco | jaypipes, noted | |
| 15:00:53 | jroll | cdent: edleafe: I'd love to start on this spec today, if you want to give it a quick skim before I do: https://etherpad.openstack.org/p/nova-ironic-flavor-transition-plan | |
| 15:01:08 | cdent | handling streams | |
| 15:01:14 | cdent | sorry phone | |
| 15:01:51 | edleafe | jroll: will get to it in a bit. Meeting Hell Morning and all... | |
| 15:02:15 | jroll | dansmith: mriedem: looks like most of the placement crew is happy with this flavor extra specs, spec, when you have a few: https://review.openstack.org/#/c/446570/ | |
| 15:02:17 | jroll | edleafe: no rush | |
| 15:07:28 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Stop using mox stubs in nova/tests/unit/cells/fakes.py https://review.openstack.org/342043 | |
| 15:08:32 | alex_xu | cdent: +2 on the patch, thanks for explain all of that to me patiently | |
| 15:12:27 | bauzas | jroll: dansmith: FWIW, just reviewing https://review.openstack.org/#/c/446570/2/specs/pike/approved/custom-resource-classes-in-flavors.rst now | |
| 15:12:54 | jroll | bauzas: woohoo | |
| 15:13:34 | cdent | alex_xu: thanks for asking so many questions and being so thourough. is great. | |
| 15:13:56 | mriedem | jroll: starred | |
| 15:16:40 | mriedem | sdague: alex_xu: oomichi: i put this on the api subteam meeting agenda, but would be nice to get your feedback, or at least start thinking about this before then https://review.openstack.org/#/c/447149/1/specs/pike/approved/service-hyper-uuid-in-api.rst@148 | |
| 15:17:08 | mriedem | alex_xu: i know it's late for you so don't worry too much about it today | |
| 15:17:20 | cdent | jroll: I dunno, after telling you to change that 0 to a 1, I am _completely_ exhausted. | |
| 15:17:25 | mriedem | just lose a *little* bit of sleep :) | |
| 15:19:41 | alex_xu | mriedem: got it, I will check it tomorrow morning | |
| 15:24:16 | dane-fichter | johnthetubaguy: got a second to talk about the trusted flavors spec? | |
| 15:31:29 | openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in admin_actions. https://review.openstack.org/440829 | |
| 15:31:31 | bauzas | jroll: made a comment on https://review.openstack.org/#/c/446570/2 | |
| 15:31:52 | bauzas | jroll: not sure it could be a bug, but I would appreciate some brainstorm | |
| 15:35:03 | openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in admin_actions. https://review.openstack.org/440829 | |
| 15:37:50 | openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in admin_password.py https://review.openstack.org/443957 | |
| 15:38:28 | openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in agents.py https://review.openstack.org/445208 | |
| 15:40:21 | openstackgerrit | Sandeep Pawar proposed openstack/nova master: Libvirt volume driver for Veritas HyperScale https://review.openstack.org/443951 | |
| 15:40:23 | jroll | bauzas: resize depends on migrate being available, right? | |
| 15:40:38 | jroll | (which ironic can't do) | |
| 15:40:39 | bauzas | jroll: nova resize ? | |
| 15:40:42 | jroll | yes | |
| 15:40:58 | bauzas | I dunno, but good point, lemme verify | |
| 15:41:07 | openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in aggregates.py https://review.openstack.org/445230 | |
| 15:41:10 | jroll | I'm looking, I see lots of migration code in it | |
| 15:41:16 | bauzas | jroll: either way, this spec doesn't only target a specific virt driver | |
| 15:41:34 | bauzas | so I'm supposing it can be possible | |
| 15:41:42 | bauzas | eg. FPGA devices with libvirt | |
| 15:41:51 | jroll | bauzas: your resize concerns are around the upgrade thing we do in the ironic driver, though | |
| 15:41:54 | bauzas | although it would require libvirt to expose it | |
| 15:42:07 | jroll | (afaict) | |
| 15:42:23 | bauzas | jroll: well, basically I thought about resize because it's all about an existing instance taking an API flavor | |
| 15:42:43 | bauzas | here, that spec is focusing on changing the instance nested flavors, not the API-faced flavors AFAICS | |
| 15:43:06 | bauzas | so we could end up mixing both old and new world, which could be a problem | |
| 15:43:18 | bauzas | jroll: tbc, my -1 is for signaling a potential problem | |
| 15:43:22 | jroll | I still don't get it, sorry :/ | |
| 15:43:26 | jroll | yeah I understand that much :) | |
| 15:43:39 | jroll | just trying to understand the concern | |
| 15:43:46 | bauzas | jroll: first, lemme verify if resize is available for ironic | |
| 15:44:01 | jroll | sure | |
| 15:44:27 | bauzas | mmm, it is not | |
| 15:44:28 | bauzas | https://docs.openstack.org/developer/nova/support-matrix.html#operation_resize | |
| 15:44:57 | bauzas | so perhaps it can be a nobrainer | |
| 15:45:04 | mriedem | cfriesen: comments in https://review.openstack.org/#/c/265282/ | |
| 15:45:15 | mriedem | cfriesen: i'm +2 otherwise | |
| 15:47:42 | jroll | bauzas: replied in gerrit | |
| 15:53:40 | bauzas | jroll: I'm still struggling to evaluate the impacty | |
| 15:53:46 | bauzas | impact* | |
| 15:55:11 | jroll | bauzas: that instance.flavor migration thing only impacts allocations, afaict | |
| 15:55:44 | mriedem | cfriesen: nvm i'll just address the issues quick and approve | |
| 15:59:04 | bauzas | jroll: just to make sure I understand correctly | |
| 15:59:35 | bauzas | jroll: we migrate the existing instances in order to self-heal the allocations that would claim custom resource classes, right? | |
| 16:01:02 | jroll | bauzas: yep. we don't want a flavor to appear that suddenly can claim a node with an instance already on it | |
| 16:01:08 | jroll | though, thinking back to this morning | |
| 16:01:39 | jroll | if we make a change that makes nova claim all resources for ironic nodes with an instance... we don't need this extra migration | |
| 16:03:11 | bauzas | jroll: graaah, just entering a team meeting, need to defer my thinkins for that :( | |
| 16:03:17 | bauzas | thinkings* | |
| 16:03:22 | jroll | bauzas: it's fine, no worries | |
| 16:05:40 | jamespage | mriedem: hello | |
| 16:05:48 | jamespage | mriedem: would you have time to chat about https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1665698 | |
| 16:05:48 | openstack | Launchpad bug 1665698 in libvirt (Ubuntu Yakkety) "/etc/qemu-ifup not allowed by apparmor" [Medium,Triaged] | |
| 16:06:36 | mriedem | jamespage: ok, but i have no context on that. | |
| 16:06:48 | jamespage | mriedem: let me give you some :-) | |
| 16:06:53 | jamespage | mriedem: ok so... | |
| 16:06:56 | jamespage | mriedem: some history | |
| 16:07:04 | mriedem | this is the empty script path element thing? | |
| 16:07:11 | mriedem | i saw there was a revert proposed for that | |