Earlier  
Posted Nick Remark
#openstack-nova - 2017-03-16
10:35:16 lyarwood mdbooth: on the Cinder side? I have no idea.
10:35:25 lyarwood mdbooth: but in the API yes
10:35:35 lyarwood mdbooth: that's all we care about right?
10:35:47 mdbooth So a cinderv2 attachment_id is the same as a cinderv3 attachment_id
10:35:53 mdbooth i.e. the uuid values are the same
10:36:01 lyarwood mdbooth: that I don't know
10:36:06 openstackgerrit Stephen Finucane proposed openstack/nova master: Replace obsolete vanity openstack.org URLs https://review.openstack.org/443266
10:36:06 gibi mdbooth, lyarwood: I think we you want to change when the volume.detach is sent then it would make sense to send a detach.start and a detach.end
10:36:30 mdbooth gibi: Out of scope for this change, tbh.
10:36:36 mdbooth Waaaaaaaaay out of scope
10:36:47 gibi mdbooth: then let's not change when to send the volume.detach :)
10:36:47 lyarwood gibi: but I can follow up with that after
10:37:07 gibi lyarwood: I think it is not super important
10:38:08 mdbooth lyarwood gibi: I don't know enough about the practical uses of notifications to know how important that order change is, but if there's any doubt we should leave it alone
10:38:36 mdbooth It's not at all relevant to lyarwood's change
10:39:00 mdbooth lyarwood: So that means moving the notification with the detach call
10:39:37 lyarwood mdbooth: sure, then the notification comes before bdm.destroy
10:40:04 mdbooth lyarwood: I don't see a problem with that.
10:40:14 gibi mdbooth, lyarwood: OK
10:41:06 openstackgerrit John Garbutt proposed openstack/nova-specs master: Add policy-remove-scope-checks spec https://review.openstack.org/433037
10:41:14 openstackgerrit John Garbutt proposed openstack/nova-specs master: Add additional-default-policy-roles spec https://review.openstack.org/427872
10:41:15 mdbooth lyarwood: As I see it, it's more about the behaviour when detach fails, tbh
10:41:35 lyarwood mdbooth: true
10:42:02 openstackgerrit Sylvain Bauza proposed openstack/nova-specs master: Proposed block accepting AZ renames https://review.openstack.org/446446
10:42:15 lyarwood mdbooth: I need to run for a dentist appointment, back in ~90mins or so.
10:42:23 lyarwood mdbooth: are you around for the cinder/nova meeting later today?
10:42:30 mdbooth lyarwood: kk
10:42:44 mdbooth lyarwood: Possibly. Talk later.
10:42:52 lyarwood mdbooth: ack, thanks
11:03:21 openstackgerrit Sean Dague proposed openstack/nova master: remove hacking rule that enforces log translation https://review.openstack.org/446452
11:22:40 openstackgerrit Jianghua Wang proposed openstack/nova master: XenAPI: device tagging https://review.openstack.org/333781
11:23:45 openstackgerrit Bing Li proposed openstack/nova master: Add server-action-removefloatingip.json file and update servers-actions.inc https://review.openstack.org/446471
11:30:22 gibi dansmith: Hi! I left some suggestion in https://review.openstack.org/#/c/445697
11:43:50 gibi alexey_weyl: I checked the aggregate notification in a new devstack from master.
11:44:02 gibi alexey_weyl: It works for me. See the logs in http://paste.openstack.org/show/602943/
12:06:41 alexey_weyl gibi: Hi
12:07:41 alexey_weyl gibi: I have checked it also, and i saw that notifications work for vitrage with master. but still notifications don't work on liberty (notifications about the aggregated hosts)
12:10:05 gibi alexey_weyl: I don't have access to Liberty test node right now. Also Liberty is already reached end of support
12:10:48 gibi alexey_weyl: so even if it is buggy we cannot fix it on Liberty
12:14:37 alexey_weyl gibi: ok, i see that, and it is ok. but I have some other issue
12:15:25 alexey_weyl gibi: The thing is that for example in devstack when you create it, you don't have an "aggregated host" but we have AZs.
12:16:41 alexey_weyl gibi: After our talk before I thought that I could use only the Aggregated hosts to get the needed data, but it seems that I would need to get the AZs by calling the availability-zone list and thus because it doesn't has id we have a problem
12:17:03 mdbooth lyarwood: You back?
12:19:01 robcresswell Quick question; someone's added a patch to Horizon that hides the Soft Reboot button if the Instance state is anything other than Active; is this correct? Had a look at the API docs but they only seem to show how to form the request, not any of the conditions around its usage.
12:19:54 mdbooth robcresswell: soft reboot doesn't make sense for an instance which isn't running
12:20:38 robcresswell mdbooth: Yeah, I'm not clued in on every specific status nova supports
12:20:44 mdbooth error, perhaps
12:21:30 mdbooth robcresswell: I mean, regardless of what the api allows, from a UI pov that restriction makes sense to me
12:22:06 robcresswell mdbooth: Cool. Good enough for me.
12:22:24 robcresswell Thanks
12:24:43 alexey_weyl gibi: The reason that I would need to call the availability-zone list as well is because sometimes we don't have the aggregated hosts but we have AZs
12:27:27 gibi alexey_weyl: if you have an AZ then you automatically have a host aggregate behind it
12:28:13 gibi alexey_weyl: the availability-zone list just iterate throught the host aggregates to see if there is a metadata key on the aggregate with name availability_zone
12:29:04 openstackgerrit John Garbutt proposed openstack/nova-specs master: Add policy-remove-scope-checks spec https://review.openstack.org/433037
12:31:55 gibi alexey_weyl: what would be different for you if there would be uuid besids AZ name?
12:32:55 lyarwood mdbooth: back now, going to attempt to eat lunch and then catch up on your review comments
12:40:15 openstackgerrit Béla Vancsics proposed openstack/nova master: Reduce code complexity - libvirt/config.py https://review.openstack.org/359879
12:40:52 alexey_weyl gibi: on my devstack which is a devstack that works with master branch, I have AZs but don't have any aggregated hosts
12:41:06 mdbooth lyarwood: You might want to start with the detach refactor, btw, because I think that requires a rethink which may affect other patches.
12:42:29 gibi alexey_weyl: but you have an empty host aggregate I assume
12:44:05 lyarwood mdbooth: kk looking now
12:44:08 gibi alexey_weyl: actually you can have more than one empty host aggregate connected to the same AZ
12:45:46 gibi alexey_weyl: and those aggregates have uuid
12:45:56 gibi alexey_weyl: if you need something unique
12:47:04 openstackgerrit John Garbutt proposed openstack/nova-specs master: Add additional-default-policy-roles spec https://review.openstack.org/427872
12:51:52 alexey_weyl gibi: I don't quite understand. I ran on my devstack the command "nova aggregate-list" and received that it is empty and then I ran "nova availability-zone-list" and I saw to AZs
12:52:27 alexey_weyl gibi: what is this empty aggregated host?
12:59:19 lyarwood hmm does any have an idea how I can reference a line in the original file of a gerrit diff?
13:00:09 rfolco cdent, ping
13:00:16 cdent hi rfolco
13:00:42 rfolco cdent, cannot find how to test concurrent update/delete. How to emulate that ?
13:01:19 cdent rfolco: the idea you have before of trying to do a DELETE ../inventories with an incorrect resource_provider_generation should be good enough
13:02:06 rfolco cdent, hmm I thought the generation would fall into a different code path, not that exception.
13:02:34 cdent the generation being wrong is the only thing that can cause ConcurrentUpdateDetected to raise
13:02:35 jaypipes sfinucan: well, there will need to be *some* os-vif complementary part to that, yes.
13:03:24 jaypipes macsz: btw, you're comment on that "i find the lack of commit message disturbing." was most excellent ;)
13:03:36 rfolco cdent, also, delete does not produce json, only post/put do. So not sure about the other suggestion on checking delete request/response with 409
13:03:47 gibi alexey_weyl: run nova aggregate-list
13:04:09 cdent rfolco: the error's response body will be json if you send an accept header of application/json
13:04:27 rfolco cdent, accept header mesans the decorator ?
13:04:32 cdent so even though a success response is empty an error response will not
13:04:51 cdent i mean in the gabbi test: request_headers:\naccept: application/json\n
13:05:14 openstackgerrit Balazs Gibizer proposed openstack/nova master: use context mgr in instance.delete https://review.openstack.org/443764
13:05:46 rfolco cdent, hmmm, ok, thanks
13:06:05 cdent rfolco: that "hmmm" makes it sound you're not quite sure what I mean or ... ?
13:06:27 rfolco cdent, haha hmm means, ok in theory I got it, lets see in practice.
13:06:58 cdent ah, okay, cool. let me know if you need more info as you go along
13:07:00 rfolco cdent, I'll bother you again if I get stuck
13:08:03 gibi alexey_weyl: the AZ is not a real entity in nova. The host aggregate is the real one and if you have an aggregate with a special metadata 'availability_zone' then the hosts in that aggregate become part of an AZ
13:08:38 alexey_weyl gibi: I have ran the nova aggregate-list and I returned empty
13:08:47 alexey_weyl gibi: although I have 2 AZs
13:24:16 gibi alexey_weyl: nova and internal?
13:25:17 gibi alexey_weyl: nova is the default AZ. host not part of any AZ will belong there
13:26:00 gibi alexey_weyl: you can ignore the internal, as far as I understand internal never contains compute hosts
13:26:53 mriedem has anyone seen this test fail before? http://logs.openstack.org/75/446175/1/gate/gate-tempest-dsvm-neutron-full-ubuntu-xenial/479c7bf/console.html#_2017-03-16_01_31_33_688563
13:26:58 gibi alexey_weyl: I hope somebody correct me as I reached the limit of my knowledge
13:29:17 mriedem bauzas: can you take a look at the ocata regression fix here https://review.openstack.org/#/c/444106/ and the functional test below it? the test is the one i was talking about yesterday.
13:29:30 mriedem we need to get those in because they are hurting the ironic ci
13:45:36 openstackgerrit Rafael Folco proposed openstack/nova master: DELETE all inventory for a resource provider https://review.openstack.org/416669
13:50:44 openstackgerrit Balazs Gibizer proposed openstack/nova master: doc: configurable versioned notifications topics https://review.openstack.org/446523

Earlier   Later