| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-03-14 | |||
| 21:56:52 | ZZelle | mriedem, only one person in VMware subteam? | |
| 21:56:56 | efried | mriedem ...which, as you say, seems a bit weird - and fairly involved to validate | |
| 21:57:01 | browne | ZZelle: sure, just put me on the patch to review | |
| 21:57:24 | ZZelle | browne, ok :) | |
| 21:57:41 | edleafe | efried: ah, ok. Thought it was related to another libvirt thing mriedem and I were discussing | |
| 21:57:57 | efried | ZZelle https://etherpad.openstack.org/p/pike-nova-priorities-tracking has a list of subteam members, FYI. | |
| 21:58:06 | mriedem | browne: since you're here, do you know if the vcenter driver has to wait at all to make a connection to the backing vcenter on startup? | |
| 21:58:12 | efried | ZZelle Not sure if your patch would be appropriate for inclusion in that subteam review list. | |
| 21:58:44 | openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: add some documentation around quotas https://review.openstack.org/417563 | |
| 21:59:34 | browne | mriedem: i believe there was a bug related to that. where startup of nova-compute was slow because it was connecting to vcenter on startup to retrieve all objects or some effect like that | |
| 21:59:40 | browne | let me do a search for it | |
| 21:59:42 | efried | mriedem https://github.com/openstack/nova/blob/edf51119fa59ff8a3337abb9107a06fa33d3c68f/nova/virt/vmwareapi/host.py#L49-L118 | |
| 21:59:45 | efried | and browne ^^ | |
| 22:00:13 | ZZelle | efried, i should add my changes in "Ready for subteam review:" part? | |
| 22:00:17 | efried | mriedem browne Looks like on both init and get_host_stats, it checks and updates the service state. | |
| 22:00:40 | efried | ZZelle Not sure if your change set needs to be special to be included there - that's a question for browne et al. | |
| 22:00:46 | mriedem | browne: i remember that too i think, but i might also be thinking of a cache issue with the _sync_instance_power_state periodic task in the compute | |
| 22:00:52 | ZZelle | efried, ok | |
| 22:01:08 | browne | efried: yeah, and i believe someone created a patch to lazy init the state on startup, but wasn't approved | |
| 22:01:26 | efried | browne The above code looks like it kinda does that. | |
| 22:01:38 | efried | lazy and (kinda) polling | |
| 22:01:48 | browne | yeah, so maybe it did get in | |
| 22:01:56 | efried | I like how it cheats by using get_host_stats to kick off the recheck. | |
| 22:02:30 | efried | I can git blame that sucker to determine the provenance... | |
| 22:02:46 | ZZelle | efried, or it's a way to ensure VMware connection during nova-compute-vmware startup? | |
| 22:03:36 | efried | ZZelle Yeah, that's the idea. But it doesn't block; it just marks the compute service as down whenever it detects the external connection is dead - and then re-tests it whenever get_host_stats runs. | |
| 22:03:51 | efried | mriedem and I are trying to figure out if a similar approach is apppropriate for the PowerVM driver. | |
| 22:04:05 | efried | (or if that's more trouble than it's worth) | |
| 22:04:49 | ZZelle | efried, iirc (at least in kilo) the nova-compute crashs if it fails to connect to VMware during service startup | |
| 22:05:17 | efried | ZZelle And that's what the PowerVM external driver does (after trying to connect for 10 minutes) | |
| 22:06:18 | efried | ZZelle mriedem browne Looks like it happened here https://review.openstack.org/#/c/290315/ as a result of https://launchpad.net/bugs/1316928 | |
| 22:06:18 | openstack | Launchpad bug 1316928 in OpenStack Compute (nova) "VMware driver does not change compute node state to unavailable after disconnecting from vCenter" [Medium,Fix released] - Assigned to Giridhar Jayavelu (gjayavelu) | |
| 22:08:57 | browne | efried: i was thinking of a different bug, but this one looks familiar too | |
| 22:11:30 | efried | So mriedem, I'm thinking this is a pretty involved bit of stuff to try to drop into the initial patch. Whaddaya say I knock that timeout down to like two minutes, and develop the state changer thingy in a subsequent change set? | |
| 22:17:07 | mriedem | efried: sure, and leave a TODO in the initial patch or whatever | |
| 22:17:15 | efried | mriedem Cool beans, thanks. | |
| 22:17:23 | mriedem | bmace: let's chat here, | |
| 22:17:40 | mriedem | bmace: there is a weekly nova/cinder meeting http://eavesdrop.openstack.org/#Cinder,_Nova | |
| 22:17:55 | mriedem | bmace: for anyone interested in the multiattach stuff, that's a good meeting to be in for latest status and what needs attention or help | |
| 22:18:19 | bmace | mriedem: thanks much | |
| 22:18:46 | mriedem | bmace: we're tracking review priorities per subteam in here https://etherpad.openstack.org/p/pike-nova-priorities-tracking | |
| 22:19:06 | mriedem | cinder stuff is at L75 | |
| 22:19:21 | mriedem | i'm trying to keep as much of it contained to per-week increments as possible, | |
| 22:19:47 | mriedem | so right now the priorities i believe are getting a cinderclient release done so nova can determine the min/max versions from the cinder api, | |
| 22:20:03 | mriedem | getting some data model changes into the nova block_device_mappings table (lyarwood's patches), | |
| 22:20:16 | mriedem | and reviewing johnthetubaguy's spec and making sure it looks ok | |
| 22:20:49 | mriedem | so eyes on the spec would be good - the more people looking the better. i don't know how familiar your people are with the bdm attach/detach flows in nova, or the compute manager and block_device code | |
| 22:20:54 | mriedem | it gets a bit hairy | |
| 22:22:56 | bmace | mriedem: i have heard some stories from the folks looking at it about the hair ;) | |
| 22:25:41 | smcginnis | mriedem: cinderclient is released. I think we need to raise the minimum version though. | |
| 22:26:00 | smcginnis | mriedem: But new deployments are likely getting the latest and goodest. | |
| 22:27:45 | openstackgerrit | Ed Leafe proposed openstack/nova master: WIP - move urlmap.py https://review.openstack.org/444524 | |
| 22:27:45 | openstackgerrit | Ed Leafe proposed openstack/nova master: WIP - Combine the two auth.py files https://review.openstack.org/444521 | |
| 22:27:46 | openstackgerrit | Ed Leafe proposed openstack/nova master: WIP - Move __init__.py https://review.openstack.org/444522 | |
| 22:27:46 | openstackgerrit | Ed Leafe proposed openstack/nova master: WIP - Move wsgi.py https://review.openstack.org/444523 | |
| 22:27:47 | openstackgerrit | Ed Leafe proposed openstack/nova master: WIP - Move common.py https://review.openstack.org/445668 | |
| 22:27:47 | openstackgerrit | Ed Leafe proposed openstack/nova master: WIP - move api_version_request https://review.openstack.org/445669 | |
| 22:27:50 | openstackgerrit | Ed Leafe proposed openstack/nova master: WIP - move compute directory https://review.openstack.org/445670 | |
| 22:27:51 | openstackgerrit | Ed Leafe proposed openstack/nova master: WIP - Move the test fakes https://review.openstack.org/445671 | |
| 22:32:14 | mriedem | smcginnis: ok yeah we need the g-r bump then for ildikov's patch to check the max available version in nova | |
| 22:45:29 | openstackgerrit | Anusha Unnam proposed openstack/nova master: POC: add descriptions to server tags https://review.openstack.org/434842 | |
| 22:46:03 | EmilienM | mriedem: FYI I abandon https://review.openstack.org/#/c/428424/ - you win | |
| 22:57:15 | openstackgerrit | Samantha Blanco proposed openstack/nova master: [WIP] Make flavor-rxtx policy more granular https://review.openstack.org/444036 | |
| #openstack-nova - 2017-03-15 | |||
| 00:15:08 | openstackgerrit | christopher.uhler proposed openstack/nova master: Libvirt volume driver for Veritas HyperScale https://review.openstack.org/443951 | |
| 00:40:52 | mriedem | edleafe: dansmith: on https://review.openstack.org/#/c/441544/7/nova/objects/fields.py did we decide to not check before adding the CUSTOM_ prefix if it were already in the norm_name? | |
| 00:41:02 | mriedem | i believe that's come up before | |
| 00:42:08 | dansmith | mriedem: we're depending on the drivers to return legit classes, yes | |
| 00:52:08 | mriedem | so, we could still create CUSTOM_CUSTOM_BAREMETAL_GOLD then | |
| 00:52:17 | openstackgerrit | Dan Smith proposed openstack/nova master: Teach HostAPI about cells https://review.openstack.org/442162 | |
| 00:52:17 | openstackgerrit | Dan Smith proposed openstack/nova master: Make scheduler target cells to get compute node instance info https://review.openstack.org/439891 | |
| 00:52:18 | openstackgerrit | Dan Smith proposed openstack/nova master: Sort CellMappingList.get_all() for safety https://review.openstack.org/443174 | |
| 00:52:19 | openstackgerrit | Dan Smith proposed openstack/nova master: Add get_by_instance_uuids() to InstanceMappingList https://review.openstack.org/443292 | |
| 00:52:19 | openstackgerrit | Dan Smith proposed openstack/nova master: Clean up ClientRouter debt https://review.openstack.org/444487 | |
| 00:52:20 | openstackgerrit | Dan Smith proposed openstack/nova master: Make server_groups determine deleted-ness from InstanceMappingList https://review.openstack.org/443293 | |
| 00:52:20 | openstackgerrit | Dan Smith proposed openstack/nova master: Remove Mitaka-era service version check https://review.openstack.org/442861 | |
| 00:52:21 | openstackgerrit | Dan Smith proposed openstack/nova master: Make conductor ask scheduler to limit migrates to same cell https://review.openstack.org/438025 | |
| 00:52:21 | openstackgerrit | Dan Smith proposed openstack/nova master: Add workaround to disable group policy check upcall https://review.openstack.org/442736 | |
| 00:52:22 | openstackgerrit | Dan Smith proposed openstack/nova master: Avoid lazy-loading projects during flavor notification https://review.openstack.org/445697 | |
| 00:52:31 | mriedem | and it wouldn't be the drivers fault, it could be the operator set the node.resource_class value to be 'CUSTOM_BAREMETAL_GOLD' | |
| 00:53:07 | dansmith | right, but that's what we should do, IMHO | |
| 00:53:17 | dansmith | otherwise there's this odd ambiguity, | |
| 00:53:44 | dansmith | and the node resource class is an ironic construct, not specifically "this is (or may be) the exact resource class in placement" | |
| 00:54:40 | mriedem | so ironic's API should then return a 400 if i try to set node.resource_class to anything with the CUSTOM_ prefix? | |
| 00:55:01 | dansmith | that's up to them, but I'd expect not | |
| 00:55:59 | dansmith | and since they haven't placed those restrictions thus far (any of the ones required to be a resource class in placement), | |
| 00:56:23 | dansmith | we should just treat that as a thing, prefix with CUSTOM_ and normalize as we need) | |
| 00:56:41 | dansmith | like, maybe they let the resource class include spaces, they clearly allow lowercase, maybe punctuation, etc | |
| 00:56:46 | dansmith | and that's cool | |
| 01:00:10 | mriedem | ok so CUSTOM_CUSTOM_BAREMETAL_GOLD just might be a thing you end up with, and if so, oops, but it doesn't break | |
| 01:00:37 | dansmith | right | |
| 01:00:58 | mriedem | not sure i want to start thinking about what it would take to unwind that if you wanted to fix it, | |
| 01:01:04 | mriedem | across both services | |
| 01:01:13 | dansmith | I don't think it's a big deal actually, but, | |
| 01:01:23 | dansmith | when they start reporting into placement, they can generate and handle their classes however they want | |
| 01:03:12 | mriedem | ok | |
| 01:03:21 | mriedem | i've left comments in the code parts, will do tests later | |
| 01:57:11 | openstackgerrit | Danfly proposed openstack/nova master: Completely remove mox from unit/network/test_linux_net.py https://review.openstack.org/445504 | |
| 02:19:44 | openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs master: Send out notifications when instance tags changed https://review.openstack.org/429569 | |
| 02:47:36 | openstackgerrit | Wei Cao proposed openstack/nova master: vmware: Change the VM Create spec https://review.openstack.org/444119 | |
| 03:09:03 | alex_xu | gmann: johnthetubaguy some test https://review.openstack.org/445361 | |