| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-03-10 | |||
| 21:20:40 | efried | thorst_afk ^^ addressed comments. Hoping for that +1 before you disappear into babyland. | |
| 21:20:50 | thorst_afk | efried: k | |
| 21:33:35 | efried | harlowja Another TaskFlow-havin' change set, if you're interested ^^ | |
| 21:33:41 | harlowja | cools | |
| 21:34:01 | efried | harlowja Be sure to read thorst's commentary ;-) | |
| 21:34:47 | harlowja | kk | |
| 21:35:43 | harlowja | woah, lots of commentary | |
| 21:35:44 | harlowja | lol | |
| 21:36:16 | harlowja | hopefully taskflow has helped some :-P | |
| 21:36:33 | efried | harlowja As you can see, we definitely dig it. | |
| 21:36:49 | harlowja | ya, i mean i don't like having all the LinearFlow and such objects | |
| 21:37:02 | harlowja | ha | |
| 21:37:02 | harlowja | i was going to try to make it more natural, but haven't quite figured that out | |
| 21:37:32 | harlowja | it'd be interesting to do something like | |
| 21:37:48 | efried | harlowja I was telling thorst yesterday - I've had a TODO for a long time to rework our TaskFlow usage into a much more complicated unordered parallel flow with appropriate interdependencies. | |
| 21:37:59 | efried | He basically said, "You had my veto at 'complicated'" | |
| 21:38:13 | harlowja | lol | |
| 21:38:51 | harlowja | ya, if i could i'd somehow plug what taskflow in at more of the language level | |
| 21:39:11 | efried | harlowja FYI, this is the flow I was talking about: https://github.com/openstack/nova-powervm/blob/master/nova_powervm/virt/powervm/driver.py#L384 | |
| 21:39:41 | harlowja | so that somehow u could give say a set of interconnected functions to some kind of object and it would try to extrapolate the flow(s) | |
| 21:40:16 | efried | harlowja You basically have that, with provides/requires. And I'm sure it works perfectly with no bugs. | |
| 21:40:17 | harlowja | ya, it'd be interesting to try to make such kind of functions more elegant | |
| 21:40:25 | harlowja | well i was thinking of something like | |
| 21:40:48 | efried | But I've fiddled with it a little bit and remember finding it a bit complicated to figure out how to set up the right engine/flow so it would actually be useful and run stuff in parallel. | |
| 21:41:26 | harlowja | `def a(): | |
| 21:41:26 | harlowja | b() | |
| 21:41:27 | harlowja | def b(): | |
| 21:41:27 | harlowja | c()` | |
| 21:41:27 | harlowja | now given a, is there a way to 'decompile' that into a corresponding set of linear flows (for example) | |
| 21:41:47 | efried | harlowja You're talking about static analysis of the code, though? | |
| 21:41:51 | harlowja | sort of | |
| 21:42:12 | efried | My knee-jerk is that you'd be passing the 80/20 point there ;-) | |
| 21:42:18 | harlowja | fair enough | |
| 21:42:19 | harlowja | ha | |
| 21:43:14 | harlowja | afaik the parallelism, basiclaly if u have things that can run in parallel (determined by ordering relationships); then changing the engine will run them in parallel (if there is no paralleism possible, then changing the engine won't do much) | |
| 21:44:43 | efried | harlowja Well, we did do some of that, down in pypowervm. You may actually get a kick out of this: https://github.com/powervm/pypowervm/blob/develop/pypowervm/utils/transaction.py#L498 | |
| 21:45:04 | efried | (thorst_afk we were just talkin about ya) | |
| 21:45:15 | harlowja | interesting | |
| 21:45:52 | harlowja | anything in taskflow that may make such stuff easier/more pretty/other? | |
| 21:47:08 | harlowja | seems like that FeedTask could just be a nestedflow? | |
| 21:47:17 | efried | harlowja To be honest, given what it does, I don't see a whole lot of improvement. | |
| 21:47:20 | harlowja | k | |
| 21:47:34 | efried | What's a nestedflow? | |
| 21:47:50 | harlowja | root_flow = flow("root") | |
| 21:47:56 | harlowja | root_flow.add(task1, task2...) | |
| 21:48:03 | harlowja | root_flow.add(nested_flow) | |
| 21:48:09 | harlowja | where nested_flow is yet another flow | |
| 21:48:49 | efried | harlowja Yeah, that's how we use it. | |
| 21:48:54 | harlowja | oh, k | |
| 21:49:02 | efried | https://github.com/openstack/nova-powervm/blob/master/nova_powervm/virt/powervm/driver.py#L454 | |
| 21:49:17 | efried | The aforementioned | |
| 21:50:26 | harlowja | kk | |
| 21:53:51 | figleaf | leakypipes: just catching up on scrollback. I ran tests on that patch and didn't get any errors | |
| 21:54:04 | leakypipes | figleaf: yeah, it's weird.. :) | |
| 21:54:53 | figleaf | leakypipes: well, Gerrit like is, so... :) | |
| 21:55:05 | figleaf | s/like is/likes it | |
| 21:55:13 | leakypipes | yeah, I saw that :) | |
| 21:56:19 | openstackgerrit | Dan Smith proposed openstack/nova master: Clean up ClientRouter debt https://review.openstack.org/444487 | |
| 22:06:53 | cfriesen | has anyone run into an issue with libvirt (version 1.2.12) reporting "operation failed: domain is no longer running" if you pause the instance while the migration is running (to force completion)? It seems to be fixed in libvirt 1.2.17. I'm looking at the libvirt code, but I figured I'd ask... | |
| 22:17:37 | openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova master: Allow live migrate paused instance when post copy is enabled https://review.openstack.org/444517 | |
| 22:29:00 | melwitt | dansmith: your thoughts would be appreciated on the consoleauth token upcall patch https://review.openstack.org/#/c/415922/ I was wondering whether it makes sense to also reject requests for connect_info too since it seemed possible it wouldn't be usable | |
| 22:29:28 | melwitt | or if I'm not understanding that right | |
| 22:39:35 | openstackgerrit | Ed Leafe proposed openstack/nova master: WIP - Combine the two auth.py files https://review.openstack.org/444521 | |
| 22:39:35 | openstackgerrit | Ed Leafe proposed openstack/nova master: WIP - Move __init__.py https://review.openstack.org/444522 | |
| 22:39:36 | openstackgerrit | Ed Leafe proposed openstack/nova master: WIP - move urlmap.py https://review.openstack.org/444524 | |
| 22:39:36 | openstackgerrit | Ed Leafe proposed openstack/nova master: WIP - Move wsgi.py https://review.openstack.org/444523 | |
| 22:52:57 | efried | melwitt Seems like you still have reservations about https://review.openstack.org/#/c/443745/. Not that you want to rollback the whole change; maybe just a reword before you commit. (I'm paraphrasing - that's not a direct quota [sic].) | |
| 22:56:21 | melwitt | efried: yeah, I think it's probably worth fixing the docstring and comments so as not to possibly confuse others down the line. I considered adjusting the wording myself and +2 it, but mriedem has a merge conflict at the top of the stack that I thought he might want to handle himself | |
| 22:58:47 | melwitt | heh, no, was a good quota joke | |
| 22:59:30 | efried | whew | |
| 22:59:50 | efried | There are so precious few of those, as we all know. | |
| 23:00:42 | melwitt | that's true, we don't get a lot of quota jokes around here. mostly just quota lamentations | |
| #openstack-nova - 2017-03-11 | |||
| 00:35:04 | openstackgerrit | Anusha Unnam proposed openstack/nova master: Add description to policies https://review.openstack.org/440836 | |
| 15:42:00 | openstackgerrit | Diana Clarke proposed openstack/python-novaclient master: Fix 'nova list --fields' error in no instances case https://review.openstack.org/396074 | |
| 18:21:34 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Plumbing for tagged nic attachment https://review.openstack.org/415622 | |
| 18:21:35 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Delete nic metadata when detaching interface https://review.openstack.org/435387 | |
| 18:21:37 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Libvirt support for tagged volume attachment https://review.openstack.org/418100 | |
| 18:21:38 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Delete disk metadata when detaching volume https://review.openstack.org/435082 | |
| 18:21:40 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Plumbing for tagged volume attachment https://review.openstack.org/391941 | |
| 18:21:41 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: API support for tagged device attachment https://review.openstack.org/376021 | |
| 18:21:44 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Libvirt support for tagged nic attachment https://review.openstack.org/415520 | |
| 19:12:12 | openstackgerrit | Dan Smith proposed openstack/nova master: No API cell up-call to delete consoleauth tokens https://review.openstack.org/415922 | |
| 23:10:47 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Decrement quota usage when deleting an instance in cell0 https://review.openstack.org/443395 | |
| 23:10:49 | openstack | bug 1670627 in OpenStack Compute (nova) "quota is always in-use after delete the ERROR instances " [Critical,In progress] https://launchpad.net/bugs/1670627 - Assigned to Matt Riedemann (mriedem) | |
| 23:10:49 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add regression test for bug 1670627 https://review.openstack.org/443745 | |
| 23:10:49 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Temporarily untarget context when deleting from cell0 https://review.openstack.org/443403 | |
| #openstack-nova - 2017-03-12 | |||
| 01:10:51 | mriedem | dansmith: new laptop means new dev env means relearning dash all over again :) | |
| 01:12:13 | dansmith | so it arrived? | |
| 01:12:25 | mriedem | yeah friday | |
| 01:12:36 | dansmith | cool | |
| 01:12:40 | mriedem | and lenovo fixed the thumbpad on this one, which i love | |
| 01:12:54 | mriedem | fixed == putting the buttons at the bottom of the pad again | |
| 01:12:59 | dansmith | ah | |
| 01:13:06 | dansmith | yeah that was a major problem | |
| 01:13:32 | mriedem | i also finally figured out how to turn on the backlit keyboard, heh - even though the old one had it, but i never used it | |
| 01:13:39 | mriedem | finally i can work in the dark | |
| 01:13:43 | mriedem | like a real troll | |
| 01:14:27 | dansmith | speaking of staying in the dark, we're just about to start "gremlins" and eat | |
| 01:14:48 | mriedem | ok. just eat before midnight. | |
| 01:14:50 | mriedem | ttyl | |