Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-03-10
15:25:22 ioni mriedem, ^
15:27:26 dims_ ioni : does it work if you just delete the line 33? (https://review.openstack.org/#/c/444350/1/nova/conf/notifications.py)
15:28:05 ioni testing now
15:28:11 dims_ thanks!
15:28:27 mriedem dims_: removing the deprecated_group line would break the alias right?
15:28:51 mriedem ioni: we should fix the other similar issues
15:28:56 dims_ should end up as 'DEFAULT' i think mriedem (need to check)
15:28:59 mriedem i pointed those out in the review (as did sfinucan)
15:29:03 ioni dims_, no, it doesn't work
15:29:20 ioni mriedem, i just saw your comment
15:29:20 mriedem dims_: if you don't have the deprecated_group kwarg, oslo.config doesn't know it came from a deprecated group and won't alias
15:29:21 lyarwood sfinucan: stupid question but where is the stable/ocata openstack-docs-tools build listed?
15:29:27 ioni mriedem, i'll resend
15:29:51 mriedem lyarwood: there isn't a stable branch for that http://git.openstack.org/cgit/openstack/openstack-doc-tools/
15:29:58 dims_ ioni : mriedem : ack thanks
15:30:20 sfinucan lyarwood: The tools are found in openstack-docs-tools, but the output is kept in openstack-manuals
15:30:20 sfinucan https://review.openstack.org/#/c/436474/
15:30:25 lyarwood mriedem / sfinucan ; right, so do we need https://review.openstack.org/#/c/444306/ in stable/ocata ? I assume not
15:31:30 sfinucan lyarwood: That tool checks out the nova code and uses a combo of oslo.config and Jinja2 templates to build those table files
15:31:49 lyarwood sfinucan: ah gotcha
15:32:40 sfinucan then dumps it into openstack-manuals project, which is where the stable/ocata branch will be (not openstack-doc-tools)
15:32:53 sfinucan yes, it *is* a somewhat convoluted tool chain :)
15:34:04 lyarwood sfinucan: ha, I was just looking for proof that we needed it, I'll add a note in the review, LGTM otherwise.
15:36:11 ioni mriedem can you help me a bit?
15:37:10 ioni i don't know how to send a new patch in the same review :D
15:41:17 openstackgerrit Ionuț Bîru proposed openstack/nova master: Correctly set up deprecation warning https://review.openstack.org/444357
15:42:04 ioni sorry for that :(
15:42:13 ioni i didn't know how to send a new patch set
15:42:55 sfinucan ioni: No problem :) If you keep the 'Change-ID' line the same, it will submit a new patchset
15:43:15 ioni damn it
15:43:25 sfinucan it's fine though. Don't worry about it
15:44:17 siva_krishnan ioni: git review --amend should help as well
15:44:22 sfinucan ioni: +2d
15:44:39 siva_krishnan sorry git commit --amend
15:44:55 ioni well, i did a rebase
15:45:01 ioni from two commits that i made locally
15:45:13 ioni and i messed up i guess
15:45:40 mriedem1 artom: replied in https://review.openstack.org/#/c/393930/ - i think we talked about that at one point
15:45:49 mriedem1 artom: basically the various interface APIs in nova are a mess
15:45:57 mriedem1 and that's why i omitted nic tags from the spec
15:46:11 mriedem that's lazy on my part, i just didn't want to sort out the interface APIs first
15:46:33 mriedem ioni: i do git commit -a --amend
15:46:49 mriedem then git review to push it up
15:46:56 ioni mriedem, cool. i'll keep in mind
15:47:43 leakypipes cdent: oh, that's -w because I still need to submit a mini-spec or blueprint.
15:48:22 cdent leakypipes: ended up leaving it off this week's update
15:48:33 sfinucan johnthetubaguy, mriedem: noddy stuff, but I'd like to fix this in stable/ocata before you make the point release next week https://review.openstack.org/#/c/443086/
15:48:54 sfinucan (AJaeger asked me to do so for openstack-manuals)
15:48:57 artom mriedem, I don't remember talking about it, but OK, your explanation makes sense
15:49:56 mriedem sfinucan: can you show me where those are broken today?
15:50:01 mriedem a bug would have been nice
15:50:10 mriedem if we're backporting
15:50:13 leakypipes cdent: totally fine :) mostly was just pushing it off my lappie so I could pull to my workstation ;)
15:50:15 mriedem plus links to see what the bug is would be nice
15:50:51 cdent leakypipes: I know how that can be. I left a comment on it as a sort of note to self to remember my confusion and sadness
15:51:04 leakypipes :)
15:51:28 cdent and with that I'm going for a walk, biab
15:51:34 sfinucan mriedem: https://docs.openstack.org/newton/config-reference/compute/config-options.html look for 'flat_network_bridge'
15:51:48 sfinucan or any of the giant text with grey bars on the left
15:52:25 sfinucan I didn't think formatting issues like that warranted a bug but I'll draw up one shortly
15:52:25 mriedem ok i see
15:52:39 mriedem sfinucan: well i just didn't see any examples in the commit message
15:52:45 mriedem also, this doesn't seem like a huge issue
15:53:01 mriedem and it's been like this for awhile already, like all of ocata
15:53:42 sfinucan mriedem: I can't include images in commit messages, and the issues won't exist once they're fixed
15:54:17 sfinucan openstack-manuals hasn't released the ocata docs yet, hence why I'm eager to fix it now
15:54:22 mriedem ok i guess i just won't ask for any context or examples
15:54:31 mriedem anyway, +2
15:55:40 sfinucan mriedem: ta
15:59:53 mriedem ioni: https://review.openstack.org/#/c/444374/
16:01:27 ioni mriedem, do i have to do something? :D
16:02:01 openstackgerrit Stephen Finucane proposed openstack/nova master: Always set MTU when plugging devices https://review.openstack.org/408781
16:03:52 mriedem ioni: nope
16:07:25 openstackgerrit Stephen Finucane proposed openstack/nova master: hardware: Flatten functions https://review.openstack.org/367470
16:07:26 openstackgerrit Stephen Finucane proposed openstack/nova master: Standardize '_get_XXX_constraints' functions https://review.openstack.org/385071
16:07:27 openstackgerrit Stephen Finucane proposed openstack/nova master: Rename '_numa_get_constraints_XXX' functions https://review.openstack.org/385072
16:07:27 openstackgerrit Stephen Finucane proposed openstack/nova master: De-duplicate _numa_get_flavor_XXX_map_list https://review.openstack.org/385074
16:08:04 leakypipes rfolco: morning!
16:08:25 rfolco leakypipes, afternoon!
16:08:25 leakypipes rfolco: so, I can support cdent's review suggestions on your patch. Go with KeyError raise.
16:10:10 rfolco leakypipes, nice. I can do something like: http_except = webob.exc.status_map.get(req) .... if not None, then raise http_except
16:10:23 rfolco instead of status_map[req]
16:10:54 rfolco this way I avoid keyerror and get rid of dict
16:11:41 leakypipes rfolco: well, I think cdent actually prefers raising a KeyError there, since this is a code path that is dev-only -- i.e. users cannot influence this code path and we want to bomb out early if a developer adds an call to raise_http_code_if_microversion() is passed an improper status code.
16:13:39 rfolco hmm makes sense. If keyerror is fine, easier for me :)
16:13:39 rfolco leakypipes, thx++
16:13:40 leakypipes rfolco: go for it :)
16:22:32 openstackgerrit Eric Fried proposed openstack/nova master: WIP: PowerVM Driver: SSP emphemeral disk support https://review.openstack.org/443189
16:30:45 openstackgerrit Stephen Finucane proposed openstack/nova master: console: introduce basic framework for security proxying https://review.openstack.org/345396
16:30:46 openstackgerrit Stephen Finucane proposed openstack/nova master: console: introduce framework for RFB authentication https://review.openstack.org/345397
16:30:47 openstackgerrit Stephen Finucane proposed openstack/nova master: console: provide an RFB security proxy implementation https://review.openstack.org/345399
16:30:47 openstackgerrit Stephen Finucane proposed openstack/nova master: console: introduce the VeNCrypt RFB authentication scheme https://review.openstack.org/345398
17:02:14 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/nova master: [WIP] Read NIC features in libvirt https://review.openstack.org/444415
17:06:56 mriedem1 dansmith: so no obfuscation for https://review.openstack.org/#/c/438023/25/nova/context.py ?
17:08:09 melwitt mriedem: it's not storing the url in the context anymore
17:09:30 mriedem oh cool
17:09:45 mriedem i'm going to have to rebase my quotas fix now.. :(
17:11:38 leakypipes dansmith: your once over on gibi's patch here pls: https://review.openstack.org/#/c/440347
17:14:59 melwitt leakypipes: not sure I understand the comment on that one, that instance.flavor isn't connected to data in the db. it's connected to instance_extra and can be lazy-loaded on an instance that was queried without joining with instance_extra earlier
17:15:47 mriedem melwitt: leakypipes: bauwser: also need to get these in https://review.openstack.org/#/q/topic:bug/1670627 - that's a major regression in ocata and need to get that backported for a 13.0.1 next week

Earlier   Later