Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-03-09
22:30:15 armax email
22:30:29 armax we should probably sit down and talk about it at some point
22:34:18 mriedem yeah
22:37:55 tonyb sean-k-mooney: It's all good. As you can see I'm trying to work with you but for the most part I'm learning on my feet. It'd be cool if we had a clear direction on what level of support we have for Windows platforms. Are they for development? or just runtime? I'm treatign win32 vs cygwin much like Ubuntu vs Fedora. Anyway we don't overlap much but we can keep going back and forth on the review
22:40:28 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix missing instance.delete notification https://review.openstack.org/437222
22:57:14 mriedem great, now the functional test isn't passing after i rebased on top of the notification fix
23:12:20 openstackgerrit Samantha Blanco proposed openstack/nova master: [WIP] Make flavor-rxtx policy more granular https://review.openstack.org/444036
23:31:02 mriedem dansmith: ha
23:31:04 mriedem so,
23:31:19 mriedem the notification patch doesn't have a test that hits notify_about_instance_delete
23:31:25 mriedem but mine on top of it do
23:31:34 mriedem UnboundLocalError: local variable 'system_metadata' referenced before assignment
23:32:10 mriedem fixing
23:35:25 efried mriedem That whole initializing-a-variable-within-a-try-and-then-using-it-in-the-except-or-finally thing...
23:35:40 mriedem efried: i even thought about it when i was looking at it before
23:35:56 mriedem efried: er i mean, it was a test to see if you would have caught and you didn't!
23:36:35 efried mriedem Rat farts! I _did_ review that change set!
23:37:01 mriedem rat farts indeed
23:46:05 openstackgerrit Dan Smith proposed openstack/nova master: Get instance availability_zone without hitting the api db https://review.openstack.org/439754
23:46:05 openstackgerrit Dan Smith proposed openstack/nova master: Teach HostAPI about cells https://review.openstack.org/442162
23:46:06 openstackgerrit Dan Smith proposed openstack/nova master: Make os-availability-zones know about cells https://review.openstack.org/442163
23:46:06 openstackgerrit Dan Smith proposed openstack/nova master: Change MQ targeting to honor only what is in the context https://review.openstack.org/438023
23:46:07 openstackgerrit Dan Smith proposed openstack/nova master: Make scheduler target cells to get compute node instance info https://review.openstack.org/439891
23:46:07 openstackgerrit Dan Smith proposed openstack/nova master: Sort CellMappingList.get_all() for safety https://review.openstack.org/443174
23:46:08 openstackgerrit Dan Smith proposed openstack/nova master: Add get_by_instance_uuids() to InstanceMappingList https://review.openstack.org/443292
23:46:08 openstackgerrit Dan Smith proposed openstack/nova master: Make server_groups determine deleted-ness from InstanceMappingList https://review.openstack.org/443293
23:46:09 openstackgerrit Dan Smith proposed openstack/nova master: Remove Mitaka-era service version check https://review.openstack.org/442861
23:46:12 openstackgerrit Dan Smith proposed openstack/nova master: Add cell field to Destination object https://review.openstack.org/438024
23:46:13 openstackgerrit Dan Smith proposed openstack/nova master: Make conductor ask scheduler to limit migrates to same cell https://review.openstack.org/438025
23:46:13 openstackgerrit Dan Smith proposed openstack/nova master: Add workaround to disable group policy check upcall https://review.openstack.org/442736
23:46:14 openstackgerrit Dan Smith proposed openstack/nova master: Add identity helper property to CellMapping https://review.openstack.org/444038
23:50:32 mriedem dansmith: i hope you ran pep8
23:53:07 melwitt pep8 takes forever to run now, like before it even runs flake8. dunno what it's doing
23:55:20 mriedem melwitt: you know about: tox -e pep8 -- -HEAD?
23:55:27 mriedem cinder has fast8
23:55:28 mriedem same thing
23:55:37 melwitt no, what does that do?
23:55:43 mriedem runs only on the changes in the commit
23:55:45 mriedem -HEAD
23:55:55 mriedem danpb wrote that quite a while ago
23:56:17 mriedem https://github.com/openstack/nova/blob/master/tools/flake8wrap.sh#L12
23:56:18 melwitt oh, hm
23:56:33 mriedem i never run full pep8 on nova anymore
23:56:36 melwitt wow. thanks
23:57:30 efried Second that.
#openstack-nova - 2017-03-10
00:00:14 efried Now if he could just do that for pyXX...
00:01:33 mriedem you don't want it for py27
00:01:53 efried mriedem It would have to be really, really smart.
00:02:05 mriedem this just cycled in https://www.youtube.com/watch?v=Lrle0x_DHBM so things are looking up
00:02:12 efried In my case, I'm getting away with -- nova.tests.unit.virt.powervm
00:05:17 cburgess Oh wow thats soo cool.
00:08:00 mriedem cburgess: -HEAD or earth, wind and fire? :)
00:08:11 cburgess head
00:08:22 melwitt both, duh
00:11:30 mriedem here come dem fixes
00:11:40 openstackgerrit Matt Riedemann proposed openstack/nova master: Decrement quota when deleting an instance in cell0 https://review.openstack.org/443395
00:11:41 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix missing instance.delete notification https://review.openstack.org/437222
00:11:42 openstackgerrit Matt Riedemann proposed openstack/nova master: Add regression test for bug 1670627 https://review.openstack.org/443745
00:11:42 openstack bug 1670627 in OpenStack Compute (nova) "quota is always in-use after delete the ERROR instances " [Critical,In progress] https://launchpad.net/bugs/1670627 - Assigned to Matt Riedemann (mriedem)
00:11:42 openstackgerrit Matt Riedemann proposed openstack/nova master: Temporarily untarget context when deleting from cell0 https://review.openstack.org/443403
00:17:59 openstackgerrit Eric Fried proposed openstack/nova master: WIP: PowerVM Driver: SSP emphemeral disk support https://review.openstack.org/443189
00:28:20 openstackgerrit Matt Riedemann proposed openstack/nova master: Decrement quota when deleting an instance in cell0 https://review.openstack.org/443395
00:28:21 openstackgerrit Matt Riedemann proposed openstack/nova master: Temporarily untarget context when deleting from cell0 https://review.openstack.org/443403
00:33:12 melwitt dansmith: I added a question on the consoleauth upcall patch https://review.openstack.org/#/c/415922/7/nova/compute/api.py@3469 if you have any thoughts
01:41:57 openstackgerrit gengchc2 proposed openstack/nova-specs master: Fix typos in server-count-api.rst,etc https://review.openstack.org/413916
02:28:49 openstackgerrit Alex Xu proposed openstack/nova-specs master: Fix the typo in the resource provider traits spec https://review.openstack.org/444065
02:29:10 alex_xu dansmith: thanks for the review, and the typo fix ^
02:51:48 Qiming alex_xu, morning
02:51:58 alex_xu Qiming: morning too
02:52:18 Qiming alex_xu, about the returning of user_data in OS-EXT-SERV-ATTR:user_data
02:52:31 alex_xu Qiming: yea
02:52:47 Qiming alex_xu, why didn't we just return it in user_data?
02:53:04 alex_xu Qiming: you mean the prefix?
02:53:08 Qiming the API doc says this: OS-EXT-SERV-ATTR:user_databodystring
02:53:08 Qiming The user_data the instance was created with.
02:53:09 Qiming New in version 2.3
02:53:41 Qiming alex_xu, it is creating some problems when we try to deal with it in openstacksdk
02:54:39 Qiming alex_xu, when we are creating an instance, we pass in user_data, when we receive a response from CREATE or GET, we have to parse it with a prefex
02:55:15 Qiming alex_xu, it is not like the other attributes, kernel_id, root_device_name, ramdisk_id, reservation_id, launch_index, and hostname
02:55:31 alex_xu Qiming: yea, that is really a old style. for now, any new added field without prefix any more
02:55:57 Qiming all the others can be treated as extended server attributes, except for user_data
02:56:02 alex_xu but for back-compatible, we can't remove the prefix directly. at least, it needs a microversion
02:56:03 gmann Qiming: yea as alex_xu mentioned, they were old notation which we have to keep supporting
02:56:46 Qiming so, a microversion to change it (user_data) back is acceptable?
02:56:50 gmann but can you access kernel_id without prefix in server GET ?
02:57:03 Qiming gmann, no
02:57:14 gmann ok
02:57:28 Qiming kernel_id didn't come from user request, users won't expect that
02:57:54 alex_xu Qiming: if just change a prefix for a field, i'm not sure it is worth to do that
02:57:54 gmann Qiming: ok on create things you mean, got it
02:58:08 gmann because GET server has all those with prefix like OS-EXT-SERV-ATTR:kernel_id
02:58:09 Qiming same question for 'personality', which is also an "input only" attribute
02:58:26 Qiming once provided to create/POST, we get no chance to see it again, :)
02:58:30 alex_xu Qiming: personality is a field plan to remove
02:59:51 Qiming gmann, for attributes "added" at server side, it is okay to add a prefix, but for 'user_data', it is weird that its name has changed when I'm retrieving it
03:00:13 gmann alex_xu: yea and that was the reason to plan remove
03:00:58 Qiming ya, removal might be the right thing to do
03:01:36 Qiming anyway, 'personality' is not heavily used like 'user_data' AFAICT
03:02:32 Qiming in the same spirit, maybe 'host_status' for example should have a prefix, :)
03:04:17 gmann Qiming: yea those are not consistent actually due to legacy v2 way was like that and in v2.1 we try to do without prefix as no more extensions

Earlier   Later