Earlier  
Posted Nick Remark
#openstack-nova - 2017-03-09
19:43:14 efried mriedem https://github.com/powervm/pypowervm/blob/develop/pypowervm/tests/tasks/test_storage.py#L93-L99
19:43:18 asettle cdent and jaypipes - how did you both get on?
19:43:41 efried mriedem Or perhaps https://github.com/powervm/pypowervm/blob/develop/pypowervm/tests/tasks/test_storage.py#L355-L363 is closer to what you want.
19:44:02 jaypipes asettle: was there an updated revision pushed? I didn't see one?
19:44:26 asettle jaypipes: nope. sorry, that's not what I meant. Just checking in to see if you or cdent had other thoughts/concerns since we last spoke
19:44:30 mriedem efried: that's a bit ugly imo
19:44:33 asettle I see your comments on patch 8
19:44:36 asettle Thank you :)
19:44:40 mriedem the .__enter__.return_value
19:44:56 cdent asettle: i put more comments on the review, but basically I was able to confirmation that the placement parts are okay
19:45:09 efried mriedem Would it be less ugly if __enter__ wasn't a double-underscore method?
19:45:32 openstackgerrit Dan Smith proposed openstack/nova master: Make discover_hosts only query for unmapped ComputeNode records https://review.openstack.org/427903
19:45:33 openstackgerrit Dan Smith proposed openstack/nova master: Add ability to query for ComputeNodes by their mapped value https://review.openstack.org/427902
19:45:33 openstackgerrit Dan Smith proposed openstack/nova master: Add ComputeNode.mapped field https://review.openstack.org/427901
19:45:36 asettle Terrific! Ugh thank you so much cdent :D
19:45:56 jaypipes asettle: nope, besides those suggestions I put on the initial review, I'm good! :)
19:47:40 asettle Ugh you guys are excellent :D thank you both and to mriedem for looking at this all week :) Crossing my fingers that some of these edits should set us on the right path for both RDO and Ubuntu
19:47:53 asettle I'll check back in with Brian in the morning.
19:50:08 openstackgerrit christopher.uhler proposed openstack/nova master: Libvirt volume driver for Veritas HyperScale https://review.openstack.org/443951
20:00:28 mriedem guh
20:00:41 mriedem annoying when you have the fix for a thing all day, but spend 2 hours trying to get tests to work
20:00:45 mriedem *unit* tests
20:01:05 cdent mriedem: after all this time you haven't been able to accept that as the new normal?
20:01:57 mriedem sometimes i don't mind,
20:02:02 mriedem i only mind when i have other stuff to be doing
20:04:50 efried mriedem Then you have to rebase the thing...
20:06:18 mriedem i do actually have to rebase this
20:06:20 mriedem but want it working first
20:06:35 mriedem i want the *mocks* working first
20:08:47 mriedem gee thanks everyone
20:09:09 mriedem what i really need is coffee
20:09:09 dansmith mriedem: basically, we all acknowledge your mundane plight, now get back to work
20:09:11 mriedem and metal
20:09:15 mriedem ha
20:09:18 dansmith :)
20:10:41 mriedem i need comstud here to kick me in my ass
20:11:54 efried I could put you in an armbar, but that would be counterproductive to your typing abilities.
20:12:09 melwitt what's special about comstud kicking you? what about us??
20:12:34 dansmith er, "scaredy"
20:22:13 mriedem melwitt: because you'd probably apologize afterward
20:22:21 mriedem comstud on the other hand...
20:22:44 melwitt heh
20:26:47 openstackgerrit Sujitha proposed openstack/nova master: Add description to policies in admin_password.py https://review.openstack.org/443957
20:28:08 mriedem f yes
20:36:36 openstackgerrit Sujitha proposed openstack/nova master: Add description to policies in admin_password.py https://review.openstack.org/443957
20:37:05 tasker is there a way to "build" a new instance in an un-powered state?
20:42:10 tasker b'ah. probably the wrong channel, but I'm trying to do the above programatticaly.
20:42:10 dansmith you're revising that quota set and un-WIPing them all I assume right?
20:44:50 mriedem dansmith: yeah
20:44:56 mriedem plumber called, more distractoins
20:46:25 efried tasker That doesn't sound... easy. I can think of some ways to hack it. But I don't think the APIs provide anything.
20:46:38 tasker efried: i was afraid of that.
20:47:48 efried tasker Example: create it with no boot disk, and it (maybe) boots into grub/OF. The nova side will see this as "active", so the spawn will succeed, but the VM didn't _really_ boot.
20:48:51 tasker i have an instance with two volumes, one boot, one mounted at /usr. not ideal, but not my instance. i need to be able to, at will, make a backup of the volumes, restore them, and spin up a new copy of the instance. but if the instance boots from 'vda' alone, it'll have problems with no 'vdb' and I can't attach a volume until it's active.
20:49:09 tasker efried: that's not too bad.
20:49:29 mriedem dansmith: like the water in my basement, here comes the flood
20:49:33 openstackgerrit Matt Riedemann proposed openstack/nova master: Decrement quota when deleting an instance in cell0 https://review.openstack.org/443395
20:49:34 openstackgerrit Matt Riedemann proposed openstack/nova master: Temporarily untarget context when deleting from cell0 https://review.openstack.org/443403
20:49:34 efried ...can't attach volume until active, why?
20:49:54 tasker Conflict: Cannot 'attach_volume' while it is in vm_state building
20:50:13 mriedem tasker: i think cburgess is trying to solve a similar issue
20:50:16 mriedem at least with that conflict
20:50:26 mriedem you should join forces
20:50:28 tasker oh? do you have a commit review i can check out?
20:52:11 tasker I'll checkout gerrit and get send a message their way.
20:52:53 mriedem sec
20:54:26 mriedem i thought this https://review.openstack.org/#/c/417541
20:54:49 mriedem tasker: see L33 here for PTG discoussion https://etherpad.openstack.org/p/nova-ptg-pike-cinder
20:54:51 mriedem *discussion
20:55:14 tasker thanks! I'll check it out.
20:55:44 mriedem dansmith: are you checking those changes out? if they look ok at first glance, i'll start working on rebasing on top of gibi's changes
20:55:59 dansmith I will yeah
20:57:50 openstackgerrit melanie witt proposed openstack/nova master: Count resources to check quota for cells https://review.openstack.org/416521
20:58:22 dansmith gross
20:58:35 dansmith well, I don't like the context mocking
20:58:55 dansmith but I shan't hold up on that
21:00:37 cburgess mriedem tasker What did I do?
21:00:59 cburgess mriedem Oh that thing yeah... so thats now part of johnthetubaguy spec on moving to the new cinder attach api
21:03:12 mriedem dansmith: for the assertions?
21:03:19 dansmith mriedem: yeah
21:03:19 mriedem or just the 20 context calls?
21:03:23 dansmith the context calls
21:03:23 mriedem oh
21:03:25 mriedem yeah, well,
21:03:32 mriedem see ^ for the last 3 hours :)
21:03:37 dansmith heh yeah I know
21:05:41 mriedem dansmith: comments in https://review.openstack.org/#/c/437222/
21:05:45 mriedem the notification one
21:06:50 cburgess mriedem So https://review.openstack.org/#/c/417541 should be abandoned. I'll have yuming do that shortly. Our work is now covered by johnthetubaguy work in https://review.openstack.org/#/c/373203/
21:07:12 mriedem cburgess: i can abandon it if you want
21:07:17 cburgess Go ahead
21:07:35 cburgess mriedem Abandon with great abandon.
21:07:49 dansmith mriedem: so in the delete_while_booting, we can't soft delete, so it's always going to be a hard instance-is-gone
21:08:03 dansmith because we're just deleting the mapping
21:08:14 dansmith well, wait
21:08:55 dansmith yeah, right,
21:09:03 dansmith because if we deleted that, then we're going to end up with no instance record when the conductor realizes that we won
21:09:07 dansmith L1712
21:10:57 dansmith well, wait,
21:11:18 mriedem it seems like we just don't support soft_delete for the case that the instance isn't in a cell yet

Earlier   Later