| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-03-08 | |||
| 22:37:42 | mriedem | don't be | |
| 22:38:01 | mriedem | i just use you as my encyclopedia of nova horrors | |
| 22:44:38 | openstackgerrit | Sujitha proposed openstack/nova master: Reduce calls to load_tags() to 0 https://review.openstack.org/435146 | |
| 22:47:08 | mriedem | jaypipes: dansmith: i'm going to head home, but wrote up the abstract for the spec i'm going to work on later https://blueprints.launchpad.net/nova/+spec/service-hyper-pci-uuid-in-api | |
| 22:47:15 | mriedem | let me know if i screwed anything up in there | |
| 22:47:22 | jaypipes | mriedem: will do. thx. | |
| 22:53:04 | openstackgerrit | Dan Peschman proposed openstack/nova master: No API cell up-call to delete consoleauth tokens https://review.openstack.org/415922 | |
| 22:53:35 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: PowerVM Driver: SSP emphemeral disk support https://review.openstack.org/443189 | |
| 22:54:07 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: PowerVM Driver: SSP emphemeral disk support https://review.openstack.org/443189 | |
| 23:13:41 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: PowerVM Driver: SSP emphemeral disk support https://review.openstack.org/443189 | |
| 23:28:32 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/443357 | |
| 23:33:07 | openstackgerrit | Jay Pipes proposed openstack/nova master: virt: implement get_inventory() for Ironic https://review.openstack.org/441544 | |
| 23:33:12 | jaypipes | dansmith: ^^ | |
| 23:34:56 | dansmith | jaypipes: done thanks | |
| 23:35:03 | jaypipes | dansmith: danke | |
| #openstack-nova - 2017-03-09 | |||
| 00:03:09 | alex_xu | mriedem: will check that patch in the morning | |
| 00:03:47 | alex_xu | jaypipes: something looking for your feedback https://review.openstack.org/441829, cdent didn't want the cache :) | |
| 00:04:23 | jaypipes | alex_xu: yeah, it's next on my list. currently reviewing https://review.openstack.org/#/c/435954/6/specs/pike/approved/enable-sriov-nic-features.rst | |
| 00:05:00 | alex_xu | jaypipes: thanks :) | |
| 00:09:59 | dansmith | what kind of monster doesn't want a cache? | |
| 00:21:02 | dansmith | alex_xu: can you drop your -1 from this now? https://review.openstack.org/#/c/441388/9 | |
| 00:25:30 | mriedem | dansmith: just setup amazon household for prime, finally | |
| 00:25:34 | mriedem | oh so sweet | |
| 00:25:50 | mriedem | now i don't have to secretly log into laura's account to order things | |
| 00:25:52 | dansmith | you mean you just got prime, or just got setup so laura can order stuff without you? | |
| 00:25:55 | dansmith | oh heh | |
| 00:25:59 | mriedem | she's had prime for years | |
| 00:26:01 | dansmith | welcome to 2009! | |
| 00:26:03 | mriedem | but has always been my proxy | |
| 00:26:06 | mriedem | \o/ | |
| 00:26:10 | jaypipes | mriedem: can you record the Grand Tour and let me stream from your house? :) | |
| 00:27:05 | dansmith | jaypipes: I know you're old, but... amazon prime video is streaming and generally "recording" it is hard to do | |
| 00:27:56 | jaypipes | dansmith: I was expecting mriedem to set up a camcorder, tape it, upload the tape to his personal server and let me stream it from there. | |
| 00:28:10 | jaypipes | rofl | |
| 00:29:01 | jaypipes | alex_xu: ok, sorry, I goofed. you were actually third in the queue, right behind my current review on https://review.openstack.org/#/c/364468/11/specs/pike/approved/reserve-numa-with-pci.rst | |
| 00:43:19 | openstackgerrit | Dan Smith proposed openstack/nova master: Change MQ targeting to honor only what is in the context https://review.openstack.org/438023 | |
| 00:43:19 | openstackgerrit | Dan Smith proposed openstack/nova master: Teach os-migrations about cells https://review.openstack.org/442685 | |
| 00:43:20 | openstackgerrit | Dan Smith proposed openstack/nova master: Add cell field to Destination object https://review.openstack.org/438024 | |
| 00:43:21 | openstackgerrit | Dan Smith proposed openstack/nova master: Teach simple_tenant_usage about cells https://review.openstack.org/441388 | |
| 00:43:21 | openstackgerrit | Dan Smith proposed openstack/nova master: Teach os-aggregates about cells https://review.openstack.org/442200 | |
| 00:44:18 | mriedem | who wants to volunteer to run the meeting in the morning? | |
| 00:57:53 | openstackgerrit | Dan Smith proposed openstack/nova master: Change MQ targeting to honor only what is in the context https://review.openstack.org/438023 | |
| 00:57:54 | openstackgerrit | Dan Smith proposed openstack/nova master: Teach os-migrations about cells https://review.openstack.org/442685 | |
| 00:57:54 | openstackgerrit | Dan Smith proposed openstack/nova master: Add cell field to Destination object https://review.openstack.org/438024 | |
| 00:57:55 | openstackgerrit | Dan Smith proposed openstack/nova master: Teach simple_tenant_usage about cells https://review.openstack.org/441388 | |
| 00:57:55 | openstackgerrit | Dan Smith proposed openstack/nova master: Teach os-aggregates about cells https://review.openstack.org/442200 | |
| 01:14:15 | dansmith | gfdi | |
| 01:14:28 | dansmith | jaypipes: your requests have thrown off the whole cosmic balance of my patches | |
| 01:14:44 | jaypipes | dansmith: :( | |
| 01:14:48 | jaypipes | sorry duder. | |
| 01:15:39 | melwitt | jaypipes: I've got the transactional safety change in my working dir. just finishing up some changes to the quota count patch | |
| 01:16:14 | jaypipes | melwitt: coolio. | |
| 01:25:04 | openstackgerrit | Dan Smith proposed openstack/nova master: Change MQ targeting to honor only what is in the context https://review.openstack.org/438023 | |
| 01:25:05 | openstackgerrit | Dan Smith proposed openstack/nova master: Teach os-migrations about cells https://review.openstack.org/442685 | |
| 01:25:06 | openstackgerrit | Dan Smith proposed openstack/nova master: Add cell field to Destination object https://review.openstack.org/438024 | |
| 01:25:06 | openstackgerrit | Dan Smith proposed openstack/nova master: Teach simple_tenant_usage about cells https://review.openstack.org/441388 | |
| 01:25:07 | openstackgerrit | Dan Smith proposed openstack/nova master: Teach os-aggregates about cells https://review.openstack.org/442200 | |
| 02:18:52 | Kevin_Zheng | Hi, is this a known issue about quotas and cells? https://bugs.launchpad.net/nova/+bug/1670627 | |
| 02:18:52 | openstack | Launchpad bug 1670627 in OpenStack Compute (nova) "quota is always in-use after delete the ERROR instances " [Undecided,In progress] - Assigned to huangtianhua (huangtianhua) | |
| 02:19:04 | Kevin_Zheng | Looks critical | |
| 02:23:14 | melwitt | Kevin_Zheng: we have seen some quota bugs on the multicell patches that are currently in progress, but I hadn't heard about the specific issue with ERROR instances until now | |
| 02:23:54 | Kevin_Zheng | melwitt: Thanks for the reply | |
| 02:24:19 | melwitt | Kevin_Zheng: and I think your analysis is right. we've been working on quotas in regard to cells right now, which will address the issues you're seeing. just didn't realize there were already problems in the wild with the single cell case | |
| 02:24:26 | Kevin_Zheng | melwitt: shouldn't all quota calculated from nova_api db? | |
| 02:24:41 | melwitt | Kevin_Zheng: yes, see this series https://review.openstack.org/#/c/410945/ | |
| 02:25:25 | Kevin_Zheng | melwiit: yeah, I know you are working on quota related issues so I ask here to see if it is already known :) | |
| 02:25:42 | melwitt | it isn't in nova_api db yet, that series moves it there and gets rid of "usages" and "reservations" | |
| 02:26:52 | Kevin_Zheng | Ok, thanks, I will have a look | |
| 02:27:04 | Kevin_Zheng | will it fix the problem we meet? | |
| 02:27:16 | melwitt | ah, cool. yeah, we didn't know about that one yet and I agree it sounds critical. our intention was that things should be okay in the single cell deployment | |
| 02:28:21 | mriedem | Kevin_Zheng: we'll have to fix the bug separately | |
| 02:28:24 | melwitt | yes, it will fix that problem. but I think we'll have to do a small different fix for now, that we can backport | |
| 02:28:26 | mriedem | because we have to backport the fix | |
| 02:28:29 | mriedem | jinx | |
| 02:28:45 | Kevin_Zheng | yeah sounds reasonable | |
| 02:28:45 | mriedem | so when we bury the instance in cell0, | |
| 02:28:46 | melwitt | hah, yeah | |
| 02:28:56 | mriedem | we have to remove the reservation from cell0 | |
| 02:28:59 | mriedem | i think? | |
| 02:29:06 | mriedem | we must be making a claim in cell0 or how does that work? | |
| 02:29:14 | mriedem | s/claim/reservation/ | |
| 02:30:09 | melwitt | thinking ... we're not doing anything to target the reservation/usage/etc | |
| 02:30:41 | melwitt | so it should be in cell0 I think. and that's not getting removed ... so I think you're right | |
| 02:33:24 | mriedem | the quota reservation happens in nova-api here https://github.com/openstack/nova/blob/master/nova/compute/api.py#L312 | |
| 02:33:50 | mriedem | but since that's not targeted to cell0, wouldn't that be in the main cell, i.e. nova database? | |
| 02:34:21 | mriedem | the commit is here https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1059 | |
| 02:35:22 | mriedem | there is no rollback of the quota in _bury_in_cell0 | |
| 02:35:22 | mriedem | https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L836 | |
| 02:35:50 | mriedem | which probably makes sense because don't we want to keep the reservation until the instance is actually deleted? | |
| 02:35:53 | melwitt | there shouldn't be because ERROR instances occupy quota | |
| 02:36:23 | melwitt | but when the user deletes it, we need to do a reverse reserve and commit and somehow that's going to the wrong db | |
| 02:37:18 | mriedem | we put the instance in cell0 here https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L881 | |
| 02:37:19 | melwitt | it's probably something like, we target cell0 to delete the instance and the quota reserve/commit for the freeing of quota goes to cell0 in the same target and we didn't mean to | |
| 02:37:31 | melwitt | or something | |
| 02:38:19 | mriedem | yeah, so we made the reservation in the nova db, but put the instance in the nova_cell0 db, and right when we delete i bet we find it in cell0 via the instance mapping | |
| 02:40:11 | mriedem | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1708 | |
| 02:40:12 | melwitt | yeah, I'm looking in compute/api.py and I'm not seeing any freeing of quota for local deletes | |
| 02:40:15 | mriedem | i think deleted would be False there | |
| 02:40:19 | mriedem | because conductor deleted the build request | |
| 02:40:40 | mriedem | we delete the build request in _bury_in_cell0 here https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L888 | |