Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-03-08
16:50:40 mdbooth sdague: You were +2 on https://review.openstack.org/#/c/441246/. I just changed the commit message to reflect that there's a second part to the puzzle.
16:51:30 mdbooth (Also, there's a second part to the puzzle ;))
16:59:02 mriedem sfinucan: nope
16:59:07 mriedem sfinucan: the blueprint isn't approved
16:59:11 mriedem and i don't see a re-proposed spec
16:59:53 sfinucan mriedem: Ah, I only thought -2s only applied after spec approval deadline. I'll resub the spec now
17:03:59 mriedem dansmith: something else i thought about yesterday with your simple tenant usage change
17:04:09 mriedem but in get_all in the compute API we have a check for cells v1
17:04:32 dansmith mriedem: on a call, but let me think about that when I'm done
17:05:01 dansmith not sure it's as important here. the cells1 check is purely to avoid overwriting data in the replication, but here we're looking at history, so probably fine
17:05:03 dansmith anyway, biab
17:05:21 openstackgerrit Stephen Finucane proposed openstack/nova-specs master: Websockify security proxy framework https://review.openstack.org/443234
17:09:58 openstackgerrit Sujitha proposed openstack/nova master: Reduce calls to load_tags() to 0 https://review.openstack.org/435146
17:29:32 jroll so openstackclient defaults to the latest microversion, do y'all pin that or send 'latest'?
17:30:25 openstackgerrit Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/delete #1: no-ops https://review.openstack.org/438119
17:30:37 openstackgerrit Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #2: functional https://review.openstack.org/438598
17:31:10 openstackgerrit Eric Fried proposed openstack/nova master: PowerVM Driver: power_on/off and reboot https://review.openstack.org/427380
17:32:18 openstackgerrit Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #3: TaskFlow https://review.openstack.org/438729
17:32:31 openstackgerrit Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #4: full flavor https://review.openstack.org/391288
17:32:48 openstackgerrit Eric Fried proposed openstack/nova master: PowerVM Driver: console https://review.openstack.org/409402
17:34:54 cfriesen at the PTG a suggestion was made to add an option to the live migration request to specify "force live migration after X seconds". Was anyone planning on running with that?
17:35:54 jroll never mind my question, I found it, the answer is that it's pinned
17:36:03 mriedem jaypipes: ComputeNode.stats is where all of the virt driver capabilities dict garbage lives right?
17:37:50 raj_singh cfriesen: yes
17:38:12 raj_singh cfriesen: I have a spec https://review.openstack.org/#/c/442809/
17:38:22 mriedem claudiub: jaypipes: can you both take a look at this? https://review.openstack.org/#/c/364468/
17:38:29 mriedem claudiub: guestions in there for you wrt the hyperv driver
17:38:40 mriedem jaypipes: questions in there for you about nested resource providers and placement
17:38:45 mriedem sfinucan: ^ questions/comments inline
17:39:34 mriedem seems like the numa/pci information is something that would be fed into nested resource provider via the new get_inventory method on the virt driver
17:39:39 raj_singh cfriesen: and this https://review.openstack.org/#/c/438467/
17:39:49 mriedem so the libvirt driver could say what it's inventory of available pci devices is
17:40:21 mriedem and then the scheduler you query placement for that info and place an instance that requires pci onto one of those hosts, and for instances that don't require pci, it weighs those away from those providers
17:42:27 sean-k-mooney mriedem: looking at stpehens spec i dont know if you need driver changes so much as compute agent changes
17:42:52 mriedem compute agent?
17:42:59 mriedem we don't have a compute agent
17:43:19 sean-k-mooney n-cpu?
17:43:46 cfriesen compute server
17:43:48 sfinucan mriedem, sean-k-mooney: Might be easier show you the code :) https://review.openstack.org/#/c/379625/10
17:44:05 cfriesen make that compute service
17:44:16 mriedem sfinucan: ok that's not the compute driver
17:45:05 sean-k-mooney mriedem: right what sfinucan is proposing to change is how the pci device is selected when it lands on the compute node but i tink that should be driver independent
17:45:08 mriedem so the compute_nodes.numa_topology field has the data you need, which we get in the resource tracker
17:45:36 mriedem sean-k-mooney: i thought the point was to not land instances that don't require pci on hosts that have available pci inventory?
17:45:58 mriedem doing that calculation after we've picked the host is too late
17:46:13 sean-k-mooney mriedem: that is where the weigher comes in
17:46:36 sean-k-mooney mriedem: untill we have claims you need to do it twice
17:46:45 sfinucan mriedem: Yeah, it's two steps
17:47:00 sfinucan Step A: Don't use hosts with PCI devices if we don't need them (the weigher)
17:47:29 sean-k-mooney if you run out of server that dont have pci decices and you have to land on one that does then you should still prefer a numa node that does not have pci devices attached
17:47:35 sfinucan Step B: If we do get a host with PCI devices, avoid NUMA nodes with PCI devices if we don't need them
17:47:59 sean-k-mooney yep what sfinucan said :)
17:50:47 mriedem i'll be honest, my eyes glaze over once i see numa_fit_instance_to_host
17:53:39 sean-k-mooney mriedem: that is fair. if i didnt have to know about numa effect for my job i would happy delete it form my mind
17:55:48 sean-k-mooney sfinucan: so stepen to sergeys vis versa comment are you going to extend the weigher to also perfer numa nodes with pci devices available when they are requested or just update the comment ?
17:56:54 sfinucan sean-k-mooney: I think I'll just remove the comment and rely on balancing with CPUs
17:57:31 sean-k-mooney sfinucan: ok its a 30 second else clause with the same labmda but the order reversed to add if you wanted too
17:58:11 sfinucan sean-k-mooney: But it's another 10 minutes writing unit tests ;)
17:58:13 sean-k-mooney sfinucan: i havent thaugh however if it is desireable
17:59:01 sean-k-mooney haha ya i was impressed that the ratio of test lines to code was actull 29:11
17:59:50 sean-k-mooney less then 4 time the amount of code in unit tests then busness logic is rare
18:02:34 openstackgerrit Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #2: functional https://review.openstack.org/438598
18:02:39 inc0 good morning people, http://lists.openstack.org/pipermail/openstack-dev/2017-March/113507.html <- this issue might interest you
18:03:18 inc0 pretty much libvirt 2.5 seems to be broken with current nova vm datafiles creation
18:05:09 inc0 I'm not sure if it's ubuntu-specific or it's libvirt 2.5 specific, but it is broken:)
18:05:31 inc0 and we have few alternatives to handle this
18:05:56 inc0 one would be to allow nova to create these files with custom umask
18:06:13 inc0 today it's hard 722, if we could make it 772, that would do it
18:06:27 inc0 umask and ownership
18:07:44 sean-k-mooney inc0: the umask is the revers of what you think it is. where 777 is read write execute normally for umask its 000
18:08:40 inc0 fair enough;)
18:08:41 sean-k-mooney inc0: you would need umask 002
18:08:45 inc0 well, file mode
18:11:20 sean-k-mooney inc0: i have a vm using devstack with 2.5 currently and i can boot vms. i know on the kolla channel tere was an issue with the console file correct
18:11:35 sean-k-mooney is that what your refering too or is more then just the console
18:11:45 openstackgerrit Stephen Finucane proposed openstack/nova-specs master: Reserve NUMA nodes with PCI devices attached https://review.openstack.org/364468
18:14:01 sfinucan mriedem: I've clarified the fact that there's no real changes to the driver (the location of the code confused me and I wrote that code a good while back)
18:14:01 openstackgerrit Eric Fried proposed openstack/nova master: PowerVM Driver: power_on/off and reboot https://review.openstack.org/427380
18:14:17 openstackgerrit Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #3: TaskFlow https://review.openstack.org/438729
18:16:38 sfinucan As for the resource tracker stuff: I'd be inclined to suggest that the change is both helpful/small enough, and nested resource providers still fuzzy enough, to warrant taking the weigher route for now
18:17:24 sfinucan However, I'm not sure what the plan is for weighers and what the migration path is when we move to resource providers, so I'd definitely like jaypipes' input
18:17:42 sfinucan For now though, it's late and the Lego Batman movie isn't going to see itself :)
18:18:16 sean-k-mooney sfinucan: nice i must go see that soon.
18:18:28 sean-k-mooney sfinucan: let me know if its any good :)
18:21:10 bauzas mriedem: I +W'd https://review.openstack.org/#/c/442723/1 but I think we could possibly have follow-ups
18:21:14 bauzas see commentqs
18:21:25 openstackgerrit Dan Peschman proposed openstack/nova master: No API cell up-call to delete consoleauth tokens https://review.openstack.org/415922
18:21:58 openstackgerrit Dan Smith proposed openstack/nova master: Add functools.wraps to wrapper https://review.openstack.org/443175
18:22:08 mriedem dansmith: no ice_t?
18:22:28 dansmith mriedem: if I can't have my fun you can't either
18:22:45 mriedem works for me
18:22:52 bauzas dansmith: wow, chilling at the series https://review.openstack.org/#/c/441461/8
18:23:04 dansmith the first time it came up, I was going to rename it to gangsta_rapper
18:23:06 sean-k-mooney inc0: what is the actully error that ye are seeing with libvirt 2.5?
18:23:20 dansmith bauzas: all but one tempest test is passing with multiple cells with that series :)
18:23:33 bauzas \o/
18:23:37 bauzas heh for https://review.openstack.org/#/c/443175/3/nova/conductor/manager.py
18:23:41 dansmith and I had that working before, but broke it in cleanup
18:23:46 bauzas that remembers me some comment I made :)
18:25:09 bauzas dansmith: any reason why you added https://review.openstack.org/#/c/443175/3/nova/conductor/manager.py as a top patch and not just modified https://review.openstack.org/#/c/438022/15 ?

Earlier   Later