Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-03-07
23:29:39 dansmith but I guess that's not what she means
23:29:41 mriedem there is a bunch of discussion between alex_xu and diana and jaypipes and johnthetubaguy in https://review.openstack.org/#/c/386771/ about sorting
23:30:04 dansmith so this is even larger of a merge sort than list instances right?
23:30:20 dansmith I mean, this is potentially an order of magnitude or more larger than just a list of live instances
23:31:34 mriedem depends on the window i suppose
23:32:16 mriedem i'm wondering if we only need to sort if detailed=True
23:32:29 dansmith okay then I'm going to move this to later in the set so we can progress on some of the other ones while we argue about this forever
23:32:32 mriedem but, it might also be dependent on the limit/marker
23:33:08 mriedem if you get a tenant_id then all it does is sort on the uuids
23:33:14 openstackgerrit Dan Smith proposed openstack/nova master: Enlighten server tags API about cells https://review.openstack.org/440856
23:33:15 openstackgerrit Dan Smith proposed openstack/nova master: Target cell in super conductor operations https://review.openstack.org/438022
23:33:15 openstackgerrit Dan Smith proposed openstack/nova master: Change MQ targeting to honor only what is in the context https://review.openstack.org/438023
23:33:16 openstackgerrit Dan Smith proposed openstack/nova master: Teach os-migrations about cells https://review.openstack.org/442685
23:33:16 openstackgerrit Dan Smith proposed openstack/nova master: Make consoleauth target the proper cell https://review.openstack.org/441461
23:33:17 openstackgerrit Dan Smith proposed openstack/nova master: Add cell field to Destination object https://review.openstack.org/438024
23:33:17 openstackgerrit Dan Smith proposed openstack/nova master: WIP: Make conductor ask scheduler to limit migrates to same cell https://review.openstack.org/438025
23:33:18 openstackgerrit Dan Smith proposed openstack/nova master: Add workaround to disable group policy check upcall https://review.openstack.org/442736
23:33:18 openstackgerrit Dan Smith proposed openstack/nova master: Get instance availability_zone without hitting the api db https://review.openstack.org/439754
23:33:19 openstackgerrit Dan Smith proposed openstack/nova master: Teach HostAPI about cells https://review.openstack.org/442162
23:33:19 openstackgerrit Dan Smith proposed openstack/nova master: Make os-availability-zones know about cells https://review.openstack.org/442163
23:33:20 openstackgerrit Dan Smith proposed openstack/nova master: Make scheduler target cells to get compute node instance info https://review.openstack.org/439891
23:33:20 openstackgerrit Dan Smith proposed openstack/nova master: Teach simple_tenant_usage about cells https://review.openstack.org/441388
23:33:21 openstackgerrit Dan Smith proposed openstack/nova master: Teach os-aggregates about cells https://review.openstack.org/442200
23:33:21 openstackgerrit Dan Smith proposed openstack/nova master: Remove Mitaka-era service version check https://review.openstack.org/442861
23:34:19 dansmith I really don't understand the sorting discussion on that spec
23:34:38 mriedem need diana and alex_xu to explain
23:34:47 mriedem i can't read through all of that and "sort" it out
23:34:51 mriedem get it
23:34:52 dansmith yeah
23:35:09 mriedem i'm literally laughing here to myself and my own joke
23:35:18 mriedem i think it's time to head home
23:51:28 openstackgerrit Jin Li proposed openstack/nova master: Transform instance.soft_delete notifications https://review.openstack.org/383970
#openstack-nova - 2017-03-08
00:31:43 openstackgerrit Dan Smith proposed openstack/nova master: Get instance availability_zone without hitting the api db https://review.openstack.org/439754
00:31:43 openstackgerrit Dan Smith proposed openstack/nova master: Make scheduler target cells to get compute node instance info https://review.openstack.org/439891
00:31:44 openstackgerrit Dan Smith proposed openstack/nova master: Remove Mitaka-era service version check https://review.openstack.org/442861
00:31:44 openstackgerrit Dan Smith proposed openstack/nova master: Add workaround to disable group policy check upcall https://review.openstack.org/442736
00:59:31 openstackgerrit Li Yingjun proposed openstack/nova-specs master: Spec for support set vgamem for video https://review.openstack.org/438787
01:14:29 openstackgerrit Artom Lifshitz proposed openstack/nova master: Plumbing for tagged nic attachment https://review.openstack.org/415622
01:14:29 openstackgerrit Artom Lifshitz proposed openstack/nova master: Delete nic metadata when detaching interface https://review.openstack.org/435387
01:14:31 openstackgerrit Artom Lifshitz proposed openstack/nova master: Libvirt support for tagged volume attachment https://review.openstack.org/418100
01:14:32 openstackgerrit Artom Lifshitz proposed openstack/nova master: Delete disk metadata when detaching volume https://review.openstack.org/435082
01:14:34 openstackgerrit Artom Lifshitz proposed openstack/nova master: Plumbing for tagged volume attachment https://review.openstack.org/391941
01:14:36 openstackgerrit Artom Lifshitz proposed openstack/nova master: API support for tagged device attachment https://review.openstack.org/376021
01:14:38 openstackgerrit Artom Lifshitz proposed openstack/nova master: Libvirt support for tagged nic attachment https://review.openstack.org/415520
02:11:40 openstackgerrit Maho Koshiya proposed openstack/nova master: Add interfaces functional negative tests https://review.openstack.org/442892
02:24:01 alex_xu dansmith: sort by 'uuid' is for stable sort result, since the 'project_id' isn't unique value. at least we should keep the sort result stable.
02:24:28 alex_xu dansmith: looks like CellMappingList.get_all have problem, it haven't any specific sort key
02:24:33 alex_xu so the result can be unstable
02:24:53 dansmith alex_xu: it'll be stable, but not guaranteed
02:25:17 alex_xu dansmith: yes, but better to have a specific sort key?
02:25:24 dansmith alex_xu: but sure we can make cellmapping sort explicitly
02:25:33 alex_xu dansmith: yea
02:25:45 dansmith alex_xu: we can.. cells don't get created and destroyed, so I don't think it's a problem, but it's a trivial amount of small data to sort, so we can do that too
02:26:04 dansmith alex_xu: will you say that on the review and I'll follow up tomorrow with a separate patch for that?
02:26:29 alex_xu dansmith: yea, I will comment on teh review
02:28:16 dansmith alex_xu: cool thanks
02:28:24 alex_xu dansmith: np
02:54:24 diana_clarke dansmith: Do you know the history behind limit/offset vs limit/marker?
03:08:10 openstackgerrit Vladik Romanovsky proposed openstack/nova master: libvirt: add video config parse method https://review.openstack.org/442914
03:08:11 openstackgerrit Vladik Romanovsky proposed openstack/nova master: libvirt: a method to prepare SPICE console connection https://review.openstack.org/442915
03:13:16 dansmith diana_clarke: I don't even know that there's history there, so.. no?
03:17:19 diana_clarke dansmith: I'm curious why there was a switch at some point to marker vs. offset. That is, the problem that shift was trying to solve at the expense of an easier API.
03:17:44 diana_clarke (I just followed the pattern)
03:20:05 diana_clarke Off the top of my head, I can't think of another API that uses markers (over offsets).
03:20:30 dansmith diana_clarke: I'm not aware of any shift from offset to marker, so it may have been before my time (or at least before I started paying attention)
03:21:50 diana_clarke dansmith: Welp, recent code uses markers, older code uses markers (that's all I know).
03:22:18 diana_clarke typo: older code uses _offsets__
03:24:27 dansmith really? what older code uses offsets?
03:25:30 dansmith I see mention of offsets in openstack/api/common, but that's pretty new code, AFAIK
03:27:53 dansmith unless it was just transplanted from somewhere, but I thought all the original pagination was done in db where I see no offsets
03:28:04 dansmith but anyway, I dunno :)
03:35:16 alex_xu dansmith: https://review.openstack.org/#/c/441388/7/nova/api/openstack/compute/simple_tenant_usage.py a comment about optimize the marker
03:35:26 dansmith alex_xu: responding now
03:35:34 dansmith alex_xu: were you going to comment on the sorting thing too
03:35:34 dansmith ?
03:35:56 alex_xu dansmith: yea, I added comment in the PS6
03:36:44 dansmith alex_xu: ah I see now, thanks
03:36:50 alex_xu dansmith: np
03:37:36 dansmith alex_xu: here is the other one of the pattern: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2548
03:38:04 alex_xu dansmith: yes, i'm ok to optimize that in later patch. I just follow a -1 since Matt already -1, to earn a point :)
03:38:15 dansmith haha
03:38:39 dansmith alex_xu: you're a pro now :)
03:38:51 alex_xu yea \o/
03:38:57 dansmith :)
04:39:37 openstackgerrit Akira KAMIO proposed openstack/nova master: Replace root volume during rebuild https://review.openstack.org/442295
05:18:25 cfriesen alex_xu: you on?
05:25:38 openstackgerrit Chris Friesen proposed openstack/nova-specs master: add spec for instance flavor API https://review.openstack.org/265282
05:29:11 openstackgerrit Chris Friesen proposed openstack/nova-specs master: Support Instance Rebuild With Userdata https://review.openstack.org/431052
06:01:43 openstackgerrit kavitha h r proposed openstack/os-vif master: The Python 3.5 is added https://review.openstack.org/442955
06:34:17 alex_xu cfriesen: yes
06:35:21 openstackgerrit Akira KAMIO proposed openstack/nova master: Replace root volume during rebuild https://review.openstack.org/442295
06:54:14 cfriesen alex_xu: if you're still here...I made some comments on https://review.openstack.org/#/c/265282 Also, it occurs to me that the "resize" command currently returns the flavorid. Should we keep that (since it shouldn't be stale)?
06:55:36 alex_xu cfriesen: yea, i'm here. I'm good with your reply, but i guess you misse done https://review.openstack.org/#/c/265282/5/specs/pike/approved/instance-flavor-api.rst@131
06:55:40 alex_xu s/done/one
06:55:57 alex_xu cfriesen: for resize, let me check
06:57:22 cfriesen whoops, right. will check the rxtx_factor
06:57:42 alex_xu cfriesen: currently we didn't have response from resize
06:58:23 alex_xu cfriesen: and...as I remember, you are in Canada...why you are still wakeup
06:58:38 cfriesen it's 1am and I'm still up. :)
06:58:49 alex_xu cfriesen: ok :)

Earlier   Later