| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-03-07 | |||
| 20:15:43 | dansmith | mriedem: we've never supported anything beyond n-1, | |
| 20:15:51 | dansmith | mriedem: we do because n-2 computes will refuse to start | |
| 20:15:53 | mriedem | we could use nova-status upgrade check mofo ftw | |
| 20:16:14 | dansmith | mriedem: you literally can't start n-2 computes, I think that's pretty clear messaging :) | |
| 20:16:26 | mriedem | why? | |
| 20:16:34 | dansmith | why is that clear or why can you not? | |
| 20:16:38 | mriedem | why can you not? | |
| 20:16:51 | dansmith | the service checkin will refuse to roll the minimum version back | |
| 20:17:10 | mriedem | but what if i never restarted the compute and i've just got a mitaka compute still running | |
| 20:18:00 | dansmith | mriedem: you likely wouldn't have been able to complete online migrations, and thus never have been able to apply ocata schema migrations, etc | |
| 20:18:15 | dansmith | mriedem: we've had those kinds of deps before, not sure if we really have had them between mitaka and ocata, but.. | |
| 20:18:29 | mriedem | to be clear, you're talking about this? https://github.com/openstack/nova/blob/master/nova/objects/service.py#L304 | |
| 20:18:32 | dansmith | it's always been a blanket policy, I'm not sure why we're suddenly concerned about it | |
| 20:18:40 | dansmith | yeah | |
| 20:18:54 | mriedem | "This could happen if we were started with older code by accident, either due to a rollback or an old and un-updated node suddenly coming back onto the network." | |
| 20:19:03 | mriedem | so i get that, like with an evacuated node | |
| 20:20:01 | mriedem | i'm not super concerned about this, i'd just like something a bit more blocking during upgrade that says, oh you have computes < x and x is the minimum to get to pike, so stop upgrade now | |
| 20:20:22 | dansmith | well, nova-status is the right place for that I guess | |
| 20:20:35 | dansmith | and if you ignore it, then shame on you | |
| 20:21:42 | mriedem | hmm, service version 12 wasn't mitaka either | |
| 20:21:50 | mriedem | mitaka max service version was 9 | |
| 20:22:05 | dansmith | mriedem: right 12 was newton, | |
| 20:22:08 | mriedem | newton max was 15 | |
| 20:22:09 | dansmith | it checks for <12 right? | |
| 20:22:16 | migi | dansmith: hey, question if I want to check "nova-manage db archive_deleted_rows" do I need to have full dump of nova db (maybe even different one??) or just some tables? | |
| 20:22:32 | mriedem | dansmith: the get me a network checks for < 12 yeah | |
| 20:22:49 | migi | dansmith: I was reading the https://docs.openstack.org/ops-guide/ops-backup-recovery.html and am unsure if the nova db is sufficient | |
| 20:22:51 | dansmith | mriedem: right, so it's checking for mitaka, or n1 or whatever | |
| 20:22:58 | mriedem | dansmith: we could add a min compute service version check to nova-status that requires compute minimum of 16 | |
| 20:23:01 | dansmith | migi: you have to have all the tables, but don't have to have data | |
| 20:23:08 | dansmith | migi: but it won't be much of a test without data | |
| 20:23:22 | dansmith | mriedem: right, that's the only place I think it makes sense | |
| 20:23:46 | mriedem | so we land that, then remove the straddle code in the api, maybe doesn't have to be in order | |
| 20:23:48 | melwitt | jaypipes: I'm currently hacking up the count resources for quota patch if you want to hold off on that one (also, thanks for reviewing the quotas object one) | |
| 20:23:50 | mriedem | just before we release | |
| 20:23:52 | migi | dansmith: thanks | |
| 20:24:22 | dansmith | mriedem: it's advisory anyway, but I can do it as part of removing this check yeah | |
| 20:24:29 | mriedem | dansmith: that would be lovely | |
| 20:25:07 | mriedem | i'm going to start reviewing https://review.openstack.org/#/c/440856/ and up, do i need any pep talk before i start? | |
| 20:25:32 | dansmith | mriedem: you can do it, you big code reviewing stud muffin you | |
| 20:25:42 | mriedem | heh | |
| 20:25:56 | melwitt | you might need a montage | |
| 20:26:41 | mriedem | thanks miyagi https://www.youtube.com/watch?v=iBktYJsJq-E | |
| 20:26:51 | dansmith | mriedem: actually the pep talk is: consider all the infra puppies you kill by asking for nitty changes at the bottom, knowing that I'll follow up with legit stuff :P | |
| 20:27:12 | mriedem | psh | |
| 20:27:18 | mriedem | just for saying that, i'm going to be extra critical | |
| 20:27:19 | dansmith | I'm shocked I haven't gotten a citation already today with all the resources this set is consuming | |
| 20:27:47 | mriedem | sdague removed all of the scenario tests so no one cares anymore | |
| 20:27:55 | dansmith | heh | |
| 20:31:47 | dansmith | I'd like to add up my "bill" for all the resources I use in nodepool for a month | |
| 20:31:51 | dansmith | just for shits and giggles | |
| 20:38:56 | migi | dansmith: ok one more question for today. Let's say I have this dump and will run nova-manage. Do I need to know for which nova version the sql was created or can I use nova-manage from Liberty against db created by master? | |
| 20:39:23 | dansmith | migi: they have to match | |
| 20:39:41 | mriedem | dansmith: blam https://review.openstack.org/#/c/441388/5 | |
| 20:39:43 | migi | dansmith: and this info is somewhere in sql or do I need to store it in metadata somewhere outisde | |
| 20:39:56 | migi | dansmith: that was too much of questions as I said last one one before | |
| 20:40:13 | dansmith | migi: you can get the version number out of the database somewhere, yeah | |
| 20:40:22 | migi | dansmith: ok will find it then, thanks | |
| 20:40:38 | dansmith | migi: I don't recall where, but it's like a single-row table that sqla-migrate uses | |
| 20:40:52 | mriedem | it's the 'nova.migrations' table i believe | |
| 20:41:18 | migi | mriedem: thanks, will find it :) | |
| 20:44:30 | dansmith | mriedem: ack | |
| 20:44:33 | mriedem | https://www.youtube.com/watch?v=X9UM4N5sGBs | |
| 20:44:33 | dansmith | well, that was qick | |
| 20:44:37 | mriedem | ha | |
| 20:44:53 | dansmith | here and I was being nice and writing your nova-status thing | |
| 20:44:54 | mriedem | i'm not sure i can put links to judas priest songs in reviews | |
| 20:45:05 | jaypipes | melwitt: sure, no prob. I was just reviewing the migration one. you want me to hold off? | |
| 20:45:22 | melwitt | jaypipes: hold off on the top patch, the third one | |
| 20:45:29 | jaypipes | gotcha. | |
| 20:45:30 | jaypipes | will do. | |
| 20:45:48 | melwitt | thanks :) | |
| 21:07:13 | openstackgerrit | Dan Smith proposed openstack/nova master: Add nova-status check for minimum service version https://review.openstack.org/442787 | |
| 21:07:25 | dansmith | mriedem: ^ | |
| 21:14:27 | mriedem | just get in line | |
| 21:19:33 | dansmith | mriedem: guh, that breaks my math doubling even for the other things | |
| 21:19:40 | dansmith | mriedem: and if I have only one cell, then we don't poke this | |
| 21:30:29 | openstackgerrit | Dan Smith proposed openstack/nova master: Get instance availability_zone without hitting the api db https://review.openstack.org/439754 | |
| 21:30:29 | openstackgerrit | Dan Smith proposed openstack/nova master: Teach HostAPI about cells https://review.openstack.org/442162 | |
| 21:30:29 | openstackgerrit | Dan Smith proposed openstack/nova master: Make os-availability-zones know about cells https://review.openstack.org/442163 | |
| 21:30:30 | openstackgerrit | Dan Smith proposed openstack/nova master: Target cell in super conductor operations https://review.openstack.org/438022 | |
| 21:30:31 | openstackgerrit | Dan Smith proposed openstack/nova master: Change MQ targeting to honor only what is in the context https://review.openstack.org/438023 | |
| 21:30:31 | openstackgerrit | Dan Smith proposed openstack/nova master: Teach os-migrations about cells https://review.openstack.org/442685 | |
| 21:30:32 | openstackgerrit | Dan Smith proposed openstack/nova master: Make scheduler target cells to get compute node instance info https://review.openstack.org/439891 | |
| 21:30:32 | openstackgerrit | Dan Smith proposed openstack/nova master: Make consoleauth target the proper cell https://review.openstack.org/441461 | |
| 21:30:33 | openstackgerrit | Dan Smith proposed openstack/nova master: Add cell field to Destination object https://review.openstack.org/438024 | |
| 21:30:33 | openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Make conductor ask scheduler to limit migrates to same cell https://review.openstack.org/438025 | |
| 21:30:34 | openstackgerrit | Dan Smith proposed openstack/nova master: Teach simple_tenant_usage about cells https://review.openstack.org/441388 | |
| 21:30:34 | openstackgerrit | Dan Smith proposed openstack/nova master: Teach os-aggregates about cells https://review.openstack.org/442200 | |
| 21:30:36 | openstackgerrit | Dan Smith proposed openstack/nova master: Add workaround to disable group policy check upcall https://review.openstack.org/442736 | |
| 21:30:51 | dansmith | mriedem: look at all that puppy blood you spilled | |
| 21:30:53 | dansmith | jaypipes: shake it at mriedem ! | |
| 21:30:57 | mriedem | dude | |
| 21:30:59 | jaypipes | :) | |
| 21:30:59 | mriedem | clearly | |
| 21:31:08 | dansmith | mriedem: when I get back I'll remove that check behind the nova-status change | |
| 21:31:10 | mriedem | maybe if you guys didn't break the api contract | |
| 21:31:12 | mriedem | ... | |
| 21:31:29 | dansmith | nobody uses simple_tenant_usage | |
| 21:31:30 | mriedem | dansmith: comments are in the nova-status change also | |