| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-03-03 | |||
| 16:02:10 | leakypipes | superdan: :) | |
| 16:03:29 | leakypipes | mriedem: answered. | |
| 16:03:34 | mriedem | leakypipes: so remember the regex you have to parse in the scheduler report client to tell if you've hit an inventory in use error? | |
| 16:03:41 | mriedem | which will break if translated or the error msg changes? | |
| 16:04:10 | mriedem | turns out there is a spec for returning a body with error details, which would include a code you can key off of http://specs.openstack.org/openstack/api-wg/guidelines/errors.html | |
| 16:04:21 | mriedem | i wonder if we should start toying with the idea of using that in placement | |
| 16:04:51 | mriedem | while it's small, since trying to retrofit that into nova at this point would be tough | |
| 16:04:51 | leakypipes | mriedem: yes, I'm aware of that spec and encouraged someone to work on that in Pike. can't remember who though... | |
| 16:05:04 | leakypipes | mriedem: agreed. | |
| 16:05:23 | leakypipes | mriedem: I shall put out a call to arms on the ML. | |
| 16:05:36 | leakypipes | mriedem: just as soon as I finish this damn placement PTG wrapup email | |
| 16:05:50 | mriedem | leakypipes: ok meh all around on tha traits test thing :) +2 | |
| 16:06:01 | leakypipes | mriedem: yeah, I know :) it's meh | |
| 16:06:13 | mriedem | bauwser: want to get https://review.openstack.org/#/c/440656/ and then i can request a release for os-traits? | |
| 16:06:19 | leakypipes | mriedem: not much to test in "hey, here's some constants" :) | |
| 16:06:33 | mriedem | leakypipes: yeah i knwo | |
| 16:06:35 | mriedem | *know | |
| 16:09:17 | openstackgerrit | Alex Szarka proposed openstack/nova master: Reduce code complexity in vmops._spawn method https://review.openstack.org/438502 | |
| 16:15:59 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Reconnect volumes and encryptors during a hard reboot https://review.openstack.org/400384 | |
| 16:16:41 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Check if domain is persistent before detaching volume https://review.openstack.org/441204 | |
| 16:18:33 | openstackgerrit | Arnaud Morin proposed openstack/nova master: Add warning on setting secure_proxy_ssl_header https://review.openstack.org/423375 | |
| 16:18:36 | AJaeger | could another core +2A the nova translation import, please? The change is fine with the deletions... https://review.openstack.org/#/c/439925/ | |
| 16:21:31 | superdan | mriedem: merged | |
| 16:22:23 | openstackgerrit | Maciej Szankin proposed openstack/nova master: conf: fix netconf, my_ip and host are unclear https://review.openstack.org/441210 | |
| 16:32:36 | mriedem | lyarwood: have you ever seen anything like this during a swap volume? this is mitaka http://paste.openstack.org/show/601357/ | |
| 16:32:44 | mriedem | with https://review.openstack.org/#/c/433793/ | |
| 16:33:06 | mriedem | i don't have the libvirt/qemu instance logs so kind of blind | |
| 16:35:09 | lyarwood | looking | |
| 16:36:02 | lyarwood | mriedem: nope, is this from a downstream customer report? | |
| 16:36:57 | mriedem | yeah | |
| 16:37:15 | mriedem | found https://bugzilla.redhat.com/show_bug.cgi?id=1002813 but that's pretty old | |
| 16:37:15 | openstack | bugzilla.redhat.com bug 1002813 in libvirt "block_resize returns undefined error" [Medium,Closed: errata] - Assigned to jferlan | |
| 16:38:17 | lyarwood | kashyap: ^ have you seen http://paste.openstack.org/show/601357/ anywhere before? | |
| 16:39:22 | kashyap | Seems like it has a long history, and some back-n-forth between QEMU & libvirt | |
| 16:41:12 | mriedem | w/o the actual libvirt/qemu logs i'm kind of dead in the water, which i've already replied back and told them | |
| 16:41:16 | kashyap | lyarwood: mriedem: Checking with a libvirt block dev. I haven't seen this myself | |
| 16:41:40 | kashyap | Yes, libvirt logs (with specific log filters) will help understand the call flow at that level | |
| 16:41:46 | mriedem | i think they are running libvirt 1.2.17 or 2.0.0 but not entirely sure since i couldn't find the libvirt version in the compute logs (i think that might be logged at debug, which they don't have enabled) | |
| 16:42:12 | lyarwood | yeah, we should really log that at INFO at the start, it's only one line | |
| 16:42:46 | kashyap | True, that's the first thing I sort of look, and waste 5 minutes trying it fish it out | |
| 16:42:54 | kashyap | s/look/look for/ | |
| 16:43:45 | kashyap | Oh, it's the 'mirror' element patch for block operation completion | |
| 16:44:14 | kashyap | mriedem: But in CI gate we should have those logs | |
| 16:44:38 | kashyap | Assuming you quoted from this job failure (gate-tempest-dsvm-cells-ubuntu-trusty) | |
| 16:45:01 | lyarwood | kashyap: the snippet isn't from CI | |
| 16:46:26 | kashyap | lyarwood: Then, from where is it? | |
| 16:46:47 | kashyap | mriedem: Can we get the exact 'block_resize' command that was sent to see what's causing the mess? | |
| 16:46:53 | lyarwood | kashyap: a downstream customer of mriedem, sorry if that wasn't clear | |
| 16:46:57 | kashyap | But I think you are also looking for the same | |
| 16:47:23 | mriedem | yeah sorry not a ci issue, | |
| 16:47:26 | kashyap | mriedem: Normally I have these log filters that I use for canned bugzilla responses -- https://kashyapc.fedorapeople.org/virt/openstack/request-nova-libvirt-qemu-debug-logs.txt | |
| 16:47:32 | mriedem | i'm just fishing for obvious 'oh yeah i know about that' | |
| 16:47:54 | mriedem | kashyap: thanks i can pass that on | |
| 16:48:21 | kashyap | mriedem: Also, tell them to not miss the NOTE at the end of that text file :-) | |
| 16:49:07 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova-specs master: Enable SR-IOV NIC offload feature discovery https://review.openstack.org/435954 | |
| 16:53:13 | mriedem | sileht: superdan: that devstack cells fix is merged now | |
| 16:53:25 | superdan | [08:21:31] <superdan>mriedem: merged | |
| 16:53:44 | mriedem | superdan: i thought you were talking about jay's os-traits patch | |
| 16:53:51 | superdan | ah, no :) | |
| 16:53:57 | mriedem | https://review.openstack.org/#/c/440656/ | |
| 16:53:57 | superdan | I'm rebasing my stuff on top right now | |
| 16:54:00 | mriedem | you should +W that anyway | |
| 16:55:33 | openstackgerrit | Maciej Szankin proposed openstack/nova master: conf: fix default values reporting infra worker https://review.openstack.org/441227 | |
| 16:55:42 | siva_krishnan | johnthetubaguy: why do we allow to live migrate a paused instance ? Shouldn't it be restricted ? | |
| 16:56:20 | johnthetubaguy | siva_krishnan: it should just work, I would have thought? so thats fine to allow it | |
| 16:56:31 | sileht | mriedem, thanks a lot ! | |
| 16:57:30 | mriedem | johnthetubaguy: siva_krishnan: it does just work, at least with libvirt | |
| 16:57:37 | mriedem | we also test live migrating paused instances in the gate | |
| 16:57:45 | mriedem | that's been in nova for several years now | |
| 16:57:48 | siva_krishnan | johnthetubaguy: mriedem it doesn't work when post copy is enabled. | |
| 16:58:27 | johnthetubaguy | siva_krishnan: why? | |
| 17:00:21 | superdan | mriedem: whoa I have core there? | |
| 17:00:24 | johnthetubaguy | siva_krishnan: I am curious, how/when does it fail? | |
| 17:00:26 | siva_krishnan | johnthetubaguy: fails with this error http://paste.openstack.org/show/601362/ | |
| 17:00:55 | johnthetubaguy | siva_krishnan: hmm, interesting, work a bug report I think | |
| 17:01:28 | siva_krishnan | johnthetubaguy: sure. | |
| 17:01:41 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Make BlockDeviceMapping object support uuid https://review.openstack.org/242603 | |
| 17:01:45 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Add uuid column to BlockDeviceMapping https://review.openstack.org/242602 | |
| 17:02:55 | johnthetubaguy | siva_krishnan: probably should not request post_copy if vm is paused, that should fix it | |
| 17:03:55 | siva_krishnan | yup | |
| 17:05:27 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Check if domain is persistent before detaching volume https://review.openstack.org/441204 | |
| 17:09:28 | mdbooth | lyarwood: Swift work with the transient domain patch :) | |
| 17:10:00 | mdbooth | lyarwood: I wonder, though, if it's kinda weird we're getting the persistent state from guest, then passing it straight back. | |
| 17:10:41 | mdbooth | Intuitively I think guest.detach_device_with_retry() should just do the right thing? | |
| 17:10:42 | lyarwood | mdbooth: weird in the sense it might change in the meantime | |
| 17:10:52 | mdbooth | Nah, I think that's ok | |
| 17:11:18 | lyarwood | mdbooth: yeah I see your point, why allow the assumption | |
| 17:11:23 | mdbooth | I just wonder if the default behaviour of that persistent argument should be neither True nor False, but 'whatever will work' | |
| 17:11:50 | mdbooth | There may be a reason to override it somewhere, but if not we should probably also just remove the argument | |
| 17:12:39 | mdbooth | Anyway, patch looks good. That's a stylistic thing I guess. | |
| 17:12:40 | kashyap | mdbooth: Yeah, during the downstream bug triage, Lee already pointed the fix on IRC | |
| 17:12:45 | kashyap | So yeah, lyarwood++ | |
| 17:13:47 | mriedem1 | lyarwood: i guess i'm going to have to do that here too https://review.openstack.org/#/c/349014/ | |
| 17:14:57 | openstackgerrit | Danil Akhmetov proposed openstack/nova master: Use proper user and tenant in the owner section of libvirt.xml. https://review.openstack.org/399679 | |
| 17:15:28 | mdbooth | mriedem lyarwood: Yeah, I think a sane default could prevent a proliferation of unhandled edge cases | |
| 17:15:40 | lyarwood | mriedem: yeah I think so | |
| 17:16:10 | mriedem | i'm fine with that | |
| 17:16:15 | mriedem | then i don't have to duplicate it | |
| 17:17:31 | mriedem | johnthetubaguy: am i overthinking the need for a unique constraint across volume_id and attachment_id here? https://review.openstack.org/#/c/437597/4/nova/db/sqlalchemy/models.py | |
| 17:18:01 | mdbooth | lyarwood: +1 with a suggestion from me | |