| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-03-01 | |||
| 12:07:23 | johnthetubaguy | oh wait, I can read | |
| 12:07:35 | kevinbenton | :) | |
| 12:08:23 | johnthetubaguy | kevinbenton: I was checking when the keypair is added into the DB, its really early now: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L981 | |
| 12:08:39 | johnthetubaguy | s/now// | |
| 12:09:08 | johnthetubaguy | basically its in the instance from the first DB save | |
| 12:10:19 | openstackgerrit | Timofey Durakov proposed openstack/python-novaclient master: Deperecate cell_name cli arg for migration-list https://review.openstack.org/439141 | |
| 12:11:02 | johnthetubaguy | kevinbenton: I have to run to get some lunch, but hopefully there are some micro leads there | |
| 12:11:25 | johnthetubaguy | sdague: in case its useful, I wrote up my quota notes here: https://review.openstack.org/#/c/429678 | |
| 12:11:55 | johnthetubaguy | sdague: did a quick post PTG refresh, but its mostly just thoughts I put together before the PTG | |
| 12:13:41 | sdague | kevinbenton: if you are patching in logging, probably worth adding a dump of what InstanceMetadata looks like before it's returned, maybe we would find some missing bits in there | |
| 12:13:51 | openstackgerrit | Kevin Benton proposed openstack/nova master: Add some metadata logging to root cause ssh failure https://review.openstack.org/439560 | |
| 12:14:07 | kevinbenton | sdague: can you leave a comment on that of where i should do that? ^^ | |
| 12:14:15 | sdague | yeh, let me go look | |
| 12:15:46 | sdague | kevinbenton: so it's in the other file, let me send a git link | |
| 12:16:00 | sdague | https://github.com/openstack/nova/blob/37cd9a961b065a07352b49ee72394cb210d8838b/nova/api/metadata/handler.py#L306 | |
| 12:16:08 | sdague | I would put a log debug of that data structure before we return it | |
| 12:18:30 | kevinbenton | sdague: ack | |
| 12:18:46 | kevinbenton | sdague: i also filed an E-R query here https://review.openstack.org/439562 | |
| 12:19:18 | sdague | once that is posted I'll +2, we can get johnthetubaguy to +2 after his lunch, and at least hopefully see some of this in the future | |
| 12:20:16 | sdague | kevinbenton: we should wait for mriedem_away / mtreinish for that banner error issue, because I have this vague recolection of things like paramiko lying to us about the real issue on thing like that | |
| 12:20:26 | sdague | but maybe they remember the deal | |
| 12:20:39 | kevinbenton | sdague: ack | |
| 12:21:13 | openstackgerrit | Kevin Benton proposed openstack/nova master: Add some metadata logging to root cause ssh failure https://review.openstack.org/439560 | |
| 12:21:17 | kevinbenton | sdague: ^^ | |
| 12:25:07 | sdague | kevinbenton: looks good, lets just wait for the test to run so we can see what this looks like in the main job | |
| 12:25:23 | kevinbenton | sdague: ack | |
| 12:25:38 | sdague | I think the only thing I wonder is if InstanceMetadata has a reasonable repr :) | |
| 12:25:47 | sdague | but we'll find out | |
| 12:27:29 | kevinbenton | <InstanceMetadata object at 0x38477827> | |
| 12:27:33 | kevinbenton | what's not to love? :0 | |
| 12:27:50 | sdague | :) | |
| 12:27:58 | kevinbenton | it's just a dict isn't it? | |
| 12:28:07 | kevinbenton | or is it a magical structured thing | |
| 12:28:29 | sdague | no, it's an object | |
| 12:28:35 | sdague | https://github.com/openstack/nova/blob/37cd9a961b065a07352b49ee72394cb210d8838b/nova/api/metadata/base.py#L111 | |
| 12:28:49 | sdague | and, yeh, I'm not seeing a sane repr | |
| 12:30:42 | sdague | so... actually | |
| 12:31:29 | sdague | ok, comment left on where we probably can dump the data and have it all | |
| 12:32:26 | kevinbenton | ok, so remove the one in handler.py then? | |
| 12:32:47 | kevinbenton | sdague: ^^ | |
| 12:34:55 | openstackgerrit | Kevin Benton proposed openstack/nova master: Add some metadata logging to root cause ssh failure https://review.openstack.org/439560 | |
| 12:37:22 | sdague | kevinbenton: yeh | |
| 12:38:30 | openstackgerrit | Dao Cong Tien proposed openstack/nova master: Stop using mox int unit/virt/xenapi/image/test_utils.py https://review.openstack.org/342626 | |
| 12:38:54 | bhagyashris | alex_xu: Hi, I want to discuss regarding the backup api. Have a free time? | |
| 12:43:25 | openstackgerrit | Timofey Durakov proposed openstack/python-novaclient master: Deperecate cell_name cli arg for migration-list https://review.openstack.org/439141 | |
| 12:45:41 | alex_xu | bhagyashris: hi, i'm here, actually we have api meeting after 15 mins, if that is ok for you, we can discuss it at meeting | |
| 12:45:59 | alex_xu | nova api meeting is in 15 mins at #openstack-meeting-4 | |
| 12:46:33 | bhagyashris | alex_xu: Is the backup api will be deprecate in future ? | |
| 12:47:29 | bhagyashris | alex_xu: ok. | |
| 12:48:01 | alex_xu | bhagyashris: I think it is useless, due to it totatlly can be impelmenet by client through the create-image api | |
| 12:51:17 | bhagyashris | alex_xu: ok. Is that will depcrecate in future release ? MEans just want to know about future plan. | |
| 12:51:57 | alex_xu | bhagyashris: no plan yet, no-one propose that yet. but maybe worth a talk in the api meeting today | |
| 12:52:45 | bhagyashris | alex_xu: ok. Thank you for information. | |
| 12:53:06 | alex_xu | bhagyashris: np | |
| 12:57:00 | bhagyashris | alex_xu: Actually I have submitted one patch https://review.openstack.org/#/c/409644/ regarding the backup rotation parameter change from 0 to 1 and got few comments , so just wanted to know about the future plan regarding backup api. | |
| 12:58:59 | alex_xu | bhagyashris: i see | |
| 13:01:43 | bhagyashris | alex_xu: Thank you. | |
| 13:04:45 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Validate huge pages https://review.openstack.org/399653 | |
| 13:04:45 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: create functional test base class https://review.openstack.org/407055 | |
| 13:13:48 | openstackgerrit | Stephen Finucane proposed openstack/nova master: api-ref: body verification for os-hypervisors https://review.openstack.org/398197 | |
| 13:20:44 | openstackgerrit | Tomi Juvonen proposed openstack/nova-specs master: Planned host maintenance https://review.openstack.org/310510 | |
| 13:28:44 | sfinucan | jaypipes: Could you take a look at https://review.openstack.org/#/q/topic:sriov_numa_func_test+status:open again. Resolved a merge conflict due to the libvirt version bump | |
| 13:29:01 | sfinucan | vladikr: You might be interested in ^ too. Touches code you wrote, afaict | |
| 14:01:33 | alex_xu | jaypipes: dansmith, bauzas, I get a problem when implement the 'GET /traits/namespace' and 'GET /traits?namespace=*'. Those APIs leads to placement API still need to import os-traits lib. So is it ok that we create db table for namespace, and sync namespace from os-trait into db by 'placement-manage' also? | |
| 14:07:46 | johnthetubaguy | alex_xu: I think we said we would sync into the DB, so we have the integer ids in the DB for more efficient storage, I think | |
| 14:09:08 | alex_xu | johnthetubaguy: yea, we sync the traits from os-traits into the db https://review.openstack.org/#/c/376198/, but that didn't include the namespace | |
| 14:11:33 | johnthetubaguy | alex_xu: ah... | |
| 14:11:48 | alex_xu | johnthetubaguy: the valid namespace is defined by os-traits also https://github.com/openstack/os-traits/blob/master/os_traits/const.py#L70 | |
| 14:12:33 | alex_xu | and I expect 'GET/traits/namespace' return all the valid traits. And expect validate the valid traits which input in 'GET /traits?namespace=*' | |
| 14:13:47 | rpodolyaka | johnthetubaguy: dansmith: hmm, do you guys recall if we kept CONF opts for a separate placement DB in this revert https://review.openstack.org/#/c/360638/ intentionally or by mistake? | |
| 14:14:18 | rpodolyaka | it's not going to work w/o cdent's https://review.openstack.org/#/c/362766/ | |
| 14:14:28 | johnthetubaguy | rpodolyaka: I think it was on purpose, just haven't merged the finish bits yet I guess | |
| 14:14:37 | rpodolyaka | but people find these options in the sample conf file and have wrong expectations | |
| 14:15:02 | johnthetubaguy | rpodolyaka: yeah, that got missed last cycle, it should have been a blocker really | |
| 14:16:49 | mtreinish | sdague: so we did use real ssh with -vvv to test the banner error failure | |
| 14:17:02 | mtreinish | sdague: the socket is being closed right when the ssh client expects the banner response from the server | |
| 14:21:11 | jaypipes | alex_xu: heading into the office. will answer your question (or we could do a hangout?) a little later. alternately, we can just discuss on the patch if you're heading to bed... | |
| 14:22:44 | kevinbenton | johnthetubaguy, sdague: look how lucky we are. that very patch hit the failure :) | |
| 14:22:57 | kevinbenton | johnthetubaguy: http://logs.openstack.org/60/439560/3/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/569fcd0/logs/testr_results.html.gz | |
| 14:25:16 | sdague | kevinbenton: nice | |
| 14:25:27 | sdague | the metadata server being useful at all? | |
| 14:25:55 | mriedem | sfinucan: on https://review.openstack.org/#/c/412390/ can we also make that default to the noop driver like in my change? | |
| 14:26:44 | mriedem | asettle: have you been talking to spotz about install guide docs for placement and cells v2? | |
| 14:27:54 | kevinbenton | sdague: well it's telling me there is indeed a public-key associated with it | |
| 14:28:10 | mriedem | asettle: https://review.openstack.org/#/c/438328/ | |
| 14:28:44 | mriedem | bauzas: johnthetubaguy: ^ fyi on the docs thing | |
| 14:29:10 | johnthetubaguy | mriedem: oh, cool | |
| 14:31:15 | sdague | kevinbenton: so... rolling conversation on #openstack-qa that is related | |
| 14:31:17 | asettle | Hey mriedem sure have. We'd been discussing it before I went to lunch. I'd seen this patch before, but wasn't sure if it ticked all the boxes. | |
| 14:31:21 | asettle | Does this *deal* with everything? | |
| 14:31:56 | mriedem | i haven't read it yet in detail since it's a WIP | |
| 14:32:03 | mriedem | but i also pointed out we have these docs in the nova devref | |
| 14:32:04 | mriedem | https://docs.openstack.org/developer/nova/placement.html https://docs.openstack.org/developer/nova/cells.html | |
| 14:34:08 | asettle | mriedem: having it in nova dev ref is great, but we do need to have the docs in docs.o.o updated as its the user facing documentation. If people can't install from our site, it's a problem. | |
| 14:34:46 | mriedem | yeah i get that, but i also hope people trying to sort this out are reading our devref | |
| 14:35:07 | mriedem | i can poke through the docs change, but i also just got into the office so it's not going to happen right now | |
| 14:36:07 | asettle | No problem mriedem :) I'd like to start a bigger conversation about this too with docs liaisons for the base projects that we document but there does not appear to be a docs liaison for nova. Do you know of who would be able to fill this role? I am hoping to liaise and generate a better way for this content to be updated when necessary (to avoid running into an issue like this again :)) | |
| 14:36:10 | mriedem | i've added a couple of nova devs that helped write the docs that are in nova | |
| 14:36:27 | mriedem | we don't really have a docs liaison for stuff like this no | |
| 14:36:29 | asettle | Cool :) that will be very helpful, thank you | |