| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-02-15 | |||
| 23:14:57 | dansmith | or something | |
| 23:15:18 | dansmith | I guess just stashing the connection url would be better or something | |
| 23:15:27 | dansmith | but still, need a serialization hack | |
| 23:15:57 | melwitt | dansmith: what do you mean by "after an rpc call"? like after the rpc, you're left with the wrong db url? | |
| 23:17:16 | dansmith | melwitt: after an rpc call you have context.db_connection=None | |
| 23:18:03 | melwitt | that should fall back to main, right | |
| 23:18:23 | dansmith | it does, but it means we call get_context with that =None, which means we take the lock, | |
| 23:18:33 | dansmith | which we have to do because we need to use whatever target_cell has set global state to | |
| 23:19:35 | dansmith | oh and your change doesn't actually work for me, | |
| 23:19:41 | dansmith | because what I'm hitting is the recursion on the lock, | |
| 23:20:06 | bauzas | jroll: or others, any way to guess the hypervisor_hostname given a specific instance ? | |
| 23:20:10 | dansmith | so I have to do it before I take the lock, which is fine because the lock is just to protect global state, which isn't a problem if our context is targeted | |
| 23:20:22 | bauzas | I need to know the ComputeNode record related to a specific instance | |
| 23:20:55 | bauzas | but I don't have a specific helper method in the object module for that | |
| 23:21:26 | bauzas | mmmmpf | |
| 23:21:39 | bauzas | I can see a 'node' attribute | |
| 23:21:48 | bauzas | in the instance object | |
| 23:25:14 | melwitt | dansmith: I still don't understand the problem. it's failing to acquire the lock or it keeps recursing or? | |
| 23:25:36 | dansmith | fails to acquire the lock recursively yeah | |
| 23:27:55 | melwitt | I'm trying to remember how it tries to acquire it recursively. I know we talked about this a couple of months ago | |
| 23:28:10 | dansmith | well, this is a new way | |
| 23:28:22 | dansmith | let me continue my unclean quest and see if I get anywhere | |
| 23:28:28 | dansmith | and then you can crap all over it | |
| 23:29:25 | melwitt | heh, okay | |
| 23:32:22 | bauzas | calling it a day \o | |
| 23:34:39 | melwitt | dansmith: I guess it seems like it shouldn't be able to recurse unless a get_context_manager happened within a target_cell, or something | |
| 23:35:04 | dansmith | melwitt: right, but the target_cell sets ctxt.db_connection and then the rpc call removes it | |
| 23:36:23 | melwitt | dansmith: so you're within a target_cell, and then an rpc call occurs and returns, then something else does a db access and get_context_manager can't acquire the lock? all within one target_cell? | |
| 23:36:30 | dansmith | no | |
| 23:36:44 | dansmith | you're in a target cell, then inside the rpc call but your db_connection=None | |
| 23:36:55 | dansmith | no call/return | |
| 23:37:10 | melwitt | oh, on the "other side" | |
| 23:37:27 | dansmith | right | |
| 23:37:32 | melwitt | okay | |
| 23:38:53 | melwitt | yeah, something I played around with but got nowhere was I was trying to assign a default db url per service, so each would know its own default instead of doing the _last_ctxt_mgr thing | |
| 23:39:09 | dansmith | right, which is kinda this | |
| 23:39:13 | melwitt | so that things wouldn't blur across service boundaries | |
| 23:39:15 | melwitt | yeah | |
| 23:41:09 | openstackgerrit | Sujitha proposed openstack/nova master: Remove mox from nova/tests/unit/db/test_db_api.py https://review.openstack.org/434557 | |
| 23:43:24 | melwitt | dansmith: looking at my old notes I was trying to patch the rpc dispatch to slap the db url for the service onto the incoming context so all non target_cell db access would use it | |
| 23:43:45 | dansmith | right, that'd be one way, | |
| 23:43:58 | dansmith | but you have to then know what service you're in and what default connection it should be | |
| 23:44:08 | melwitt | but the hard part was trying to match up the service:url and I didn't find a good non-messy way to do that | |
| 23:44:10 | melwitt | yeah | |
| 23:44:11 | dansmith | whereas if we can make it stick during a target call... | |
| #openstack-nova - 2017-02-16 | |||
| 00:05:49 | dansmith | oh. snap | |
| 00:07:57 | openstackgerrit | STEW TY proposed openstack/nova master: Transform instance.resize_revert notification https://review.openstack.org/396811 | |
| 00:08:43 | melwitt | dansmith: good news? | |
| 00:08:56 | dansmith | melwitt: yes, you'll be crapping on it soon | |
| 00:09:04 | melwitt | haha, nice | |
| 00:09:13 | openstackgerrit | STEW TY proposed openstack/nova master: Transform instance.resize_revert notification https://review.openstack.org/396811 | |
| 00:16:12 | openstackgerrit | Dan Smith proposed openstack/nova master: Make start and stop admin actions cells-aware https://review.openstack.org/433362 | |
| 00:16:13 | openstackgerrit | Dan Smith proposed openstack/nova master: Make CellDatabases fixture work over RPC https://review.openstack.org/434563 | |
| 00:16:16 | dansmith | melwitt: ^ | |
| 00:20:08 | melwitt | dansmith: looks pretty good to me, actually. it's self-contained and makes it clear what's happening | |
| 00:20:10 | dansmith | melwitt: it works for my test, but haven't checked to see if it breaks anything else just yet | |
| 00:20:39 | dansmith | \o/ | |
| 00:29:37 | dansmith | heh, so many unit tests pass None for the context so I'll have to be defensive there | |
| 00:30:36 | melwitt | dansmith: yeah, I was just noticing that in my change I had "if context and context.db_connection" but it was just because of naughty unit tests probably | |
| 00:30:48 | dansmith | yeah | |
| 00:31:28 | dansmith | melwitt: did you see this? https://review.openstack.org/#/c/433298 | |
| 00:31:39 | dansmith | failed because of the cellsv1 breakage, but should be ready for review at least | |
| 00:31:53 | melwitt | maybe there were some tests that were checking for a None context on purpose, or something too | |
| 00:31:54 | dansmith | with that, I can boot an instance with "multiple cells" | |
| 00:33:37 | openstackgerrit | Dan Smith proposed openstack/nova master: Make CellDatabases fixture work over RPC https://review.openstack.org/434563 | |
| 00:33:37 | openstackgerrit | Dan Smith proposed openstack/nova master: Make start and stop admin actions cells-aware https://review.openstack.org/433362 | |
| 00:33:47 | melwitt | dansmith: yeah, I wondered what you meant by that, meaning, how did you find you can create a true multi cell instance with it? | |
| 00:34:29 | dansmith | melwitt: because I have a hack for devstack that makes cell0 the main connection for the api service, which means anything not targeted fails | |
| 00:34:55 | dansmith | and it is how I hit these two first patches for multiple cell support .. i.e. it exposes where we're not targeting | |
| 00:35:03 | melwitt | oh, cool. so you saw it work in devstack. was just curious | |
| 00:35:12 | dansmith | melwitt: yep, with this: https://review.openstack.org/#/c/433318/ | |
| 00:35:35 | melwitt | nice | |
| 00:36:10 | dansmith | much simpler than actual multi-cell devstack and should let us flush out a ton of things without the complication | |
| 00:36:29 | melwitt | pretty cool | |
| 00:47:30 | openstackgerrit | STEW TY proposed openstack/nova master: Transform instance.resize_confirm notification https://review.openstack.org/390654 | |
| 00:51:07 | openstackgerrit | STEW TY proposed openstack/nova master: Transform instance.resize_confirm notification https://review.openstack.org/390654 | |
| 00:52:13 | cburgess | mriedem do we have a start time for the PTG? 9AM? 10AM? | |
| 00:54:21 | openstackgerrit | STEW TY proposed openstack/nova master: Transform instance.rescue notifications https://review.openstack.org/385644 | |
| 00:55:30 | dansmith | cburgess: 7am | |
| 00:55:38 | dansmith | donuts by 6:30 | |
| 00:55:39 | openstackgerrit | STEW TY proposed openstack/nova master: Transform instance.rescue notifications https://review.openstack.org/385644 | |
| 00:55:40 | cburgess | dansmith *glare* | |
| 00:56:15 | cburgess | dansmith I wish there was a voodoo in ATL | |
| 00:56:22 | cburgess | We do have Krispy Kreme though which is decent. | |
| 00:56:24 | mriedem | cburgess: 9am | |
| 00:56:36 | cburgess | I won't have a car though so bringing donuts might be tough. | |
| 00:56:47 | dansmith | cburgess: I'm sure you'll work it out | |
| 00:56:47 | cburgess | Getting dropped off or taking Marta or Uber most mornings. | |
| 00:56:50 | cburgess | mriedem Cool | |
| 00:56:57 | cburgess | dansmith Besides, donuts are only for Friday meetup. | |
| 00:57:21 | mriedem | cburgess: just remember that old saying, | |
| 00:57:24 | mriedem | cash, grass or ass | |
| 00:57:27 | dansmith | cburgess: remember ptg is "all friday all week" | |
| 00:57:37 | cburgess | mriedem LOL | |
| 00:57:57 | cburgess | dansmith Well that will be a productive time then.. oh wait... | |
| 00:58:02 | mriedem | dansmith: i don't think you've yet realized the amount of coordination that is going into the PTG scheduling now across teams | |
| 00:58:22 | mriedem | it's like the design summit now, but worse because there aren't actually slots | |
| 00:58:27 | mriedem | except those we make ourselves | |
| 00:58:27 | dansmith | mriedem: I'm sure :) | |
| 00:58:31 | openstackgerrit | STEW TY proposed openstack/nova master: Transform instance.unrescue notifications https://review.openstack.org/388275 | |