Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-02-10
14:41:54 johnthetubaguy mriedem: jroll: -2 removed
14:42:20 jroll mriedem: johnthetubaguy: you rock, thanks
14:43:33 mriedem lyarwood: i think i'm going to hold https://review.openstack.org/#/c/431530/ out of rc2 since it's latent
14:43:49 mriedem lyarwood: but good if that fixes it, i remember takashi tried to fix that and we had to revert his fix
14:45:35 lyarwood mriedem: yup np and thanks, hopefully that's enough this time. https://review.openstack.org/#/c/427808/ hasn't landed yet btw, I'll try to get another tempest core to ack now.
14:46:34 mriedem lyarwood: well....
14:46:35 mriedem oh,
14:46:43 mriedem i guess we only enable that test starting in ocata
14:46:59 mriedem i was going to say, you'd break stable/mitaka, but we don't run the test there
14:49:20 lyarwood mriedem: yup, that reminds me I still haven't landed https://review.openstack.org/#/c/427602/
14:50:10 mriedem ah so that's why the ceph job has been red for weeks :)
14:50:22 mriedem good thing we made it non-voting for other brokenness before that
14:52:06 lyarwood yeah sorry about that, the lack of fire from the job no longer voting means I keep dropping this
15:01:17 openstackgerrit Chris Friesen proposed openstack/nova-specs master: add spec for instance flavor API https://review.openstack.org/431775
15:02:25 cfriesen ^ the "flavor information in nova show output" spec from yesterday's discussion
15:03:39 mriedem cfriesen: can you please just cleanup the existing review?
15:03:43 mriedem rather than post a new one
15:04:23 mriedem https://review.openstack.org/#/c/265282
15:04:52 mriedem also, did you know there was a claude friesen?
15:10:18 cfriesen mriedem: I started by cherry-picking the existing review...oh, did I change the Change-Id maybe?
15:10:34 mriedem cfriesen: most likely
15:10:49 mriedem although cherry-picking should preserve that
15:10:54 mriedem i would have just done a git review -d
15:10:56 mriedem but either words
15:10:59 mriedem *works
15:11:52 cfriesen didn't even know about "git review -d". :)
15:13:01 openstackgerrit Chris Friesen proposed openstack/nova-specs master: add spec for instance flavor API https://review.openstack.org/265282
15:13:46 artom cfriesen, you're not alone, I was like a year into my Openstack work when I saw a colleague use it
15:14:30 cfriesen I cherrypicked and then squashed some stuff on top and forgot to preserve the old change-id. That newer one ^ should be the right one.
15:16:31 mriedem cool thanks
15:16:41 mriedem i'm nowhere near ready to review pike specs yet,
15:16:45 mriedem but it's good to get those ducks in a row
15:17:10 cfriesen speaking of specs...did anything happen in Ocata for this? https://blueprints.launchpad.net/nova/+spec/memory-bw
15:17:40 cfriesen looks like parts of it got merged and parts were abandoned
15:20:42 openstackgerrit Silvan Kaiser proposed openstack/nova master: Switch Nova Quobyte volume driver to mount via systemd-run https://review.openstack.org/432344
15:23:16 mriedem first, did we have an ocata midcycle? i'm totally drawing a blank
15:23:29 mriedem i guess not
15:23:31 mriedem because of the short release
15:23:48 mriedem cfriesen: we said at the newton midcycle that we weren't going to do the memory bandwidth tracking stuff in nova
15:25:02 mriedem cfriesen: see http://lists.openstack.org/pipermail/openstack-dev/2016-August/100600.html
15:25:06 mriedem "* Future of compute host metrics monitoring in Nova"
15:25:24 mriedem http://docs.openstack.org/developer/nova/policies.html?highlight=monitoring#metrics-gathering
15:28:43 cfriesen mriedem: thanks for the links
15:32:37 cfriesen mriedem: is there any coalescing around a new standard metrics gathering tool?
15:34:45 mriedem cfriesen: not that i'm aware of,
15:34:49 mriedem there are lots of metrics gathering tools,
15:34:56 mriedem i'm sure there are probably at least 3 competing big tent projects
15:36:04 mriedem cfriesen: might be worth asking the telemetry and/or watcher teams,
15:36:11 mriedem edleafe is involved with watcher so he might have some tips
15:37:15 edleafe cfriesen: I'd ask in #openstack-watcher
15:37:23 edleafe oops! my manners
15:38:51 figleaf heh
15:40:03 openstackgerrit Dan Smith proposed openstack/nova master: Remove flavor_* functions from db/api https://review.openstack.org/431752
15:40:03 openstackgerrit Dan Smith proposed openstack/nova master: Remove main_db flavor compatibility https://review.openstack.org/431722
15:40:04 openstackgerrit Dan Smith proposed openstack/nova master: Remove straggling use of main db flavors in cellsv1 code https://review.openstack.org/432352
15:40:14 mriedem random question - why do we even have this decorator on compute_api.delete when it won't enforce anything? https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2152
15:40:43 mriedem i think everything in here will eval to False https://github.com/openstack/nova/blob/master/nova/compute/api.py#L130
15:40:54 mriedem so we'll never get InstanceInvalidState
15:42:24 cfriesen mriedem: is there no way to assert that the vm_state/task_state must be None?
15:42:40 mriedem that's not what None means there
15:42:42 cfriesen but yeah, that does seem pointless on the delete operation
15:42:48 mriedem None for that decorator means, i don't care about vm_state or task_state
15:42:54 cfriesen mriedem: yeah, I see that.
15:43:15 cfriesen mriedem: but what if I wanted to ensure that it actually was None?
15:43:49 cfriesen wait, I guess vm_state should be something else
15:44:02 mriedem then you pass in (None,)
15:45:03 sfinucan mriedem: We can't remove the floating IP nova-manage commands until we remove cells v1 and nova-network, correct? https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L305-L308
15:45:52 mriedem sfinucan: corect
15:45:53 mriedem *correct
15:45:55 mriedem i already tried
15:45:56 mriedem and gave up
15:46:00 mriedem b/c devstack uses those
15:46:11 sfinucan mriedem: aww :(
15:46:12 cfriesen mriedem: maybe it serves to assert that we don't care about the state?
15:46:28 mriedem cfriesen: then we shouldn't even use the decorator right?
15:46:43 sfinucan OK, I'll update that comment to reflect the new reality so
15:46:48 cfriesen mriedem: an argument could be made to that effect
15:52:26 cfriesen someone should tell leakypipes about VMs.
16:08:02 artom cfriesen, I hear there's a thing called OvenShack or something that can even manage VMs for you
16:09:47 superdan hah
16:16:50 openstackgerrit Sivasathurappan Radhakrishnan proposed openstack/nova master: Extract _post_live_migratiion_network_setup https://review.openstack.org/413021
16:17:48 openstackgerrit Sivasathurappan Radhakrishnan proposed openstack/nova master: [WIP] Network binding based on events https://review.openstack.org/432370
16:19:46 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-manage: Update deprecation timeline https://review.openstack.org/432373
16:30:48 mriedem melwitt: some feedback in https://review.openstack.org/#/c/429075/
16:31:14 melwitt cool, thanks
16:36:43 kashyap mriedem: [OT?] Your response on that IRC thread made me chuckle, and do a `grep` for the said word (not going to repeat here, lest it ends up archives again)
16:36:50 kashyap So, it's not really _that_ bad:
16:36:53 kashyap $ grep $WORD ~/irclogs/FN-B/#openstack-nova.log | wc -l
16:36:54 kashyap 12
16:37:37 kashyap I checked that all entries were from you :-)
16:38:15 mriedem kashyap: heh
16:38:20 mriedem yeah i wasn't making it up
16:39:11 kashyap Oh, should mention the archives were starting only from 22-MAR-2015
16:40:24 kashyap mriedem: On a diff. topic, from your email on min libv version
16:40:43 kashyap Should the next one be 1.3.1, then?
16:40:55 kashyap FWIW, /me wrote this http://lists.openstack.org/pipermail/openstack-dev/2017-February/111933.html
16:41:01 mriedem kashyap: well, i know you always want bleeding edge so i'm not sure i can trust you here :)
16:41:05 mriedem i saw your response
16:41:23 mriedem your general comment on anything libvirt version related is "but that version was released 2 years ago?!"
16:42:06 kashyap mriedem: No, please don't be so harsh that I don't care about operators who don't care about bleeding edge.

Earlier   Later