Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-02-08
10:38:35 openstackgerrit Stephen Finucane proposed openstack/nova master: conf: Deprecate two more nova-net options https://review.openstack.org/412390
10:38:36 openstackgerrit Stephen Finucane proposed openstack/nova master: conf: Deprecate 'ipv6_backend' https://review.openstack.org/430716
10:38:36 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Fix indentation in conf/netconf https://review.openstack.org/430717
10:38:37 openstackgerrit Stephen Finucane proposed openstack/nova master: WIP: conf: Add 'vif' group https://review.openstack.org/430718
10:40:56 nikeshm lyarwood: ok
10:41:08 nikeshm i am trying to switch to xenial
11:15:26 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.43: List/Show all server migration types https://review.openstack.org/430839
11:29:12 sfinucan macsz: Something to look out for in the conf option patches - deprecated_since should now be '16.0.0'
11:29:20 sfinucan johnthetubaguy: likewise ^
11:29:38 johnthetubaguy sfinucan: yeah +1
11:33:39 sfinucan johnthetubaguy: I would be interested in your thoughts on https://review.openstack.org/430718
11:34:53 johnthetubaguy sfinucan: the file inject of network templates will not go away
11:35:10 johnthetubaguy sfinucan: putting that in config drive is the only way to configure networking without DHCP
11:35:33 johnthetubaguy sfinucan: its the more general file injection that would die, AFAIK
11:35:46 sfinucan johnthetubaguy: Aha, yeah I wasn't sure if there was a difference
11:36:15 johnthetubaguy its the open the file system and write files in that really has to die
11:36:30 johnthetubaguy the write files passed in API into config drive is also not brilliant
11:36:47 johnthetubaguy the create files from info we know and put it into config drive, I think has to stay
11:36:50 sfinucan aye, mriedem spoke of doing just that this cycle
11:36:51 johnthetubaguy but I might have that all wrong
11:38:49 sfinucan johnthetubaguy: Out of curiosity, are you aware of any reason /not/ to provide IPv6 information in that injected template if we IPv6 networks available
11:39:00 sfinucan i.e. do we really need to use 'CONF.use_ipv6' here https://github.com/openstack/nova/blob/d48aeb5783ea9bd9495eb2e7c67bc587dfd7d85d/nova/virt/netutils.py#L131-L132
11:39:32 johnthetubaguy good point, that does seem a bit nuts, we should just inject what neutron sends us
11:40:06 sfinucan I'm thinking it's a remnant from nova-network days used as a "quick escape"
11:40:16 sfinucan But I don't see any reason to keep it around now
11:40:29 sfinucan Likewise for libvirt port filters https://github.com/openstack/nova/blob/d48aeb5783ea9bd9495eb2e7c67bc587dfd7d85d/nova/virt/libvirt/firewall.py#L158 and #L172
11:40:45 lyarwood mdbooth: wallofde^C^Ctext added to https://review.openstack.org/#/c/383859/16
11:45:43 johnthetubaguy sfinucan: thats probably right, it sounds broken to me
11:47:19 sfinucan Time to go kill some code so :)
11:47:23 sfinucan Yay
11:48:43 johnthetubaguy sfinucan: :)
11:48:53 openstackgerrit John Garbutt proposed openstack/nova master: Stop failed live-migrates getting stuck migrating https://review.openstack.org/430404
11:55:34 johnthetubaguy sfinucan: if you get chance, this is another nasty live-migrate bug that was blocking the live-migration performance testing OSIC are doing: https://bugs.launchpad.net/nova/+bug/1662626
11:55:34 openstack Launchpad bug 1662626 in OpenStack Compute (nova) "live-migrate left in migrating as domain not found" [Medium,In progress] - Assigned to John Garbutt (johngarbutt)
11:56:08 johnthetubaguy sfinucan: along with this one: https://review.openstack.org/#/c/429798/5
11:56:12 sfinucan johnthetubaguy: so https://review.openstack.org/#/c/430404/ ?
11:56:27 johnthetubaguy sfinucan: both of them
11:56:34 johnthetubaguy well, all three I guess
11:56:34 sfinucan gotcha
11:56:57 johnthetubaguy one fixes the root cause of the error, the other fixes our handing of the error, if that makes sense
11:57:12 sfinucan It does
11:57:19 sfinucan I'll take a look shortly, once I'm done with lyarwood / mdbooth's two fixes
12:01:00 openstackgerrit Alex Szarka proposed openstack/nova master: Transform instance-exists notification https://review.openstack.org/403660
12:04:31 lyarwood sfinucan: we should start a club
12:05:24 lyarwood or a therapy group
12:20:55 mdbooth lyarwood: Awesome, thanks for doing that.
12:21:05 mdbooth lyarwood: Just making the log level change now.
12:21:27 openstackgerrit MarkMielke proposed openstack/nova master: DiskFilter should only apply when storage is requested https://review.openstack.org/430091
12:22:36 lyarwood mdbooth: np
12:22:38 lyarwood gerrit--
12:23:36 mdbooth lyarwood: Incidentally, the patch I posted for the detach race doesn't work, because the race isn't local to the compute host
12:23:49 mdbooth Which is annoying
12:28:09 lyarwood mdbooth: wonderful, so I guess we just remove the detach from the compute layer, see which virt drivers we break and add in an additional detach there?
12:28:56 mdbooth lyarwood: The issue is that the bdm list is fetch on the api node and passed to the compute node, but is out of date by the time it's used.
12:29:21 mdbooth So we can take a lock on the compute node, but we're still operating on a list which was generated outside of that lock.
12:29:53 mdbooth It would also race with anything else which modified bdms other than the compute node
12:31:39 lyarwood mdbooth: isn't the compute the only thing modifying bdms for running instances?
12:32:04 mdbooth lyarwood: I doubt it, tbh.
12:32:32 mdbooth I wouldn't be surprised to discover that api and conductor also touch them at various times.
12:32:44 mdbooth No specific examples come to mind, just my expectation.
12:33:30 openstackgerrit Matthew Booth proposed openstack/nova master: libvirt: Fix races with nfs volume mount/umount https://review.openstack.org/383859
12:33:51 mdbooth lyarwood sfinucan johnthetubaguy: ^^^ no changes other than some log levels
12:42:33 sfinucan lyarwood: Finally worked my way though https://review.openstack.org/#/c/427364/
12:42:51 sfinucan up to you to someone else for the +W though :)
12:43:01 sfinucan /-1
12:44:49 alex_xu nova api meeting is in 15 mins at #openstack-meeting-4
12:53:59 openstackgerrit John Garbutt proposed openstack/nova master: Remove stuck live-migration detection https://review.openstack.org/430218
12:54:00 openstackgerrit John Garbutt proposed openstack/nova master: WIP: Avoid all live-migration timeouts by default https://review.openstack.org/430890
12:57:15 lyarwood sfinucan: ah awesome thanks! I'll chase another core review once the tempest test is passing, appears to be hitting a few unrelated issues atm
12:59:53 sfinucan How on earth did no one detect https://bugs.launchpad.net/nova/+bug/1644248 before now?
12:59:53 openstack Launchpad bug 1644248 in OpenStack Compute (nova) "Nova incorrectly tracks live migration progress" [High,In progress] - Assigned to John Garbutt (johngarbutt)
13:00:57 alex_xu johnthetubaguy: sdague are you around for nova api meeting today? plan to talk about Pike plan today
13:02:59 sfinucan johnthetubaguy: I think you need a deprecation reno section in https://review.openstack.org/#/c/429798/5
13:10:43 sfinucan johnthetubaguy, mdbooth: Think I've got all those patches reviewed. Now for foooood
13:23:46 openstackgerrit Stephen Finucane proposed openstack/nova master: conf: Deprecate 'ipv6_backend' https://review.openstack.org/430716
13:23:47 openstackgerrit Stephen Finucane proposed openstack/nova master: conf: Fix indentation in conf/netconf https://review.openstack.org/430717
13:23:47 openstackgerrit Stephen Finucane proposed openstack/nova master: conf: Deprecate 'firewall_driver' https://review.openstack.org/412390
13:23:48 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Ignore 'use_ipv6' for port filters https://review.openstack.org/430909
13:23:48 openstackgerrit Stephen Finucane proposed openstack/nova master: netutils: Ignore 'use_ipv6' for network templates https://review.openstack.org/430910
13:23:49 openstackgerrit Stephen Finucane proposed openstack/nova master: conf: Deprecate 'use_ipv6' https://review.openstack.org/430911
13:23:49 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Ignore 'allow_same_net_traffic' for port filters https://review.openstack.org/430912
13:23:50 openstackgerrit Stephen Finucane proposed openstack/nova master: conf: Deprecate 'allow_same_net_traffic' https://review.openstack.org/430913
13:23:50 openstackgerrit Stephen Finucane proposed openstack/nova master: conf: Deprecate 'metadata_host', 'metadata_port' https://review.openstack.org/430914
13:23:51 openstackgerrit Stephen Finucane proposed openstack/nova master: conf: Deprecate various 'iptables_' options https://review.openstack.org/430915
13:23:59 sfinucan johnthetubaguy: ^ fixed the use_ipv6 use case, and then some :)
13:28:42 lpetrut Hi, I have a question regarding cells caching: did anyone propose a patch already, refreshing n-api's cached cells list? https://github.com/openstack/nova/blob/466769e588dc44d11987430b54ca1bd7188abffb/nova/compute/api.py#L109-L112
13:56:09 johnthetubaguy lpetrut: I don't think so, because we only support having one cell right now (other than for testing)
13:57:06 lpetrut johnthetubaguy: got it, thanks
13:58:52 openstackgerrit Feodor Tersin proposed openstack/nova master: libvirt: Parse virt_type attribute of LibvirtConfigGuest from xml https://review.openstack.org/414747
13:58:53 openstackgerrit Feodor Tersin proposed openstack/nova master: libvirt: Parse os attributes of LibvirtConfigGuest from xml https://review.openstack.org/410665
13:58:53 openstackgerrit Feodor Tersin proposed openstack/nova master: libvirt: Parse filesystem elements of guest config https://review.openstack.org/410666
13:58:54 openstackgerrit Feodor Tersin proposed openstack/nova master: libvirt: Use config types to parse XML for instance disks https://review.openstack.org/410667
13:58:54 openstackgerrit Feodor Tersin proposed openstack/nova master: libvirt: Add missing tests for utils.find_disk https://review.openstack.org/414750
13:58:55 openstackgerrit Feodor Tersin proposed openstack/nova master: libvirt: Parse basic attributes of LibvirtConfigGuest from xml https://review.openstack.org/414748
13:58:56 openstackgerrit Feodor Tersin proposed openstack/nova master: libvirt: Use config types to parse XML for root disk https://review.openstack.org/411941
13:58:56 openstackgerrit Feodor Tersin proposed openstack/nova master: libvirt: Introduce Guest.get_config method https://review.openstack.org/414749
13:58:56 openstackgerrit Feodor Tersin proposed openstack/nova master: libvirt: Simplify internal usage of get_instance_disk_info https://review.openstack.org/334901
13:58:57 openstackgerrit Feodor Tersin proposed openstack/nova master: libvirt: Remove unused disk_info parameter https://review.openstack.org/382025
14:00:34 mordred sdague: thanks for reminding me I need to implement the needs-floating-ip flag
14:01:05 mordred sdague: it's one of the best examples, because discovering whether the cloud requires a floating ip or not involves _several_ api calls and a bunch of guess work

Earlier   Later