| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-02-07 | |||
| 21:33:19 | diana_clarke | dansmith: before I take the WIP off my patch, I'll do a DB dump before and after and diff them. It's already on my TODO list. | |
| 21:33:40 | dansmith | diana_clarke: excellent, thanks | |
| 21:34:09 | diana_clarke | mriedem: And here are the api database migration times, if you're curious. This time sorted by migration number: http://paste.openstack.org/show/598005/ | |
| 21:36:06 | mriedem | diana_clarke: fyi https://github.com/openstack/nova/blob/master/tools/db/schema_diff.py | |
| 21:36:19 | mriedem | dprince wrote that when he was collapsing migrations way back when | |
| 21:36:32 | diana_clarke | mriedem: ah, thanks! | |
| 22:05:31 | pumaranikar | sdague, can you please check https://review.openstack.org/#/c/395194/. Placement json formatter change. | |
| 22:10:44 | openstackgerrit | Diana Clarke proposed openstack/nova master: Reduce the number of COMMIT & SELECT 1 statements https://review.openstack.org/430390 | |
| 22:24:09 | openstackgerrit | Alex Szarka proposed openstack/nova master: Refactor init_instance:resume_guests_state https://review.openstack.org/349582 | |
| 22:25:16 | openstackgerrit | Alex Szarka proposed openstack/nova master: Changed maximum code complexity to 25 https://review.openstack.org/351176 | |
| 22:29:35 | mordred | mriedem: so - I've got this question about boot from volume | |
| 22:30:51 | mordred | mriedem: http://developer.openstack.org/api-ref/compute/?expanded=create-server-detail#create-server says that block_device_mapping_v2.boot_index takes a string and also that None should be used for volumes not used as boot volumes | |
| 22:32:00 | mriedem | was just packing up... | |
| 22:32:20 | mordred | mriedem: but we just got an error "Invalid input for field/attribute boot_index. Value: None. None is not of type 'integer" | |
| 22:32:24 | mriedem | mordred: http://docs.openstack.org/developer/nova/block_device_mapping.html might be helpful | |
| 22:32:33 | mordred | mriedem: yup. it also says None is valid | |
| 22:34:01 | mriedem | i feel like something was just recently changed in the json schema there, is this master? | |
| 22:34:18 | mordred | dhellmann: you were doing master devstack? | |
| 22:34:30 | mordred | mriedem: I think so yeah? | |
| 22:34:43 | dhellmann | mordred : yes, master devstack (from a few hours ago) | |
| 22:34:51 | mriedem | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/block_device_mapping.py#L56 | |
| 22:35:28 | mordred | fantastic | |
| 22:36:06 | mriedem | what's the image and dest type? | |
| 22:36:19 | mriedem | source_type and destination_type i mean | |
| 22:37:01 | mriedem | because https://github.com/openstack/nova/blob/master/nova/block_device.py#L198 | |
| 22:37:02 | dhellmann | it's a qcow2 ubuntu image | |
| 22:37:16 | mordred | destination_type would be 'volume' | |
| 22:37:22 | mriedem | and source_type is? | |
| 22:37:23 | mriedem | image? | |
| 22:37:25 | dhellmann | I want to boot it ephemeral and attach a volume | |
| 22:37:47 | mordred | yah- source_type also volume | |
| 22:38:01 | mriedem | have you tried omitting boot_index | |
| 22:38:02 | mriedem | ? | |
| 22:38:05 | mordred | yes. that works | |
| 22:38:12 | mordred | as does providing -1 or '-1' | |
| 22:38:46 | mordred | however, None worked in the past and is still referneced in the docs ... so maybe there's a bug somewhere, I'm just not sure what to file/write up | |
| 22:38:59 | mordred | (we can make shade dtrt by omitting or using -1 | |
| 22:39:14 | mriedem | oomichi: Kevin_Zheng: gmann: alex_xu: do you remember anything recently related to this? ^ | |
| 22:39:40 | mriedem | https://review.openstack.org/#/c/410006/ | |
| 22:40:50 | mriedem | mordred: i wouldn't put a ton of faith in the api-ref docs on this one | |
| 22:40:57 | mordred | mriedem: ok | |
| 22:41:01 | openstackgerrit | Pushkar Umaranikar proposed openstack/nova master: Placement api: set custom json_error_formatter in resource_class https://review.openstack.org/430463 | |
| 22:41:04 | mriedem | i'd be interested in knowing if it's different on like a liberty install | |
| 22:41:29 | mordred | mriedem: None worked against dreamhost - whatever version is running there | |
| 22:41:43 | mriedem | mordred: because my guess is the wording in the api-ref was pulled from http://docs.openstack.org/developer/nova/block_device_mapping.html and that's more about the actual object code in nova rather than the API | |
| 22:42:05 | mordred | ah - k. so it's likely just a docs bug | |
| 22:42:06 | dhellmann | dreamhost is either mitaka or newton | |
| 22:42:15 | mriedem | i'd file a bug either way so we can investigate | |
| 22:42:27 | dhellmann | I can do that | |
| 22:42:37 | mriedem | plus, if the api is ok but the docs are wrong, we can use the bug to fix the docs | |
| 22:42:51 | mordred | cool. | |
| 22:42:52 | mordred | thanks dhellmann ! | |
| 22:43:05 | openstackgerrit | Alex Szarka proposed openstack/nova master: Changed maximum code complexity to 30 https://review.openstack.org/351176 | |
| 22:43:10 | dhellmann | thanks, mordred & mriedem | |
| 22:45:00 | mriedem | also, | |
| 22:45:07 | mriedem | i wonder if you were hitting a nova v2 vs v2.1 endpoint before... | |
| 22:45:11 | mriedem | v2 didn't have schema validation | |
| 22:45:22 | mriedem | mordred: dhellmann: ^ | |
| 22:45:39 | mordred | oh - it's entirely possible | |
| 22:46:06 | mordred | shade is (currently) just piggybacking novaclient which grabs latest microversion aiui | |
| 22:46:12 | mordred | I haven't gotten to doing explicit microversion code myself | |
| 22:46:29 | mordred | (that'll be next month - expect plenty of questions from me) | |
| 22:47:02 | mriedem | there is where the legacy v2 api bdm v2 stuff happened https://github.com/openstack/nova/blob/liberty-eol/nova/api/openstack/compute/legacy_v2/servers.py#L424 | |
| 22:47:54 | mriedem | which only checked boot_index here https://github.com/openstack/nova/blob/liberty-eol/nova/block_device.py#L201 | |
| 22:48:00 | mriedem | if source_type == 'image' and destination_type == 'local': | |
| 22:48:33 | mriedem | and then that dict was probably turned into an object https://github.com/openstack/nova/blob/liberty-eol/nova/objects/block_device.py#L73 | |
| 22:48:36 | mriedem | where boot_index can be None | |
| 22:49:18 | mriedem | the compute api did some validation here too https://github.com/openstack/nova/blob/liberty-eol/nova/compute/api.py#L1315 | |
| 22:49:20 | mriedem | on the object | |
| 22:49:22 | mriedem | SO, | |
| 22:49:38 | mriedem | i think it just means that the v2.1 API json schema validation regressed from the v2 API validation | |
| 22:49:56 | mriedem | would be cool if you guys could confirm that it was working when you were talking to a v2 compute endpoint cloud vs v2.1 | |
| 22:50:03 | mriedem | but that'd be my professional opinion | |
| 22:50:09 | mriedem | dr debug | |
| 22:51:06 | mriedem | dhellmann: i've got to run but just throw ^ into the bug report and i'll check it out later when i'm home | |
| 22:51:15 | dhellmann | mriedem : ok | |
| 22:51:36 | dhellmann | mriedem : I am currently working my way through the rather long instructions for filing a nova bug | |
| 22:56:09 | dhellmann | mriedem: https://bugs.launchpad.net/nova/+bug/1662699 | |
| 22:56:09 | openstack | Launchpad bug 1662699 in OpenStack Compute (nova) "API documentation and behavior do not match for booting with attached volumes" [Undecided,New] | |
| 23:02:31 | Daviey | dhellmann: I *think* that might have been the same issue i saw when using Packer with volumes. Had to change Packer's usage with Volumes | |
| 23:02:40 | openstackgerrit | Alex Szarka proposed openstack/nova master: Reduce code complexity - servers.py https://review.openstack.org/359861 | |
| 23:02:52 | openstackgerrit | Alex Szarka proposed openstack/nova master: Reduce code complexity - manager.py https://review.openstack.org/359868 | |
| 23:02:59 | openstackgerrit | Alex Szarka proposed openstack/nova master: Reduce code complexity - linux_net.py https://review.openstack.org/359871 | |
| 23:03:21 | dhellmann | Daviey : yeah, it's a behavior change but it's not clear if it's a bug and if so where (code or docs) | |
| 23:11:16 | openstackgerrit | Alex Szarka proposed openstack/nova master: Transform instance-exists notification https://review.openstack.org/403660 | |
| 23:35:38 | openstackgerrit | Dan Smith proposed openstack/nova master: Add an update_cell command to nova-manage https://review.openstack.org/430354 | |
| #openstack-nova - 2017-02-08 | |||
| 00:37:13 | alex_xu | pkholkin: :( but thanks for your contribution, and good luck in your new adventure! :) | |
| 01:00:44 | openstackgerrit | Vivek Agrawal proposed openstack/nova-specs master: Spec for libvirt driver extension for Veritas HyperScale https://review.openstack.org/430488 | |
| 01:18:17 | Kevin_Zheng | mriedem: I have one concerning destination type here also https://review.openstack.org/#/c/402372/ | |
| 01:40:04 | openstackgerrit | Vladik Romanovsky proposed openstack/nova master: tests: fix vlan test type from int to str https://review.openstack.org/430496 | |
| 01:42:38 | mriedem | Kevin_Zheng: i left a comment in your change | |
| 01:42:50 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Allow None for block_device_mapping_v2.boot_index https://review.openstack.org/430497 | |
| 01:42:56 | mriedem | mordred: dhellmann: alex_xu: oomichi: gmann: Kevin_Zheng: fix for the boot_index=None thing ^ | |
| 01:43:09 | Kevin_Zheng | thanks | |
| 01:44:44 | Kevin_Zheng | mriedem: yeah, my initial plan was to fail | |
| 01:45:13 | Kevin_Zheng | mriedem: so should we make destination_type checked in schema or in python? | |
| 01:46:46 | mriedem | Kevin_Zheng: i'm not sure, it would be good to understand what cases, if any, that destination_type could be None | |
| 01:48:13 | Kevin_Zheng | mriedem: Ok, I understand, I will try more cases | |
| 01:48:50 | mriedem | Kevin_Zheng: oh i see your defaults are copied from what novaclient does | |
| 01:48:56 | mriedem | i didn't know that novaclient did that | |