Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-02-06
15:21:53 bauzas nah, just went to school for $daughter but back
15:21:58 mriedem oh i see
15:22:11 bauzas now, I need some homework support
15:22:14 bauzas but
15:22:19 bauzas I'm still around
15:22:33 bauzas and starting Wed, will be off because of a conference
15:22:39 mriedem ok, well i'm leaving for a couple of hours
15:23:08 mriedem heh
15:23:17 mriedem i just can't keep up with your active schedule
15:25:34 openstackgerrit Emilien Macchi proposed openstack/nova master: DNM - test tripleo without nova api in WSGI/apache https://review.openstack.org/429008
15:39:35 openstackgerrit John Garbutt proposed openstack/nova-specs master: WIP: Spec idea on the future of quotas for Nova https://review.openstack.org/429678
15:40:31 openstackgerrit Dan Smith proposed openstack/nova master: Reserve migration placeholders for Ocata backports https://review.openstack.org/427900
15:41:07 dansmith we should probably merge this now ^
15:45:01 diga bauzas: Hi
15:45:15 diga bauzas: sorry got delay due to dinner
15:45:47 macsz diga: https://etherpad.openstack.org/p/nova-scheduler-pike
15:46:05 diga macsz: okay, will go through it
15:48:36 diga macsz: I dont know if someone is working on Ironic side
15:48:47 diga macsz: but its essential thing
15:54:06 jroll diga: macsz: we plan o figure out that upgrade path problem at PTG sometime, if that's what you're asking about
15:54:35 macsz jroll: that answers the question :)
15:54:40 jroll :D
16:04:05 mdbooth lyarwood: Incidentally, it turns out your swap_volume patch is required for my nfs patch. I was seeing a log warning from my patch about unmounting a volume which supposedly wasn't mounted. Turns out the root cause was swap_volume disconnecting the wrong volume.
16:04:23 mdbooth Rebased my change on yours and the problem goes away.
16:04:38 diana_clarke Does anyone know off the top of their head how to run the functional mysql nova tests locally? Environment variables, etc?
16:04:38 lyarwood mdbooth: ah nice
16:04:56 mdbooth lyarwood: Well, does in my testing, anyway. I should push the rebase and re-run ci.
16:06:08 diga jroll: Yep
16:10:35 mdbooth lyarwood: Mind if I rebase swap_volume, btw?
16:11:07 mdbooth I have a minor clash with your findmnt change, which merged after the base of your swap_volume change
16:11:18 mdbooth So it would be convenient to me to have both.
16:11:20 lyarwood mdbooth: nope, go ahead
16:11:32 mdbooth Thanks
16:13:09 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Reconnect volumes and encryptors during a hard reboot https://review.openstack.org/400384
16:13:59 openstackgerrit Matthew Booth proposed openstack/nova master: libvirt: Remove redundant bdm serial mangling and saving during swap_volume https://review.openstack.org/427364
16:13:59 openstackgerrit Matthew Booth proposed openstack/nova master: libvirt: Fix races with nfs volume mount/umount https://review.openstack.org/383859
16:14:38 lyarwood mdbooth: ^ that's another small change that takes a while to get your head around if you have any time tomorrow to review
16:26:58 dansmith melwitt: wanna look this over? https://review.openstack.org/#/c/429056/
16:28:55 openstackgerrit Pushkar Umaranikar proposed openstack/nova master: [WIP] Placement api: Add json_error_formatter to defaults https://review.openstack.org/395194
16:31:39 openstackgerrit sahid proposed openstack/nova master: libvirt: update the active migrations DS to support migration result https://review.openstack.org/409260
16:31:40 openstackgerrit sahid proposed openstack/nova master: libvirt: ensure live-migration success https://review.openstack.org/409261
16:32:23 melwitt dansmith: done
16:32:45 dansmith melwitt: thanks
16:33:00 openstackgerrit Lee Yarwood proposed openstack/nova master: encryptors: Switch to os-brick encryptor classes https://review.openstack.org/391597
16:35:25 dansmith melwitt: cdent: FWIW, the reason I used a naked "placement" is because I'm referring to placement api, service, database, catalog entry, etc as a group
16:35:41 dansmith "placement service" would be fine too, but... that was my thought process
16:36:53 cdent dansmith: yeah, thus the "fine as is". I think "service" is a nice to have, because it's hard to be sure that "placement" on its own is a proper noun and not just some random thing, like layout of the knives and forks on the table.
16:37:12 melwitt dansmith: I see, thanks for clarifying. that makes it make a lot more sense
16:39:05 pumaranikar cdent, johnthetubaguy https://review.openstack.org/#/c/395194/ updated patchset for json error formatter. can you please quickly review and let me know that this is what we are expecting. ?
16:39:19 edleafe cdent: Capitalization maybe? E.g.: 'placement' (random thing) vs. 'Placement' (the resource thingy)
16:39:50 cdent edleafe: because it is new, I'm still not certain that's enough. All of us here think of it as this well known things, but it is not.
16:41:56 edleafe true
16:48:24 cdent pumaranikar: yeah, that looks like a good way to go assuming it works well. How do you feel about it?
16:49:37 pumaranikar cdent, thanks for quick review. Yes it will work. Only thing is we need to modify decorator everywhere
16:50:04 pumaranikar cdent, thats why I thought of middleware initially.
16:50:37 cdent that's okay, I think, as it is a pretty simple change and in any case, no matter how we add, we have to change a bunch of files to remove the keyword arg from all the raised exceptions
16:51:06 cdent I think to get a middleware version that actually worked properly would be considerably more complex (because of the need to parse headers and some response bodies)
16:51:51 pumaranikar cdent, yes. that makes sense.
16:52:10 pumaranikar cdent, i will try to update this today in all places.
16:52:41 cdent pumaranikar: you could consider doing a stack of changes where you change each file in handlers/*.py in a different patch
16:53:38 pumaranikar cdent, yes good idea. It would be easy for review.
16:55:39 pumaranikar cdent, are we ok with class name in wrapper file ? :)
16:56:18 cdent I think it is good enough. If people don't like it we can change it easily enough during the review process
16:57:37 pumaranikar cdent, ok. Will let you know once i make changes atleast in all allocations related actions
16:58:34 cdent cool, looking forward to it
16:58:42 edleafe cdent: First pass at functional code paths for placement testing: https://etherpad.openstack.org/p/nova-placement-functional
16:58:49 edleafe cdent: Now to disappear into meetings
16:58:59 cdent edleafe: cool, I'll look at that either this evening or tomorrow morning
16:59:34 edleafe cdent: thanks. Just wanted to get something down before I got sucked into other things
16:59:53 cdent ✔
17:03:45 mriedem dansmith: the revert on that manila change passed https://review.openstack.org/#/c/429729/ :)
17:03:52 mriedem so i guess it's already fixed...
17:16:58 openstackgerrit Matt Riedemann proposed openstack/nova master: Handle InstanceInvalidState for os-assisted-volume-snapshots https://review.openstack.org/429476
17:19:42 mriedem alex_xu: gmann: oomichi: i'm asserting that we don't need a microversion change for ^ but open to being correct
17:19:45 mriedem *corrected
17:28:24 cfriesen mriedem: what about a suspended guest?
17:29:37 mriedem cfriesen: i guess we do allow that for regular snapshots
17:30:26 mriedem i thought something was wonky with suspended instances in a volume-backed instance flow, but might be thinking of something else
17:33:54 dansmith mriedem: nice
17:37:00 mriedem cfriesen: ooo i actually had that backward
17:37:38 mriedem cfriesen: https://github.com/openstack/nova/blob/9ae5b2306b7a7cc9e77c77292256b13926920ead/nova/compute/api.py#L2805
17:37:58 mriedem we only allow active/stopped/suspended for volume-backed snapshot in the "normal" flow
17:38:03 mriedem so i'll change my patch to follow that
17:40:56 cfriesen mriedem: do we not support paused because we don't bother quiescing the disk first?
17:42:22 mriedem it does quiesce, https://github.com/openstack/nova/blob/9ae5b2306b7a7cc9e77c77292256b13926920ead/nova/virt/libvirt/driver.py#L1913
17:42:32 mriedem and if that fails, it snapshots w/o quiesce
17:42:37 mriedem so maybe paused would work too,
17:42:41 mriedem i just haven't tested it
17:43:05 mriedem i'd have to get a devstack + nfs plugin setup to test this out, which would take some time
17:43:24 dansmith someone should hit this: https://review.openstack.org/#/c/427981/
17:43:30 dansmith last doc change on the books for rc2
17:44:18 dansmith mriedem: this is on the list for rc2...should I spend time reviewing it or what? https://review.openstack.org/#/c/424428/
17:44:28 mriedem dansmith: yeah
17:44:53 cfriesen mriedem: I meant quiesce before pausing...since otherwise there could potentially be data loss in the snapshot....but maybe we'd get the same with suspend. I don't know enough about qemu behaviour in pause vs suspend
17:45:14 mriedem oh before pause,
17:45:36 mriedem https://github.com/openstack/nova/blob/9ae5b2306b7a7cc9e77c77292256b13926920ead/nova/virt/libvirt/guest.py#L566
17:46:16 openstackgerrit John Garbutt proposed openstack/nova master: Default live_migration_progress_timeout to off https://review.openstack.org/429798
17:47:06 praveen Hi mriedem , One help!
17:47:08 praveen There is an observation.. Lets suppose project quota for max number of vms is set as 5. 3 Vms are already up and running into that project. Now, when user triggers another 3 Vms at one go as multiple deployment then 2 vms gets deployed succesfully but another VM does not.. which is correct because of quota error... But there is no indication/error message which gets shown into logs or UI.....
17:47:09 praveen ...Is this the way multipe server create behaves?

Earlier   Later