Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-02-02
20:19:39 cdent edleafe: I left more about the min_unit stuff on https://review.openstack.org/#/c/416752/7
20:19:41 dansmith right, and I was thinking it was looking for nova-compute, which is what the change was
20:19:45 dansmith so I jumped
20:19:46 amoralej and where api services are registered?
20:19:54 dansmith amoralej: you changing it just means you're looking up a different service
20:19:55 amoralej i don't see it in services table
20:20:05 amoralej we are running it as wsgi
20:20:22 dansmith oh, hmm, I bet that is a problem
20:20:50 edleafe cdent: I can get to those changes today
20:20:50 amoralej dansmith, this is my services table http://paste.openstack.org/show/597426/
20:20:52 dansmith amoralej: you see no service records in the services table for nova-osapi_compute?
20:21:01 dansmith yeah
20:21:08 dansmith because you don't use our service infrastructure
20:21:22 dansmith mriedem: we've never said we're okay to run under wsgi did we?
20:21:37 mriedem dansmith: we don't have anything official
20:21:37 amoralej EmilienM ^
20:21:39 mriedem but i know people run it
20:21:45 mriedem i think Fuel did too
20:21:48 cdent edleafe: feel free, but I don't think there's any rush: because the RT sets min_unit correctly, any "proper" use of the placement api will work okay and a bad admin can't send 0 allocations to the inventory that's been written (because min_unit is 1)
20:22:18 cdent (if you do do it, add me to the review so it is on my radar so I know not to do it)
20:22:23 dansmith the thing is, I'm not sure what in the last day would have broken
20:22:39 edleafe cdent: Understood, but I hate building those checks into things external to placement
20:23:07 mriedem dansmith: even with your change, we would have hit this i think https://review.openstack.org/#/c/427782/3/nova/compute/api.py@2269
20:23:10 cdent edleafe: oh yeah, totally agree
20:23:14 EmilienM nova gate is not running api in wsgi with apache?
20:23:16 edleafe cdent: because the next time some service tries to use placement, we have to copy/paste all that external stuff there, too
20:23:22 mriedem EmilienM: no
20:23:27 dansmith mriedem: on wsgi, yeah
20:23:37 EmilienM why?
20:23:47 mriedem EmilienM: no one has made that happen
20:24:04 dansmith and we have things like this that hook into our service framework
20:24:27 mriedem apache support was hacked in several releases ago as a kind of 'i want to see if i can do this' but it wasn't like a supported new feature or anything
20:24:32 amoralej i'm trying to test it with nova-api
20:24:32 mriedem it was a little toy patch
20:25:42 EmilienM tripleo has been running it in productince since Newton
20:25:50 EmilienM production*
20:26:29 dansmith so few real-world users at this point I guess
20:26:52 dansmith dims_: since you were originally involved, any idea how many real people running fuel might be running nova api under apache?
20:27:15 EmilienM dansmith: few real-world users? It's in OSP10
20:27:56 dansmith EmilienM: yeah, I dunno what the footprint of that looks like
20:28:34 mriedem jaypipes: "any idea how many real people running fuel might be running nova api under apache?"
20:29:01 mwhahaha mriedem: a bunch, it's in 9 believe
20:30:31 mriedem https://github.com/openstack/nova/blob/ed55dcad83d5db2fa7e43fc3d5465df1550b554c/nova/wsgi/nova-api.py#L15
20:30:35 mriedem EXPERIMENTAL support script for running Nova API under Apache2 etc.
20:30:37 mriedem anywho
20:30:56 jroll experimental means battle-tested production grade software, right
20:31:01 jroll like nova-bm
20:31:05 mriedem carrier grade
20:31:09 jroll ++
20:31:48 cdent I'm unclear why exporting deploy() as application is so fraught with risk?
20:32:03 EmilienM mriedem: yeah a lot of operators are doing that
20:32:13 EmilienM mriedem: I don't have numbers but it's something common
20:32:49 mriedem cdent: like i said earlier, it was just a 'lets see if this can happen' thing long ago that we never built CI around
20:32:50 jroll cdent: I think the current theory is that it doesn't get any of this code: https://github.com/openstack/nova/blob/ed55dcad83d5db2fa7e43fc3d5465df1550b554c/nova/service.py#L139
20:33:00 melwitt yeah, we didn't do it but thought we should have since things like the api rate limiting can't work as-is
20:33:01 jroll specifically line 154
20:33:25 mriedem so i think we provide a workaround hack in ocata
20:33:28 cdent thank jroll that's what I was after
20:33:33 mriedem and work on running nova-api under apache in one of the gate jobs in pike
20:33:45 jroll cdent: it's overridden for the wsgi thing, I guess, but same idea: https://github.com/openstack/nova/blob/ed55dcad83d5db2fa7e43fc3d5465df1550b554c/nova/service.py#L376
20:33:49 jroll no problem
20:35:00 mwhahaha so to answer, fuel doesn't use apache for the nova api. it's haproxy fronting the standalone service
20:35:09 EmilienM I think Nova team should consider moving the experimental tripleo job to the gate. We have seen over the last weeks (more probably) that it brings very useful feedback on how it works outside devstack
20:35:36 dansmith mwhahaha: ah, good to know
20:37:28 EmilienM mriedem: I think testing api service with apache is part of the goal for Pike
20:37:38 mriedem which goal?
20:37:42 mriedem how many goals are we up to now?
20:37:59 mriedem i said we can start running it in one gating job for nova in pike as a start
20:38:01 EmilienM in https://governance.openstack.org/tc/goals/pike/deploy-api-in-wsgi.html#completion-criteria
20:38:09 mriedem because we have a unicorn snowflake job for stuff like that already
20:38:11 EmilienM mriedem: 2 goals
20:39:05 mriedem ok, so i guess it's a goal for us then anyway
20:39:10 mriedem i'll throw it in our ptg etherpad
20:40:53 dims_ dansmith : i don't think the fuel team ever picked it up from where we left off here in nova. so probably not very many (http://git.openstack.org/cgit/openstack/fuel-library/tree/deployment/puppet/openstack_tasks/manifests/openstack_controller/openstack_controller.pp)
20:41:12 dims_ jaypipes : amirite?
20:41:35 dansmith dims_: gotcha
20:42:14 EmilienM mriedem: I will propose to run tripleo job in the gate for nova
20:42:21 mriedem EmilienM: i will -1
20:42:25 EmilienM of course you will
20:42:30 EmilienM but you'll have to explain why
20:42:45 mriedem because it's not even non-voting in the nova check queue for starters
20:42:50 mriedem we aren't going to gate on something right off the bat
20:43:00 EmilienM ok, let's make non voting first
20:43:06 EmilienM and see how it goes
20:43:07 mriedem are you talking 1 job or 6?
20:43:14 EmilienM but we need to stop ignoring the world outside devstack
20:43:19 EmilienM 1 job
20:43:23 EmilienM which takes 50 min max
20:43:30 mriedem wfm
20:43:35 EmilienM cool
20:43:56 openstackgerrit Dan Smith proposed openstack/nova master: Don't ever cache service versions at zero https://review.openstack.org/428404
20:43:56 openstackgerrit Dan Smith proposed openstack/nova master: Work around deployments with unsupported API services https://review.openstack.org/428415
20:44:16 dansmith mriedem: ^ untested, but might workaround the issue for experimental and unsupported setups
20:44:21 mriedem yup
20:48:31 openstackgerrit Dan Smith proposed openstack/nova master: Don't ever cache service versions at zero https://review.openstack.org/428404
20:48:32 openstackgerrit Dan Smith proposed openstack/nova master: Clarify the language in the apache wsgi sample https://review.openstack.org/428417
20:48:37 dansmith mriedem: also recommend this, since there's clearly confusion around the word "experimental"
20:49:19 dansmith and with that, I'm going to walk away for a bit.
20:49:51 mriedem jaypipes: https://review.openstack.org/#/c/428375/
20:49:59 EmilienM mriedem: the tripleo job has finished to run, http://logs.openstack.org/60/428360/2/experimental/gate-tripleo-ci-centos-7-nonha-multinode/6ca334c/logs/subnode-2/var/log/nova/nova-compute.txt.gz

Earlier   Later