| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-02-01 | |||
| 16:39:39 | dansmith | mriedem: probably should.. we do in the compute/api if we get similarly interrupted by a delete | |
| 16:39:59 | mriedem | ok, was just thinking about orphans | |
| 16:40:06 | alaski | is the instance hard deleted? If there's an instance record there should be a mapping | |
| 16:40:19 | mriedem | alaski: it's not hard deleted no | |
| 16:40:21 | dansmith | alaski: oh good point | |
| 16:40:24 | bauzas | I was about to sat that | |
| 16:40:30 | bauzas | because we soft delete | |
| 16:40:44 | bauzas | but alaski beated me | |
| 16:40:45 | mriedem | the build request is hard-deleted, but if the instance exists then we don't care about the build request | |
| 16:40:56 | mriedem | yeah i suppose for nova list --deleted | |
| 16:40:59 | dansmith | yeah | |
| 16:41:00 | mriedem | touche | |
| 16:41:30 | dansmith | alaski: nice save from the sidelines :) | |
| 16:42:44 | alaski | dansmith: I lurk so I can occasionally seem smart still :) | |
| 16:43:01 | dansmith | alaski: not much danger of that being forgotten, but as you wish :) | |
| 16:44:02 | mriedem | now if he'd only tell me how to untangle this one test... | |
| 16:44:33 | mordred | mriedem: dammit man. now I'm participating in a database related thread on the mailing list | |
| 16:44:34 | alaski | have you tried turning it off and back on... | |
| 16:44:39 | mordred | mriedem: there is no way this ends well for anyone | |
| 16:54:42 | bauzas | mriedem: are you considering keeping that https://review.openstack.org/#/c/427775/1 or do you prefer to remove the conditions for the get() method ? | |
| 16:54:50 | bauzas | conditionals* even | |
| 16:54:56 | bauzas | I tend to prefer the latter | |
| 16:55:04 | dansmith | bauzas: we need to remove the TODOs regardless | |
| 16:55:18 | bauzas | we = who does that so I could +2 it ? | |
| 16:55:27 | dansmith | I already have the patch up | |
| 16:55:32 | bauzas | oh, nice | |
| 16:55:35 | dansmith | WIP, so don't go look yet | |
| 16:55:43 | bauzas | please be a gentleman, so I could CC it :) | |
| 16:56:27 | dansmith | wat? | |
| 16:57:32 | dansmith | oh fuck. that breaks every api samples test.. cripes. | |
| 17:06:01 | bauzas | dansmith: cells meeting or should we leave you having fun with api sample tests ? | |
| 17:06:12 | dansmith | bauzas: we just had it and you didn't show up | |
| 17:06:27 | dansmith | so we adjourned to do work | |
| 17:06:48 | bauzas | heh | |
| 17:11:41 | mriedem | so i can't figure this out, | |
| 17:11:42 | mriedem | https://github.com/openstack/nova/blob/master/nova/tests/unit/conductor/test_conductor.py#L1513 | |
| 17:11:53 | mriedem | i changed that to self.assertEqual(3, build_and_run_instance.call_count) | |
| 17:11:59 | mriedem | and it always fails saying it's only called once | |
| 17:12:04 | mriedem | but there are 3 build requests in that test | |
| 17:12:35 | mriedem | as far as i can tell, things should be peachy | |
| 17:13:13 | edleafe | jaypipes: are you working on https://review.openstack.org/#/c/404472/, or do you want me to fix the tests? | |
| 17:14:55 | bauzas | mriedem: but we only schedule once with 3 requests in it, right ? https://github.com/openstack/nova/blob/master/nova/tests/unit/conductor/test_conductor.py#L1512 | |
| 17:15:44 | mriedem | bauzas: it's asserting this is called https://github.com/openstack/nova/blob/d308d1f70e7e840b1b0c8f4307998d89f9a5ddff/nova/conductor/manager.py#L959 | |
| 17:15:48 | mriedem | which is in a for loop | |
| 17:15:53 | mriedem | over the list of build requests | |
| 17:15:59 | mriedem | of which there are 3 | |
| 17:16:07 | mriedem | so unless something is failing and making it continue before that for 2 of them, i'm lost | |
| 17:19:18 | bauzas | mriedem: correct me if I'm wrong, but we're only passing one request_spec ? | |
| 17:19:47 | bauzas | so the zip thing would only return one tuple | |
| 17:20:56 | bauzas | mriedem: yup, we're only passing one of those https://github.com/openstack/nova/blob/master/nova/tests/unit/conductor/test_conductor.py#L1414-L1415 | |
| 17:22:30 | bauzas | mriedem: so if you wanna make sure you have 3 calls, just add 2 new request_specs in the params dict | |
| 17:23:03 | jaypipes | edleafe: yeah, I'm working on it. | |
| 17:23:24 | edleafe | jaypipes: cool - didn't want it to languish if you were busy | |
| 17:23:38 | jaypipes | edleafe: yeah, sorry, meeting hell day.. | |
| 17:28:20 | mriedem | bauzas: ah beautiful | |
| 17:28:22 | mriedem | thanks | |
| 17:28:55 | openstackgerrit | Dan Smith proposed openstack/nova: Remove pre-cellsv2 short circuit in instance get https://review.openstack.org/427782 | |
| 17:29:03 | bauzas | \o/ | |
| 17:30:20 | breitz | anybody use and IDE like pycharm to debug nova with? I'm trying but failing to find the magic to make it all work | |
| 17:30:46 | dtp | dansmith melwitt you guys need anything? | |
| 17:31:03 | dansmith | dtp: own any guns? | |
| 17:31:19 | dtp | no :( but have been thinking about it lately | |
| 17:31:25 | dansmith | dtp: then, no. | |
| 17:31:27 | dansmith | heh | |
| 17:31:29 | dtp | :) | |
| 17:32:11 | mriedem | dtp: review these? https://review.openstack.org/#/q/topic:man+project:openstack/nova+status:open | |
| 17:32:20 | dtp | ok | |
| 17:33:09 | bauzas | breitz: I think we have something about that | |
| 17:33:12 | bauzas | in our dev doc | |
| 17:33:25 | bauzas | breitz: but tbh, I just pdb when I want to introspect | |
| 17:33:36 | marst | breitz: what's failing? | |
| 17:33:40 | mriedem | LOG.error is my pdb | |
| 17:33:50 | breitz | thats what I do (pdb) but was looking for getting an IDE working. | |
| 17:33:55 | bauzas | yeah found http://docs.openstack.org/developer/nova/development.environment.html#using-a-remote-debugger | |
| 17:33:59 | bauzas | breitz: ^ | |
| 17:34:29 | bauzas | mriedem: sometimes you need something more dynamic :p | |
| 17:34:57 | bauzas | like "oh shit, I knew that, I need to run again to see the next call" | |
| 17:35:05 | mriedem | LOG.error(locals())?! | |
| 17:35:35 | breitz | thanks for the link - I'll read through that (some of which I've followed). Basically I can get pycharm to connect to the remote - but I can't get any breakpoints in nova-compute or any exception to drop me into the debugger. | |
| 17:35:35 | bauzas | mriedem: you won't convince me :p | |
| 17:35:42 | mriedem | btw, just let me say, i'm a professional engineer | |
| 17:36:00 | bauzas | LOL | |
| 17:36:56 | bauzas | I even use Atom | |
| 17:36:58 | mriedem | so, are https://review.openstack.org/#/c/427782/ and https://review.openstack.org/#/c/427775/ coexisting? or does the first supersede the second? | |
| 17:37:22 | melwitt | I use pdb occasionally | |
| 17:37:36 | dansmith | mriedem: they can co-exist.. my preference is this: | |
| 17:37:36 | bauzas | mriedem: I don't really like https://review.openstack.org/#/c/427775/1/nova/conductor/manager.py | |
| 17:37:56 | dansmith | mriedem: poke mine a bit and see if we hit the bug with it. If not, I'd like to merge it and get data before we merge yours | |
| 17:38:17 | bauzas | yeah, I think dansmith's change could help us getting a better situation | |
| 17:38:18 | dansmith | mriedem: yours doesn't hurt anything other than performance and maybe making the race harder to catch if it's still there, so I just wanted to delay | |
| 17:38:26 | dansmith | mriedem: but, we're also up against the deadline, so.. | |
| 17:38:36 | mriedem | -W for now | |
| 17:41:17 | cdent | bbl | |
| 17:52:26 | openstackgerrit | Oliver Walsh proposed openstack/nova: DNM - TripleO CI test https://review.openstack.org/427536 | |
| 17:59:15 | dims_ | mriedem : melwitt : dansmith : ServersNegativeTestJSON failed in the gate about 8-10 at least for the past 4 hours. looks like we are waiting on https://review.openstack.org/#/c/427775 | |
| 17:59:39 | dims_ | ah which transitively is waiting on https://review.openstack.org/#/c/427782/ | |
| 17:59:40 | dansmith | dims_: we've been working on it all morning | |
| 17:59:50 | dims_ | ack dansmith | |
| 18:00:21 | dims_ | just reporting back from watching the CI that's all :) | |
| 18:01:28 | mriedem | you're gonna get stabbed dims | |