| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-02-01 | |||
| 13:36:42 | openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/nova: placement-api: fix ResourceProviderList query https://review.openstack.org/427667 | |
| 13:36:44 | cdent | sileht: being very nit picky on the review in the hope that by the time some core comes along it is nice and happy and we get this merged quick | |
| 13:36:56 | sileht | cdent, | |
| 13:37:11 | sileht | cdent, it's not really nit picky when feedback are instant :) | |
| 13:37:23 | rpodolyaka | cdent: hmm, the second group by is done on a unique column - it must be ok, as it uniquely identifies a particular table row. I'd expect "select rp.* ..." work fine in this case | |
| 13:37:58 | rpodolyaka | tbh it's the first time I've seen a sqalclhemy model passed to group_by() | |
| 13:38:17 | rpodolyaka | my understanding is that it's equivalent of grouping by all columns of a table | |
| 13:38:19 | sileht | rpodolyaka, with postgresql you must have everything you put in the select | |
| 13:38:35 | sileht | rpodolyaka, yes because the select does 'select rp.*' | |
| 13:38:52 | sileht | rpodolyaka, so even if rp.uuid is enought, postgresql don't want to guess | |
| 13:40:01 | sileht | rpodolyaka, I think the second groupby is here just to remove duplicate rows ? | |
| 13:40:22 | mriedem | wiggin15: you need to have the placement-api service enabled, in ENABLED_SERVICES | |
| 13:40:36 | mriedem | wiggin15: if you're overriding ENABLED_SERVICES that is - there is a note in the dev list about it | |
| 13:41:53 | sileht | rpodolyaka, the orignal error we have: http://logs.openstack.org/82/405682/8/check/gate-ceilometer-dsvm-tempest-plugin-postgresql-ubuntu-xenial/02f896f/logs/apache/placement-api.txt.gz?level=ERROR | |
| 13:42:10 | sileht | rpodolyaka, the error when I have fixed the first groupby: http://logs.openstack.org/68/427668/1/check/gate-ceilometer-dsvm-tempest-plugin-postgresql-ubuntu-xenial/372f489/logs/apache/placement-api.txt.gz?level=ERROR | |
| 13:42:22 | mriedem | johnthetubaguy: sfinucan: your call on https://review.openstack.org/#/c/412634/ since it's disabled by default an experimental now anyway | |
| 13:42:36 | mriedem | it was already approved once, just had a busted unit test | |
| 13:43:05 | rpodolyaka | sileht: hmm, interesting | |
| 13:43:08 | cdent | mriedem: I tagged this https://bugs.launchpad.net/nova/+bug/1660959 as rc-potential because postgres support used to work in placement api. it's what sileht and rpodolyaka are talking over now. | |
| 13:43:08 | openstack | Launchpad bug 1660959 in OpenStack Compute (nova) "placement resource provider filtering does not work with postgres" [Undecided,In progress] - Assigned to Mehdi Abaakouk (sileht) | |
| 13:43:15 | mriedem | cdent: yup saw it, thanks | |
| 13:43:17 | mriedem | silly pg | |
| 13:43:24 | wiggin15 | mriedem we have "export OVERRIDE_ENABLED_SERVICES" with services like "c-api", "q-metering" etc., is this it? | |
| 13:43:32 | mriedem | wiggin15: i think so yes | |
| 13:43:35 | mriedem | you need placement-api in that list | |
| 13:43:38 | wiggin15 | mriedem thanks | |
| 13:43:40 | sfinucan | mriedem: I'm happy to let it in, in that case. It's technically a feature but it seems low risk to me. Can't speak for johnthetubaguy, mind | |
| 13:43:40 | sileht | cdent, and our (future) stable/ocata is already broken too :p | |
| 13:43:54 | mriedem | i'm heading into the office, bbiab | |
| 13:44:23 | cdent | sileht: I think the whole world's future is broken lately. | |
| 13:46:29 | rpodolyaka | sileht: heh, looks like it only allows this for PKs, but not for UNIQUEs - http://paste.openstack.org/show/597180/ | |
| 13:48:53 | sileht | rpodolyaka, do we have another column that can do it (instead of putting all cols) ? | |
| 13:51:16 | sileht | rpodolyaka, I will use id, then | |
| 13:51:23 | rpodolyaka | sileht: yeah, we have the PK - `id` | |
| 13:54:02 | openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/nova: placement-api: fix ResourceProviderList query https://review.openstack.org/427667 | |
| 13:56:46 | openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/nova: placement-api: fix ResourceProviderList query https://review.openstack.org/427667 | |
| 14:07:27 | johnthetubaguy | BobBall: seeing some XenAPI issues on this glance related patch: https://review.openstack.org/#/c/412634/24 | |
| 14:07:36 | johnthetubaguy | BobBall: is this a general problem we are seeing at the moment? | |
| 14:08:11 | BobBall | Checking | |
| 14:08:42 | BobBall | general problem meaning unrelated to this patch? | |
| 14:09:08 | johnthetubaguy | BobBall: it feels very related to this patch, but we haven't changed the code that XenAPI uses, AFAIK | |
| 14:09:19 | johnthetubaguy | BobBall: just wanted to check its not a general issue | |
| 14:09:35 | BobBall | hmmmz - actually we are failing all tests in the last couple of hours... | |
| 14:10:40 | johnthetubaguy | BobBall: looks like the plugins have changed or something? | |
| 14:10:52 | BobBall | Big sadness from the Citrix CI at the moment :( | |
| 14:11:45 | BobBall | Investigating. Plugins certainly shouldn't have changed since we're pulling in from a fixed version of os-xenapi from nova's requirements... | |
| 14:12:18 | BobBall | Made the mistake of trying to open a 1MB log file in firefox. Apparently it doesn't like a 1MB html file and has decided it needs a really long think about it | |
| 14:13:06 | johnthetubaguy | BobBall: yeah, I had to download it | |
| 14:13:13 | johnthetubaguy | BobBall: I am seeing 404 from glance | |
| 14:13:28 | BobBall | Not ideal. | |
| 14:20:04 | BobBall | Looks like glance upload is broken | |
| 14:20:50 | mriedem | BobBall: like this? | |
| 14:20:51 | mriedem | 2017-02-01 12:47:40.884 20207 ERROR nova.compute.manager [instance: 797cb75d-5ab2-4231-b972-db08257716f4] Failure: ['XENAPI_PLUGIN_FAILURE', 'upload_vhd2', 'PluginError', 'Got Permanent Error response [404] while uploading image [79f5d221-0e61-4ee9-82e4-69f507219b78] to glance [http://192.168.33.1:9292/v2/images/79f5d221-0e61-4ee9-82e4-69f507219b78/file]'] | |
| 14:21:02 | BobBall | Tis only upload, yes, not download. | |
| 14:21:12 | BobBall | I think. | |
| 14:21:12 | mriedem | what changed? | |
| 14:21:15 | BobBall | Trying to figure that out. | |
| 14:23:59 | mriedem | johnthetubaguy: sfinucan: i've flip flopped and decided to nack anymore of https://blueprints.launchpad.net/nova/+spec/use-service-tokens | |
| 14:24:01 | BobBall | first failure was 11 hours ago on change 427536 | |
| 14:24:09 | mriedem | cinder and neutron are done, let's do the glance stuff in pike | |
| 14:24:21 | johnthetubaguy | mriedem: yeah, I am fine with that, thats like Friday right? | |
| 14:24:39 | mriedem | johnthetubaguy: yeah | |
| 14:24:41 | mriedem | i think so anyway | |
| 14:24:45 | sfinucan | mriedem: What he said ^ | |
| 14:24:46 | mriedem | i believe stable/ocata is created from rc1 | |
| 14:26:13 | bauzas | mriedem: it is | |
| 14:26:19 | bauzas | mriedem: we have to write the cut | |
| 14:26:34 | bauzas | mriedem: have you seen dhellmann's emails about that ? | |
| 14:26:41 | bauzas | I can do a WIP if you wish | |
| 14:26:54 | mriedem | bauzas: yes i know about it | |
| 14:26:55 | bauzas | and you would just update with the right SHA1 | |
| 14:27:50 | BobBall | I have a meeting in 3 minutes... Will have to look into the CI after the meeting. | |
| 14:28:07 | BobBall | mriedem / johnthetubaguy - suggest you remove the Citrix CI from voting until I can fix? | |
| 14:28:16 | bauzas | mriedem: okay, but I mean, you okay with writing the releases change ? | |
| 14:28:22 | BobBall | (or figure out what's going on...) | |
| 14:28:29 | bauzas | mriedem: that would create the branch | |
| 14:28:37 | mriedem | bauzas: yes | |
| 14:28:40 | bauzas | kewl | |
| 14:28:57 | mriedem | we have a lot of shit to fix before then :( | |
| 14:29:12 | mriedem | BobBall: looks like that's already taken care of https://review.openstack.org/#/admin/groups/511,members | |
| 14:29:21 | BobBall | +1 | |
| 14:30:59 | jroll | mriedem: think we should be using the same service token for ironic interactions (rather than separate auth configs we use today) | |
| 14:31:05 | jroll | slash johnthetubaguy ^ | |
| 14:32:50 | johnthetubaguy | mriedem: this one seems ready now, and good to have: https://review.openstack.org/#/c/421760/ | |
| 14:33:35 | mriedem | jroll: is that a question? | |
| 14:33:42 | mriedem | johnthetubaguy: yeah it's on the list | |
| 14:33:45 | johnthetubaguy | jroll: possibly, we need to work out what we want keystone roll wise. I quite like the "i am nova" service token being used for all the cases we want for that | |
| 14:34:37 | johnthetubaguy | jroll: I would rather we move to user token + nova service user, for all interactions where possible, so it clear where the request came from at all times | |
| 14:34:49 | jroll | mriedem: oh yeah, punctuation is hard, that's a question | |
| 14:34:54 | johnthetubaguy | jroll: need some oslo.policy tweaks to get that working though | |
| 14:35:24 | jroll | johnthetubaguy: yeah, need to think more about it, user token would be nice for e.g. hitting neutron on our side | |
| 14:35:38 | mriedem | we also don't know what the performance implications are yet | |
| 14:36:05 | johnthetubaguy | mriedem: very true, it very much depends on that not being total suck | |
| 14:36:09 | mriedem | i think the hope is, in pike we pick a ci job and turn the service user stuff on | |
| 14:36:24 | mriedem | *etherpad | |
| 14:36:39 | cdent | it's cuz you're talking to a brit | |
| 14:36:44 | johnthetubaguy | mriedem: I am asking our internal CI to do some proper performance trials with/without, but they don't sound too excited yet | |
| 14:36:56 | johnthetubaguy | cdent: heh | |
| 14:39:30 | openstackgerrit | Lee Yarwood proposed openstack/nova: WIP - libvirt: Remove redundant bdm serial mangling and saving during swap_volume https://review.openstack.org/427364 | |
| 14:39:45 | openstackgerrit | Chris Dent proposed openstack/nova: Add placement request id to log when GET or POST rps https://review.openstack.org/427740 | |