Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-02-01
10:36:34 johnthetubaguy oops emitted
10:36:43 davidgiluk generate :-)
10:37:32 mdbooth Well, this merged: https://review.openstack.org/#/c/402318/ :(
10:37:49 mdbooth The libvirt driver becomes slightly less fathomable for no appreciable gain.
10:38:11 davidgiluk johnthetubaguy: you should probably loop in jdenemar to check what it looks like for you from ontop of libvirt - but you should have all the events you need to know when postcopy kicks in
10:38:35 kashyap mdbooth: Propose a revert?
10:38:47 johnthetubaguy davidgiluk: thats the plan for the follow up fix
10:38:54 mdbooth kashyap: I proposed not merging it, which didn't work.
10:39:01 kashyap mdbooth: From glancing at your comments on the review
10:39:06 davidgiluk johnthetubaguy: OK, great; if you do need anything more from qemu, just ask
10:39:09 johnthetubaguy mdbooth: sorry, got pulled into meetings after that one, so I didn't get chance to delay it
10:39:10 kashyap mdbooth: No one has bothered to respond with a counter-argument
10:39:17 johnthetubaguy mdbooth: I can fast revert it if you want
10:39:36 kashyap Then, you have by all means, a right to revert it, and restart the discussion, and make whoever proposed it to respond
10:39:48 mdbooth johnthetubaguy: If you wouldn't mind. I'm assuming, btw, that there are no real users being impacted by this.
10:40:40 johnthetubaguy mdbooth: no idea, the SUSE folks proposed this, and I believe they support users on Xen + Libivrt + Nova, so I was assuming yes
10:41:15 mdbooth It's been broken forever though, right?
10:41:36 johnthetubaguy mdbooth: sure, I assumed they were trying to change that for one of their users that are complaining
10:42:09 mdbooth I just don't want to add more sticky tape without investigating fixing the root cause.
10:42:25 mdbooth I don't see any evidence anybody looked for the root cause.
10:43:17 johnthetubaguy mdbooth: I added my assumption of the cause in the review, well the root cause is Xen being very picky about the device names
10:43:55 mdbooth We need to either be picky earlier, or translate it earlier.
10:44:18 johnthetubaguy mdbooth: the problem is, you don't know if its Xen until it hits the compute node
10:44:19 mdbooth Sticking a band-aid at the lowest possible level is just going to be a source of bugs
10:44:42 mdbooth Yeah, that occurred to me. No immediate answer to that as I haven't given it any thought.
10:44:53 mdbooth Seems that nobody else has either, though.
10:45:46 mdbooth Might be something to be resolved in driver.spawn, and attach/detach volume?
10:46:03 mdbooth That way it's resolved at the time it's created
10:47:55 mdbooth Do those names have any semantic meaning at the api level beyond 'the Nth disk' anyway? I don't think we support multiple controller types, do we?
10:48:24 johnthetubaguy we support multiple hypervisors in a single cloud, at least in theory
10:48:38 mdbooth If ^^^ is a valid assumption, ComputeManager could rewrite it to a number, and the driver could change it back to whatever it wanted.
10:48:58 johnthetubaguy I don't think we even respect the number any more, but it could
10:49:01 mdbooth johnthetubaguy: It's in a single instance. i.e. could we have both sda and vda in the same instance?
10:49:36 johnthetubaguy sda would always fail to attach, all disks need to be vd* I believe, or xvd*
10:50:17 mdbooth Right, so computemanager would see it got 'sda' from the api, translate that to '0', and the driver would change it to 'sda', 'vda', or 'xvda' as required.
10:51:08 johnthetubaguy seems like a good refactor to do on top of the bug fix
10:51:54 mdbooth johnthetubaguy: The bug fix makes the existing code worse, though, and I see no evidence that anybody looked for a root cause.
10:52:47 mdbooth Given that it's obviously not urgent, I don't see why we would choose to take more tech debt for that.
10:53:28 mdbooth Anyway, it's not that important in itself.
10:53:44 mdbooth Just death by 1,000 cuts.
10:53:55 johnthetubaguy it breaks a pretty fundamental API feature, that seemed fairly important to be from a parity point of view, but I duno really.
10:56:54 mdbooth johnthetubaguy: Yeah, I know. But it's been broken a long time and I'd have preferred to see an attempt to fix it without adding tech debt first.
10:57:34 johnthetubaguy mdbooth: that my preference too, but its a balancing act
10:58:11 johnthetubaguy I was very boarderline on -1 +2 myself
10:58:14 mdbooth If it's important to somebody, they'll fix it. You even suggested where to look, and I agreed.
10:58:48 bauzas lyarwood: nice catch, +2d https://review.openstack.org/#/c/427267/2
10:59:13 sfinucan bauzas: Could you take a look at https://review.openstack.org/#/c/392643/, please? :)
10:59:14 bauzas johnthetubaguy: in case you wanna fix a nasty bug with an easy peasy fix ^
10:59:35 bauzas sfinucan: roger
10:59:39 mdbooth johnthetubaguy: Now ^^^ is a nasty bug :)
10:59:56 mdbooth Ah, not that one.
11:00:13 mdbooth The one before which bauzas mentioned.
11:02:03 kashyap sfinucan: Your friendly monthly reminder: If you put commit IDs in single quotes, then 'clickability" is lost :-)
11:02:10 sfinucan lyarwood: Finally done, though it seems bauzas pipped me to the mark :)
11:02:23 sfinucan nasty old bug indeed
11:02:24 kashyap sfinucan: Just reminding for next time.
11:02:26 lyarwood bauzas: thanks!
11:02:33 lyarwood sfinucan: cheers, np :)
11:02:33 sfinucan sorry, kashyap :'(
11:11:21 openstackgerrit Sergey Nikitin proposed openstack/nova-specs: Restore V3 Diagnostics info https://review.openstack.org/427637
11:15:59 sfinucan johnthetubaguy: What are we doing about https://review.openstack.org/#/c/357190 ?
11:16:41 johnthetubaguy sfinucan: not sure what you mean?
11:16:53 johnthetubaguy oh, its that damm mox things
11:17:01 sfinucan aye :)
11:18:24 johnthetubaguy sfinucan: these bits hurt my eyes a little "mock_domain.undefineFlags.assert_has_calls([mock.call(1)])"
11:18:45 johnthetubaguy assert_called_once_with(1) would be much better
11:19:13 sfinucan derekh - you around?
11:19:21 derekh sfinucan: yup
11:19:57 sfinucan See John's comments above - could you respin https://review.openstack.org/#/c/417227 accordingly
11:20:08 johnthetubaguy its OK, we can do a follow on patch
11:20:26 sfinucan johnthetubaguy: Won't argue with that
11:20:27 johnthetubaguy derekh: its these bits, I think we can make it a lot simpler: https://review.openstack.org/#/c/417227/2/nova/tests/unit/virt/libvirt/test_driver.py@11908
11:20:45 johnthetubaguy derekh: I wouldn't complain normally, but folks might start copying that pattern
11:21:12 derekh johnthetubaguy: ack, I'll push a follow up this morning
11:21:21 johnthetubaguy derekh: awesome, thanks
11:21:35 derekh johnthetubaguy: np
11:21:44 derekh johnthetubaguy: sfinucan thanks both
11:21:45 johnthetubaguy sfinucan: my browsers got out of hand, so I gave up this morning and closed everything!
11:21:49 sfinucan (y)
11:22:57 sfinucan johnthetubaguy: Also, are we proceeding with this change or punting to Pike? https://review.openstack.org/#/c/412634/
11:23:17 sfinucan mriedem's etherpad sugggests the former, but it seems a little late in the day https://etherpad.openstack.org/p/nova-ocata-feature-freeze
11:24:00 johnthetubaguy sfinucan: so we have merged half of it, but its tempting to wait until friday, i.e. pike
11:24:23 sfinucan that would be my gut feeling - it's not critical
11:25:17 jd__ hi there
11:25:33 jd__ could someone give me a hint on what this failure means http://logs.openstack.org/82/405682/8/check/gate-ceilometer-dsvm-tempest-plugin-postgresql-ubuntu-xenial/02f896f/logs/screen-n-sch.txt.gz#_2017-02-01_10_20_33_556 ?
11:25:56 johnthetubaguy sfinucan: so it does stop people from taking large snapshots
11:26:50 johnthetubaguy sfinucan: I am tempted to ask mriedem to make the call
11:28:10 sfinucan johnthetubaguy: sounds fine by me - he's clearly thinking about it anyway, given the Etherpad
11:28:24 openstackgerrit Stephen Finucane proposed openstack/nova: conf: Resolve TODOs in 'database' https://review.openstack.org/393695
11:30:05 johnthetubaguy sfinucan: completeness wise, we have merged half of it already
11:31:36 openstackgerrit Stephen Finucane proposed openstack/nova: rbd: Remove unnecessary 'encode' calls https://review.openstack.org/412356
11:37:19 sfinucan johnthetubaguy: True, but it's still a new feature rather than a regression fix. Definitely happy to let someone else make the decision for me :)
11:37:33 johnthetubaguy sfinucan: its totally a feature
11:47:01 cdent jd__: that's probably this: http://lists.openstack.org/pipermail/openstack-dev/2017-January/111295.html
11:59:15 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/nova: Optimize time during PCI alias parsing process https://review.openstack.org/427145
12:00:30 openstackgerrit John Garbutt proposed openstack/nova: Adopts keystoneauth with glance client. https://review.openstack.org/412634
12:03:59 openstackgerrit John Garbutt proposed openstack/nova: Add service_token for nova-glance interaction https://review.openstack.org/419662
12:06:49 openstackgerrit John Garbutt proposed openstack/nova: Adopts keystoneauth with glance client. https://review.openstack.org/412634
12:06:49 openstackgerrit John Garbutt proposed openstack/nova: Add service_token for nova-glance interaction https://review.openstack.org/419662
12:09:09 openstackgerrit John Garbutt proposed openstack/nova: DNM: Test service token in Glance https://review.openstack.org/419666

Earlier   Later