| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-01-31 | |||
| 13:48:45 | toabctl | mriedem, yes. the test is not executed. | |
| 13:48:58 | toabctl | but then I should reenable the test with my changeset | |
| 13:49:17 | openstackgerrit | Andy McCrae proposed openstack/nova: Allow placement endpoint interface to be set https://review.openstack.org/426163 | |
| 13:49:33 | mriedem | BobBall: ah so i can't use a depends-on like the xenserver ci | |
| 13:49:43 | toabctl | oh. it's on the external CI. so I can not simply change that | |
| 13:49:53 | mriedem | right | |
| 13:50:08 | mriedem | BobBall: we could move that blacklist into the nova tree... | |
| 13:50:09 | toabctl | so I did test that manually on our internal CI... | |
| 13:50:11 | mriedem | then it's branch-specific | |
| 13:50:13 | BobBall | Sorry mriedem, it's not... | |
| 13:50:28 | mriedem | BobBall: like this https://github.com/openstack/nova/blob/master/devstack/tempest-dsvm-lxc-rc | |
| 13:51:04 | mriedem | then that job definition just needs to use the DEVSTACK_GATE_TEMPEST_REGEX variable | |
| 13:51:32 | BobBall | That's nice, but curious because clearly it's not *just* nova implicated with some of the tempest tests - for example there have historically been some tempest tests that only work with libvirt | |
| 13:52:09 | BobBall | i.e. the tests make assumptions about the hypervisor e.g. that it can support qcow2 images made in the test themselves | |
| 13:53:08 | mriedem | right so the tempest defaults are based on the nova defaults, which are libvirt | |
| 13:53:19 | mriedem | if you're not using those defaults, you have to configure stufff | |
| 13:53:34 | mriedem | that doesn't mean we couldn't control the xenproject ci blacklist from within the nova tree | |
| 13:53:42 | BobBall | Indeed - but the case I was thinking about wasn't configurable | |
| 13:55:17 | mriedem | bauzas: rechecked your scheduler stuff, the grenade patch merged before cells v1 broke, but the cells v1 thing is fixed now so all of the rechecks are running | |
| 13:55:36 | bauzas | mriedem: cool, thanks for following that | |
| 13:57:30 | mriedem | oomichi: sdague: johnthetubaguy: want to take a crack at this? i've got a +2 on it https://review.openstack.org/#/c/424759/ | |
| 13:57:43 | mriedem | and the tempest change is approved https://review.openstack.org/#/c/426991/ | |
| 13:58:58 | johnthetubaguy | mriedem: talking a look now, would be good to get that in | |
| 13:59:16 | johnthetubaguy | mriedem: there was a spec to match it too, but thats more a documentation thing at this point I guess? | |
| 13:59:35 | tdurakov | PaulMurray paul-carlton2 eliqiao shaohe_feng pkoniszewski yuntongjin mdbooth kashyap kmartin claudiub tobasco tdurakov abhishekk mrhillsman raj_singh wznoinsk siva_krishnan hi, live-migration subteam meeting in a minute on #openstack-meeting-3 | |
| 14:10:55 | mriedem | johnthetubaguy: the spec was merged yesterday | |
| 14:11:00 | mriedem | johnthetubaguy: the spec was a normal spec | |
| 14:11:13 | mriedem | since it's an api change and we require a spec for api changes | |
| 14:11:23 | johnthetubaguy | mriedem: yep, found that, all good | |
| 14:14:02 | edleafe | cdent: about to get sucked into 4 hours of meetings, but for "moar tests", you could start adding on to https://review.openstack.org/#/c/404472/28/nova/tests/functional/api/openstack/placement/gabbits/ironic-inventory.yaml | |
| 14:14:31 | edleafe | It's just the barest of tests now, but I started it with "moar" in mind | |
| 14:14:32 | cdent | edleafe: reviewing that stuff now, will look | |
| 14:19:47 | cdent | edleafe: I think we need functional tests on the resource tracker side, not the gabbi side? | |
| 14:24:03 | sean-k-mooney | mriedem: regarding os-vif no i dont think there is anything that is outstanding that needs to merge before creating stable/ocata | |
| 14:24:40 | edleafe | cdent: ah, ok. I just had time to briefly read the scrollback. | |
| 14:25:16 | cdent | edleafe: I'll see if I can come up with something. At least think on it. | |
| 14:39:36 | dansmith | hmm, the scheduler patches are still not through the gate? | |
| 14:45:10 | derekh | could somebody put a extra pair of eyes on https://review.openstack.org/#/c/417227/ , its holding back another patch I'm trying to fix | |
| 14:58:47 | johnthetubaguy | dansmith: I think its that nasty gate bug fix that hadn't merged, when I last checked | |
| 14:59:02 | dansmith | which one? is it approved? | |
| 15:03:51 | sfinucan | derekh: Hmm, much as I hate to say it, could you move that patch /after/ the bug patch? | |
| 15:04:31 | sfinucan | I realize that might mean using Mox, but I'm not sure if we can merge a Mox-mock conversion patch first now...? | |
| 15:04:55 | sfinucan | Let's see what johnthetubaguy and/or dansmith think first though | |
| 15:05:45 | johnthetubaguy | sfinucan: I was eyeing that one up, I can try squash it | |
| 15:05:50 | johnthetubaguy | dansmith: one sec, checking | |
| 15:06:32 | johnthetubaguy | dansmith: https://review.openstack.org/#/c/427009/ | |
| 15:06:50 | dansmith | johnthetubaguy: ah okay | |
| 15:09:55 | mdbooth | dansmith: I've had 2 people call me on the N, N-1 upgrade thing in 2 days now: https://review.openstack.org/#/c/423392/ | |
| 15:10:24 | mdbooth | dansmith: Can you confirm I am/am not over-assuming there? | |
| 15:11:02 | dansmith | mdbooth: I think they want you to use versions to enforce the behavior and not just assume right? | |
| 15:17:15 | mriedem | sean-k-mooney: jaypipes: sfinucan: i'm going to put up a releases patch to cut stable/ocata for os-vif today unless you are aware of anything we have to get merged before that happens | |
| 15:17:32 | sfinucan | mriedem: Nothing on my end | |
| 15:18:32 | openstackgerrit | Maciej Szankin proposed openstack/nova: conf: Resolve TODOs in 'database' https://review.openstack.org/393695 | |
| 15:23:26 | sean-k-mooney | mriedem: i dont think anything else needs to be added before the release | |
| 15:23:43 | jaypipes | mriedem: go for it. | |
| 15:27:15 | mriedem | ok, thanks. will do after morning meetings. | |
| 15:28:17 | mdbooth | mriedem: Do we have a concept of a minimum supported service version? | |
| 15:40:20 | mdbooth | johnthetubaguy: Can we hold off on the libvirt+xen thing temporarily? Concerned about adding a quick hack for something that has been broken a long time. Quick hacks tend to last a long time, and are very expensive. Looking now. | |
| 15:41:05 | mdbooth | If this is causing a problem in the gate, could we disable the test again? | |
| 15:43:13 | johnthetubaguy | mdbooth: we could, just seems like a big gain not to have | |
| 15:44:04 | mdbooth | johnthetubaguy: I'm not definitely saying we shouldn't take the patch, just that I'd like to look first at why we need it, especially as ftersin was also concerned about it. | |
| 15:44:35 | johnthetubaguy | mdbooth: you got the link again? | |
| 15:44:40 | mdbooth | Problem is it's adding a new foo(x) returns y normally, but z in this other bizarre situation which nobody will every think of. | |
| 15:44:54 | mdbooth | https://review.openstack.org/#/c/402318/1/nova/virt/libvirt/blockinfo.py | |
| 15:44:55 | johnthetubaguy | I am just cruzing all bugs with a +2 already | |
| 15:45:17 | mdbooth | We have lots of these, and they're just edge-case bug factories. | |
| 15:47:34 | mdbooth | johnthetubaguy: My immediate thought, btw, is your suggestion to fix it during spawn | |
| 16:03:08 | openstackgerrit | Lee Yarwood proposed openstack/nova: libvirt: Limit destroying disks during cleanup to spawn https://review.openstack.org/427267 | |
| 16:05:27 | lyarwood | dansmith, mdbooth ; ^ I'd appreciate your thoughts on https://review.openstack.org/427267 if you have time today | |
| 16:05:48 | mdbooth | lyarwood: It just set my spidey sense tingling :) Was about to look. | |
| 16:06:30 | lyarwood | mdbooth: thanks | |
| 16:08:52 | derekh | sfinucan: sorry was on a call, so do I need to swap the patches around? | |
| 16:09:09 | sfinucan | derekh: No, I think johnthetubaguy is just going to squash them | |
| 16:09:21 | derekh | sfinucan: ok, cool | |
| 16:10:22 | mdbooth | lyarwood: Oof, so a failed reboot would delete the instance? | |
| 16:10:56 | lyarwood | mdbooth: well, failure to plug the vifs during a reboot would delete any local files, yeah | |
| 16:11:06 | mdbooth | Eesh, that's baaaad | |
| 16:13:24 | mdbooth | lyarwood: Compare this change for context: https://review.openstack.org/#/c/389593/2/nova/virt/libvirt/driver.py | |
| 16:13:35 | dansmith | lyarwood: oof, that's from me huh? | |
| 16:13:59 | dansmith | although it's just because I'm calling cleanup where we weren't before | |
| 16:14:10 | mdbooth | I'm -1 on ^^^ because it superficially probably passes the cases we can think of right now, but it depends on the phase of the moon. | |
| 16:14:24 | mdbooth | If we took your change and ^^^, rbd disks would be deleted anyway | |
| 16:15:26 | mdbooth | That's just a comment on why I'm against that sort of thing in general, btw, and I want us to start fixing root causes. | |
| 16:15:51 | dansmith | mdbooth: is this demonstrably worse than what we have today? because I don't think it is, and the bug is pretty bad... | |
| 16:15:58 | mdbooth | At first glance, I think your patch effectively specifies the caller's intent. | |
| 16:16:31 | mdbooth | dansmith: I'm not being clear, I think the *other* patch is bad, and lyarwood's patch is an example of why. | |
| 16:17:47 | mdbooth | dansmith: Sorry, was internally also trying to justify being against https://review.openstack.org/#/c/402318/ | |
| 16:19:48 | lyarwood | dansmith: yeah AFAICT we just didn't make it to cleanup before your patch | |
| 16:20:20 | dansmith | so, to restate, I think we should merge lyarwood's patch | |
| 16:20:50 | lyarwood | cool thanks | |
| 16:20:51 | mdbooth | dansmith: Yeah. Reviewing now. | |
| 16:34:53 | mriedem | sdague: did you see this? http://lists.openstack.org/pipermail/openstack-dev/2017-January/111137.html | |
| 16:35:07 | mriedem | sdague: i was wondering if the new devstack-tools stuff somehow screwed up local.conf for multinode grenade? | |
| 16:35:43 | sdague | mriedem: it's possible, though I thought I had that covered | |
| 16:36:22 | mriedem | we know d-g is setting it http://logs.openstack.org/61/417961/40/check/gate-grenade-dsvm-neutron-multinode-live-migration-nv/8c363cd/console.html.gz#_2017-01-27_23_16_09_271784 | |
| 16:36:26 | sdague | mriedem: where is that job definition | |
| 16:36:26 | mriedem | echo 'export LIVE_MIGRATION_AVAILABLE=True' | |
| 16:37:13 | mriedem | sdague: https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/devstack-gate.yaml#L1674 | |
| 16:37:13 | sdague | is that coming from project-config or d-g? | |
| 16:37:22 | mriedem | echo 'export LIVE_MIGRATION_AVAILABLE=True' is from d- | |