| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-01-30 | |||
| 19:18:09 | mriedem | in that it still works | |
| 19:19:41 | artom | mriedem, indeed... | |
| 19:20:04 | artom | I can only assume Tempest doesn't use the max microversion when actually sending the request | |
| 19:20:18 | artom | (But does use to check what tests to run) | |
| 19:20:42 | mriedem | yeah it uses 2.32 http://logs.openstack.org/51/421251/13/check/gate-tempest-dsvm-neutron-full-ssh/60bb925/logs/tempest.txt.gz#_2017-01-30_15_19_16_672 | |
| 19:21:50 | mriedem | in newton, max_microversion is capped for compute to 2.38 http://logs.openstack.org/51/421251/13/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial-newton/7071652/logs/tempest_conf.txt.gz | |
| 19:22:40 | mriedem | but it still looks like tempest just uses the min | |
| 19:22:48 | mriedem | e.g. 2.37 here http://logs.openstack.org/51/421251/13/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial-newton/7071652/logs/tempest.txt.gz#_2017-01-30_15_29_23_670 | |
| 19:23:25 | artom | That can be something we propose to Tempest - to use the max instead of the min | |
| 19:26:02 | openstackgerrit | Dan Smith proposed openstack/nova: Allow scheduler to run cell host discovery periodically https://review.openstack.org/426826 | |
| 19:27:47 | mriedem | "which re-adds the tag in all the right places." heh | |
| 19:27:57 | mriedem | that makes me think dirty thoughts for some reason | |
| 19:28:45 | artom | mriedem, gooood...? | |
| 19:29:38 | artom | At least I didn't word it about reinserting the missing (dict) member | |
| 19:29:40 | mriedem | actually it makes me think of this https://www.youtube.com/watch?v=FAyDmJvjxbg | |
| 19:30:05 | mriedem | is there anyway we can talk about a bag of dicts? | |
| 19:30:08 | openstackgerrit | Diana Clarke proposed openstack/nova: nova-manage docs: cell_v2 map_cell_and_hosts https://review.openstack.org/421420 | |
| 19:30:08 | openstackgerrit | Diana Clarke proposed openstack/nova: nova-manage docs: cell_v2 verify_instance https://review.openstack.org/421436 | |
| 19:30:09 | openstackgerrit | Diana Clarke proposed openstack/nova: nova-manage docs: cell_v2 delete_cell https://review.openstack.org/421459 | |
| 19:30:09 | openstackgerrit | Diana Clarke proposed openstack/nova: nova-manage docs: cell_v2 discover_hosts https://review.openstack.org/421442 | |
| 19:30:10 | openstackgerrit | Diana Clarke proposed openstack/nova: nova-manage docs: cell_v2 list_cells https://review.openstack.org/421458 | |
| 19:30:10 | openstackgerrit | Diana Clarke proposed openstack/nova: nova-manage docs: cell_v2 create_cell https://review.openstack.org/421444 | |
| 19:30:59 | artom | We could conceivable describe the request body as a bad of dicts | |
| 19:42:13 | mriedem | ooo i see abug | |
| 19:46:38 | mriedem | artom: comments in https://review.openstack.org/#/c/424759/ | |
| 19:46:58 | mriedem | artom: the -1 is for https://review.openstack.org/#/c/424759/9/nova/api/openstack/compute/schemas/servers.py@31 for sure | |
| 19:47:41 | artom | mriedem, "If we need further clarification we have this I guess..." oy with the sarcasm ;) | |
| 19:47:51 | mriedem | well, | |
| 19:47:57 | mriedem | not trying to be sarcastic, | |
| 19:48:00 | mriedem | if you look at the api-ref | |
| 19:48:06 | artom | Heh, you are right though | |
| 19:48:24 | mriedem | look at the description for networks.tag here http://developer.openstack.org/api-ref/compute/?expanded=create-server-detail#id7 | |
| 19:48:30 | artom | I think I was trying to be generic, because... reasons, I guess? | |
| 19:48:34 | mriedem | and block_device_mapping_v2.tag | |
| 19:48:53 | mriedem | generic is fine, and what you have in the api-ref is good | |
| 19:49:01 | mriedem | i'm on the fence about over documenting this to death | |
| 19:49:56 | artom | Surely more docs is better? | |
| 19:50:03 | mriedem | probably | |
| 19:50:25 | mriedem | you might want to make those specific parameter types then though | |
| 19:50:41 | artom | What would we gain by mentioning it less? Someone's bound to run into this, we might as well make the explanation of wtf happened as accessible as possible | |
| 19:50:52 | mriedem | so for device_network_tag you just make the comment about 2.32-2.36, and for device_bdm_tag you make the comment about 2.32 | |
| 19:51:12 | mriedem | know what i mean? | |
| 19:51:24 | artom | Aha, and then set the correct min and max version on each | |
| 19:51:27 | mriedem | yeah | |
| 19:51:28 | artom | Yep, I agree | |
| 19:51:31 | mriedem | since device_tag is used for both right now | |
| 19:51:39 | artom | Well | |
| 19:51:46 | artom | min, max, and min again | |
| 19:51:51 | artom | If I can manage that | |
| 19:52:02 | mriedem | fwiw i don't know if the sphinx plugin supports a max_version | |
| 19:52:19 | mriedem | sdague: do you know if there is a max_version for https://review.openstack.org/#/c/424759/9/api-ref/source/parameters.yaml@1506 ? | |
| 19:52:29 | mriedem | oh there is | |
| 19:52:29 | mriedem | nvm | |
| 19:52:45 | mriedem | artom: i don't think you can do min and max and then min again | |
| 19:53:04 | mriedem | so probably just min-version: 2.32, and then notes in the description about the snafu between 2.32 and 2.42 | |
| 19:54:09 | artom | mriedem, maybe if I split it again into nic_tag_2.32-2.37 and another one... | |
| 19:54:14 | artom | Worth it? | |
| 19:54:26 | mriedem | then we have the same parameter listed in the table twice | |
| 19:54:33 | artom | Or will it just be more confusing then writing it in English words | |
| 19:54:39 | artom | *than | |
| 19:54:48 | mriedem | i think english be gooder | |
| 19:55:01 | mriedem | sorry, *me think* | |
| 20:04:10 | artom | The schema deepcopy thing is a minefield :( | |
| 20:04:31 | artom | You caught the network uuid checking, presumably because you wrote 2.37 yourself | |
| 20:04:49 | mriedem | artom: exactly | |
| 20:05:09 | mriedem | artom: the tempest guys stopped doing the deepcopy i think | |
| 20:05:10 | mriedem | for this very reason | |
| 20:05:23 | mriedem | oomichi: right? ^ | |
| 20:06:52 | artom | Maybe I'll remove the network_type refactoring then and stick to copy-pasting | |
| 20:08:00 | oomichi | mriedem: yeah, you are right. gmann takes care of it on Tempest side | |
| 20:09:01 | oomichi | mriedem: that requrest came from sdague and mtreinish because the deepcopy of schema seems unreadable to know whole schema on each microversion | |
| 20:17:17 | mriedem | hmm, what's a better place for the nova-status CLI in the release notes, features or upgrades? | |
| 20:17:31 | mriedem | i assume the upgrades section gets more reads | |
| 20:18:46 | dansmith | yeah, probably | |
| 20:18:48 | dansmith | hopefully anyway | |
| 20:19:11 | dansmith | the placement patches got reset so they're still in the running | |
| 20:19:24 | dansmith | I'm going to wander off for a bit and will come back to check on them | |
| 20:20:10 | openstackgerrit | Artom Lifshitz proposed openstack/nova: Pass APIVersionRequest to extensions https://review.openstack.org/425876 | |
| 20:20:11 | openstackgerrit | Artom Lifshitz proposed openstack/nova: Fix tag attribute disappearing in 2.33 and 2.37 https://review.openstack.org/424759 | |
| 20:24:10 | edleafe | jaypipes: Found a test failure in https://review.openstack.org/#/c/404472/ due to an incomplete test I added. Do you want me to remove it, or are you working on anything else with that patch? | |
| 20:29:33 | bauzas | mriedem: I wrote about the nova-status in the prelude | |
| 20:30:00 | bauzas | mriedem: https://review.openstack.org/#/c/426864/ | |
| 20:30:12 | mriedem | was coincidentally reading that now | |
| 20:30:28 | jaypipes | edleafe: please go ahead! | |
| 20:31:23 | bauzas | mriedem: about the nova-status CLI, I think we should provide a 'feature' section | |
| 20:31:49 | bauzas | mriedem: "upgrade" section is just for discussing about what to need to modify before upgrading | |
| 20:32:04 | bauzas | mriedem: but you could still add a separate section if you want too | |
| 20:32:19 | mriedem | bauzas: i assume operators are more likely to read the upgrades release notes first, | |
| 20:32:26 | mriedem | and we want them using nova-status prior to upgrading | |
| 20:32:34 | mriedem | so seems best to just have it in the upgrade section | |
| 20:32:38 | bauzas | mriedem: sure, but the upgrades section will be huge | |
| 20:32:42 | mriedem | i didn't really want to mention the exact same thing in both ugprades and features | |
| 20:32:47 | bauzas | mriedem: so that's why I provided the prelude | |
| 20:32:48 | mriedem | it already is... | |
| 20:33:03 | bauzas | mriedem: so I think operators would see that by the prelude | |
| 20:33:57 | dtp | anyone need anything? cup of coffee, etc | |
| 20:34:05 | mriedem | just had one thanks | |
| 20:34:14 | mriedem | bauzas: ok i guess i can rebase my reno on top of yours | |
| 20:34:51 | mriedem | bauzas: and your reno needs a rebase too because your change and dan's change below it are both adding something to the prelude about cells v2 | |
| 20:35:23 | bauzas | mriedem: fine by me, which rebase? | |