| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-01-24 | |||
| 06:21:56 | Kevin_Zheng | what I want to do is to test adding tags for virt devices for version 2.37 | |
| 06:22:30 | Kevin_Zheng | because we did it wrong in version 237 before | |
| 06:23:18 | gmann | Kevin_Zheng: yea, in 2.37 file it is fine | |
| 06:23:42 | gmann | Kevin_Zheng: and you can add tests with higher version also by using the same 2.37 json file | |
| 06:24:02 | gmann | 2.40 json file is not needed i think | |
| 06:24:15 | Kevin_Zheng | hmm, maybe I can create two servers in 2.37 json? | |
| 06:24:35 | gmann | Kevin_Zheng: 2 servers means ? | |
| 06:24:42 | Kevin_Zheng | because in 237 we actually tested using "auto" for networks, | |
| 06:24:58 | Kevin_Zheng | we cannot add tag to network parameter | |
| 06:25:09 | Kevin_Zheng | thats why I added another one | |
| 06:25:45 | Kevin_Zheng | and it seems the test structure can only read file name with server-create-req.json | |
| 06:25:53 | gmann | Kevin_Zheng: you can change that auto to what you want to tests - https://github.com/openstack/nova/blob/master/nova/tests/functional/api_sample_tests/api_samples/servers/server-create-req-v237.json.tpl | |
| 06:26:30 | gmann | Kevin_Zheng: under 2.37, auto bits are being tested alone - https://github.com/openstack/nova/blob/master/nova/tests/functional/api_sample_tests/api_samples/servers/v2.37/server-create-req.json.tpl | |
| 06:26:53 | Kevin_Zheng | yeah, I did that in the last patchset | |
| 06:27:03 | Kevin_Zheng | no before the last | |
| 06:27:11 | gmann | Kevin_Zheng: ok | |
| 06:27:21 | Kevin_Zheng | but the compuete node seems not supported tagging | |
| 06:27:57 | Kevin_Zheng | could you have a check and maybe show me how to fix it? because I tried alittle but failed so I tried this way | |
| 06:28:22 | gmann | Kevin_Zheng: sure, ll look | |
| 06:28:22 | Kevin_Zheng | patchset 5 | |
| 06:34:39 | openstackgerrit | Moshe Levi proposed openstack/nova: Remove mox in network/test_linux_net.py https://review.openstack.org/316427 | |
| 06:39:52 | openstackgerrit | Wang Qing wu proposed openstack/nova: WIP(6): Introduce base PowerVM driver (ssp drv) https://review.openstack.org/422594 | |
| 06:43:29 | satyar | Hi jaypipes | |
| 06:44:03 | satyar | jaypipes around | |
| 06:46:29 | gmann | Kevin_Zheng: that is strange for me, functional tests runs with fake driver | |
| 06:51:52 | Kevin_Zheng | gmann: yeah, Thanks | |
| 06:52:49 | alex_xu | Kevin_Zheng: just checked https://review.openstack.org/#/c/415330/17, that is what I expected. | |
| 06:53:15 | satyar | Kevin_Zheng is the nova_api_cell0 changed to nova_cell0 now? | |
| 06:53:22 | Kevin_Zheng | alex_xu: thanks, then lets work on the tests | |
| 06:53:40 | alex_xu | Kevin_Zheng: thanks for working on it | |
| 06:53:44 | Kevin_Zheng | satyar: sorry I think you asked the wrong person | |
| 06:53:54 | satyar | :P sorry | |
| 06:54:10 | satyar | alex_xu | |
| 06:54:51 | satyar | i saw some changes from Dan Smith | |
| 06:54:59 | satyar | not sure whats the handler here | |
| 06:55:47 | alex_xu | satyar: dansmith is right person to answer that, but I saw this patch https://review.openstack.org/#/c/420437/ | |
| 06:57:07 | satyar | Thanks alex_xu | |
| 06:57:28 | alex_xu | satyar: np | |
| 06:59:32 | satyar | Hi dansmith | |
| 07:00:51 | openstackgerrit | Béla Vancsics proposed openstack/nova: Reduce code duplication https://review.openstack.org/342187 | |
| 07:08:28 | openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add new policy for server list/detail with all_tenants https://review.openstack.org/415330 | |
| 07:13:04 | moshele | alex_xu: hi can you review https://review.openstack.org/#/c/423608/ ? | |
| 07:46:10 | alex_xu | moshele: just add it to my list | |
| 07:46:34 | moshele | alex_xu: thanks :) | |
| 07:47:35 | alex_xu | moshele: np | |
| 08:26:44 | alex_xu | gmann: just prepare to send a mail about the device tag | |
| 08:28:40 | gmann | alex_xu: nice, thanks. | |
| 08:29:10 | gmann | alex_xu: looks like some issue in functional tests also. debugging that | |
| 08:31:04 | alex_xu | gmann: let us put all the info in the mail and discuss at here | |
| 08:31:08 | alex_xu | s/here/there/ | |
| 08:32:07 | gmann | alex_xu: +1 | |
| 08:54:44 | snikitin | alex_xu: Hi, Alex! I changed a file name in diagnostics patch and lost your +2 :( Can you look again please? Also I left a comment about your proposal for docs https://review.openstack.org/#/c/355540/ | |
| 08:55:13 | alex_xu | snikitin: ok, I will check that | |
| 08:55:58 | snikitin | thanks! | |
| 09:13:41 | openstackgerrit | Ildiko Vancsa proposed openstack/nova: Implement new attach/detach Cinder flow https://review.openstack.org/330285 | |
| 09:14:34 | openstackgerrit | Ildiko Vancsa proposed openstack/nova: Implement new attach/detach Cinder flow https://review.openstack.org/330285 | |
| 09:14:36 | openstackgerrit | Ildiko Vancsa proposed openstack/nova: Remove check_attach https://review.openstack.org/335358 | |
| 09:31:10 | moshele | sfinucan: hi can you review this https://review.openstack.org/#/c/423608/ | |
| 09:31:33 | sfinucan | moshele: Sure | |
| 09:32:01 | openstackgerrit | Hironori Shiina proposed openstack/nova: Ironic: Add soft power off support to Ironic driver. https://review.openstack.org/407977 | |
| 09:42:58 | sfinucan | moshele: Done | |
| 09:45:35 | moshele | sfinucan: thanks | |
| 09:47:11 | sfinucan | bauzas: Could you take a look at https://review.openstack.org/#/c/419479 when you have a moment? | |
| 09:47:34 | bauzas | sfinucan: currently under the water because of the scheduler upcall, but I'll try | |
| 09:47:55 | sfinucan | bauzas: No panic at all. Priorities :) | |
| 09:50:35 | bauzas | sfinucan: I'm just investigating a grenade issue, hopefully to sort it out soonish | |
| 09:58:42 | johnthetubaguy | bauzas: I have added a few ideas on that call placement from scheduler thing: https://review.openstack.org/#/c/417961 | |
| 09:59:09 | johnthetubaguy | bauzas: FWIW, the caching scheduler looks correct to me | |
| 10:00:35 | bauzas | johnthetubaguy: lemme look at | |
| 10:09:07 | johnthetubaguy | mdbooth: was reading your comment on here: https://review.openstack.org/#/c/408002 | |
| 10:09:13 | johnthetubaguy | mdbooth: very, very valid | |
| 10:09:45 | bauzas | johnthetubaguy: got a few mins for discussing about https://review.openstack.org/#/c/417961 ? | |
| 10:09:48 | johnthetubaguy | mdbooth: I thought of a slight alternative, we could update the config option docs to very clearly state there are 10 steps | |
| 10:10:22 | mdbooth | johnthetubaguy: I wonder if anybody has ever tuned this, tbh. | |
| 10:10:44 | johnthetubaguy | mdbooth: most people just tune the 500 total timeout, AFAIK | |
| 10:11:00 | johnthetubaguy | mdbooth: kill it all might be a better solution (i.e. just hard code it) | |
| 10:11:16 | johnthetubaguy | bauzas: sure thing | |
| 10:11:45 | bauzas | johnthetubaguy: so, AFAICU we're discussing on how to have a right interface | |
| 10:12:27 | mdbooth | We could add a new config variable which is a total, and immediately deprecate the old 2. The new value will default to the product of the deprecated values if not set explicitly. We hardcode 10 steps. | |
| 10:13:45 | bauzas | johnthetubaguy: so, you'd prefer to have https://review.openstack.org/#/c/417961/19/nova/scheduler/host_manager.py@635 in the scheduler report client ? | |
| 10:14:05 | mdbooth | johnthetubaguy: If this is up against the wire I can probably write that today myself, btw. Is this on anybody's radar? | |
| 10:14:18 | johnthetubaguy | mdbooth: we already have the total as a config setting I think, thats the delay between steps, not the size of the steps | |
| 10:14:37 | johnthetubaguy | mdbooth: pkoniszewski is usually responsive if he is around | |
| 10:14:42 | mdbooth | I don't think there's a total time, it's calculated. | |
| 10:15:08 | pkoniszewski | I'm around | |
| 10:15:16 | pkoniszewski | yeah, I also agree with mdbooth comment, very good point | |
| 10:15:41 | johnthetubaguy | bauzas: I think I would like to see the scheduler directly call the placement client, then pass the return value into the host_state to get back the list of objects | |
| 10:15:56 | johnthetubaguy | bauzas: it could go into the scheduler or the placement client I think | |
| 10:16:09 | johnthetubaguy | mdbooth: I think live_migration_downtime is the config I mean | |
| 10:16:15 | bauzas | johnthetubaguy: you mean the scheduler driver, not the host manager ? | |
| 10:16:27 | bauzas | johnthetubaguy: so we could just drill down a list of hosts to the host manager? | |
| 10:16:31 | johnthetubaguy | mdbooth: there is the total timeout, and the time to reach the total timeout in the steps | |
| 10:16:54 | bauzas | johnthetubaguy: I need to consider that if so | |
| 10:16:58 | johnthetubaguy | mdbooth: given we also define a time after which the live-migrate is considered failed and we give up, we could use that to define the steps | |
| 10:17:13 | bauzas | johnthetubaguy: I actually made that split because of the CachingScheduler, but lemme think about that loud | |
| 10:17:19 | pkoniszewski | johnthetubaguy: live migration timeout can be set to 0 to disable it | |
| 10:17:22 | johnthetubaguy | bauzas: I think we would pass resource providers into the host manager | |
| 10:17:30 | pkoniszewski | johnthetubaguy: however, nova still needs to increase downtime over time | |
| 10:17:33 | bauzas | johnthetubaguy: I'm not sure I like that | |
| 10:17:33 | johnthetubaguy | bauzas: it shouldn't affect the caching scheduler | |