Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-01-23
04:27:37 openstackgerrit Takashi NATSUME proposed openstack/nova: api-ref: Fix keypair API parameters https://review.openstack.org/420626
04:27:41 openstackgerrit Takashi NATSUME proposed openstack/nova: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042
04:27:46 openstackgerrit Takashi NATSUME proposed openstack/nova: Avoid forcing translation on logging calls https://review.openstack.org/413876
04:27:48 openstackgerrit Takashi NATSUME proposed openstack/nova: Refactor a test method including 3 test cases https://review.openstack.org/394738
04:27:53 openstackgerrit Takashi NATSUME proposed openstack/nova: api-ref: Fix parameters in os-hosts.inc https://review.openstack.org/416444
05:53:10 openstackgerrit Takashi NATSUME proposed openstack/nova: Use ListOfIntegersField in oslo.versionedobjects https://review.openstack.org/423912
06:17:19 openstackgerrit zhangyanxian proposed openstack/nova-specs: Delete the unnecessary word in pcs-support.rst https://review.openstack.org/423927
06:17:49 openstackgerrit zhangyanxian proposed openstack/nova-specs: Delete the unnecessary word in pcs-support.rst https://review.openstack.org/423927
06:31:25 openstackgerrit Hussain Chachuliya proposed openstack/nova: Fix 500 error while passing 4-byte unicode data https://review.openstack.org/407514
06:56:34 openstackgerrit zhurong proposed openstack/python-novaclient: Fix client can not auth with token https://review.openstack.org/423946
07:08:34 openstackgerrit Zhenyu Zheng proposed openstack/nova: Fix device taging after API microversion 2.37 https://review.openstack.org/423952
07:34:48 openstackgerrit Zhenyu Zheng proposed openstack/nova: Add sort_key white list for server list/detail https://review.openstack.org/415142
07:52:21 openstackgerrit Wang Qing wu proposed openstack/nova: WIP(5): Introduce base PowerVM driver (ovs vif) https://review.openstack.org/422512
08:02:45 snikitin BobBall: Hi, Bob! Could you please look at Xen diagnostics again? https://review.openstack.org/#/c/399613/ Citrix XenServer CI is finally green! https://review.openstack.org/#/c/413606/
08:10:47 openstackgerrit gengchc2 proposed openstack/nova: Improved-the-judgment-of-the-service-status-in-memcache https://review.openstack.org/423754
08:12:52 openstackgerrit Pawel Koniszewski proposed openstack/nova: live-mig: Add claims and proper resource tracking https://review.openstack.org/244489
08:12:54 openstackgerrit Pawel Koniszewski proposed openstack/nova: libvirt: pass libvirt reference methods to migration https://review.openstack.org/328997
08:12:55 openstackgerrit Pawel Koniszewski proposed openstack/nova: libvirt: live-migrate updates NUMA and cpus in the XML https://review.openstack.org/286744
08:28:13 openstackgerrit Zhenyu Zheng proposed openstack/nova: Fix device taging after API microversion 2.37 https://review.openstack.org/423952
08:34:41 openstackgerrit Zhenyu Zheng proposed openstack/nova: Fix device taging after API microversion 2.37 https://review.openstack.org/423952
08:38:54 openstackgerrit sahid proposed openstack/nova: numa: add numa constraints for emulator threads policy https://review.openstack.org/385023
08:38:57 openstackgerrit sahid proposed openstack/nova: libvirt: return a CPU overhead if isolate emulator threads requested https://review.openstack.org/385364
08:38:57 openstackgerrit sahid proposed openstack/nova: objects: add new field cpuset_reserved in NUMACell https://review.openstack.org/400874
08:38:58 openstackgerrit sahid proposed openstack/nova: numa: fit instance topology with cpus reserved onto cores https://review.openstack.org/400875
08:38:58 openstackgerrit sahid proposed openstack/nova: virt: update overhead to take into account vCPUs https://review.openstack.org/385024
08:39:01 openstackgerrit sahid proposed openstack/nova: libvirt: make emulator threads to run on the reserved pCPU https://review.openstack.org/400878
08:39:01 openstackgerrit sahid proposed openstack/nova: numa: take into account cpus reserved https://review.openstack.org/400876
08:39:02 openstackgerrit sahid proposed openstack/nova: numa: update numa usage incording the cpu reserved https://review.openstack.org/400877
08:44:20 openstackgerrit Zhenyu Zheng proposed openstack/nova: Add sort_key white list for server list/detail https://review.openstack.org/415142
08:59:31 openstackgerrit Istvan Imre proposed openstack/python-novaclient: Pass relevant parameters to Token based authentication https://review.openstack.org/419441
09:26:16 openstackgerrit Zhenyu Zheng proposed openstack/nova: Fix device taging after API microversion 2.37 https://review.openstack.org/423952
09:42:54 openstackgerrit gengchc2 proposed openstack/nova: Improved-the-judgment-of-the-service-status-in-memcache https://review.openstack.org/423754
09:46:42 openstackgerrit Duong Ha-Quang proposed openstack/nova: Remove mox in nova/tests/unit/compute/test_shelve.py (3) https://review.openstack.org/342648
09:49:28 sfinucan Morning, mdbooth. Any chance you could take a gawk at https://review.openstack.org/#/c/392643/ when you have a chance?
09:49:43 openstackgerrit Rikimaru Honjo proposed openstack/nova: Consolidate unit tests for shelve API https://review.openstack.org/421220
09:55:03 alex_xu johnthetubaguy: gmann Kevin_Zheng, I guess we need some discussion on https://review.openstack.org/#/c/415330/16/nova/policies/servers.py for making progress, are you guys around?
09:55:11 pkoniszewski hello, can I have some eyes on this series https://review.openstack.org/#/q/topic:lm-downtime ? Freeze is near, those 3 are simple patches to increase live migration success rate and reduce configuration complexity
09:55:46 Kevin_Zheng alex_xu: you can represent me :), I'm about to driving
09:56:17 alex_xu Kevin_Zheng: yea, just focus on driving :)
09:58:36 mikal were
09:58:42 mikal Doh, sorry
10:03:30 snikitin BobBall: thank you for review!
10:03:53 BobBall snikitin: Thank you for your perseverence with the CI ;)
10:04:25 gmann alex_xu: hi
10:04:43 gmann alex_xu: actually problem is we cannot not know whether rule is overridden or not right?
10:04:57 bauzas johnthetubaguy: hola, got a sec ?
10:05:13 bauzas johnthetubaguy: not sure you saw my ML thread about the placement API
10:05:33 gmann alex_xu: it can be with same default value RULE_ADMIN_API and operator can claim this was our overridden value why you broke us
10:05:41 bauzas johnthetubaguy: http://lists.openstack.org/pipermail/openstack-dev/2017-January/110661.html
10:05:57 alex_xu gmann: I thought we have some way, just like this https://github.com/openstack/oslo.policy/blob/master/oslo_policy/generator.py#L216
10:06:02 bauzas johnthetubaguy: but I'd love your operator insights, in particular wrt the CachingScheduler
10:07:51 gmann alex_xu: yea but if they have overridden with RULE_ADMIN_API then they expect to work on same way which makes 1st and 2nd case same
10:08:11 openstackgerrit Duong Ha-Quang proposed openstack/nova: Remove mox in nova/tests/unit/compute/test_shelve.py (3) https://review.openstack.org/342648
10:09:33 gmann alex_xu: making old rule to RULE_ANY breaks the old operator as johnthetubaguy pointed
10:11:35 alex_xu gmann: so we expect 1st and 2nd cases work as old behaviour?
10:12:01 lyarwood reviews on the following findmnt removal change would be appreciated if anyone has time, currently hitting EL based distros pretty hard - https://review.openstack.org/#/c/420146/
10:12:10 gmann alex_xu: only 1st but it is hard to differentiate those cases
10:12:50 alex_xu gmann: so we expect 2nd case as new behaviour
10:13:23 gmann alex_xu: yea
10:14:13 alex_xu gmann: if we can check whether there is override, then we can implement all three cases.
10:15:12 gmann alex_xu: even override with default value we consider that as 1st case right ?
10:15:49 alex_xu gmann: yes, I think it is fine
10:16:11 alex_xu gmann: that is way for operator to enforce a old behaviour
10:16:29 gmann alex_xu: so how to check if overridden ?
10:16:58 alex_xu gmann: i'm thinking this way https://github.com/openstack/oslo.policy/blob/master/oslo_policy/generator.py#L176
10:17:37 alex_xu gmann: if the rule in the enforcer.file_rules, then it should mean the rule in the policy.json
10:19:35 gmann alex_xu: but i think we say, generate the policy with all default rules and then override if needed, it means all rules will be in policy.json ?(not sure how operator prepare policy.json)
10:19:35 sahid jaypipes: could you ack https://review.openstack.org/#/c/400874 i repin it to change the variable name
10:19:56 gmann i am just assuming how people use config file
10:24:20 alex_xu gmann: we expect the policy.json empty. the policy.json should only have override rule
10:24:21 gmann alex_xu: like this - http://docs-draft.openstack.org/30/415330/16/check/gate-nova-docs-ubuntu-xenial/13f51ca//doc/build/html/sample_policy.html
10:24:36 gmann alex_xu: and operator just override the interested one
10:24:58 gmann alex_xu: but m not sure about that this is how they use or they have only overriden rules in policy.json
10:27:13 alex_xu gmann: if the user really have override rule, there will be a warning message :)
10:28:31 gmann alex_xu: yea that case is fine as you said but if anyone assuming overridden rule even with default value only and expect to work same way
10:29:10 gmann they do not believe the nova policy default values and want to make sure by overriding the rule even with same default value
10:30:04 claudiub|2 sfinucan: moshele: hello. If you have a tiny bit of time, can you take a look at the hyper-v pci passthrough patch? it is quite small too: https://review.openstack.org/#/c/420614/
10:32:07 sfinucan claudiub|2: Just back from vacation so I'm chowing down on (a crazy amount of) mails and other reviews. If you stick me on the review though, I'll aim to get around to it today or tomorrow
10:32:39 claudiub|2 sfinucan: sure, ty. :)
10:34:01 alex_xu gmann: emmm....maybe johnthetubaguy and sdague can ensure that whether we expect a empty policy.json for new installation
10:35:27 mdbooth sfinucan: Looking now.
10:36:35 mdbooth sfinucan: Incidentally, this one needs to get into Ocata: https://review.openstack.org/#/c/423392/ . It's a continuation of a previous code removal. Needs to be phased for upgrades, hence need for Ocata.
10:36:50 mdbooth It's very simple.
10:37:37 sfinucan mdbooth: Sure thing. I'll chuck that on my review queue :)
10:41:03 gmann alex_xu: yea, that will be nice to know for me too
10:47:19 moshele claudiub|2: sure I will take a look later today
10:51:33 cdent bauzas, jaypipes : was just reading back through the log about something to do with noauthmiddleware and fixtures and placement, but can't really piece together the gist. Were you able to work things out?
10:51:45 bauzas cdent: I fixed the problem
10:52:01 bauzas cdent: it was merged on Friday by adding a PlacementFixture
10:52:39 cdent bauzas: In any case there is a functional test of placement api that does not use gabbi: https://github.com/openstack/nova/blob/master/nova/tests/functional/api/openstack/placement/test_report_client.py
10:52:40 bauzas cdent: now I have another question about having resource usage call being optionals given the existing filters
10:52:55 bauzas cdent: I know
10:53:01 cdent bauzas: and the noauthmiddleware is _not_ something I wrote special, it is the nova one adapted
10:53:06 cdent do you have a link to the new fixture?
10:53:12 cdent (I mean the review that made it)
10:53:15 bauzas cdent: the problem was with the existing other functional tests that call the scheduler
10:53:35 bauzas cdent: see nova.fixtures.PlacementFixture
10:53:39 cdent Yeah, I've seen the mail about the optionals, it's next on my list to look at more closely
10:53:56 bauzas cdent: I'll be pushing a new PS by today
10:54:00 cdent cool

Earlier   Later