Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-01-18
09:39:36 gmann Kevin_Zheng: alex_xu we can strict for enum(desc, asc)
09:39:55 gmann Kevin_Zheng: alex_xu can we do date-time for created_at etc in https://review.openstack.org/#/c/420494/
09:40:18 Kevin_Zheng I think the current bp is about to not limit those
09:40:32 gmann Kevin_Zheng: in case you can run non date-time string for created_at and it 500
09:40:46 Kevin_Zheng and we already response 400 for sort dir
09:41:01 gmann Kevin_Zheng: not limiting but i doubt it 500 currently same for created_at
09:41:02 Kevin_Zheng didnt dive too deep to find where that happened though
09:41:18 gmann Kevin_Zheng: on sort_dir yes that why we can do on schema side, no need to go deep to get 400
09:45:01 gmann Kevin_Zheng: alex_xu here - https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L2489
09:45:07 gmann we can just do on schema side
09:47:52 Kevin_Zheng I tested created at
09:48:01 Kevin_Zheng it will not return 500
09:50:24 gmann then we should make this also 400 like other strict validation in that patch, same for launched_at and terminated_at?
09:50:51 Kevin_Zheng yeah
09:51:03 Kevin_Zheng I think it will be ok with the current path
09:51:39 Kevin_Zheng will be a strict limit with microversion afterwards. I think thats the plan, if I rememered correctly
09:51:56 Kevin_Zheng the current is about to not affect current behavior
09:56:29 tovin07 jaypipes, i rebase this patch (OSprofiler in Nova), could you review it? https://review.openstack.org/#/c/254703/ thanks!
09:57:07 tovin07 because it conflict with recent merged
09:59:53 openstackgerrit Vasyl Saienko proposed openstack/nova: Support Ironic interface attach/detach in nova virt https://review.openstack.org/364413
10:02:19 openstackgerrit Takashi NATSUME proposed openstack/nova: api-ref: Fix a parameter in os-availability-zone.inc https://review.openstack.org/417233
10:02:48 openstackgerrit Vasyl Saienko proposed openstack/nova: Implement interface attach/detach in ironic virt driver https://review.openstack.org/419975
10:03:02 openstackgerrit Vasyl Saienko proposed openstack/nova: Generate necessary network metadata for ironic port groups https://review.openstack.org/388756
10:13:36 openstackgerrit Zhenyu Zheng proposed openstack/nova: Add sort_key white list for server list/detail https://review.openstack.org/415142
10:16:05 gmann Kevin_Zheng: opps, i mis read about created_at return 500, if not 500 then it should not be modified as you said. thanks
10:16:25 openstackgerrit Zhenyu Zheng proposed openstack/nova: Add release note and docs for filter/sort whitelist https://review.openstack.org/421760
10:18:14 openstackgerrit zhangyujun proposed openstack/nova: Query parameter validation for hosts API https://review.openstack.org/418880
10:35:45 openstackgerrit Béla Vancsics proposed openstack/nova: Transform instance.trigger_crash_dump notification https://review.openstack.org/396225
10:37:29 openstackgerrit Claudiu Belu proposed openstack/nova: Hyper-V PCI Passthrough https://review.openstack.org/420614
10:49:48 openstackgerrit Claudiu Belu proposed openstack/nova: Adds CPUFeaturesField to ImageMetaProps https://review.openstack.org/420960
11:02:03 openstackgerrit Alvaro Lopez Garcia proposed openstack/nova: Ensure that periodic reclaim cleans DB deleted instances https://review.openstack.org/323250
11:04:03 openstackgerrit Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(2/2) https://review.openstack.org/408964
11:05:10 openstackgerrit Takashi NATSUME proposed openstack/nova: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042
11:05:15 openstackgerrit Takashi NATSUME proposed openstack/nova: Add functional tests for cold migration to same host https://review.openstack.org/414926
11:05:39 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient: Microversion 2.42 - Enable cold migration with target host https://review.openstack.org/406707
11:10:43 alex_xu Kevin_Zheng: yea, that is the plan
11:31:13 openstackgerrit Takashi NATSUME proposed openstack/nova: api-ref: Fix keypair API parameters https://review.openstack.org/420626
11:32:57 openstackgerrit Sylvain Bauza proposed openstack/nova: Add ComputeNodeList.get_all_by_uuids method https://review.openstack.org/418134
11:32:57 openstackgerrit Sylvain Bauza proposed openstack/nova: WIP: Scheduler calling the Placement API https://review.openstack.org/417961
11:38:03 tdurakov gibi: hi, are you around?
11:44:39 gibi tdurakov: hi
11:45:25 tdurakov gibi: smth related to notifications subteam, I believe: https://bugs.launchpad.net/nova/+bug/1657428
11:45:25 openstack Launchpad bug 1657428 in OpenStack Compute (nova) "Nova sends notifications with different timestamp formats" [Undecided,New]
11:46:14 gibi tdurakov: you are right, this is notification problem
11:46:41 gibi tdurakov: I will look into this bug
11:46:51 gibi tdurakov: thanks for notifying
11:48:34 tdurakov gibi, this one shouldn't be a big deal, do you need my help fixing this?
11:51:59 gibi tdurakov: if you want to fix it then go ahead and just add me as a reviewer
11:52:22 tdurakov gibi, yeah, why not)
11:55:12 gibi tdurakov: for me the interesting thing is that why created_at and launched_at has different format
11:55:16 jroll mriedem: so, https://review.openstack.org/#/c/364413/ doesn't actually enable "nova port-attach" or whatever for ironic, it's changing stuff over to an ironic API to attach/detach vifs, so suspect you're testing the wrong thing there. also suspect we have a tempest regex for that job.
11:55:26 gibi tdurakov: those fields are copied from the instance object directly
11:55:30 openstackgerrit Claudiu Belu proposed openstack/nova: hyper-v: Adds support for VMs with nested virtualization https://review.openstack.org/398509
11:55:55 tdurakov gibi, yeah, that's strange
11:56:20 jroll mriedem: I think you want to test this, which 1) I don't expect to land this cycle, and 2) will need some devstack changes to give our VMs another nic. https://review.openstack.org/#/c/419975/5
11:56:43 jroll mriedem: that said, 364413 is tested in check queue, every boot will hit that new code path
12:05:19 gibi tdurakov: audit period values are generated here https://github.com/openstack/nova/blob/master/nova/notifications/base.py#L308
12:17:15 openstackgerrit Zhenyu Zheng proposed openstack/nova: Add sort_key white list for server list/detail https://review.openstack.org/415142
12:17:40 openstackgerrit Zhenyu Zheng proposed openstack/nova: Add new policy for server list/detail with all_tenants https://review.openstack.org/415330
12:17:51 openstackgerrit Zhenyu Zheng proposed openstack/nova: Strict pattern match query parameters https://review.openstack.org/420494
12:23:15 cdent Kevin_Zheng: if you agree with my last coment on https://review.openstack.org/#/c/410128/ can you abandon that?
12:24:03 Kevin_Zheng cdent: ah yes, I was
12:24:21 Kevin_Zheng Going to but distracted by something else
12:30:44 openstackgerrit John Garbutt proposed openstack/nova: WIP: Call preallocate_for_instance before scheduler https://review.openstack.org/413124
12:41:19 johnthetubaguy alex_xu: I was looking at: https://review.openstack.org/#/c/408571
12:41:34 johnthetubaguy alex_xu: wondering where we raise 400 errors for _foo like properties
12:41:44 openstackgerrit Andreas Jaeger proposed openstack/python-novaclient: Fix help strings https://review.openstack.org/421879
12:41:59 johnthetubaguy dang it, I see now
12:44:00 takashin bauzas: alex_xu: Could you review https://review.openstack.org/#/c/408955/ again and check my comments?
12:44:23 openstackgerrit Vladik Romanovsky proposed openstack/nova: Adding vlans filed to Device tagging metadata https://review.openstack.org/405951
12:44:23 openstackgerrit Vladik Romanovsky proposed openstack/nova: libvirt: expose virtual interfaces with vlans to metadata https://review.openstack.org/405954
12:49:53 openstackgerrit Jim Rollenhagen proposed openstack/nova: Move to tooz hash ring implementation https://review.openstack.org/399022
12:50:03 jaypipes sahid: yeah, I'm still in the middle of a review on that. sorry, yesterday most of the day was having to do management stuff :(
12:50:34 jaypipes sahid: have 4 straight hours of meetings and performance reviews to do this morning. will try to finish up reviews after that
12:51:11 wznoinsk anyone with experience in nova-lxd around?
12:52:26 jaypipes wznoinsk: the folks with experience with that would more likely be in #openstack-snaps
12:52:40 wznoinsk jaypipes, oh ok, thanks
12:53:30 jaypipes wznoinsk: and good morning :)
12:54:38 wznoinsk jaypipes, good morning to you too, must be v. early one for you?
12:55:02 jaypipes wznoinsk: nah, not too bad. 7:50am
12:57:04 wznoinsk that peace and quiet time when everybody else hasn't woken up to bother you ;-) anyways, have a good one, I'm going for lunch myself
12:58:15 jaypipes sahid: make that 5 straight hours of meetings and PRs...
12:58:33 jaypipes wznoinsk: heh, remember I have 3 pugs that are *always* bothering me :)
12:58:53 sahid jaypipes: ok thanks jay, sorry to rush you on it but i'm little bit scrary with the ff comming
12:59:19 jaypipes sahid: understood. have you found more cores to look at the bottom two patches in that series? sfinucan maybe?
12:59:43 sahid jaypipes: he is in holidays this week
13:00:13 jaypipes sahid: ah. perhaps you can reach out to another core? maybe mriedem or sdague?
13:00:17 jaypipes or bauzas?
13:01:17 sahid jaypipes: yes sure i see dansmith commenting on one of the patch, then i remember johnthetubaguy interested on this feature and perhaps mriedem
13:01:28 alex_xu nova api meeting is running
13:01:44 jaypipes sahid: dansmith is out for a while (he's adventuring in Eastern Oregon in the mountains) :)
13:02:21 sahid oh i see
13:03:46 sahid johnthetubaguy, mriedem one of you guy have a moment to review the feature emulator threads ? it's basically reserving a pCPU to make running emulator threads
13:04:39 johnthetubaguy still recovering from a nasty bug, but starting to get through my review queue, I had hoped to get to that one
13:07:42 openstackgerrit Zhenyu Zheng proposed openstack/nova: Add release note and docs for filter/sort whitelist https://review.openstack.org/421760
13:14:03 snikitin johnthetubaguy: Hi John! I heard that you are good in Xen. Could you add this xen related patch into your review queue, please? :) https://review.openstack.org/#/c/399613
13:49:13 EmilienM owalsh: hey! so I have quick updates about Placement service
13:49:24 owalsh EmilienM: shoot
13:49:28 EmilienM owalsh: the service was working fine in our CI (tripleo & puppet) a few days ago
13:49:32 openstackgerrit Davanum Srinivas (dims) proposed openstack/nova: [py35] Fixes to get more tempest tests working https://review.openstack.org/421911

Earlier   Later