| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-01-16 | |||
| 18:59:57 | openstackgerrit | Jay Pipes proposed openstack/nova: placement: RT now adds proper Ironic inventory https://review.openstack.org/404472 | |
| 18:59:59 | openstackgerrit | Jay Pipes proposed openstack/nova: rt: use a single ResourceTracker object instance https://review.openstack.org/398473 | |
| 19:00:01 | jaypipes | mriedem: ^^ | |
| 19:00:21 | mriedem | que bueno | |
| 19:01:26 | cdent | good timing jaypipes my to do list just rolled around to those | |
| 19:01:34 | jaypipes | coolio. | |
| 19:01:41 | mriedem | jaypipes: were you going to also update _setup_pci_tracker to pass the compute_node object in ther? | |
| 19:01:43 | mriedem | *there | |
| 19:01:54 | jaypipes | mriedem: ah, shitbuckets. | |
| 19:01:56 | jaypipes | one sec. | |
| 19:02:34 | mriedem | otherwise it looks super hot | |
| 19:02:35 | mriedem | like, omg | |
| 19:08:03 | mriedem | melwitt: good point on https://review.openstack.org/#/c/332713/14/nova/cmd/manage.py@1432 | |
| 19:08:10 | mriedem | i obviously didn't think about that | |
| 19:09:09 | mriedem | heh i even said that in PS9: | |
| 19:09:10 | mriedem | "I think I'd like to see us first check to see if a cell mapping exists with the given name (or combination of name/transport_url/database_connection) and if we already have a match, we just exit without doing anything (not a failure)." | |
| 19:10:17 | melwitt | mriedem: yeah, I've been admittedly confused about whether we return 0 for a no-op or not among all these commands. it seems like it hasn't been consistent | |
| 19:11:04 | melwitt | like simple_cell_setup returns non-zero if it didn't create a cell mapping, but map_cell_and_hosts returns 0 in the same case I think | |
| 19:11:25 | mriedem | yeah bauzas has a patch up to fix that actually | |
| 19:11:53 | mriedem | another thing with this create_cell command is you can't create 2 cells with different names but the same db/mq urls | |
| 19:12:02 | mriedem | i'm not sure if we care about that right now, and it could be built in later if we did | |
| 19:12:26 | mriedem | seems we should have had a unique constraint on the name/db/transport combo in the schema | |
| 19:12:40 | melwitt | yeah, I thought about that and figured we shouldn't probably allow that case anyway (different name, same urls) | |
| 19:13:54 | dansmith | we should allow duplicate urls of each type at the very least | |
| 19:14:14 | dansmith | not sure it makes sense to allow complete dupes though, other than for testing | |
| 19:15:30 | mriedem | dansmith: yeah the check in create_cell right now is db AND mq urls matching an existing cell | |
| 19:15:32 | mriedem | that's a failure | |
| 19:15:52 | mriedem | which i had earlier said i thought should just be a noop (don't create a new cell), but guess i forgot that i asked for that before +2ing | |
| 19:16:02 | openstackgerrit | Jim Rollenhagen proposed openstack/nova: Move to tooz hash ring implementation https://review.openstack.org/399022 | |
| 19:16:11 | jaypipes | mriedem: just re-running tests locally. should be pushed within 15minutes. | |
| 19:16:39 | mriedem | ok push it real good please | |
| 19:17:43 | dansmith | mriedem: well, as melwitt said, returning zero for "I didn't do anything, but it's there like you asked" will be good for some people and bad for others that think they can test for existence by trying to re-create and check for error | |
| 19:18:03 | dansmith | mriedem: so my opinion is that we not make a "create this thing" operation idempotent and instead do what you asked | |
| 19:18:12 | mriedem | right, and since i'm frankly tired of trying to predict how all of this is going to be used, i'm going to give up | |
| 19:20:26 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/420844 | |
| 19:21:26 | mriedem | dansmith: don't forget about this guy https://review.openstack.org/#/c/420440/ | |
| 19:21:46 | dansmith | mriedem: jenkins says that is shit | |
| 19:22:10 | mriedem | it said that about the next in the series too which you +2ed | |
| 19:22:52 | dansmith | I hand-checked that one | |
| 19:23:23 | mriedem | i know | |
| 19:23:45 | mriedem | my detector has been honed over years of bullshit | |
| 19:33:56 | oomichi_ | mriedem: why not "nova-manage cell_v2 list" ? The other resources' commands are just "list" without resource name in sub commands | |
| 19:34:55 | mriedem | oomichi_: because we could have things like list_host_mappings or something, idk | |
| 19:35:07 | mriedem | oomichi_: and that's what we named it like for create_cell | |
| 19:35:58 | dansmith | I commented to that effect | |
| 19:36:09 | oomichi_ | mriedem: ah, I see "create_cell". I got it. | |
| 19:36:33 | oomichi_ | dansmith: Thanks, I see. it is nice to keep current one for consistent command line | |
| 19:37:49 | openstackgerrit | Jay Pipes proposed openstack/nova: placement: RT now adds proper Ironic inventory https://review.openstack.org/404472 | |
| 19:37:52 | openstackgerrit | Jay Pipes proposed openstack/nova: rt: use a single ResourceTracker object instance https://review.openstack.org/398473 | |
| 19:40:41 | melwitt | omg fixing unit tests is finding my bugs -_- | |
| 19:57:55 | melwitt | dansmith: are there any common mistakes/reasons why a lazy-load of flavor would try to occur even after specifying expected_attrs=['flavor']? | |
| 19:58:48 | dansmith | melwitt: hmm, not that I can think of | |
| 20:00:24 | slaweq | mriedem: hello | |
| 20:00:44 | slaweq | mriedem: I made small patch https://review.openstack.org/#/c/420176/ to fix https://bugs.launchpad.net/nova/+bug/1640502 | |
| 20:00:44 | openstack | Launchpad bug 1640502 in OpenStack Compute (nova) "Empty /etc/machine-id causes failure in unit tests" [Medium,In progress] - Assigned to Slawek Kaplonski (slaweq) | |
| 20:01:02 | slaweq | mriedem: can You take a look on it if You will have a while? thx in advance | |
| 20:01:13 | melwitt | dansmith: thanks, will keep digging | |
| 20:10:32 | dansmith | mriedem: I bet we need to discover hosts somewhere after the subnode runs, which is why I'm getting this: http://logs.openstack.org/79/319379/58/check/gate-tempest-dsvm-multinode-live-migration-ubuntu-xenial/c25f7d1/logs/testr_results.html.gz | |
| 20:12:29 | melwitt | oh, duh. this unit test is creating instances that don't have flavors as part of the setup and the old code used to look at inst['vcpus'] apparently | |
| 20:13:22 | melwitt | so my instance get was getting some instances with None flavors | |
| 20:20:02 | bauzas | jaypipes: hey, about https://review.openstack.org/#/c/417961/5/nova/scheduler/host_manager.py@362 | |
| 20:20:07 | bauzas | jaypipes: sec to discuss ? | |
| 20:20:17 | jaypipes | bauzas: just finishing on phone call. gimme 10. | |
| 20:20:22 | bauzas | jaypipes: fair | |
| 20:20:40 | bauzas | jaypipes: leaving notes meanwhile | |
| 20:21:23 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/420844 | |
| 20:30:33 | jaypipes | bauzas: k, done. | |
| 20:30:50 | bauzas | jaypipes: see my comment for context in gerrit | |
| 20:33:17 | mriedem | whew | |
| 20:33:44 | mriedem | dansmith: yeah probably, which is actually what i started working on | |
| 20:33:50 | mriedem | before the call i just got off of happened | |
| 20:34:40 | bauzas | jaypipes: thoughts on that ? | |
| 20:35:13 | dansmith | mriedem: okay | |
| 20:35:29 | bauzas | jaypipes: I honestly totally agree with you that using a reportclient is somehow sad | |
| 20:35:44 | bauzas | jaypipes: but I wanted to be pragmatic | |
| 20:38:41 | openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: DO NOT MERGE: check OSC https://review.openstack.org/420941 | |
| 20:43:41 | mriedem | ok on the api node i create nova_subnode_cell db, and then create subnode-cell cell with the db connection to the nova_subnode_cell db and transport_url to the primary node's same mq | |
| 20:43:48 | mriedem | transport-url is going to be the same for all of these | |
| 20:44:00 | mriedem | then on the subnode setup after n-cpu is running i need to run discover_hosts | |
| 20:45:31 | mriedem | now i need to remember how to awk stuff, damn | |
| 21:01:26 | jaypipes | bauzas: sorry, reading now. got pulled away | |
| 21:01:32 | bauzas | np | |
| 21:07:36 | comstud | mriedem: well, there's your problem | |
| 21:08:28 | jaypipes | comstud: blast from the past! howdy. | |
| 21:08:36 | comstud | yo :) | |
| 21:08:41 | jaypipes | bauzas: ok, fair point on the reporting client thing. I can go along with that. | |
| 21:08:56 | jaypipes | bauzas: with a promise to clean up ex post facto. | |
| 21:09:05 | bauzas | jaypipes: my change is still there | |
| 21:09:15 | jaypipes | bauzas: I still would need to see a ComputeNodeList.get_all_by_uuids() though. | |
| 21:09:18 | bauzas | jaypipes: I mean the placementclient one | |
| 21:09:29 | jaypipes | bauzas: understood. | |
| 21:09:29 | bauzas | jaypipes: sure, I'll redo it | |
| 21:09:49 | openstackgerrit | Claudiu Belu proposed openstack/nova: hyper-v: Adds support for VMs with nested virtualization https://review.openstack.org/398509 | |
| 21:09:50 | openstackgerrit | Claudiu Belu proposed openstack/nova: Adds CPUFeaturesField to ImageMetaProps https://review.openstack.org/420960 | |
| 21:10:10 | bauzas | jaypipes: the question I was wondering about the placementclient is that it would be reasonable to only provide CRUD ops in it | |
| 21:10:33 | bauzas | jaypipes: or if I'd rather work on objectifying that client | |
| 21:10:52 | bauzas | cutting by just the CRUD ops could possible be merged sooner | |
| 21:11:05 | jaypipes | bauzas: no, I think just pulling get/put/post/safe_connect into a class is correct. | |
| 21:11:05 | mriedem | comstud: it's ok, mrodden stopped by just at the right time and gave me the awk i needed | |
| 21:11:18 | bauzas | but I'd tend to prefer having a placementclient that would have resources in it | |