Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-01-13
11:10:35 mdbooth lyarwood: Any reason you split https://review.openstack.org/#/c/402163/ and its predecessor into separate patches?
11:12:16 openstackgerrit Balazs Gibizer proposed openstack/nova: handle uninited fields in notification payload https://review.openstack.org/415857
11:14:31 lyarwood mdbooth: not that I can think of, happy to squash them togther tbh
11:15:07 mdbooth lyarwood: Got a bit of a narrative going on there, btw. I asked you for an additional test, but then said you don't seem to need to parse filesystem at all.
11:15:13 mdbooth In which case you wouldn't need a test, I guess.
11:15:40 mdbooth The code which consumes this already assumes it's a disk, not a filesystem
11:18:41 lyarwood mdbooth: hmm do we not even call this when using lxc?
11:18:56 mdbooth lyarwood: I don't know, but it's already busted in the case I think
11:19:08 lyarwood mdbooth: true
11:19:23 mdbooth https://review.openstack.org/#/c/402163/10/nova/virt/libvirt/guest.py
11:19:34 mdbooth node = doc.find("./devices/disk/target[@dev='%s'].." % target_device)
11:19:36 mdbooth Line 311
11:20:21 mdbooth Do we support filesystems as volumes?
11:20:45 mdbooth If no, I think we don't worry about it for the moment
11:20:56 mdbooth Maybe leave a comment
11:21:46 lyarwood mdbooth: I'm not sure tbh, the lookup hasn't changed here so if we do it's already broken
11:21:56 mdbooth My thinking too
11:22:15 mdbooth I suspect we don't
11:23:26 lyarwood we do as eph storage right?
11:25:39 mdbooth I'd have to check. Don't recall off the top of my head.
11:25:58 mdbooth eph is local, though, so completely different.
11:26:52 mdbooth lyarwood: Are you working on this series while I'm reviewing, btw?
11:27:19 lyarwood mdbooth: not yet, give me 10 and I'll squash the first two
11:27:26 mdbooth i.e. Do you want me to continue sending a stream of consciousness, or wait a bit between hitting the DENIED button?
11:27:40 lyarwood mdbooth: feel free to continue
11:31:14 mdbooth lyarwood: Maybe hold off squashing...
11:31:31 Kevin_Zheng johnthetubaguy: so you are suggesting the decorator idea?
11:31:32 mdbooth That's easy done later
11:32:03 johnthetubaguy Kevin_Zheng: that was my preference at the meeting, but honestly, I am tempted to merge what we have now, and refactor later
11:32:34 johnthetubaguy Kevin_Zheng: I don't think we are talking about behaviour changes (apart from maybe different error messages?)
11:34:42 cdent Kevin_Zheng: since you're around, are you still working on https://review.openstack.org/#/c/410128/ or would you prefer someone else pick that up?
11:35:42 Kevin_Zheng cdent: one sec, I'm having some problem with my network now :(
11:37:03 Kevin_Zheng cdent: Ah, you can pick it up
11:37:21 dims cdent : good afternoon. have some time for me?
11:37:38 amoralej may i get some help on https://bugs.launchpad.net/puppet-nova/+bug/1656276 ?, i'd like to understand the best workflow to deploy nova environment with cellsv2
11:37:38 openstack Launchpad bug 1656276 in tripleo "Error running nova-manage cell_v2 simple_cell_setup when configuring nova with puppet-nova" [Critical,Triaged]
11:37:40 cdent Kevin_Zheng: will do, I didn't want to mess with it if you still had is in progress
11:37:48 cdent dims: I always have at least a little time for you
11:37:49 mdbooth lyarwood: I'm looking here, line 1530
11:38:01 mdbooth lyarwood: And here: http://libvirt.org/html/libvirt-libvirt-domain.html#virDomainBlockJobAbort
11:38:12 Kevin_Zheng cdent: yeah thanks for ask
11:38:18 dims cdent thanks :) please review a WIP for me https://review.openstack.org/#/c/419476/
11:38:35 dims cdent : with those changes, i can get some nova scenarios working http://logs.openstack.org/43/418643/5/check/gate-rally-dsvm-py35-cinder-nv/0a95698/rally-plot/results.html.gz#/CinderVolumes.create_and_attach_volume/details
11:38:52 mdbooth lyarwood: It seems to me that if we already have an unambiguous full patch to the source disk, using target dev name is only a potential source of error?
11:38:57 Kevin_Zheng johnthetubaguy: you mean the current implement of https://review.openstack.org/#/c/408571/
11:39:06 mdbooth lyarwood: What was your thinking in making this change?
11:39:19 johnthetubaguy Kevin_Zheng: yeah
11:39:19 mdbooth I haven't looked at the next patch yet, so may be missing context
11:39:27 lyarwood mdbooth: sorry you didn't link to the review, which file are we looking at?
11:39:46 mdbooth https://review.openstack.org/#/c/402163/10/nova/virt/libvirt/driver.py
11:40:00 lyarwood thanks
11:40:16 Kevin_Zheng johnthetubaguy: hmm fine by me, maybe check with alex?
11:40:23 mdbooth lyarwood: Trying to understand the motivation moving from disk_path -> target
11:40:53 mdbooth The purpose of this change and the previous one seems to be to move away from using disk_path, but I don't get why yet.
11:42:28 lyarwood mdbooth: so off the top of my head I think this was to allow us to swap rbd volumes etc
11:42:51 lyarwood mdbooth: basically anytime we don't have an actual path
11:42:57 lyarwood mdbooth: let me go over this again quickly
11:43:13 mdbooth lyarwood: Ah....
11:43:22 mdbooth RBD has no path
11:44:16 mdbooth Although, libvirt has its own representation of rbd 'paths' iirc
11:44:56 openstackgerrit jichenjc proposed openstack/nova: Allow -1 as limit value to pager https://review.openstack.org/419893
11:46:30 lyarwood mdbooth: ah and the main reason for doing this was that we would end up stashing either a disk_path or target_dev in BlockDevice._disk that was really confusing
11:47:02 lyarwood mdbooth: so I thnk i just went with target_dev as we should always have it and it's going to work when we don't have a file path
11:47:23 cdent dims, left a comment, what's there is probably fine, but I also offered an alternative plan which I can do (but not today) if you think it is better.
11:47:43 lyarwood mdbooth: sorry I should really get all of this context back in my head before asking for a review ;)
11:47:54 cdent dims I gotta go to lunch now, but will check back with you and/or the review later in the day
11:56:48 mdbooth lyarwood: FYI, in terms of merging, I think I'd split your change to Guest.get_disk into a separate patch, and merge the rest of the patch into the previous patch.
11:57:07 mdbooth I think that makes it a little more obvious what's going on.
12:01:28 lyarwood mdbooth: ack thanks
12:01:38 mdbooth lyarwood: I'm still going, btw.
12:01:57 mdbooth I don't like the change to BlockDevice, just writing why.
12:02:45 alex_xu johnthetubaguy: Kevin_Zheng i'm good with refactor the code later
12:03:46 johnthetubaguy alex_xu: one thing, do we reject with 400 the bad ones in that patch?
12:03:51 mdbooth lyarwood: Hmm, potentially scratch that.
12:04:57 alex_xu johnthetubaguy: you mean for joinedtable and internal attrs?
12:05:09 johnthetubaguy alex_xu: the joinedtable ones
12:05:18 alex_xu johnthetubaguy: yea, the current patch return 400
12:05:19 openstackgerrit Mikhail Feoktistov proposed openstack/nova: libvirt: ephemeral disk support for virtuozzo containers https://review.openstack.org/312488
12:05:29 johnthetubaguy alex_xu: I think the behaviour is the key thing
12:05:39 johnthetubaguy alex_xu: so we should be good
12:05:54 alex_xu johnthetubaguy: ++, the behaviour is everyone expected
12:07:37 openstackgerrit sahid proposed openstack/nova: libvirt: update the active migrations DS to support migration result https://review.openstack.org/409260
12:07:37 openstackgerrit sahid proposed openstack/nova: libvirt: ensure live-migration success https://review.openstack.org/409261
12:13:48 openstackgerrit jichenjc proposed openstack/nova: make limit=0 means query 0 data https://review.openstack.org/419913
12:17:45 mdbooth lyarwood: Any reason for https://review.openstack.org/#/c/399735/ to depend on the previous 2 patches?
12:18:04 mdbooth Seems the middle 2 are about fixing something Rbd related?
12:18:44 lyarwood mdbooth: other than using self._guest.get_disk_by_target_device no I don't think so
12:32:04 openstackgerrit Stephen Finucane proposed openstack/nova: scheduler: Don't modify RequestSpec in filtering https://review.openstack.org/419479
12:36:47 openstackgerrit Emilien Macchi proposed openstack/nova: CI test - never merge https://review.openstack.org/419926
12:39:47 openstackgerrit Emilien Macchi proposed openstack/nova: Debug https://bugs.launchpad.net/tripleo/+bug/1656276 https://review.openstack.org/419926
12:39:47 openstack Launchpad bug 1656276 in tripleo "Error running nova-manage cell_v2 simple_cell_setup when configuring nova with puppet-nova" [Critical,Triaged]
12:41:45 EmilienM hey nova folks, we're having a new issue with a patch merged in Nova yesterday, https://review.openstack.org/#/c/409890/ - details are reported here: https://bugs.launchpad.net/tripleo/+bug/1656276 - any feedback is welcome
12:41:45 openstack Launchpad bug 1656276 in tripleo "Error running nova-manage cell_v2 simple_cell_setup when configuring nova with puppet-nova" [Critical,Triaged]
12:43:51 openstackgerrit Sergey Nikitin proposed openstack/nova: Standardization of VM diagnostics info API. https://review.openstack.org/355540
12:55:04 dtp good morning. are quotas enforced in the database?
12:56:16 openstackgerrit Vasyl Saienko proposed openstack/nova: Support Ironic interface attach/detach in nova virt https://review.openstack.org/364413
13:13:19 openstackgerrit Vasyl Saienko proposed openstack/nova: Support Ironic interface attach/detach in nova virt https://review.openstack.org/364413
13:27:31 sahid JayF:
13:45:48 openstackgerrit Davanum Srinivas (dims) proposed openstack/nova: [WIP] try py35 functional with a clean slate https://review.openstack.org/419968
13:45:51 openstackgerrit Vladyslav Drok proposed openstack/nova: Generate necessary network metadata for portgroups https://review.openstack.org/388756

Earlier   Later