Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-01-11
09:44:58 openstackgerrit Abhishek Kekane proposed openstack/nova: Use is_valid_cidr and is_valid_ipv6_cidr from oslo_utils https://review.openstack.org/320375
09:47:32 gmann alex_xu: why we want to handle _* separately in https://review.openstack.org/#/c/408571/36
09:48:27 gmann alex_xu: i mean just 400 in server.py will be enough right instead of allowing it in schema and later allow to go from strip_additional_property
09:49:17 gmann alex_xu: also how about treating that same as other additional property, just ignore
09:53:19 lyarwood_ mdbooth: morning, was anything blocking https://review.openstack.org/#/c/383859/ aside from core reviews?
09:54:24 alex_xu gmann: if we didn't put _* in the schema, they will be stripped out
09:56:37 alex_xu gmann: we have discuss it whether we can just ignore at last api meeting http://eavesdrop.openstack.org/meetings/nova_api/2017/nova_api.2017-01-04-13.00.log.html
09:56:48 alex_xu gmann: start from "13:07:35"
09:57:18 alex_xu gmann: but yes, I'm not sure people like current implement.
10:03:22 gmann alex_xu: oh yea, for db model object internal attributes.
10:04:07 gmann alex_xu: but only allow in strip_additional and later 400 should be enough may be instead of explicitly allow in original schema ?
10:06:55 openstackgerrit Zhenyu Zheng proposed openstack/nova: Add query parameters white list for server list/detail https://review.openstack.org/408571
10:23:29 openstackgerrit zhangyujun proposed openstack/nova: Update JSON Schema for flavor access https://review.openstack.org/418683
10:40:18 mdbooth lyarwood_: Actually I've got it open right now. I was writing some docs for it at the suggestion of sfinucan and noticed a race, which I'm addressing.
10:40:27 mdbooth But basically no.
10:44:59 openstackgerrit Jiri Suchomel proposed openstack/nova: Retry few times when creating the initial connection to libvirtd. https://review.openstack.org/416928
10:45:17 openstackgerrit Zhenyu Zheng proposed openstack/nova: Add sort_key white list for server list/detail https://review.openstack.org/415142
10:46:58 openstackgerrit Zhenyu Zheng proposed openstack/nova: Add new policy for server list/detail with all_tenants https://review.openstack.org/415330
10:49:41 openstackgerrit avnish proposed openstack/nova: Removed unnecessary utf-8 encoding https://review.openstack.org/418838
10:49:48 openstackgerrit avnish proposed openstack/python-novaclient: Removed unnecessary utf-8 encoding https://review.openstack.org/418839
10:52:45 sfinucan Morning/afternoon, folks. On this, review day, could I get some eyes on two bug fixes: https://review.openstack.org/#/c/396184/ and https://review.openstack.org/#/c/392643/
10:53:17 sfinucan Both should be somewhat self explanatory, but I'm here if anyone has any questions
10:54:33 openstackgerrit Balazs Gibizer proposed openstack/nova: Remove **kwargs passing in payload __init__ https://review.openstack.org/418489
11:15:03 openstackgerrit John Garbutt proposed openstack/nova: Populate network data in _validate_requested_network_ids https://review.openstack.org/418511
11:15:08 openstackgerrit John Garbutt proposed openstack/nova: Pass objects into _create_ports_for_instance https://review.openstack.org/418512
11:15:14 openstackgerrit John Garbutt proposed openstack/nova: Pass objects into _update_ports_for_instance https://review.openstack.org/418513
11:19:33 openstackgerrit Mikhail Feoktistov proposed openstack/nova: libvirt: ephemeral disk support for virtuozzo containers https://review.openstack.org/312488
11:20:37 openstackgerrit OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/415978
11:21:45 openstackgerrit Zhenyu Zheng proposed openstack/nova: Add query parameters white list for server list/detail https://review.openstack.org/408571
11:22:08 openstackgerrit Zhenyu Zheng proposed openstack/nova: Add sort_key white list for server list/detail https://review.openstack.org/415142
11:29:03 openstackgerrit Zhenyu Zheng proposed openstack/nova: Add new policy for server list/detail with all_tenants https://review.openstack.org/415330
11:29:11 alex_xu gmann: I feel explicity in the schema is better than hide some hacky deep into some method.
11:40:39 openstackgerrit John Garbutt proposed openstack/nova: Extract preallocate_for_instance https://review.openstack.org/418876
11:49:05 openstackgerrit zhangyujun proposed openstack/nova: Query parameter validation for hosts API https://review.openstack.org/418880
11:49:50 openstackgerrit Claudiu Belu proposed openstack/nova: hyper-v: Adds support for VMs with nested virtualization https://review.openstack.org/398509
11:50:47 openstackgerrit Zhenyu Zheng proposed openstack/nova: Add new policy for server list/detail with all_tenants https://review.openstack.org/415330
11:51:27 openstackgerrit John Garbutt proposed openstack/nova: WIP: Call pre_allocate_for_instance before scheduler https://review.openstack.org/413124
11:51:28 openstackgerrit John Garbutt proposed openstack/nova: WIP: introduce preallocate_for_instance method. https://review.openstack.org/418881
11:58:23 openstackgerrit John Garbutt proposed openstack/nova: Make allocate_for_instance take consistent args https://review.openstack.org/418024
12:06:24 openstackgerrit zhangyujun proposed openstack/nova: Update JSON Schema for flavor access https://review.openstack.org/418683
12:07:59 openstackgerrit John Garbutt proposed openstack/nova: Pass objects into _validate_requested_network_ids https://review.openstack.org/418027
12:07:59 openstackgerrit John Garbutt proposed openstack/nova: Add and use ProcessedNetworkRequest object https://review.openstack.org/418025
12:51:50 alex_xu nova api sub-team meeting is 9mins at #openstack-meeting-4
12:57:46 gmann alex_xu: i see point now, for skipping _* from strip_additional we need in schema
12:57:52 gmann alex_xu: thanks :)
12:58:23 alex_xu gmann: yea, but that is a little ugly
12:59:04 gmann alex_xu true, that's side effect of maintaining lot of versions and supported codes :)
12:59:04 Kevin_Zheng lol
12:59:34 alex_xu gmann: yea :)
13:24:21 openstackgerrit Alex Szarka proposed openstack/nova: Transform instance-exists notification https://review.openstack.org/403660
13:29:05 bauzas artom: I have a question for you in https://review.openstack.org/#/c/415520/5
13:29:18 bauzas (reviewing all the blueprints for the review day)
13:29:49 bauzas artom: at least, I put -1 because of the confusing docstring
13:32:25 bauzas artom: heh, jinx for the recheck :)
13:32:29 artom bauzas, aha! Yeah, that probably makes sense
13:33:01 artom bauzas, heh, a lot of volumes tests failed on that one, so I got worried, but it looks like it's an unrelated MySQL failure and not my code
13:33:08 bauzas zactmy
13:33:28 bauzas artom: about the first change, amirite if I think you just need to signal something ?
13:33:36 bauzas you don't really care about the value itsefl
13:34:01 bauzas if so, is the tag info something we can get from the vif info ?
13:34:44 bauzas artom: ^
13:34:47 artom bauzas, I don't think it's in vif info...
13:34:52 bauzas okay
13:35:06 bauzas if so, we need it in the signature indeed
13:35:38 artom Vif info is that weird network model class, right? If so (and IIRC it is) it's not in there
13:36:34 artom bauzas, strictly speaking, we need it as a boolean flag, so... just check whether it's in kwargs? You think that'd be better?
13:37:05 bauzas artom: I'm thinking about the interface
13:37:15 bauzas I mean that method signature
13:37:27 bauzas and whether a single boolean is all that good
13:37:53 bauzas I tend to avoid adding extra arguments just for a single conditional
13:38:04 bauzas so I tend to regroup all the needed into objects
13:38:20 artom Objects or dicts? Because we know how the latter worked out ;)
13:38:22 bauzas when you can actually lookup the needed within the methods
13:38:32 bauzas nah, objects
13:38:33 bauzas I mean
13:38:43 bauzas just amending a virt signature for passing a boolean is a huge thing
13:39:02 artom Yeah, I agree with that
13:39:34 bauzas that's why I'm trying to understand whether we can either #1 get that elsewhere but not passed in as arg, or #2 pass a better argument that would help more than just a boolean
13:40:09 artom I guess we can add it as a field in the vif info?
13:40:24 bauzas well
13:40:39 bauzas if so, that means a new os-vif version, right ?
13:40:40 artom Also, other virt drivers might need it, I suppose
13:40:58 artom And we pass the tag itself from the compute manager, not just a boolean flag
13:42:32 artom bauzas, hold up, daughter's awake, back a bit later
13:43:13 bauzas np
13:53:12 huanxie Hi sdague, I have rebased my nova patch of using os-xenapi https://review.openstack.org/#/c/406059/, could you help review again? This patch already got +2/+w before, but there is a unit test conflict with upstream, so I rebased and fixed, now it's ready. Thanks a lot :)
14:04:47 openstackgerrit Sergey Nikitin proposed openstack/nova: Standardization of VM diagnostics info API. https://review.openstack.org/355540
14:04:47 openstackgerrit Sergey Nikitin proposed openstack/nova: Change parent of diagnostics objects to NovaObject class https://review.openstack.org/394480
14:04:48 openstackgerrit Sergey Nikitin proposed openstack/nova: Completed implementation of instance diagnostics for Xen https://review.openstack.org/399613
14:08:50 huanxie Hi mriedem, I have rebased my patch https://review.openstack.org/#/c/406059/ which is to use os-xenapi lib, could you help have a review again? Thanks a lot!
14:13:01 sdague huanxie: no prob
14:13:46 huanxie sdague :)
14:14:31 openstackgerrit John Garbutt proposed openstack/nova: Add and use ProcessedNetworkRequest object https://review.openstack.org/418025
14:14:32 openstackgerrit John Garbutt proposed openstack/nova: Make allocate_for_instance take consistent args https://review.openstack.org/418024
14:19:11 cdent Kevin_Zheng: are you still working on https://review.openstack.org/#/c/410128/ ?
14:26:55 openstackgerrit Pawel Koniszewski proposed openstack/nova: Update instance group during live migration https://review.openstack.org/339588
14:27:21 openstackgerrit Markus Zoeller (markus_z) proposed openstack/nova: live-migration test hook for serial console https://review.openstack.org/347471
14:46:22 openstackgerrit Dan Smith proposed openstack/nova: WIP: Test cellsv1 https://review.openstack.org/418141
14:46:59 mriedem i smell a feature review sprint coming on https://etherpad.openstack.org/p/nova-ocata-feature-freeze
14:47:00 bauzas dansmith: I stopped reviewing cellsv1 effort since a while

Earlier   Later