Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2025-04-01
09:31:54 sean-k-mooney i assume you ment ot put that in the neutron channel
09:32:12 stephenfin sean-k-mooney: trivial README change here if you've 3.5 seconds https://review.opendev.org/c/openstack/nova/+/944994
09:32:25 sean-k-mooney sahid: but i would not recommend creating a theread pool dynmaiclly in a plugin
09:32:46 sean-k-mooney sahid: if your going to use thread pools you shoudl create one globaly for neutron to use and reuse it
09:32:50 sean-k-mooney like we do in nova
09:34:00 sahid sean-k-mooney: oh yes... my mistake
09:34:22 sahid sean-k-mooney: that is an interesting point yes
09:34:41 sean-k-mooney sahid: https://review.opendev.org/c/openstack/nova/+/922497
09:35:03 sahid i will discuss that with neutron, i think ralonsoh may also need it from it's change to the l3 agent
09:35:09 sean-k-mooney actully that not quite the patch i wanted
09:35:09 sahid its
09:35:36 sean-k-mooney well no that uses futureist
09:36:19 sean-k-mooney oh im not adding eventlet tpool there im just moving the import
09:36:26 sean-k-mooney thats what was confusing me
09:40:00 sahid in all cases I think that make sense to have one global thread pool and each pick on it, so each service will use its own thread pool
09:41:00 sahid but well some time we may need to have one context os threads so we can play with them, join them or kill them
09:44:11 sean-k-mooney sahid: you shoudl never kill a thread in python
09:44:54 sean-k-mooney you shoudl be using futures for the most part when you need to wait on results
09:45:11 sean-k-mooney if you need to kill something you should be using a process pool
09:45:22 sean-k-mooney otherwise you need to dispatch cancelable tasks
09:46:03 sean-k-mooney killing a thread via python is generally unsafe, there is no public api to do that and you have to fall abck to posix hacks, which mean you can leak locks and filehandels
12:14:10 opendevreview sean mooney proposed openstack/osc-placement master: Add bindep.txt for ubunutu 24.04 support https://review.opendev.org/c/openstack/osc-placement/+/946031
12:14:49 opendevreview sean mooney proposed openstack/osc-placement master: Add bindep.txt for ubunutu 24.04 support https://review.opendev.org/c/openstack/osc-placement/+/946031
13:07:44 sean-k-mooney hi folks https://review.opendev.org/c/openstack/osc-placement/+/946031 seam to fix the osc-placement docs jobs. we will need to backport that to stable 2025.1 as well
13:08:38 sean-k-mooney we can do that after the release. tl;dr we need a bindep file to install pcre because the header is not transitivly installed on ubuntu 24.04
13:23:16 cardoe Hoping to get https://review.opendev.org/c/openstack/nova/+/942019 on your folks radar too. Really helps in figuring out why something failed to get the error message instead of the hex memory address of the error message.
13:25:07 gibi cardoe: I've approved the patch. Thanks for pushing a fix
13:25:49 cardoe Thank you. :)
14:08:20 gibi sean-k-mooney: bauzas: could one of you take a look at this simple os_traits addition https://review.opendev.org/c/openstack/os-traits/+/944049 for OTU?
14:09:06 sean-k-mooney sure but if we plan do do a realase for that we shoudl include https://review.opendev.org/c/openstack/os-traits/+/940418
14:09:09 bauzas done
14:12:17 gibi sean-k-mooney: sure
14:14:43 dansmith gibi: my test should have caught that I was iterating RCs for no reason.. do you mind if I put a slightly-unrealistic allocation in for the PCI device in the test where there are two RCs to make sure we only call invalidate once?
14:15:25 dansmith PCI in placement would only have one CUSTOM_PCI_X_Y:1 thing in the allocation, but if I put two I can make sure I'm only doing it once
14:16:32 gibi dansmith: I don't mind at all
14:16:41 dansmith cool
14:16:53 dansmith gibi: are you walking up the series again? if so, I'll hold off pushing this fix
14:17:08 opendevreview Rajesh Tailor proposed openstack/nova master: Add upgrade status check for duplicate cell names https://review.opendev.org/c/openstack/nova/+/901810
14:18:20 opendevreview Merged openstack/os-traits master: Add HW_PCI_ONE_TIME_USE trait https://review.opendev.org/c/openstack/os-traits/+/944049
14:27:05 gibi dansmith: yeah I'm reviewing at the moment
14:27:14 dansmith ack, i'll hold off
14:27:59 gibi thanks
14:40:31 artom Uggla, heads up, new security/nova x-project topic for PTL at https://etherpad.opendev.org/p/nova-2025.2-ptg#L77
14:54:26 gibi dansmith: I finished reviewing the stack
14:54:46 dansmith gibi: cool, thanks, I'm just running tests after removing the spec copy
14:54:56 gibi OK
14:57:56 opendevreview Rajesh Tailor proposed openstack/nova master: Update the api-ref for unshelve https://review.opendev.org/c/openstack/nova/+/938054
14:58:13 gibi dansmith: do you plan to push some functional test coverage top of the series?
14:59:47 dansmith I haven't gone deeply into the functional tests for pci yet, because I've been sort of working with my devstack (and scheming about getting it tested in a job)
15:00:21 dansmith if you have a pointer to a good place to look at something that would be applicable for inspiration, I can do that
15:00:58 gibi sure: https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_pci_in_placement.py this has good examples
15:01:48 gibi actually VM boots with PCI in Placement starts here https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_pci_in_placement.py#L1618
15:02:24 dansmith cool, I'll get to a stopping point in the other thing I'm doing soon and try to add some more of that
15:02:41 bauzas oh doh
15:02:50 bauzas forgot we got daylight savings here
15:03:04 bauzas I was about to yell to Uggla he forgot the meeting :D
15:03:33 gibi dansmith: cool
15:05:53 gibi dansmith: you probably need to extend our assert to check for the reserved value on the inventory here https://github.com/openstack/nova/blob/98226b60f3fe7b20e8d7f208c12f8d0086cd83d0/nova/tests/functional/libvirt/test_pci_sriov_servers.py#L182-L188
15:06:31 gibi as today only total and max_unit is asserted
15:07:08 Uggla Meeting in around 1h
15:08:14 dansmith ack
15:09:25 Uggla @artom, ok I have seen the cross session needs.
15:18:52 dansmith gibi: I'm not sure I can write those functional tests
15:27:06 dansmith well, the delay has messed up the joke.. I was going to say "I can't bring myself to waste enough vertical space to fit the style in that file"
15:27:52 dansmith Uggla: can we do an os-traits release to get the new one that merged this morning? we can't really test functionally until that's available in our reqs/venvs
15:29:43 Uggla @dansmith, yes I think so. I'll propose a patch for it right after the Epoxy release. Will it be ok for you ?
15:30:13 dansmith gibi: don't get me started
15:30:42 gibi :)
15:30:51 dansmith Uggla: I guess I'll put these in a separate patch since they won't pass until then. I already have a local patch to add just the trait reporting thing to a functional test, which can't work in CI until the os-traits release
15:31:07 dansmith so I'll just add some more in there and push that up with the caveat that it won't work until that releases
15:32:02 dansmith gibi: ^ re: functionals in a separate patch, at least for the moment
15:32:17 Uggla @dansmith, ok lgtm
15:32:53 gibi dansmith: works for me too
15:33:43 dansmith I had stopped looking at the functional stuff since I had to hack my local env with the trait to get even basic stuff working, but I'll just do that so I can make some progress there
15:34:13 dansmith gibi: unfortunately, the '\n' bytes are free, it's the screen real estate and the burning feeling in my eyeballs that is not
15:36:12 gibi true
15:37:53 gibi what if you add a new test_ file for otu and use your own style? I would totally accept that
15:38:34 gibi the current file is already 2000 LOC so it is reasonable to split
15:40:59 dansmith I already hate that nova has grown this very-different style from it's reasonably-consistent-just-not-machine-formatted style before this madeness
15:41:43 dansmith so further splitting and being different to all the other PCI-in-placement tests here doesn't seem beneficial, except for my eyeballs
15:42:27 dansmith I will attempt to hold my tongue and just do it, but if I can't stand it I'll split
15:42:42 dansmith I don't *think* there will be a lot of OTU tests here
15:42:48 dansmith there's just not that much to do I think
15:47:32 gibi dansmith: understood
15:47:58 gibi I'm not sure how nova kept the resonably consistent style in the past
15:48:27 gibi were there stricter reviewers back then?
15:49:13 gibi less hippy devs?
15:49:49 dansmith a lot of existing code and people copying the style that was there
15:50:24 dansmith we also had some guidelines like breaking lines with parens instead of backslashes, and several of the pep8 style guidelines which were not machine enforced
15:50:39 dansmith a lot of people wrote a lot of reasonably-consistent code before machine formatting made everything reliably ugly :)
15:55:45 Uggla Meeting in 5mn.
16:01:42 opendevmeet The meeting name has been set to 'nova'
16:01:42 opendevmeet Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:01:42 opendevmeet Meeting started Tue Apr 1 16:01:42 2025 UTC and is due to finish in 60 minutes. The chair is Uggla. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:01:42 Uggla #startmeeting nova
16:01:50 Uggla Hello everyone
16:02:23 masahito o/
16:02:26 dansmith o/
16:02:42 gibi o/
16:02:52 sean-k-mooney o/

Earlier   Later