| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-02-26 | |||
| 00:51:16 | sean-k-mooney[m] | so we just use nova manage in a k8s cron job instead | |
| 00:51:39 | sean-k-mooney[m] | i.e. we keep is simpel using the upstream tooling | |
| 00:52:15 | sean-k-mooney[m] | im not saying it could never be in scope but it was not in the mvp list for v1 | |
| 00:52:32 | melwitt | yeah | |
| 00:54:00 | sean-k-mooney[m] | ill try and add that to my review list for tomorrow | |
| 00:54:29 | sean-k-mooney[m] | its not nessisally impacted by ff but while i have context i might as well | |
| 00:55:26 | melwitt | haha thanks | |
| 00:55:48 | sean-k-mooney[m] | if you feel like reviewing something small this and the repoducer under neath is waiting for a second +2 https://review.opendev.org/c/openstack/nova/+/932931/2 although i pinged sylain to hopefully take a look above | |
| 00:57:01 | sean-k-mooney[m] | i think its time i went to sleep chat to you tomorrow o/ | |
| 00:57:07 | melwitt | sylvain would be ideal for that one but if he doesn't get to it I can do it | |
| 00:57:13 | melwitt | seeya tomorrow o/ | |
| 01:24:46 | opendevreview | Merged openstack/nova master: Fix device type when booting from ISO image https://review.opendev.org/c/openstack/nova/+/909611 | |
| 01:39:28 | opendevreview | melanie witt proposed openstack/nova master: DNM test headers https://review.opendev.org/c/openstack/nova/+/942752 | |
| 06:38:33 | opendevreview | Amit Uniyal proposed openstack/nova master: WIP: remove swap.disk from disk.info https://review.opendev.org/c/openstack/nova/+/942759 | |
| 06:45:22 | opendevreview | melanie witt proposed openstack/nova master: DNM test headers https://review.opendev.org/c/openstack/nova/+/942752 | |
| 08:50:33 | opendevreview | Merged openstack/nova master: Add repoducer test for bug 2074219 https://review.opendev.org/c/openstack/nova/+/932930 | |
| 09:11:53 | bauzas | gibi: sean-k-mooney[m] : I'd appreciate if you could get a swing for https://review.opendev.org/c/openstack/nova/+/845757/ | |
| 09:12:08 | bauzas | I'll also try to look at the functests failing | |
| 09:20:42 | opendevreview | Amit Uniyal proposed openstack/nova stable/2024.2: WIP: remove swap.disk from disk.info https://review.opendev.org/c/openstack/nova/+/942764 | |
| 09:31:03 | opendevreview | Amit Uniyal proposed openstack/nova stable/2024.1: WIP: remove swap.disk from disk.info https://review.opendev.org/c/openstack/nova/+/942765 | |
| 09:34:49 | opendevreview | Callum Dickinson proposed openstack/nova master: Add image meta to libvirt XML metadata https://review.opendev.org/c/openstack/nova/+/942766 | |
| 09:54:29 | opendevreview | Amit Uniyal proposed openstack/nova stable/2023.2: WIP: remove swap.disk from disk.info https://review.opendev.org/c/openstack/nova/+/942769 | |
| 10:17:21 | gibi | bauzas: is it something we need to land before FF or something we can land after FF? | |
| 10:17:53 | bauzas | gibi: well, this is not really a bugfix | |
| 10:18:17 | bauzas | but it fixes evecuates for VGPUs | |
| 10:38:37 | opendevreview | Merged openstack/nova master: Fix detaching devices by alias with mdevs https://review.opendev.org/c/openstack/nova/+/932931 | |
| 11:18:49 | opendevreview | Callum Dickinson proposed openstack/nova master: Add image meta to libvirt XML metadata https://review.opendev.org/c/openstack/nova/+/942766 | |
| 11:25:09 | sean-k-mooney | bauzas: ack ill add it to my list, i have to do a pass on the nova-operator stuff and then melwitt's nova-manage command today but i think i can get to those as well | |
| 11:25:59 | sean-k-mooney | bauzas: i think it might fix evacuate for anything with nested resouce providers if i rememebr correctly | |
| 11:26:41 | sean-k-mooney | maybe not | |
| 11:27:06 | sean-k-mooney | that not the patch i was thinkign of | |
| 11:43:02 | opendevreview | Stefan Hoffmann proposed openstack/os-vif master: [ovs] Add method to get external_ids from Interface https://review.opendev.org/c/openstack/os-vif/+/942715 | |
| 12:04:40 | opendevreview | Stefan Hoffmann proposed openstack/nova master: optional wait for ovn plug and create tap https://review.opendev.org/c/openstack/nova/+/942786 | |
| 16:30:52 | frickler | Uggla: please check https://review.opendev.org/c/openstack/governance/+/942507/comment/029df38c_6df9f638/ . it would likely also be helpful if you could join the #openstack-tc channel while you are PTL | |
| 16:32:36 | Uggla | frickler, I'm currently in a meeting, but I'will have a look after. | |
| 16:34:04 | frickler | Uggla: thx, not urgent, just so you don't miss it | |
| 16:53:44 | sean-k-mooney | dviroel: left some minor feedback on https://review.opendev.org/c/openstack/nova/+/938604 but i think this is mostly good to go | |
| 16:55:56 | dviroel | sean-k-mooney: oh, thanks, indeed, going to update it | |
| 16:56:25 | sean-k-mooney | im looking at the tempest patch now so far looks good to me | |
| 17:05:21 | sean-k-mooney | dviroel: minor comment on https://review.opendev.org/c/openstack/tempest/+/939375 as well | |
| 17:05:40 | sean-k-mooney | over all it looks fine to me but i htink you need to update teh import | |
| 17:06:19 | sean-k-mooney | gmann: ^ would you be able to comment on the questions i have inline and confirm the schema inheritance is correct or not? | |
| 17:38:49 | opendevreview | Douglas Viroel proposed openstack/nova master: Add support for showing scheduler_hints in server details https://review.opendev.org/c/openstack/nova/+/938604 | |
| 17:40:42 | dviroel | sean-k-mooney: ^ updated. Lets see if functional is going to pass. I added a scheduler hint to the server creation req | |
| 17:41:00 | dviroel | in the api_sample_tests | |
| 17:45:34 | sean-k-mooney | assuming it green i think ill be +2 | |
| 17:45:41 | sean-k-mooney | ill check back in a bit once we get some results | |
| 17:46:40 | sean-k-mooney | if it does break thign we can revert that chagne and try and update it in a follow uponce the feature is merged | |
| 17:48:15 | sean-k-mooney | dviroel: it looks a little funky https://5671b50e1757693146fd-d2676880cd4ce07846d9d5d9e5ab28d1.ssl.cf1.rackcdn.com/938604/11/check/build-openstack-api-ref/6d89054/docs/#id30 | |
| 17:48:35 | sean-k-mooney | i have not looked at the code but did you really use a regex? | |
| 17:48:37 | sean-k-mooney | "scheduler_hints": { | |
| 17:48:39 | sean-k-mooney | "same_host": [ | |
| 17:48:41 | sean-k-mooney | "[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}" | |
| 17:48:43 | sean-k-mooney | ] | |
| 17:48:45 | sean-k-mooney | }, | |
| 17:51:40 | dviroel | i was reusing an example from a sever creation | |
| 17:51:45 | dviroel | v2.63 i think | |
| 17:52:08 | sean-k-mooney | ok well it net to be a uuid | |
| 17:52:19 | sean-k-mooney | as in the example respocne shoudl not be the validation critia | |
| 17:52:37 | sean-k-mooney | it shoudl be somethign like "dc877f7e-7d69-4c3c-956b-1978cd8ed754" | |
| 17:52:59 | dviroel | yeah, let me fix that | |
| 17:53:28 | sean-k-mooney | its apprently an arry of uuids | |
| 17:53:45 | sean-k-mooney | at least based on your tempets change | |
| 17:55:25 | sean-k-mooney | oh | |
| 17:55:36 | sean-k-mooney | it can be a single uuid as a stirng or an away or them | |
| 17:55:59 | sean-k-mooney | the 2.90 create exmaple has | |
| 17:56:04 | sean-k-mooney | "OS-SCH-HNT:scheduler_hints": { | |
| 17:56:06 | sean-k-mooney | "same_host": "48e6a9f6-30af-47e0-bc04-acaed113bb4e" | |
| 17:56:08 | sean-k-mooney | } | |
| 17:56:43 | sean-k-mooney | as an example in the request | |
| 17:56:58 | sean-k-mooney | so you can just do the same in the responce example | |
| 17:57:18 | sean-k-mooney | well without the OS-SCH-HNT prefix | |
| 17:57:52 | sean-k-mooney | everything else looked good excpti the example value | |
| 18:01:10 | dviroel | yeah, they are adding this in the request sample, but not in the template, but the test does not validate that | |
| 18:03:48 | melwitt | huh, yeah, this should not have been a regex 😝 https://github.com/openstack/nova/blob/master/doc/api_samples/servers/v2.63/server-create-req.json someone missed that in review | |
| 18:04:08 | sean-k-mooney | ya.. i noticed it was broken there | |
| 18:04:25 | sean-k-mooney | but given that out of scop of dviroel's patch i decied not to mention that | |
| 18:04:36 | sean-k-mooney | im sure we have other cases where that has happen | |
| 18:05:12 | melwitt | well he mentioned it above, that's how I found it | |
| 18:06:33 | sean-k-mooney | melwitt: since your about would you have tim eto take a look at dviroel patch since you have recently look at all this for the other api changes | |
| 18:07:15 | dviroel | i used the 'uuid' - and it the end, it was replace in the post server: https://opendev.org/openstack/nova/src/commit/8f57fa7359d57e186fc6b75424b4900dc63c564f/nova/tests/functional/api_sample_tests/test_servers.py#L70 | |
| 18:07:18 | melwitt | yeah, I can look at it | |
| 18:07:39 | sean-k-mooney | cool https://review.opendev.org/c/openstack/nova/+/938604/11 is the nova change and https://review.opendev.org/c/openstack/tempest/+/939375 is the tempest update, finall https://review.opendev.org/c/openstack/nova/+/942728 pulls those together | |
| 18:08:09 | sean-k-mooney | dviroel: i will try and look at the sdk and clinet changes also but nova and tempest are the priorities | |
| 18:09:52 | dviroel | ack, thanks sean-k-mooney - yeah, not so sure if my client change is correct, ptal when you have some time | |
| 18:21:22 | opendevreview | Douglas Viroel proposed openstack/nova master: Add support for showing scheduler_hints in server details https://review.opendev.org/c/openstack/nova/+/938604 | |
| 18:30:41 | gmann | sean-k-mooney: sure, checking | |
| 18:50:39 | opendevreview | ribaudr proposed openstack/nova master: Add live_migratable flag to PCI device specification https://review.opendev.org/c/openstack/nova/+/942144 | |
| 18:50:39 | opendevreview | ribaudr proposed openstack/nova master: Augment the LiveMigrateData object https://review.opendev.org/c/openstack/nova/+/942143 | |
| 18:50:40 | opendevreview | ribaudr proposed openstack/nova master: Update conductor and filters allowing migration with SR-IOV devices https://review.opendev.org/c/openstack/nova/+/942146 | |
| 18:50:40 | opendevreview | ribaudr proposed openstack/nova master: Update manager to allow vfio pci device live migration https://review.opendev.org/c/openstack/nova/+/942145 | |
| 18:50:41 | opendevreview | ribaudr proposed openstack/nova master: Update driver to map the targeted address for SR-IOV PCI devices https://review.opendev.org/c/openstack/nova/+/942147 | |
| 19:04:47 | opendevreview | ribaudr proposed openstack/nova master: Update conductor and filters allowing migration with SR-IOV devices https://review.opendev.org/c/openstack/nova/+/942146 | |
| 19:04:48 | opendevreview | ribaudr proposed openstack/nova master: Update driver to map the targeted address for SR-IOV PCI devices https://review.opendev.org/c/openstack/nova/+/942147 | |
| 19:14:58 | mikal | Morning | |
| 19:19:22 | opendevreview | Callum Dickinson proposed openstack/nova master: Add image meta to libvirt XML metadata https://review.opendev.org/c/openstack/nova/+/942766 | |
| 19:21:52 | opendevreview | Ryota, Ochiai proposed openstack/nova master: doc: Delete deprecated settings of the installation guide https://review.opendev.org/c/openstack/nova/+/896074 | |
| 20:12:31 | gmann | sean-k-mooney: dviroel: reviewed the nova and tempest change, we are missing the update server APIs changes which is also impacted when we update the views/servers.py | |
| 20:13:04 | gmann | in nova side it is just documentation and test and in tempest tests we need to add schems and test for update server | |
| 20:16:28 | dviroel | gmann: oh thanks, I missed the update server. going to propose an update, thanks | |