| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-02-17 | |||
| 18:19:09 | sean-k-mooney | https://bugs.launchpad.net/nova/+bug/1915282 | |
| 18:20:18 | sean-k-mooney | bauzas:... i didn hit reply on my comment this morning | |
| 18:20:33 | sean-k-mooney | but ill check if they are stilll relevent or not | |
| 18:21:17 | sean-k-mooney | sort of but not worth a respin unless your fixing somethign else | |
| 18:22:53 | sean-k-mooney | bauzas: if its after FF then it would be a seperate releae note anyway because the behavior would differ across release | |
| 18:23:01 | sean-k-mooney | but amending it is fine IMO | |
| 18:23:26 | sean-k-mooney | as long as its i nthe same release i think that is preferable | |
| 18:23:41 | bauzas | I need to hardstop now, I'm basically fried | |
| 18:23:53 | bauzas | but I'll look at your comments tomorrow for sure | |
| 18:24:19 | bauzas | and yeah for the reno, it was just a tradeoff : if we merge both, that's simplier than an additional note | |
| 18:24:44 | bauzas | if we can only merge the bottom patch, then I'll respin for not breaking our release notes | |
| 18:25:07 | sean-k-mooney | i think im +2 on the first patch as well but im goign to step away for a sec and ill reivew both properly when i get back and leave +w then to gibi | |
| 18:52:05 | sean-k-mooney | dansmith: i commeted on teh normailzeation for what its worth i think the code is correct | |
| 18:54:55 | dansmith | I don't think the code is wrong as-is, it's just not what I was expecting | |
| 18:55:10 | dansmith | I think it's also not wrong to normalize the actual ratio values | |
| 18:55:56 | dansmith | totally independent of the cross-weigher normalization that happens | |
| 18:56:12 | sean-k-mooney | correct but there is also intra weigher nomralistaion | |
| 18:57:05 | sean-k-mooney | before the corss weigher nomalisation hapens we normaliase the wighet for each whost within a weigher | |
| 18:57:25 | sean-k-mooney | this was added for the disk weigher orgianlly but we did it geneically for all weighers | |
| 18:58:50 | dansmith | um, maybe I'm missing something | |
| 18:59:35 | dansmith | if I set os_distro=5000 then it will score os_distro on the same scale as like disk usage or any other weigher in this situation, no? | |
| 18:59:48 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/weights.py#L144-L146 takes all the final restuls for a given wieher and normaises them in a range of -1 to 1 | |
| 19:00:00 | sean-k-mooney | no it wont | |
| 19:01:02 | sean-k-mooney | for that host it that was all that was set 5000 would be the result of the wight for tha host | |
| 19:01:34 | sean-k-mooney | then we will get the min/max values fo the weigher and normalise the weighte to the range for 0-1.0 | |
| 19:01:36 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/weights.py#L144-L146 | |
| 19:02:16 | dansmith | okay I didn't think it worked that way, but that's good.. why can't we just use integers for the per-property weights then? Just seems cleaner than floats (as I noted on an earlier patch) | |
| 19:02:28 | sean-k-mooney | we can | |
| 19:02:42 | sean-k-mooney | it does not need to be a flot but it was for the metrics weigher | |
| 19:02:54 | sean-k-mooney | so that you could exprss 0.5 | |
| 19:03:06 | sean-k-mooney | if you wanted to make someting half as impronat | |
| 19:03:16 | sean-k-mooney | you can obviouly just invert that and multiple the other value by 2 | |
| 19:03:44 | sean-k-mooney | so "to be the same as the metric weigher" is the only reason to allow floats | |
| 19:04:03 | dansmith | yeah, integers would just be better, but it doesn't matter that much | |
| 19:04:28 | sean-k-mooney | it was copied form here https://github.com/openstack/nova/blob/master/nova/weights.py#L144-L146 | |
| 19:05:00 | sean-k-mooney | so i dont really have a stong opipion on that point so what ever works for you, gibi and sylvian is fine by me | |
| 19:08:36 | sean-k-mooney | in case you care about hte history of the normalisation change it was done in https://github.com/openstack/nova/commit/e5ba8494374a1b049eae257fe05b10c5804049ae but that not really impoant | |
| 19:14:47 | mikal | Morning | |
| 19:14:56 | sean-k-mooney | o/ | |
| 19:17:38 | mikal | Apart from people being generally time poor, is there anything blocking the SPICE API changes right now that I should know about? I feel with the tempest test and devstack changes merged we should probably try and merge the matching API microversion sooner rather than later. | |
| 19:19:34 | sean-k-mooney | so https://review.opendev.org/c/openstack/os-traits/+/940418 is still pending and we are coming up to the non client lib freeze so the followup serise for sound and usb is at risk. i think that an easy review ot land IMO but i dont knwo if melwitt will have time to revisit teh patch or if others will | |
| 19:19:42 | sean-k-mooney | i have not looked at the rest in a few days | |
| 19:21:10 | mikal | I think the API changes are more important as they're the most painful bit to keep rebasing, but I would link to try and land all of them if possible. I've been rebasing these things for over a year now. | |
| 19:23:46 | melwitt | sean-k-mooney: for the os-traits patch I don't have an opinion about since I don't really know anything about that stuff. I asked questions in case it could spark yalls memory whether anything was missing or needed to be changed. so if no one else finds any problem about it I think I can +W with your SME +2 on there | |
| 19:26:04 | melwitt | I will look at the API changes again. it can be more challenging if past comments are not addressed yet and we have to keep going back and forth on that. if that's all squared away and the tempest test is done and passing, that's good and helps a lot | |
| 19:28:34 | sean-k-mooney | ack | |
| 19:28:54 | sean-k-mooney | so on the testing font we have a few related patches | |
| 19:29:27 | sean-k-mooney | i have patches up to move the nova-ovs-hybrid-plug job to debain and enabel spice (including speice testing in tempest) | |
| 19:29:50 | sean-k-mooney | that involes change to nova and devstack and tempest | |
| 19:30:29 | sean-k-mooney | melwitt: mikal split there serise in 2 1 for spice direct, and a second indepently mergable vid series for the usb/soudn devices | |
| 19:31:08 | sean-k-mooney | in the spice serise they have a depends on agains the tepmest change and my ci testing series so that pulls everything toghter and showe it working end to end | |
| 19:32:05 | melwitt | sean-k-mooney: ok cool. my understanding is we are focusing on the spice direct, the first 3 patches | |
| 19:32:15 | sean-k-mooney | so https://review.opendev.org/c/openstack/nova/+/924844/36 is the patch that pulls everythign togheter and depend on the rest | |
| 19:32:22 | sean-k-mooney | yes | |
| 19:33:18 | melwitt | right, cool | |
| 19:34:34 | sean-k-mooney | so one thing we might need to do is change the depns on order | |
| 19:35:04 | sean-k-mooney | the devstack and tempest changes have merged | |
| 19:35:37 | sean-k-mooney | so i shoudl proably merge my 2 jobs changes into one and rebase it on mikal's series | |
| 19:36:00 | sean-k-mooney | actuly no | |
| 19:36:05 | sean-k-mooney | it can merge as is | |
| 19:36:15 | sean-k-mooney | in my serise i dont update the regex to enabel the new test | |
| 19:36:21 | sean-k-mooney | that only happens in mikal's | |
| 19:36:27 | mikal | sean-k-mooney: at least one of your patches needs a recheck too I think. | |
| 19:36:46 | sean-k-mooney | i have a pep8 issue | |
| 19:36:47 | melwitt | ack | |
| 19:36:55 | sean-k-mooney | so i need to update mine anyway | |
| 19:37:14 | sean-k-mooney | releasenotes/notes/make-virtio-the-default-spice-video-model-fff5189fa637d4bd.yaml:8: supprot ==> support | |
| 19:37:24 | sean-k-mooney | i have a typo in the release note | |
| 19:39:03 | sean-k-mooney | its in the bottom of my two paches so ill update them both now | |
| 19:42:45 | sean-k-mooney | hum odd that was already fixed | |
| 19:43:50 | sean-k-mooney | ill just rebase them and check again | |
| 19:52:46 | opendevreview | sean mooney proposed openstack/nova master: Dont deploy n-spice on compute nodes. https://review.opendev.org/c/openstack/nova/+/940873 | |
| 19:52:46 | opendevreview | sean mooney proposed openstack/nova master: move nova-ovs-hybrid-plug to deploy with spice and fix qxl default https://review.opendev.org/c/openstack/nova/+/940835 | |
| 19:55:35 | sean-k-mooney | gerrit rejected my rebase as identical | |
| 19:55:55 | sean-k-mooney | so i just reflowed the release note to be less then 80 cols | |
| 19:56:08 | mikal | Oh they typo one? I pushed a fix for that to your review a week or so ago IIRC. | |
| 20:04:32 | sean-k-mooney | ya for some reason pep8 didnt run again? | |
| 20:04:36 | sean-k-mooney | it super odd | |
| 20:07:31 | opendevreview | Merged openstack/nova master: Drop dependency on netifaces https://review.opendev.org/c/openstack/nova/+/931582 | |
| 20:07:42 | opendevreview | Merged openstack/nova master: Reproduce bug/2097359 https://review.opendev.org/c/openstack/nova/+/940603 | |
| 20:07:49 | opendevreview | Merged openstack/nova master: Update InstanceNUMACell version after data migration https://review.opendev.org/c/openstack/nova/+/940604 | |
| 20:45:50 | opendevreview | Merged openstack/nova master: Update InstanceNUMACell version in more cases https://review.opendev.org/c/openstack/nova/+/940953 | |
| 20:46:02 | opendevreview | Merged openstack/nova master: Add support for showing image properties in server show response https://review.opendev.org/c/openstack/nova/+/939649 | |
| 20:46:08 | opendevreview | Merged openstack/nova master: Disable the heal instance info cache periodic task https://review.opendev.org/c/openstack/nova/+/939476 | |
| 23:05:16 | sean-k-mooney | mikal: since https://review.opendev.org/c/openstack/nova/+/939649 was landed we will unfortunlty need to bump the microversion for the spice direct patch | |
| 23:19:52 | opendevreview | Doug Goldstein proposed openstack/nova master: ironic: fix logging of validation errors https://review.opendev.org/c/openstack/nova/+/942019 | |
| 23:26:34 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Add [libvirt]default_tpm_secret_security https://review.opendev.org/c/openstack/nova/+/940194 | |
| 23:26:35 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Add [libvirt]supported_tpm_secret_security https://review.opendev.org/c/openstack/nova/+/940195 | |
| 23:26:36 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Add hw:tpm_secret_security extra spec validation https://review.opendev.org/c/openstack/nova/+/940197 | |
| 23:26:36 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Add hw_tpm_secret_security image property https://review.opendev.org/c/openstack/nova/+/940196 | |
| 23:26:37 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: TPM: support instances with `host` secret security https://review.opendev.org/c/openstack/nova/+/941795 | |
| 23:26:37 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Ensure secret security policy for TPM instances https://review.opendev.org/c/openstack/nova/+/941062 | |
| 23:26:38 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Modify vTPM LM block to block legacy instances https://review.opendev.org/c/openstack/nova/+/941483 | |
| 23:26:38 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Allow vTPM live migration for `deployment` secret security https://review.opendev.org/c/openstack/nova/+/925771 | |
| 23:26:39 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: TPM: support instances with `deployment` secret security https://review.opendev.org/c/openstack/nova/+/942021 | |
| 23:32:43 | mikal | sean-k-mooney: ummm, that will require a new tempest change as well then. That's very disappointing. | |
| 23:33:20 | sean-k-mooney | ya i really didnt want ot merge that until your patch was in | |
| 23:40:31 | mikal | https://review.opendev.org/c/openstack/tempest/+/942023 is the tempest renumbering. gmann you'll need to take a look at that one soonish please. | |
| 23:41:00 | mikal | We wont see an end-to-end run though until I get a chance to renumber the nova API changes as well. | |
| 23:41:13 | sean-k-mooney | strictly speakign that should have a depends on against the nova change | |