| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-02-06 | |||
| 19:18:54 | opendevreview | Michael Still proposed openstack/nova master: Don't calculate the minimum compute version repeatedly. https://review.opendev.org/c/openstack/nova/+/940848 | |
| 19:18:55 | opendevreview | Michael Still proposed openstack/nova master: Protect older compute managers from sound model requests. https://review.opendev.org/c/openstack/nova/+/940770 | |
| 19:18:55 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra spec for sound device. https://review.opendev.org/c/openstack/nova/+/926126 | |
| 19:18:56 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra specs for USB redirection. https://review.opendev.org/c/openstack/nova/+/927354 | |
| 19:19:07 | mikal | ^--- fixes a one character error in the first patch in that series | |
| 19:20:42 | sean-k-mooney | ah you have split out the sound/usb ones and the performance improvment, nice | |
| 19:22:55 | mikal | Yeah, I wrote up a decoder ring on the etherpad because its getting complicated -- https://etherpad.opendev.org/p/nova-2025.1-status | |
| 19:23:20 | mikal | But there's basically two independent series now -- the API changes, and the "VDI changes" (sound, usb, compute version bumps etc). | |
| 19:23:53 | mikal | I agree we should focus on the API changes first, but that's blocking right now on me getting some quality time with tempest. | |
| 19:27:27 | sean-k-mooney | in its current form both can be merged in either order and in parallel so that will help i think. | |
| 20:14:21 | sean-k-mooney | mikal: https://zuul.opendev.org/t/openstack/build/842a66f2cfe54eb39d856a3bf311bb5c | |
| 20:14:34 | sean-k-mooney | mikal: debian works and the job passes with it | |
| 20:15:04 | sean-k-mooney | so ill revert the commetned out jobs but we should be able to test in that job | |
| 20:27:39 | opendevreview | sean mooney proposed openstack/nova master: Dont deploy n-spice on compute nodes. https://review.opendev.org/c/openstack/nova/+/940873 | |
| 20:27:39 | opendevreview | sean mooney proposed openstack/nova master: move nova-ovs-hybrid-plug to deploy with spice and fix qxl default https://review.opendev.org/c/openstack/nova/+/940835 | |
| 20:34:21 | mikal | sean-k-mooney: cool, thank you. I assume we still want to do a tempest test, which I will try to actually get around to attempting today. | |
| 20:35:21 | sean-k-mooney | i think so but those should help with a job we can run the test in | |
| 20:35:56 | mikal | Agreed | |
| 20:36:05 | mikal | Thanks for chasing this bit for me. | |
| 20:36:09 | sean-k-mooney | i just added those to the etherpad too with some explanations | |
| 20:36:28 | mikal | Cool | |
| 20:36:45 | sean-k-mooney | mikal: if nothing else, we have not deprecated spice supprot and there is litrally no spice job anywhere so just for that i consider those to be a win | |
| #openstack-nova - 2025-02-07 | |||
| 06:11:58 | mikal | sean-k-mooney / dansmith / melwitt: https://review.opendev.org/c/openstack/tempest/+/940943 is an attempt at a tempest test for the spice-direct stuff. I think it likely needs to be entangled with sean-k-mooney's devstack and zuul config changes to actually work though. | |
| 06:13:14 | mikal | I've put it on the etherpad as well at the end of the API series. | |
| 07:37:58 | opendevreview | benlei proposed openstack/nova master: Abort live migration task when stop nova compute service https://review.opendev.org/c/openstack/nova/+/938223 | |
| 10:34:48 | opendevreview | Balazs Gibizer proposed openstack/nova master: Bump InstanceNUMACell version after data migration https://review.opendev.org/c/openstack/nova/+/940604 | |
| 10:34:49 | opendevreview | Balazs Gibizer proposed openstack/nova master: Bump InstanceNUMACell version after half migration https://review.opendev.org/c/openstack/nova/+/940953 | |
| 10:55:37 | Uggla | Tentative vGPU vfio discussing latest open points. Friday, February 7 · 14:00 – 14:45 UTC link: https://meet.google.com/hia-iodh-fcz | |
| 11:10:35 | opendevreview | Taketani Ryo proposed openstack/nova-specs master: Add a spec for libvirt driver launching Arm CCA-encrypted instances https://review.opendev.org/c/openstack/nova-specs/+/938276 | |
| 11:20:13 | opendevreview | Balazs Gibizer proposed openstack/nova master: Update InstanceNUMACell version in more cases https://review.opendev.org/c/openstack/nova/+/940953 | |
| 11:20:13 | opendevreview | Balazs Gibizer proposed openstack/nova master: Update InstanceNUMACell version after data migration https://review.opendev.org/c/openstack/nova/+/940604 | |
| 11:20:14 | opendevreview | Balazs Gibizer proposed openstack/nova master: Refactor InstanceNUMA* data migrations https://review.opendev.org/c/openstack/nova/+/940958 | |
| 11:30:01 | opendevreview | Balazs Gibizer proposed openstack/nova master: Update InstanceNUMACell version in more cases https://review.opendev.org/c/openstack/nova/+/940953 | |
| 12:40:58 | opendevreview | Balazs Gibizer proposed openstack/nova master: Update InstanceNUMACell version in more cases https://review.opendev.org/c/openstack/nova/+/940953 | |
| 12:41:25 | opendevreview | Rajesh Tailor proposed openstack/nova master: Add support for showing image properties in server show response https://review.opendev.org/c/openstack/nova/+/939649 | |
| 12:47:49 | gibi | dansmith: the pcpuset fix is now split and hopefully satisfies CI https://review.opendev.org/q/topic:%22bug/2097359%22 | |
| 12:52:29 | sean-k-mooney | mikal: ill be back on monday, im on pto today but we should be able to add a patch to nova on top of my series that depend on that and your api change and that will demonstrate it workign end to end, you can have depneds on in the same repo we just normally dont becuase its harder to debug if there is a merge conflcit, but it will mean we do not need to stack the patches. | |
| 15:09:44 | opendevreview | ribaudr proposed openstack/nova master: Bump os-traits to 3.3.0 in requirements https://review.opendev.org/c/openstack/nova/+/940975 | |
| 15:16:27 | opendevreview | ribaudr proposed openstack/placement master: Bump os-traits to 3.3.0 in requirements https://review.opendev.org/c/openstack/placement/+/940976 | |
| 16:05:36 | opendevreview | Balazs Gibizer proposed openstack/nova master: [test]generic OVO version update tests https://review.opendev.org/c/openstack/nova/+/940984 | |
| 16:07:23 | gibi | dansmith: ^^ this is my fist stab about the generic ovo version update testing | |
| 16:08:04 | dansmith | ack | |
| 16:08:09 | gibi | it already able to catch the pcpuset bug while showing that the same bug is not reproducible via request_spec.numa_topology just via instance.numa_topology | |
| 16:10:52 | dansmith | cool | |
| 16:14:24 | cardoe | hoping to get https://review.opendev.org/c/openstack/nova/+/940836 approved as a backport. I'll also propose it to 2024.1 which is where the issue was first introduced but my present use case is 2024.2 with ironic | |
| 16:25:01 | opendevreview | Sylvain Bauza proposed openstack/nova master: Add a new ImagePropertiesWeigher https://review.opendev.org/c/openstack/nova/+/940642 | |
| 16:30:01 | opendevreview | Doug Szumski proposed openstack/nova master: Stop corrupting ephemeral volumes during live migration https://review.opendev.org/c/openstack/nova/+/940900 | |
| #openstack-nova - 2025-02-10 | |||
| 10:54:36 | sean-k-mooney | gibi: i forgot to hit send, the numa code and pci code expect that its workign with an upleveled object at least for the instance numa objectss | |
| 10:55:05 | sean-k-mooney | so i disagre that that how nova was designed | |
| 10:55:22 | sean-k-mooney | it might have been how dansmith intenetd we use ovo in nova | |
| 10:55:51 | sean-k-mooney | but in practice its not the mental model i or others had when writing the numa features | |
| 10:58:05 | sean-k-mooney | we always wote the code assuming the obejct would be version matched to the current processes class defintion | |
| 11:00:45 | gibi | sean-k-mooney: yeah I would like to use our ovos in a way that if a field is defined in the `fields` dict of the class then i) the ovo has that field always ii) the ovo hides all the necessary version forward (or backward) migration logic from the caller | |
| 11:01:17 | gibi | This is not the first time such assumption of mine gets invalidated | |
| 11:01:18 | sean-k-mooney | we should never loose data by upleveling, (unless we stop supporting a feature) | |
| 11:01:33 | sean-k-mooney | i dont think its invlaide | |
| 11:01:45 | sean-k-mooney | i think dansmith has been overcome by events | |
| 11:02:09 | sean-k-mooney | i.e. even if there view poitn was the orginal intent it not how we have been using them in the code for years | |
| 11:02:50 | sean-k-mooney | migration is fine by the way becasue we pass data with dedicated objects for live migration | |
| 11:03:01 | sean-k-mooney | so we not passing an instance numa toplogy object form one compute to another | |
| 11:03:21 | sean-k-mooney | were are always gettign it form teh conductor | |
| 11:03:30 | sean-k-mooney | or constucting it locally | |
| 11:04:30 | sean-k-mooney | the conductor will backlevel it if the compute is older but the compute can use the latest version it knows about in all cases | |
| 11:04:32 | gibi | I see | |
| 11:05:58 | sean-k-mooney | oh i did push my comments on teh follow up https://github.com/openstack/nova/blob/e27bbe72e0d293e55c30d4f90ca0afcf47427419/nova/compute/manager.py#L955-L958 | |
| 11:06:20 | sean-k-mooney | cool i was going to check _get_numa_constriats in hardware.py to see what we set it too | |
| 11:06:47 | sean-k-mooney | just since you might not know this. we use the instance numa toplogy in 2 ways. | |
| 11:07:23 | sean-k-mooney | for the schduler we partially popuplated it with the "requests" form the flavor/image | |
| 11:07:44 | sean-k-mooney | and then later we actully fully populated it with the actul cores/numa assignmentes on the compute node | |
| 11:08:31 | sean-k-mooney | so in the schduler 2 we jsut have "i woudl like 2 numa nodes please" and on the ocmpute we actully also record "sure you can have 1 an 3" | |
| 11:10:22 | sean-k-mooney | that may or may not be relevent jsut want to let you knwo that the api/sechduler use only a subset of the files. we could have had 2 obejct but we didnt for historical reasons i dont remember | |
| 11:12:50 | sean-k-mooney | well no, the intent was to evenutally have the scheduler/conductor do the numa claim in the db but we never did that so the idea was we woudl pass the fully populated numa toplogy obejct to the comptue isntead of claiming the speciric cores ectra on the compute | |
| 11:13:04 | sean-k-mooney | but we decied to build placement instead so never got around to that | |
| 11:14:27 | gibi | we have a case to return cpu_policy None from https://github.com/openstack/nova/blob/e27bbe72e0d293e55c30d4f90ca0afcf47427419/nova/virt/hardware.py#L1562 | |
| 11:14:41 | sean-k-mooney | https://github.com/openstack/nova/blob/e27bbe72e0d293e55c30d4f90ca0afcf47427419/nova/virt/hardware.py#L2294 | |
| 11:15:13 | sean-k-mooney | yep that exactly what i rememebred and wanted to confrim | |
| 11:15:55 | gibi | anyhow I pushed a fix that considers None the same as SHARED | |
| 11:16:12 | sean-k-mooney | yep i saw | |
| 11:16:15 | gibi | it seems we don't have the bot active posting the incoming patchsets | |
| 11:16:34 | sean-k-mooney | i still got the emails | |
| 11:16:59 | sean-k-mooney | i think there was a gerrit restart at teh weekend maybe the bot need to be restarted? | |
| 11:17:31 | gibi | yeah | |
| 11:17:47 | sean-k-mooney | the last review email was from friday as far as i can tell | |
| 11:17:52 | sean-k-mooney | any idea how to do that? | |
| 11:18:19 | gibi | nope | |
| 11:18:25 | gibi | probably infra knows | |
| 11:18:34 | sean-k-mooney | ok i was going to say letst just ask there | |
| 11:21:42 | sean-k-mooney | if i open a chat to opendevreview it does nto prompt with anythign so i guess its not contolled like that | |
| 13:59:48 | opendevreview | Rajesh Tailor proposed openstack/nova master: Add support for showing image properties in server show response https://review.opendev.org/c/openstack/nova/+/939649 | |
| 14:06:12 | gibi | hey the bot is back \o/ | |
| 14:06:55 | sean-k-mooney | yep fungi restarted it. there was an unplanned gerrit outage over the weekend i think and it just didnt reconnect | |
| 14:08:39 | fungi | yeah, if gerrit vanishes like happened that time (nova spontaneously stopped the vm, still waiting to hear back from the provider on a root cause), the client doesn't notice the server has gone away and continues listening on a tcp connection that will never receive new packets | |
| 14:09:23 | sean-k-mooney | nova only updates it to stopped if it sees it stopped on the libvirt side | |
| 14:09:32 | sean-k-mooney | or if it recived an api request to do so | |
| 14:09:58 | sean-k-mooney | so proably an issue on the underlying host like an OOM kills would be my guess | |
| 14:10:27 | sean-k-mooney | if they cant root cause it tell them to file a nova but and let use know and we can maybe point them in the right direction | |
| 15:10:57 | bauzas | hmmmpffff, I got a similar nova-next and nova-multicell failure for my patch | |
| 15:10:59 | bauzas | https://6944f33f3ef66c20bc22-320386062a8fef96051148fe5e7af6b1.ssl.cf5.rackcdn.com/940642/5/check/nova-next/c60809e/testr_results.html | |
| 15:11:05 | bauzas | https://8ea52cf6ed28836394cc-227b19b7b0e554c64ba32d661a445fcc.ssl.cf1.rackcdn.com/940642/5/check/nova-multi-cell/13c8443/testr_results.html | |
| 15:11:18 | bauzas | looks like our lordy gate is b0rken | |