| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-10-01 | |||
| 17:31:58 | gmann | yeah and add py3.12 also | |
| 17:32:07 | sean-k-mooney | yep | |
| 17:32:44 | tkajinam | I though I modified setup.cfg but I somehow reverted that change... | |
| 17:33:17 | opendevreview | Takashi Kajinami proposed openstack/nova master: Remove Python 3.8 support https://review.opendev.org/c/openstack/nova/+/931047 | |
| 17:33:23 | sean-k-mooney | that explains why v1 and v2 are the same exctp the commit message :) | |
| 17:33:52 | sean-k-mooney | gmann: you prefer not to bump python_requires in general yes | |
| 17:34:03 | sean-k-mooney | to allow it to install even if its not nessiarly compatible | |
| 17:34:14 | gmann | sean-k-mooney: yeah, it create problem more than benefit | |
| 17:34:24 | sean-k-mooney | without a downstream patch python once we revert to hashlibg directly it will fail on vanilla py38 | |
| 17:34:55 | sean-k-mooney | usedforsecurity does not exist in the upstream python 3.8 hashlib | |
| 17:35:04 | gmann | python versions listed in classifier should tell what all python versions are tested and supported and rest all no guarantee | |
| 17:35:08 | tkajinam | I'd say classifier is just useless because it does not enforce anything and have been unmantained for very long | |
| 17:35:11 | gmann | if it work as long as it is good | |
| 17:35:34 | gmann | this is just a info and doc we do not need to enforce things | |
| 17:36:08 | sean-k-mooney | gmann: right my point is nova wont work on py38 with this change (unless the distro backported the hashlib change to 3.8) | |
| 17:36:41 | tkajinam | what you are saying is equivalent to drop all min version from requirements, IMHO | |
| 17:37:05 | tkajinam | I don't know why we should maintain these although we won't maintain compat version for core python. | |
| 17:37:15 | sean-k-mooney | so tkajinam we may not be able to do this change this cycle | |
| 17:37:27 | sean-k-mooney | we still need ubuntu 22.04 for grenade | |
| 17:37:34 | sean-k-mooney | and i belive it uses 3.8 | |
| 17:37:56 | sean-k-mooney | this is the release whre we are moving all the ci to 24.04 but 22.04 is kept for smoth upgrades | |
| 17:38:08 | sean-k-mooney | 22.04 has alternitive pythons liek 3.9 | |
| 17:38:17 | sean-k-mooney | so we could use that instead but its not the default | |
| 17:38:34 | tkajinam | 22.04 uses 3.10 afaik | |
| 17:38:47 | sean-k-mooney | oh you might be right | |
| 17:38:55 | sean-k-mooney | i may have mixed that up | |
| 17:39:42 | sean-k-mooney | tkajinam: ah yes your correct | |
| 17:40:07 | sean-k-mooney | 20.04 used 3.8 22.04 is alredy 3.10 | |
| 17:40:09 | tkajinam | a few projects like cinder, heat, horizon, octavia already removed py38 support but they have survived | |
| 17:40:13 | tkajinam | yeah | |
| 17:40:44 | sean-k-mooney | so that means the oldest python we have in ci (for master at least) is already 3.9 on centos | |
| 17:41:07 | tkajinam | yes. 3.8 has been untested since 2024.2 | |
| 17:41:15 | sean-k-mooney | ack | |
| 17:41:15 | tkajinam | unless the repo contains the job left (eg. placement) | |
| 17:41:55 | sean-k-mooney | oh we missed updatign placement did we not merge the patch to update it for 2024.2? | |
| 17:42:44 | sean-k-mooney | https://review.opendev.org/c/openstack/placement/+/881366 ... | |
| 17:42:50 | gmann | sean-k-mooney: tkajinam I sent on ML to remove this flag. IMO, it will not hurt anything but avoid our effort to update and coordinate it everytime | |
| 17:42:54 | sean-k-mooney | i tought we merged that | |
| 17:43:28 | gmann | and coordination is always missing among all openstack project and this flag create issue | |
| 17:43:43 | sean-k-mooney | gmann: im ok to remove it but as i said we knwo it wont work this time and ya the cordination is tough | |
| 17:44:17 | sean-k-mooney | hopefully less of an issue now that python has a yearly releace cadnace and predicable EOL date | |
| 17:44:35 | gmann | yeah, everytime olso bump the min in this flag it fail many projects and it take time for fixing all their CI even fix is very simple | |
| 17:46:04 | sean-k-mooney | so im wondering if we should merge https://review.opendev.org/c/openstack/placement/+/881366 before https://review.opendev.org/c/openstack/placement/+/931033 or just go strait to tkajinam's patch | |
| 17:46:15 | sean-k-mooney | tkajinam: is there a reaosn you marked that WIP | |
| 17:46:16 | tkajinam | we do actually remove compatibilities in some repos. if we remove the min then it appears as wired errors instead of explicit failure during installation | |
| 17:47:35 | tkajinam | sean-k-mooney, I tought https://review.opendev.org/c/openstack/placement/+/925648 is the primary way but I'm fine with it... note that 925648 revealed that functional-py39 uses python 3.8 actually which needs to be fixed... | |
| 17:47:50 | tkajinam | I mean I'm ok to merge job update and leave min bump for now | |
| 17:48:10 | gmann | ++ | |
| 17:48:18 | sean-k-mooney | we have several patches for it in placement we just need to choose one to proceed with | |
| 17:49:10 | gmann | or merge all in single one, remove py3.8 job + add py301, py311 jobs and leave the min version bump | |
| 17:49:22 | sean-k-mooney | placement-perfload by the way is having a wheel build fialure for a missing header | |
| 17:49:51 | sean-k-mooney | i think that is unrelated and and existing fialure tha twe shoudl fix in a differnt patch | |
| 17:50:15 | sean-k-mooney | it has quite a few failures https://zuul.opendev.org/t/openstack/builds?job_name=placement-perfload&project=openstack%2Fplacement | |
| 17:51:00 | sean-k-mooney | im going to finish for today soon | |
| 17:51:03 | tkajinam | py311 functional job already exists and pass so I prefer to use it now and then replace it by py312 if needed | |
| 17:51:20 | gmann | ah yeah, ++ for py3.12 | |
| 17:51:38 | sean-k-mooney | im happy to go with gmann's suggestion fo a single path to do everythin and just test the upper and lower python version i.e. 3.9 and 3.12 for tox jobs | |
| 17:51:49 | tkajinam | ok | |
| 18:00:41 | sean-k-mooney | by the way 3.12 support is added by https://review.opendev.org/c/openstack/placement/+/919578/3 | |
| 18:01:10 | sean-k-mooney | the pre-commit series was all intended to be in 2024.2... | |
| 18:02:03 | sean-k-mooney | it would likely be best to merge https://review.opendev.org/c/openstack/placement/+/919578/3 first and then rebase tkajinam change on top | |
| 18:02:51 | sean-k-mooney | gmann: if we wanted to avoid the merge conflict merging up to https://review.opendev.org/c/openstack/placement/+/919580/3 before tkajinam's change woudl make sense | |
| 18:03:36 | gmann | sean-k-mooney: sure, will check after tc meeting | |
| 18:03:42 | sean-k-mooney | no worries | |
| 18:10:48 | opendevreview | Takashi Kajinami proposed openstack/placement master: Replace py38 job by py311 job https://review.opendev.org/c/openstack/placement/+/931033 | |
| 18:10:49 | opendevreview | Takashi Kajinami proposed openstack/placement master: Move upper functional job to py312 https://review.opendev.org/c/openstack/placement/+/931052 | |
| 20:39:35 | opendevreview | Merged openstack/placement master: tox: Simplify functional testenv definitions https://review.opendev.org/c/openstack/placement/+/919578 | |
| 21:28:02 | opendevreview | Merged openstack/placement master: Integrate pre-commit https://review.opendev.org/c/openstack/placement/+/919579 | |
| 21:30:04 | opendevreview | Merged openstack/placement master: pre-commit: Add autopep8 https://review.opendev.org/c/openstack/placement/+/923490 | |
| 21:30:05 | opendevreview | Merged openstack/placement master: pre-commit: Add sphinx-lint https://review.opendev.org/c/openstack/placement/+/919580 | |
| 21:59:43 | opendevreview | Merged openstack/placement master: Replace py38 job by py311 job https://review.opendev.org/c/openstack/placement/+/931033 | |
| #openstack-nova - 2024-10-02 | |||
| 01:53:49 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Add base image format tracking with file extensions https://review.opendev.org/c/openstack/nova/+/930962 | |
| 01:53:49 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Move cache filename generation to imagebackend https://review.opendev.org/c/openstack/nova/+/930961 | |
| 01:53:50 | opendevreview | melanie witt proposed openstack/nova master: objects: Add image_type to BlockDeviceMapping object https://review.opendev.org/c/openstack/nova/+/930965 | |
| 01:53:50 | opendevreview | melanie witt proposed openstack/nova master: db: Add image_type to block_device_mapping table https://review.opendev.org/c/openstack/nova/+/930964 | |
| 01:53:51 | opendevreview | melanie witt proposed openstack/nova master: WIP libvirt: Add image multi-backend https://review.opendev.org/c/openstack/nova/+/930967 | |
| 01:53:51 | opendevreview | melanie witt proposed openstack/nova master: virt: Add image_type to relevant DriverBlockDevice https://review.opendev.org/c/openstack/nova/+/930966 | |
| 01:53:52 | opendevreview | melanie witt proposed openstack/nova master: api: Add microversion 2.97 to add image_type to block_device_mapping_v2 https://review.opendev.org/c/openstack/nova/+/930968 | |
| 02:42:31 | opendevreview | Ghanshyam proposed openstack/osc-placement master: Update python classifier in setup.cfg https://review.opendev.org/c/openstack/osc-placement/+/931113 | |
| 03:01:03 | opendevreview | melanie witt proposed openstack/nova master: api: Add microversion 2.97 to add image_type to block_device_mapping_v2 https://review.opendev.org/c/openstack/nova/+/930968 | |
| 03:01:03 | opendevreview | melanie witt proposed openstack/nova master: WIP libvirt: Add image multi-backend https://review.opendev.org/c/openstack/nova/+/930967 | |
| 03:31:15 | opendevreview | Takashi Kajinami proposed openstack/placement master: Move upper functional job to py312 https://review.opendev.org/c/openstack/placement/+/931052 | |
| 06:19:09 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix typos and punctuation issues https://review.opendev.org/c/openstack/nova/+/878779 | |
| 09:28:05 | opendevreview | Takashi Kajinami proposed openstack/nova master: Replace deprecated constant_time_compare https://review.opendev.org/c/openstack/nova/+/931146 | |
| 14:38:24 | opendevreview | Andrew Bonney proposed openstack/nova master: Don't reset port dns_name when shelving instances https://review.opendev.org/c/openstack/nova/+/919961 | |
| 14:41:01 | tkajinam | I wonder if anyone knows a good replacement of distutils.versionpredicate ? | |
| 14:41:09 | tkajinam | context behind my question is https://bugs.launchpad.net/oslo.versionedobjects/+bug/2083518 | |
| 14:41:40 | tkajinam | distutils was removed in Python 3.12 but that module is still used by nova and oslo.versionedobjects | |
| 16:04:11 | stephenfin | I thought sean-k-mooney had deprecated ImagePropertiesFilter in favour of placement. Apparently not | |
| 16:12:31 | tkajinam | :-( | |
| 16:14:59 | tkajinam | I now understand how huge disaster the removal of pkg_resources and distutils is | |
| 16:15:04 | tkajinam | py 3.12 is mess | |
| 16:39:21 | dansmith | tkajinam: it's been a disaster in every community I'm in | |
| 16:39:59 | tkajinam | yeah | |
| 16:40:47 | tkajinam | and we may see more "exciting" situation with upcoming py313 ... | |
| 16:41:44 | dansmith | yep | |
| 16:41:51 | dansmith | I mean... "yep :(" | |
| 16:43:00 | tkajinam | :-S | |
| 17:03:28 | sean-k-mooney | stephenfin: i tought i did also. there may have been usecase my prefilter could not cover | |
| 17:03:54 | sean-k-mooney | stephenfin: i did add a placement prefilter for image metadtaa | |