| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-10-01 | |||
| 16:55:05 | dansmith | I just want to point out this patch of mine, which fixes a long-running transgression with us lying to glance about volume snapshots: https://review.opendev.org/c/openstack/nova/+/930754 | |
| 16:55:35 | dansmith | as far as I could tell while looking, the snap we create for volumes is not useful for actually booting from and was added for a completely unrelated reason ages ago | |
| 16:55:46 | dansmith | so i think we might want to consider not doing that anymore if there is no reason | |
| 16:56:14 | dansmith | if there is, then we're going to need to consider what we want to do there when we stop allowing nova to boot from unformatted (i.e. raw) images in the future | |
| 16:56:27 | dansmith | but I have a lot of history summarized there with links if anyone wants to have a look | |
| 16:56:51 | dansmith | that's blocking glance work because we fail in tempest tests to snapshot BFV instances since glance rejects nova's lies that we're uploading a qcow2 when we're clearly not | |
| 16:56:56 | bauzas | dansmith: fwiw, I trust you on that yet another image backend story | |
| 16:57:06 | dansmith | please trust but verify :) | |
| 16:57:17 | dansmith | anyway, no time to discuss in depth now, I need to run to something else but wanted to point it out | |
| 16:57:35 | gibi | dansmith: thanks for the heads up, I have to read your excellent commit message... | |
| 16:58:35 | bauzas | dansmith: I'll carefully verify your commit msg then | |
| 16:58:38 | dansmith | thanks | |
| 16:59:45 | gibi | bauzas: I feel we are done | |
| 16:59:54 | bauzas | yup, and we're on time | |
| 17:00:02 | gibi | perfect :) | |
| 17:00:11 | bauzas | I was doing some paperwork to add dansmith's patch into the etherpad | |
| 17:00:14 | bauzas | that's his fault | |
| 17:00:19 | bauzas | thanks all | |
| 17:00:22 | opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2024/nova.2024-10-01-16.01.log.html | |
| 17:00:22 | opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2024/nova.2024-10-01-16.01.txt | |
| 17:00:22 | opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2024/nova.2024-10-01-16.01.html | |
| 17:00:22 | opendevmeet | Meeting ended Tue Oct 1 17:00:22 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 17:00:22 | bauzas | #endmeeting | |
| 17:00:29 | gibi | bauzas: thanks | |
| 17:00:31 | elodilles | thanks o/ | |
| 17:00:32 | gibi | o/ | |
| 17:00:50 | tkajinam | thank you | |
| 17:17:40 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Add new option to enforce multipath volume connections https://review.opendev.org/c/openstack/nova/+/845660 | |
| 17:27:13 | opendevreview | Takashi Kajinami proposed openstack/nova master: Remove Python 3.8 support https://review.opendev.org/c/openstack/nova/+/931047 | |
| 17:27:52 | opendevreview | Takashi Kajinami proposed openstack/nova master: Remove Python 3.8 support https://review.opendev.org/c/openstack/nova/+/931047 | |
| 17:28:51 | gmann | tkajinam: I think we should remove the python_requires itself | |
| 17:29:37 | sean-k-mooney | currently tkajinam is not modifying it | |
| 17:30:01 | sean-k-mooney | or the verions in setup.cfg at all | |
| 17:30:49 | sean-k-mooney | there patch is just reverting to using hashlib instead of oslo for md5 | |
| 17:31:14 | sean-k-mooney | tkajinam: we shoudl proably update https://github.com/openstack/nova/blob/master/setup.cfg#L13-L23 in the same patch | |
| 17:31:38 | sean-k-mooney | wether we remvoe python_requires = >=3.8 or change it to python_requires = >=3.9 i have less opipion on | |
| 17:31:47 | sean-k-mooney | but we shoudl drop Programming Language :: Python :: 3.8 | |
| 17:31:58 | gmann | yeah and add py3.12 also | |
| 17:32:07 | sean-k-mooney | yep | |
| 17:32:44 | tkajinam | I though I modified setup.cfg but I somehow reverted that change... | |
| 17:33:17 | opendevreview | Takashi Kajinami proposed openstack/nova master: Remove Python 3.8 support https://review.opendev.org/c/openstack/nova/+/931047 | |
| 17:33:23 | sean-k-mooney | that explains why v1 and v2 are the same exctp the commit message :) | |
| 17:33:52 | sean-k-mooney | gmann: you prefer not to bump python_requires in general yes | |
| 17:34:03 | sean-k-mooney | to allow it to install even if its not nessiarly compatible | |
| 17:34:14 | gmann | sean-k-mooney: yeah, it create problem more than benefit | |
| 17:34:24 | sean-k-mooney | without a downstream patch python once we revert to hashlibg directly it will fail on vanilla py38 | |
| 17:34:55 | sean-k-mooney | usedforsecurity does not exist in the upstream python 3.8 hashlib | |
| 17:35:04 | gmann | python versions listed in classifier should tell what all python versions are tested and supported and rest all no guarantee | |
| 17:35:08 | tkajinam | I'd say classifier is just useless because it does not enforce anything and have been unmantained for very long | |
| 17:35:11 | gmann | if it work as long as it is good | |
| 17:35:34 | gmann | this is just a info and doc we do not need to enforce things | |
| 17:36:08 | sean-k-mooney | gmann: right my point is nova wont work on py38 with this change (unless the distro backported the hashlib change to 3.8) | |
| 17:36:41 | tkajinam | what you are saying is equivalent to drop all min version from requirements, IMHO | |
| 17:37:05 | tkajinam | I don't know why we should maintain these although we won't maintain compat version for core python. | |
| 17:37:15 | sean-k-mooney | so tkajinam we may not be able to do this change this cycle | |
| 17:37:27 | sean-k-mooney | we still need ubuntu 22.04 for grenade | |
| 17:37:34 | sean-k-mooney | and i belive it uses 3.8 | |
| 17:37:56 | sean-k-mooney | this is the release whre we are moving all the ci to 24.04 but 22.04 is kept for smoth upgrades | |
| 17:38:08 | sean-k-mooney | 22.04 has alternitive pythons liek 3.9 | |
| 17:38:17 | sean-k-mooney | so we could use that instead but its not the default | |
| 17:38:34 | tkajinam | 22.04 uses 3.10 afaik | |
| 17:38:47 | sean-k-mooney | oh you might be right | |
| 17:38:55 | sean-k-mooney | i may have mixed that up | |
| 17:39:42 | sean-k-mooney | tkajinam: ah yes your correct | |
| 17:40:07 | sean-k-mooney | 20.04 used 3.8 22.04 is alredy 3.10 | |
| 17:40:09 | tkajinam | a few projects like cinder, heat, horizon, octavia already removed py38 support but they have survived | |
| 17:40:13 | tkajinam | yeah | |
| 17:40:44 | sean-k-mooney | so that means the oldest python we have in ci (for master at least) is already 3.9 on centos | |
| 17:41:07 | tkajinam | yes. 3.8 has been untested since 2024.2 | |
| 17:41:15 | sean-k-mooney | ack | |
| 17:41:15 | tkajinam | unless the repo contains the job left (eg. placement) | |
| 17:41:55 | sean-k-mooney | oh we missed updatign placement did we not merge the patch to update it for 2024.2? | |
| 17:42:44 | sean-k-mooney | https://review.opendev.org/c/openstack/placement/+/881366 ... | |
| 17:42:50 | gmann | sean-k-mooney: tkajinam I sent on ML to remove this flag. IMO, it will not hurt anything but avoid our effort to update and coordinate it everytime | |
| 17:42:54 | sean-k-mooney | i tought we merged that | |
| 17:43:28 | gmann | and coordination is always missing among all openstack project and this flag create issue | |
| 17:43:43 | sean-k-mooney | gmann: im ok to remove it but as i said we knwo it wont work this time and ya the cordination is tough | |
| 17:44:17 | sean-k-mooney | hopefully less of an issue now that python has a yearly releace cadnace and predicable EOL date | |
| 17:44:35 | gmann | yeah, everytime olso bump the min in this flag it fail many projects and it take time for fixing all their CI even fix is very simple | |
| 17:46:04 | sean-k-mooney | so im wondering if we should merge https://review.opendev.org/c/openstack/placement/+/881366 before https://review.opendev.org/c/openstack/placement/+/931033 or just go strait to tkajinam's patch | |
| 17:46:15 | sean-k-mooney | tkajinam: is there a reaosn you marked that WIP | |
| 17:46:16 | tkajinam | we do actually remove compatibilities in some repos. if we remove the min then it appears as wired errors instead of explicit failure during installation | |
| 17:47:35 | tkajinam | sean-k-mooney, I tought https://review.opendev.org/c/openstack/placement/+/925648 is the primary way but I'm fine with it... note that 925648 revealed that functional-py39 uses python 3.8 actually which needs to be fixed... | |
| 17:47:50 | tkajinam | I mean I'm ok to merge job update and leave min bump for now | |
| 17:48:10 | gmann | ++ | |
| 17:48:18 | sean-k-mooney | we have several patches for it in placement we just need to choose one to proceed with | |
| 17:49:10 | gmann | or merge all in single one, remove py3.8 job + add py301, py311 jobs and leave the min version bump | |
| 17:49:22 | sean-k-mooney | placement-perfload by the way is having a wheel build fialure for a missing header | |
| 17:49:51 | sean-k-mooney | i think that is unrelated and and existing fialure tha twe shoudl fix in a differnt patch | |
| 17:50:15 | sean-k-mooney | it has quite a few failures https://zuul.opendev.org/t/openstack/builds?job_name=placement-perfload&project=openstack%2Fplacement | |
| 17:51:00 | sean-k-mooney | im going to finish for today soon | |
| 17:51:03 | tkajinam | py311 functional job already exists and pass so I prefer to use it now and then replace it by py312 if needed | |
| 17:51:20 | gmann | ah yeah, ++ for py3.12 | |
| 17:51:38 | sean-k-mooney | im happy to go with gmann's suggestion fo a single path to do everythin and just test the upper and lower python version i.e. 3.9 and 3.12 for tox jobs | |
| 17:51:49 | tkajinam | ok | |
| 18:00:41 | sean-k-mooney | by the way 3.12 support is added by https://review.opendev.org/c/openstack/placement/+/919578/3 | |
| 18:01:10 | sean-k-mooney | the pre-commit series was all intended to be in 2024.2... | |
| 18:02:03 | sean-k-mooney | it would likely be best to merge https://review.opendev.org/c/openstack/placement/+/919578/3 first and then rebase tkajinam change on top | |
| 18:02:51 | sean-k-mooney | gmann: if we wanted to avoid the merge conflict merging up to https://review.opendev.org/c/openstack/placement/+/919580/3 before tkajinam's change woudl make sense | |
| 18:03:36 | gmann | sean-k-mooney: sure, will check after tc meeting | |