| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-09-06 | |||
| 14:08:43 | sean-k-mooney | we have not had any testing of openvz/Virtuozzo supprort for years so its unlikely that even still works without this | |
| 14:20:02 | dansmith | yeah, mkfs will definitely overwrite the partition table bits, the problem is vfat creates one again itself and adds a boot record (because it's actually a partition within a partition) | |
| 14:20:07 | dansmith | so this should not fail if you choose extN right? | |
| 14:24:00 | sean-k-mooney | ill check but i dont expect it to no, im just tryin gto figure out how to confirm that since the funcitonl test sute is complaining about privespe when i change the default | |
| 14:24:32 | sean-k-mooney | oh | |
| 14:24:37 | sean-k-mooney | no thats ok | |
| 14:24:42 | sean-k-mooney | it failed after the safty check | |
| 14:25:08 | sean-k-mooney | we call _update_utime_ignore_eacces(base) after the safty checks | |
| 14:26:55 | sean-k-mooney | so ya the inspecotr for ext4 returns RawFileInspecotr instead of the mbr/gpt one | |
| 14:27:56 | sean-k-mooney | dansmith: so i had a proposal to change our default to not format ephmeral disk | |
| 14:28:29 | sean-k-mooney | if i was to quickly implemnte that and wrap the mkfs call in an if then that woudl work for the default case | |
| 14:28:58 | sean-k-mooney | althernitivly i guess we coudl add a vfat inspector? or special case that in the mbr/gpt one | |
| 14:30:15 | dansmith | it's not that we need a vfat inspector, it's that we'd need the gpt one to not detect the vfat VBR as an MBR, or not obsess over the lack of partitions | |
| 14:30:23 | dansmith | or ideally, just not if it thinks it's a VBR instead of an MBR | |
| 14:30:24 | sean-k-mooney | i would prefer not to need to update oslo for this if we can avoid it but there are workaroudn that we can suggest to people in the interim | |
| 14:30:26 | dansmith | I'm looking into options | |
| 14:30:48 | dansmith | well, again, we shouldn't need to be inspecting blank images we're creating at all | |
| 14:30:53 | dansmith | so that's the non-oslo fix | |
| 14:31:45 | sean-k-mooney | right so i can implemant that with a new parmater to create_image in the image backend and default inspect_backingfile to true | |
| 14:31:55 | sean-k-mooney | then explcitly set it to false for epmeral disks | |
| 14:32:09 | sean-k-mooney | or ephmeral but only when vfat | |
| 14:32:46 | dansmith | all ephemeral should be fine I think | |
| 14:32:47 | sean-k-mooney | if we are ok with that approch ill stop trying ot make it pass and just swap to tuning it off for now when we are creating blank images | |
| 14:33:10 | dansmith | but yeah, that's really what we want to do I think and I'll work in parallel to stop the detection just in case anyone uses a raw vfat in a glance parition | |
| 14:33:19 | dansmith | *image | |
| 14:33:35 | sean-k-mooney | dansmith: are you ok with defering stoping creatin backing files for epmereal disks to the larger image backend refactor | |
| 14:34:22 | dansmith | certainly deferring it past the targeted fix for this | |
| 14:34:28 | sean-k-mooney | ack | |
| 14:34:43 | dansmith | and yeah, I think continuing to slice the current backend is just asking for trouble, even for something smallish like not using backing files I think | |
| 14:35:41 | sean-k-mooney | i feel like while i coudl make it work it woudl be more error prone espcialy when it compes to move ops and upgrade behavior | |
| 14:36:03 | dansmith | yeah | |
| 14:43:15 | dansmith | sean-k-mooney: are you okay with excluding images of floppy disks? | |
| 14:43:42 | dansmith | I don't mean a fake image you created to boot from floppy, but like an actual dd image of a floppy created on MS-DOS 6 or something | |
| 14:43:46 | sean-k-mooney | yes im also happy with droping floopy drive supprot form hw_disk_bus if we have not already | |
| 14:44:03 | dansmith | AFAIK, qemu dropped floppy support a while back anyway right? | |
| 14:44:17 | sean-k-mooney | it did in q35 | |
| 14:44:23 | dansmith | ah okay | |
| 14:44:24 | sean-k-mooney | and i think we did downstream | |
| 14:44:30 | sean-k-mooney | btu not sure about upstream with pc | |
| 14:44:39 | dansmith | well, we could check a range, but I think it's easier if we just check for the descriptor that says "this was created on a hard disk" | |
| 14:53:52 | dansmith | sean-k-mooney: https://review.opendev.org/c/openstack/oslo.utils/+/928448 | |
| 14:54:00 | dansmith | I will get a test image up too | |
| 14:56:39 | sean-k-mooney | im using oslo.utils form a local git repo so i can apply that and test it in my funcitonal test | |
| 14:57:43 | dansmith | cool | |
| 15:01:30 | sean-k-mooney | Switched to branch "review/dan_smith/cut-the-fat" :) | |
| 15:01:37 | dansmith | you're welcome :) | |
| 15:02:19 | gibi | lol | |
| 15:11:36 | opendevreview | Dan Smith proposed openstack/nova master: DNM: Test with FAT image https://review.opendev.org/c/openstack/nova/+/928451 | |
| 15:11:58 | dansmith | sean-k-mooney: we'll make sure this ^ fails the same way you're seeing with ephemeral and then add in the oslo change to see that it cures | |
| 16:25:26 | sean-k-mooney | dansmith: sorry was on a call, so if i include your oslo fix and revert back to vfat it seams to be working. its failing at the same point where it tries to use privesep post the safty check | |
| 16:25:39 | sean-k-mooney | ill look a little closer now and confirm | |
| 16:27:18 | sean-k-mooney | ok so ya the inspector is now RawFileinspector when using vfat | |
| 16:28:40 | dansmith | cool | |
| 16:29:14 | dansmith | sean-k-mooney: if you could file a bug with the fail/trace it would be good to get that attached to the oslo fix when we ask for the merge/release | |
| 16:29:25 | dansmith | unless.. is it in the zuul results from your repro change? | |
| 16:30:00 | dansmith | ah, I got it | |
| 16:30:04 | dansmith | I can file the bug then | |
| 16:30:27 | sean-k-mooney | ok i was going to try and do it before i finsih for today but eys its in the zuul change | |
| 16:30:48 | dansmith | I got it, you should weekend | |
| 16:31:16 | sean-k-mooney | one thing we could try is we could update the dnm patch to depned on the oslo one and try and run the expermintal job | |
| 16:31:44 | sean-k-mooney | im not sure that will work but i planned to do that when working on the nova change to not run the inspection on ephmeral disks | |
| 16:31:57 | dansmith | I will after it fails, | |
| 16:32:07 | dansmith | I wanted one run repro'ing the problem with the dedicated test image | |
| 16:33:34 | sean-k-mooney | ack, we might need other zuul config to make depens on to oslo.utils work and at present the job cant run form oslo.utils on nova but we can figure all that out next week | |
| 16:33:45 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add igb value to hw_vif_model image property https://review.opendev.org/c/openstack/nova/+/928456 | |
| 16:33:52 | dansmith | required_projects should just work | |
| 16:35:23 | sean-k-mooney | gibi: :) as an fyi we shoudl also add a trait here https://github.com/openstack/os-traits/blob/master/os_traits/compute/net.py#L26-L38 | |
| 16:35:28 | dansmith | tempest.api.image.v2.test_images_formats.ImagesFormatTest.test_compute_rejects_invalid(fat-vbr) [19.473212s] ... FAILED | |
| 16:35:31 | dansmith | as expected ^ | |
| 16:35:51 | gibi | sean-k-mooney: yeah there is a bunch of TODOs | |
| 16:36:20 | gibi | but good point I missed that so far | |
| 17:06:20 | sean-k-mooney | gibi: it wont break without it but it needed to make the image metadata prefileter be able to select host with igb support | |
| 17:07:14 | sean-k-mooney | gibi: if i recall correctly when we try to generate requried traits we check if its a knwo valide trait ad drop the request if we dont find a match | |
| 17:17:27 | opendevreview | sean mooney proposed openstack/nova master: [WIP] adapt to vfat support in oslo.utils https://review.opendev.org/c/openstack/nova/+/928462 | |
| 17:19:09 | opendevreview | sean mooney proposed openstack/nova master: [WIP] adapt to vfat support in oslo.utils https://review.opendev.org/c/openstack/nova/+/928462 | |
| 17:19:09 | opendevreview | sean mooney proposed openstack/nova master: [WIP] Add functional repoducer for ephemeral disks https://review.opendev.org/c/openstack/nova/+/928310 | |
| 17:25:47 | opendevreview | Dan Smith proposed openstack/nova master: DNM: Test with FAT image https://review.opendev.org/c/openstack/nova/+/928451 | |
| 17:26:11 | opendevreview | sean mooney proposed openstack/nova master: [WIP] adapt to vfat support in oslo.utils https://review.opendev.org/c/openstack/nova/+/928462 | |
| 17:26:11 | opendevreview | sean mooney proposed openstack/nova master: [WIP] Add functional repoducer for ephemeral disks https://review.opendev.org/c/openstack/nova/+/928310 | |
| 17:26:44 | sean-k-mooney | ill take a look on monday at actuly doing what we said to not need th oslo release but https://review.opendev.org/c/openstack/nova/+/928462 will at least try and test test with your oslo patch | |
| 17:27:40 | sean-k-mooney | i added dosfstools to bindep for now as a test requirement so hopefully that will fix the functional job an allow the test to pass | |
| 17:28:58 | sean-k-mooney | anyway enjoy your weekend folks o/ | |
| 17:31:56 | dansmith | sean-k-mooney: cool thanks see you monday | |
| 17:37:34 | opendevreview | Dan Smith proposed openstack/nova master: DNM: Test with FAT image https://review.opendev.org/c/openstack/nova/+/928451 | |
| 18:21:36 | artom | *to avoid proposing | |
| 19:10:17 | dansmith | artom: yeah, all manner of puns ahead | |
| 19:17:04 | JayF | You know, when I saw that comment, my thought was "oh god there's another image type?!" and completely missed the joke :D | |
| 19:18:19 | dansmith | JayF: does ironic support any naked vfat images for anything? | |
| 19:18:28 | JayF | no | |
| 19:18:54 | JayF | I saw your commit in oslo utils, I don't think it'd impact ironic | |
| 19:19:26 | dansmith | it certainly won't yet because you're using the earlier stuff which doesn't detect MBRs, but yeah I was just wondering if you might have any false positives from some case you do support | |
| 19:19:59 | dansmith | it's really silly that we format ephemerals at all, but especially silly that we will format them as FAT32 just so windows guests would have something to see, even though it's totally useless to them | |
| 21:06:22 | opendevreview | Merged openstack/nova stable/2023.2: hardware: Correct log https://review.opendev.org/c/openstack/nova/+/927473 | |
| 21:16:41 | zigo | Howdy here! New fun OpenStack cli tool: https://salsa.debian.org/openstack-team/clients/oscs | |
| 23:10:47 | opendevreview | melanie witt proposed openstack/nova master: DNM try minimalistic imagebackend refactor https://review.opendev.org/c/openstack/nova/+/925635 | |
| #openstack-nova - 2024-09-07 | |||
| 00:35:36 | opendevreview | melanie witt proposed openstack/nova master: DNM try minimalistic imagebackend refactor https://review.opendev.org/c/openstack/nova/+/925635 | |
| 01:21:29 | opendevreview | melanie witt proposed openstack/nova master: DNM try minimalistic imagebackend refactor https://review.opendev.org/c/openstack/nova/+/925635 | |
| 03:14:15 | opendevreview | melanie witt proposed openstack/nova master: DNM try minimalistic imagebackend refactor https://review.opendev.org/c/openstack/nova/+/925635 | |
| 10:10:54 | opendevreview | Balazs Gibizer proposed openstack/nova stable/2023.1: hardware: Correct log https://review.opendev.org/c/openstack/nova/+/928485 | |
| #openstack-nova - 2024-09-09 | |||
| 07:17:23 | bauzas | morning | |