| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-02-28 | |||
| 12:34:54 | stblatzheim | subnet_dict (which is returned) is defined here: https://github.com/openstack/nova/blob/7fa1859576ac577da89cb817f93b1c54d3a937ce/nova/network/neutron.py#L3608 Would need to add the enable_dhcp conditionaly here also i suppose. Should i make a new review for this? | |
| 12:35:03 | opendevreview | Pavlo Shchelokovskyy proposed openstack/nova master: Auto set heartbeat_in_pthread for wsgi services https://review.opendev.org/c/openstack/nova/+/909880 | |
| 13:02:12 | sean-k-mooney | stblatzheim adding the enable_dhcp there is fine | |
| 13:02:33 | sean-k-mooney | stblatzheim: so yes feel free to update your exixting reivew | |
| 13:03:09 | sean-k-mooney | so just add enable_dhcp there adn then make the if check for either enable_dhcp or dhcp_server | |
| 13:05:38 | opendevreview | ribaudr proposed openstack/nova master: Check shares support (compute manager) https://review.opendev.org/c/openstack/nova/+/885751 | |
| 13:05:38 | opendevreview | ribaudr proposed openstack/nova master: Allow to mount manila share using Cephfs protocol https://review.opendev.org/c/openstack/nova/+/883862 | |
| 13:05:39 | opendevreview | ribaudr proposed openstack/nova master: Check shares support (only API exception) https://review.opendev.org/c/openstack/nova/+/885752 | |
| 13:05:39 | opendevreview | ribaudr proposed openstack/nova master: Add share lock/unlock and restrict visibility https://review.opendev.org/c/openstack/nova/+/890340 | |
| 13:05:40 | opendevreview | ribaudr proposed openstack/nova master: Check shares support (API) https://review.opendev.org/c/openstack/nova/+/850499 | |
| 13:05:40 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (API) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 13:05:41 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | |
| 13:05:41 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/885753 | |
| 13:05:42 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | |
| 13:05:43 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach_error notification https://review.opendev.org/c/openstack/nova/+/860282 | |
| 13:05:43 | opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | |
| 13:05:45 | opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | |
| 13:05:45 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach_error notification https://review.opendev.org/c/openstack/nova/+/860283 | |
| 13:05:47 | opendevreview | ribaudr proposed openstack/nova master: Docs about Manila shares API usage https://review.opendev.org/c/openstack/nova/+/871642 | |
| 13:05:47 | opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | |
| 13:12:41 | auniyal | hi melwitt, dansmith any ideas on this fail no test really failed but job failed with TIMEOUT - https://zuul.opendev.org/t/openstack/build/0e88ede030024fcbb16405750614fb2f | |
| 13:14:52 | auniyal | do you think its a deployment issue ? | |
| 13:14:53 | opendevreview | Steven Blatzheim proposed openstack/nova master: Fix nova-metadata-api for ovn dhcp native networks https://review.opendev.org/c/openstack/nova/+/910466 | |
| 13:20:54 | opendevreview | Steven Blatzheim proposed openstack/nova master: Fix nova-metadata-api for ovn dhcp native networks https://review.opendev.org/c/openstack/nova/+/910466 | |
| 13:22:29 | stblatzheim | sean-k-mooney: Updated the review like you suggested and reused existing unit test with the adaption of the new behaviour. | |
| 13:31:54 | sean-k-mooney | stblatzheim: ack im in a meeting but ill take a look when done. | |
| 13:39:52 | opendevreview | Pavlo Shchelokovskyy proposed openstack/nova master: Auto set heartbeat_in_pthread for wsgi services https://review.opendev.org/c/openstack/nova/+/909880 | |
| 13:57:26 | opendevreview | Konrad Gube proposed openstack/nova master: Use Cinder's os-extend_volume_completion volume action. https://review.opendev.org/c/openstack/nova/+/873560 | |
| 14:54:20 | opendevreview | Sylvain Bauza proposed openstack/nova master: WIP: add a periodic check for migrations https://review.opendev.org/c/openstack/nova/+/909598 | |
| 14:54:20 | opendevreview | Sylvain Bauza proposed openstack/nova master: Modify the mdevs in the migrate XML https://review.opendev.org/c/openstack/nova/+/904258 | |
| 14:54:27 | bauzas | sean-k-mooney: did a respin ^ was simplier | |
| 15:04:02 | tkajinam | sean-k-mooney, I totally agree there are multiple things we can improve, but for this specific case tbvh this was out of our control from oslo side (at least it was out of my own control) because castellan is maintained between barbican and oslo and all the changes were merged by barbican side without any consultation to oslo side... | |
| 15:04:27 | tkajinam | and they don't really care about anything they are not actually interested in. /me sighs | |
| 15:07:45 | tkajinam | we probably should try creating a mid-cycle release of some oslo libraries to detect such problems early, so that we can more smoothly complete requirement bumps, instead of finding multiple problems at last minutes | |
| 15:18:01 | sean-k-mooney | bauzas: thanks +2w on the non WIP patch | |
| 15:18:13 | sean-k-mooney | ill review the perodic after you decdid it ready | |
| 15:18:13 | bauzas | tks | |
| 15:18:26 | bauzas | I need to test it | |
| 15:18:34 | bauzas | not sure I'll have time until Friday | |
| 15:18:40 | bauzas | ETOOMANYTHINGS | |
| 15:19:16 | sean-k-mooney | tkajinam: or we just need to have something mroe visiable in our meetings ectra | |
| 15:19:33 | sean-k-mooney | to ensure we have better comuncitation | |
| 15:19:46 | sean-k-mooney | tkajinam: we have beenb usign a etherpad this cycle | |
| 15:19:54 | sean-k-mooney | in past cycle wee used review priority | |
| 15:20:25 | sean-k-mooney | so we just need a way to signal this work will be needed eiarlr so ti does not come as a surpise at the end. | |
| 15:23:00 | tkajinam | I'll try | |
| 15:34:49 | kgube | sean-k-mooney, bauzas: regarding yesterdays discussion of my patch, would it also be acceptable to just check for the supported cinder microversion in the code, so the patch is compatible with older cinderclient versions? | |
| 15:35:41 | dansmith | sean-k-mooney: so I'm a bit confused about how this encryption stuff works with ceph | |
| 15:36:29 | dansmith | sean-k-mooney: the key we're using to access a given disk is known really only to libvirt and qemu on the host, right? It's really qemu's integrated rbd client that's doing the luks on top, AFAK | |
| 15:36:56 | dansmith | so what I don't understand is how something that does *not* know about those things do image operations like flatten when it doesn't know those details | |
| 15:37:30 | dansmith | like, let's say we have an unencrypted base image, encrypted root disk on top. we haven't read or written block 10, | |
| 15:38:01 | dansmith | we call librbd to flatten the image (detach from parent), we have to copy any un-CoW'd blocks into the detached disk to make it whole | |
| 15:38:20 | dansmith | but we don't have the key, or even know that there's an encryption scheme going on in the child disk | |
| 15:50:27 | dansmith | melwitt: ^ when you're around | |
| 15:59:54 | mnaser | https://review.opendev.org/c/openstack/nova/+/909098 + https://review.opendev.org/c/openstack/nova/+/909541 is finally passing thanks | |
| 16:20:33 | opendevreview | Steven Blatzheim proposed openstack/nova master: Fix nova-metadata-api for ovn dhcp native networks https://review.opendev.org/c/openstack/nova/+/910466 | |
| 16:24:29 | opendevreview | Steven Blatzheim proposed openstack/nova master: Fix nova-metadata-api for ovn dhcp native networks https://review.opendev.org/c/openstack/nova/+/910466 | |
| 16:33:28 | opendevreview | Merged openstack/nova master: enforce remote console shutdown https://review.opendev.org/c/openstack/nova/+/901824 | |
| #openstack-nova - 2024-02-29 | |||
| 06:58:41 | opendevreview | Merged openstack/nova master: Modify the mdevs in the migrate XML https://review.opendev.org/c/openstack/nova/+/904258 | |
| 07:36:21 | opendevreview | melanie witt proposed openstack/nova master: Support (resize|cold migration) with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870933 | |
| 07:36:21 | opendevreview | melanie witt proposed openstack/nova master: Support create with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870932 | |
| 07:36:22 | opendevreview | melanie witt proposed openstack/nova master: Support rebuild with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870939 | |
| 07:36:22 | opendevreview | melanie witt proposed openstack/nova master: Support live migration with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/905512 | |
| 07:36:23 | opendevreview | melanie witt proposed openstack/nova master: Add encryption support to qemu-img rebase https://review.opendev.org/c/openstack/nova/+/870936 | |
| 07:36:23 | opendevreview | melanie witt proposed openstack/nova master: Support rescue with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/873675 | |
| 07:36:24 | opendevreview | melanie witt proposed openstack/nova master: Support snapshot with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870937 | |
| 07:36:25 | opendevreview | melanie witt proposed openstack/nova master: Support encrypted backing files for qcow2 https://review.opendev.org/c/openstack/nova/+/907961 | |
| 07:36:25 | opendevreview | melanie witt proposed openstack/nova master: Add backing_encryption_secret_uuid to BlockDeviceMapping https://review.opendev.org/c/openstack/nova/+/907960 | |
| 07:36:27 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for raw with LUKS https://review.opendev.org/c/openstack/nova/+/884313 | |
| 07:36:27 | opendevreview | melanie witt proposed openstack/nova master: Support cross cell resize with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/909595 | |
| 07:36:29 | opendevreview | melanie witt proposed openstack/nova master: Report ephemeral disk encryption in the metadata API https://review.opendev.org/c/openstack/nova/+/909945 | |
| 07:36:29 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for rbd with LUKS https://review.opendev.org/c/openstack/nova/+/889912 | |
| 07:36:31 | opendevreview | melanie witt proposed openstack/nova master: Documentation for ephemeral encryption https://review.opendev.org/c/openstack/nova/+/910034 | |
| 07:36:31 | opendevreview | melanie witt proposed openstack/nova master: Deprecate legacy ephemeral storage encryption using dm-crypt https://review.opendev.org/c/openstack/nova/+/909947 | |
| 07:36:33 | opendevreview | melanie witt proposed openstack/nova master: testing: Add ephemeral encryption support to fixtures https://review.opendev.org/c/openstack/nova/+/910571 | |
| 11:32:08 | stblatzheim | sean-k-mooney: Thanks for the review. Just a quick question as it's my first work on openstack: Which id do i need to append to the release-note file under /releasenotes/notes? Atm i have a file called bug-2055245-fix-nova-metadata-api.yaml . | |
| 11:33:50 | stephenfin | Uggla: Have you link to the discussion where we decided not to bump the object version for a new field enum? That's pretty unusual unless we're not transmitting over the wire (in which case why _not_ bump) https://review.opendev.org/c/openstack/nova/+/908864 | |
| 11:33:54 | stephenfin | cc sean-k-mooney ^ | |
| 11:34:25 | sean-k-mooney | so you can generate a templesate doing "tox -e venv reno new bug-2055245-fix-nova-metadata-api" | |
| 11:34:43 | sean-k-mooney | stblatzheim: well you can generate a file form the template i should say | |
| 11:35:03 | sean-k-mooney | then you can take the content you have and put it in that file under the fixes section | |
| 11:35:09 | sean-k-mooney | just remove all the other sections | |
| 11:35:43 | sean-k-mooney | stephenfin: we normally do bump them | |
| 11:36:00 | sean-k-mooney | and you need compat code to remove the new values when backleveling | |
| 11:36:03 | stephenfin | yeah that's my thinking. It's pretty unusual not to | |
| 11:36:25 | stephenfin | as I said in the review, if there's a good reason not then it should be noted in the commit message | |
| 11:36:27 | sean-k-mooney | if we look at the video model | |
| 11:36:37 | sean-k-mooney | that is proably the closest example to the compat code | |
| 11:37:26 | sean-k-mooney | https://github.com/openstack/nova/commit/35a591d33d8b1a6c30bf40ddc48a07715fd87339 | |
| 11:37:30 | sean-k-mooney | Uggla: ^ | |
| 11:38:39 | sean-k-mooney | adding new enum fields to the VideoModel enum required an object bump for the image metadata object and backleveling code | |
| 11:38:45 | sean-k-mooney | so you woudl need that for attaching too | |
| 11:42:54 | opendevreview | Steven Blatzheim proposed openstack/nova master: Fix nova-metadata-api for ovn dhcp native networks https://review.opendev.org/c/openstack/nova/+/910466 | |
| 11:43:27 | sean-k-mooney | stblatzheim: did you forget a git add ^ | |
| 11:43:27 | stblatzheim | sean-k-mooney: Thank you, I just uploaded the release file | |
| 11:44:00 | opendevreview | Steven Blatzheim proposed openstack/nova master: Fix nova-metadata-api for ovn dhcp native networks https://review.opendev.org/c/openstack/nova/+/910466 | |
| 11:44:16 | sean-k-mooney | :) | |
| 11:44:18 | stblatzheim | Sorry, my fault :D | |
| 11:45:42 | sean-k-mooney | stephenfin: while your here ^ nice quick review for you if you have time | |
| 11:54:10 | sean-k-mooney | bauzas: are you around | |