| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-02-15 | |||
| 18:47:56 | sean-k-mooney | so removign instances form the dict that are not on this host and dont have a migration assocated with the host would be ok i think | |
| #openstack-nova - 2024-02-16 | |||
| 06:31:02 | opendevreview | Takashi Kajinami proposed openstack/os-traits master: Add traits for TPM models https://review.opendev.org/c/openstack/os-traits/+/909107 | |
| 06:31:32 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Detect vtpm support by libvirt https://review.opendev.org/c/openstack/nova/+/908508 | |
| 06:51:59 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Report available TPM models https://review.opendev.org/c/openstack/nova/+/909183 | |
| 06:55:22 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Report available TPM models https://review.opendev.org/c/openstack/nova/+/909183 | |
| 07:42:18 | opendevreview | Rajesh Tailor proposed openstack/nova master: Add support for showing requested az in output https://review.opendev.org/c/openstack/nova/+/904568 | |
| 08:47:54 | opendevreview | Rajesh Tailor proposed openstack/nova master: Add support for showing requested az in output https://review.opendev.org/c/openstack/nova/+/904568 | |
| 09:10:35 | opendevreview | Takashi Kajinami proposed openstack/nova master: Drop unused parameter type validation method https://review.opendev.org/c/openstack/nova/+/909189 | |
| 09:35:40 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute older than Victoria https://review.opendev.org/c/openstack/nova/+/909190 | |
| 09:40:29 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Victoria https://review.opendev.org/c/openstack/nova/+/909190 | |
| 09:46:42 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Victoria https://review.opendev.org/c/openstack/nova/+/909190 | |
| 09:53:32 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Victoria https://review.opendev.org/c/openstack/nova/+/909190 | |
| 09:53:33 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Wallaby https://review.opendev.org/c/openstack/nova/+/909192 | |
| 10:17:25 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Wallaby https://review.opendev.org/c/openstack/nova/+/909192 | |
| 14:16:08 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Wallaby https://review.opendev.org/c/openstack/nova/+/909192 | |
| 14:33:32 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Xena https://review.opendev.org/c/openstack/nova/+/909202 | |
| 14:37:26 | opendevreview | Artem Vasilyev proposed openstack/nova stable/zed: libvirt: stop enabling hyperv feature reenlightenment https://review.opendev.org/c/openstack/nova/+/909098 | |
| 14:41:54 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Yoga https://review.opendev.org/c/openstack/nova/+/909204 | |
| 14:51:04 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Xena https://review.opendev.org/c/openstack/nova/+/909202 | |
| 14:51:05 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Yoga https://review.opendev.org/c/openstack/nova/+/909204 | |
| 14:57:57 | stephenfin | melwitt, bauzas: Mind hitting this small doc fixup? https://review.opendev.org/c/openstack/nova/+/903675/1/doc/source/user/security-groups.rst | |
| 15:05:17 | bauzas | dansmith: sean-k-mooney: you'll see a new revision for my patches without the periodic, but I'll add it on Monday | |
| 15:05:30 | dansmith | ack | |
| 15:06:08 | opendevreview | Sylvain Bauza proposed openstack/nova master: Reserve mdevs to return to the source https://review.opendev.org/c/openstack/nova/+/904209 | |
| 15:06:09 | opendevreview | Sylvain Bauza proposed openstack/nova master: Modify the mdevs in the migrate XML https://review.opendev.org/c/openstack/nova/+/904258 | |
| 15:18:32 | opendevreview | Takashi Kajinami proposed openstack/nova master: Drop logic for compute service version < 33 https://review.opendev.org/c/openstack/nova/+/909218 | |
| 15:19:28 | mnaser | small ping again for https://review.opendev.org/c/openstack/nova/+/909082 and https://review.opendev.org/c/openstack/nova/+/909086 (i need to work these back to zed so appreciate if we can get em in earlier :D) | |
| 15:21:07 | opendevreview | Takashi Kajinami proposed openstack/nova master: Drop unnecessary mocking of get_minimum_version_all_cells https://review.opendev.org/c/openstack/nova/+/909219 | |
| 15:23:47 | mnaser | thank you stephenfin ! :) | |
| 15:23:53 | greatgatsby_ | Hello. We've hit a bit of a snag and are trying to figure out how to work around it. After upgrading the kernel on some of our computes, they no longer have the xsaves kernel feature, which is preventing us from migrating VMs to the upgraded computes. Any suggestions greatly appreciated. | |
| 15:24:12 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Zed https://review.opendev.org/c/openstack/nova/+/909220 | |
| 15:24:13 | mnaser | greatgatsby_: ah if i can tell you how many times we've been bit by this exact one. | |
| 15:24:28 | mnaser | i assume you are running ubuntu right | |
| 15:25:24 | greatgatsby_ | hahaha, at least we're not alone! We contemplating some crazy cups and ball game, but it's getting scary. Yes, upgrading from ubuntu 20.04 default kernel. | |
| 15:25:48 | mnaser | greatgatsby_: https://bugs.launchpad.net/nova/+bug/1903822 | |
| 15:26:19 | mnaser | there is a long outstanding patch here - https://review.opendev.org/c/openstack/nova/+/762330 | |
| 15:26:29 | mnaser | maybe you can try that in your env that might be fix it for you | |
| 15:27:00 | greatgatsby_ | thanks a lot for the help, reading now | |
| 15:28:20 | mnaser | we've found biting the bullet with a cold migration is what we've ended up doing in those scenarios | |
| 15:28:39 | greatgatsby_ | that's an option we're considering too, unfortunately | |
| 15:28:49 | greatgatsby_ | thanks again for the help | |
| 15:29:07 | mnaser | np, good luck o7 | |
| 15:59:12 | bauzas | mnaser: sorry, was afk :) | |
| 15:59:21 | mnaser | no woooorries :) | |
| 15:59:27 | bauzas | mnaser : fwiw, if you need to ask for a bugfix, you can use our etherpad : | |
| 15:59:37 | bauzas | https://etherpad.opendev.org/p/nova-caracal-status#L174 | |
| 15:59:51 | bauzas | then, I'll accept it :) | |
| 16:00:12 | mnaser | oh cool, didnt know about this etherpad | |
| 16:01:48 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Zed https://review.opendev.org/c/openstack/nova/+/909220 | |
| 16:10:54 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Xena https://review.opendev.org/c/openstack/nova/+/909202 | |
| 16:12:17 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Yoga https://review.opendev.org/c/openstack/nova/+/909204 | |
| 16:15:18 | bauzas | accepted :) | |
| 16:15:47 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Victoria https://review.opendev.org/c/openstack/nova/+/909190 | |
| 16:15:48 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Xena https://review.opendev.org/c/openstack/nova/+/909202 | |
| 16:15:48 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Wallaby https://review.opendev.org/c/openstack/nova/+/909192 | |
| 16:15:49 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Yoga https://review.opendev.org/c/openstack/nova/+/909204 | |
| 16:21:28 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Wallaby https://review.opendev.org/c/openstack/nova/+/909192 | |
| 16:21:29 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Yoga https://review.opendev.org/c/openstack/nova/+/909204 | |
| 16:21:29 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Xena https://review.opendev.org/c/openstack/nova/+/909202 | |
| 16:24:05 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Zed https://review.opendev.org/c/openstack/nova/+/909220 | |
| 16:24:58 | dansmith | um | |
| 16:25:21 | dansmith | I see no reason to drop service version checks.. am I alone? | |
| 16:41:43 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Xena https://review.opendev.org/c/openstack/nova/+/909202 | |
| 16:41:44 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Yoga https://review.opendev.org/c/openstack/nova/+/909204 | |
| 16:41:45 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Zed https://review.opendev.org/c/openstack/nova/+/909220 | |
| 16:42:54 | opendevreview | Takashi Kajinami proposed openstack/nova master: Drop logic for compute service version < 33 https://review.opendev.org/c/openstack/nova/+/909218 | |
| 16:48:27 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Zed https://review.opendev.org/c/openstack/nova/+/909220 | |
| 16:58:49 | artom | That +/- line count is mighty alluring, but I do understand the robustness concern. | |
| 17:00:42 | dansmith | artom: we could drop a lot of checks and meet that requirement :) | |
| 17:00:59 | dansmith | artom: we're also talking about downstream effects of one of these checks specifically right now... | |
| 17:01:32 | artom | dansmith, yeah, I think you and I are on the same page about this | |
| 17:01:59 | artom | I understand the sentiment, but am concerned about the side effects | |
| 17:08:43 | tkajinam | we may keep some of these, but some checks even call neutron to get port details for no use | |
| 17:09:33 | dansmith | tkajinam: that's fine, those are expensive.. separating those from the service version checks would be much better IMHO | |
| 17:10:00 | tkajinam | If we prefer not removing these then I'm fine. then I'll remove all TODO comments because these shouldn't be done | |
| 17:11:44 | artom | I mean I think there's a balance that something like Victoria is _probably_ fine | |
| 17:12:07 | artom | But the more recent we go, the more it's a case of "well, it _might_ be happening somewhere" | |
| 17:12:53 | tkajinam | I have a few topis I need to bring to PTG so will add this topic there, too, to discuss the strategy. | |
| 17:13:16 | tkajinam | yeah. I understand that point and that's why I'm making per-release change instead of removing these by a single shot | |
| 17:14:00 | artom | Though most of our customer are still running a train-based release, so perhaps even Victoria should be off limits | |
| 17:14:18 | artom | I think the upstream operator survey mostly aligns with that, too | |
| 17:14:58 | dansmith | yeah, and people are also still skipping lots of releases on each upgrade, which makes keeping the older checks in the newer code more relevant than they may seem | |
| 17:16:38 | tkajinam | I agree with that stetement though I'm not too sure skipping releases during upgrade immediately means mixing versions with huge gap really during operation | |
| 17:17:12 | tkajinam | anyway I think we can discuss details during PTG. I'm almost done about the series of patches so these may show the amount of codes we may drop if we do cleanup completely. | |
| 17:17:56 | dansmith | tkajinam: it does if you miss some computes during the upgrade, which we hear about regularly | |
| 17:18:11 | opendevreview | Artom Lifshitz proposed openstack/nova stable/2023.1: libvirt: Stop unconditionally enabling evmcs https://review.opendev.org/c/openstack/nova/+/909228 | |
| 17:19:00 | opendevreview | Artom Lifshitz proposed openstack/nova stable/2023.1: libvirt: stop enabling hyperv feature reenlightenment https://review.opendev.org/c/openstack/nova/+/909229 | |
| 17:21:02 | tkajinam | yeah but even in that case I'm unsure why they can't complete upgrade before getting it back to the cluster. | |
| 17:21:19 | tkajinam | ... with keeping all my experience tripleo thrown away | |
| 17:30:13 | dansmith | they can, of course, but the point of these checks is so that nova notices these sorts of things | |
| 17:34:24 | tkajinam | nova already has version check and reject starting services in case services with too old versions exist. That'd be the first guard. operators can disable the check but they should aware of the risk of doing it, unless they expect nova should take care of any versions, or we should remove that check if that does not meet the real requirement. | |
| 17:34:50 | tkajinam | (I don't intend to get conclusion here. just dumping some of my thoughts which I may bring during PTG. | |
| 17:35:33 | tkajinam | s/unless they expect/without expecting that/ | |
| 17:37:17 | dansmith | are you talking about the check that a service doesn't regress the current minimum? that only helps if you restart the old services, which doesn't happen by definition if your upgrade tool skips them | |
| 17:37:52 | opendevreview | Takashi Kajinami proposed openstack/nova master: Cleanup logics to detect nova-compute <= Zed https://review.opendev.org/c/openstack/nova/+/909220 | |
| 17:41:34 | tkajinam | I was talking about the service version check at startup (based on https://github.com/openstack/nova/blob/master/nova/objects/service.py#L256 ). I agree it may not work for case where old services may be kept running during upgrade | |
| 17:42:02 | tkajinam | though it blocks the case that a user attempts to get old node joining back to the cluster. | |
| 17:46:45 | dansmith | Yep, that's the thing we had to add the knob to disable because it gets in the way of large upgrades, so it's not uncommon to see that turned off :) | |
| 17:47:03 | dansmith | we added it as a hard fail and immediately had to backport the knob because it was too strict for lots of real-world situations | |
| 18:33:12 | opendevreview | Merged openstack/nova master: docs: Further tweaks to the CPU models document https://review.opendev.org/c/openstack/nova/+/784066 | |